November 2024 - Wine-gitlab

[PATCH 0/1] MR6790: ntdll: use fork()/exec() to invoke unmount command instead of system().
by Michael Lelli (＠toadking) 08 Nov '24

08 Nov '24

Fix umounting filesystems mounted on paths with spaces. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57391 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6790

3 2

[PATCH 0/1] MR6772: d3dx9: Add semi-stub for D3DXOptimizeVertices.
by Alex Henrie (＠alexhenrie) 08 Nov '24

08 Nov '24

This submission is practically identical to [Vijay Kiran Kamuju's improved version](https://list.winehq.org/mailman3/hyperkitty/list/wine-devel(a)wine… of [Christian Costa's D3DXOptimizeVertices patch in Staging](https://github.com/wine-staging/wine-staging/blob/master/patches/d…. The only changes I made were adding the "Vertex order will not be optimal" message to match [the similar message in D3DXOptimizeFaces](https://gitlab.winehq.org/wine/wine/-/blob/eeabbe812ffc3…, removing the extra newlines around the function, and changing `%x` to `%lx` in the tests to resolve warnings. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47776 Signed-off-by: Vijay Kiran Kamuju <infyquest(a)gmail.com> Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6772

3 5

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 08 Nov '24

08 Nov '24

On Thu Nov 7 19:56:04 2024 +0000, Alanas wrote: > <div><a target="_blank" > href="https://gitlab.winehq.org/wine/wine/-/blob/6db2812411d45ca4b4d15dea9a00577e…"><code>pager.c</code>:<pre><code > lang="c">static BOOL PAGER_AdjustBuffer(PAGER_INFO *infoPtr, INT > size)
{
 if (!infoPtr->pwszBuffer)
 > infoPtr->pwszBuffer = Alloc(size);
 else if > (infoPtr->nBufferSize < size)
 infoPtr->pwszBuffer = > ReAlloc(infoPtr->pwszBuffer, size);

 if > (!infoPtr->pwszBuffer) return FALSE;
 if (infoPtr->nBufferSize > < size) infoPtr->nBufferSize = size;

 return > TRUE;
}</code></pre></a>Why is this function designed to leak old > <code>infoPtr->pwszBuffer</code> when <code>ReAlloc(infoPtr->pwszBuffer, > size)</code> returns <code>NULL</code>?</div> No. It's a bug. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86878

1 0

Re: [PATCH v7 0/3] MR2377: sppc: Add stubs for MS Office. - closed
by Daniel Tang (＠danielzgtg) 07 Nov '24

07 Nov '24

This merge request was closed by Daniel Tang. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2377

1 0

Re: [PATCH v7 0/3] MR2377: sppc: Add stubs for MS Office.
by Daniel Tang (＠danielzgtg) 07 Nov '24

07 Nov '24

Closing per merge unlikelihood. Alternatives approaches are at https://gitlab.winehq.org/wine/wine/-/merge_requests/5522#note_86850 . -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2377#note_86876

1 0

Re: [PATCH v4 0/1] MR2378: kernelbase: Trick V8's CHECK(old_protection == PAGE_READWRITE).
by Paul Gofman (＠gofman) 07 Nov '24

07 Nov '24

On Thu Nov 7 23:04:24 2024 +0000, Elizabeth Figura wrote: > > > Proton hack won't be acceptable upstream > > > > I learned that Wine and wine-staging doesn't like app-specific code. > However, Proton has [a lot of app-specific > workarounds](https://github.com/ValveSoftware/Proton/blob/1a73b04e6cdf29297…. > Since Microsoft > [famously](https://arstechnica.com/gadgets/2022/10/windows-95-went-the-extra… > has app-specific workarounds (which Wine needs to emulate for full > conformance), our own workaround for Microsoft Office wouldn't be much > different on the technical side. On the social side, Wine wouldn't > accept stuff like that, but Proton has a history of this. > Proton already has a hack for this issue. That hack is game specific, not enabled by default (as currently considered too dangerous and not that often needed). It is not enabled by MS Office of course. Maybe it can be, provided it works with Proton with the hack. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2378#note_86875

1 0

Re: [PATCH v4 0/1] MR2378: kernelbase: Trick V8's CHECK(old_protection == PAGE_READWRITE).
by Brendan Shanks (＠bshanks) 07 Nov '24

07 Nov '24

Also, I landed a fix for [this issue](https://bugs.winehq.org/show_bug.cgi?id=53835) in upstream Chromium 110/V8 11.0 (and it was backported to later releases of 109). There is software (various game launchers) still using affected versions (106-109), but I'd hope that Office would be more up-to-date. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2378#note_86874

1 0

[PATCH 0/1] MR6789: po: Update Lithuanian translation.
by Aurimas Fišeras 07 Nov '24

07 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6789

2 2

Re: [PATCH v3 0/1] MR6770: [ntdll] fix unwind compilation failure for android
by cqwrteur (＠trcrsired) 07 Nov '24

07 Nov '24

On Wed Nov 6 07:01:56 2024 +0000, Aida Jonikienė wrote: > You should add a person to the reviewers list instead (but that requires > developer access; you can request it with a button like "Request Access" > in the Wine repository) i cannot. No permission. Can you help me? thank you -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6770#note_86872

1 0

Re: [PATCH v4 0/1] MR2378: kernelbase: Trick V8's CHECK(old_protection == PAGE_READWRITE).
by Elizabeth Figura (＠zfigura) 07 Nov '24

07 Nov '24

> > Proton hack won't be acceptable upstream > > I learned that Wine and wine-staging doesn't like app-specific code. However, Proton has [a lot of app-specific workarounds](https://github.com/ValveSoftware/Proton/blob/1a73b04e6cdf29297…. Since Microsoft [famously](https://arstechnica.com/gadgets/2022/10/windows-95-went-the-extra… has app-specific workarounds (which Wine needs to emulate for full conformance), our own workaround for Microsoft Office wouldn't be much different on the technical side. On the social side, Wine wouldn't accept stuff like that, but Proton has a history of this. Proton already has a hack for this issue. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2378#note_86869

1 0