December 2024 - Wine-gitlab

[PATCH 0/1] MR6945: winex11: Do not use desired_state when computing state updates.
by Rémi Bernon 03 Dec '24

03 Dec '24

It is updated in window_wm_state_notify on unexpected state changes to match the host state and to avoid requesting the Win32 state again. We can use the window style instead to decide what needs to be changed. https://bugs.winehq.org/show_bug.cgi?id=57481 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6945

1 1

[PATCH 0/5] MR6944: winex11: Workaround KWin bug with maximized windows.
by Rémi Bernon 03 Dec '24

03 Dec '24

I know we've had a policy to avoid window manager specific workarounds, I think we could reconsider it. The fix could be unguarded and applied with every window manager, and could very well work, but I think it is ugly enough to justify checking for KWin specifically. The problem is that as soon as a window configure request is sent to a maximized window, KWin internal state gets bogus and it loses track of the window maximized state. I've described the KWin source details on https://bugs.kde.org/show_bug.cgi?id=496966 and opened https://invent.kde.org/plasma/kwin/-/merge_requests/6854 as a possible fix for it, but the time it will take to land could justify working around it in Wine. The workaround is to avoid sending configure requests to maximized windows, which sounds sensible and we already avoid resizing maximized windows, but, moving a maximized window to a different monitor *requires* sending a configure request. KWin bug makes no difference to requests with only position changes, and they trigger it all the same. So, the only solution is to temporarily remove the maximized state bits before sending the configure request, putting them back afterwards. This is quite straightforward to do with the new state tracker, but it could very well trigger other problems with other window managers. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57465 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6944

1 5

[PATCH 0/2] MR6909: Draft: winex11: Avoid requesting window size changes for maximized or fullscreen windows.
by Rémi Bernon 03 Dec '24

03 Dec '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57465 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6909

1 3

[PATCH v5 0/3] MR6891: cmd: Use CD /D to change directory in POPD (same as PUSHD).
by huangqinjin (＠huangqinjin) 03 Dec '24

03 Dec '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57137 -- v5: cmd: Set =C: environment variable if POPD succeeds (same as PUSHD). cmd: Refactor CD command. cmd/tests: Add tests for POPD with directory that no longer exists. https://gitlab.winehq.org/wine/wine/-/merge_requests/6891

3 8

[PATCH 0/1] MR6942: gdiplus: Use the FormatID of the source image when cloning.
by Haoyang Chen (＠chenhaoyang) 03 Dec '24

03 Dec '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6942

3 2

Re: [PATCH v10 0/6] MR6569: winex11: Refactor window state/config tracker to fix race conditions.
by Rémi Bernon 02 Dec '24

02 Dec '24

On Mon Dec 2 22:29:18 2024 +0000, Robbert van der Helm wrote: > Ah I completely missed the assignment there at the end when I was > grepping for usages of `wm_state_serial`. I still can't reliably get > Wine to accept configuration events I sent to it though. If I set the > `WM_STATE` property it does process the next event, but then it gets > stuck again after that because now `net_wm_state_serial` will be stuck > on a nonzero value. I could probably figure out a way to get Wine to > cooperate, but that's almost certainly going to break in a future Wine release. > To reiterate, my goal isn't necessarily to send `ConfigureNotify` events > to Wine. I just want a Wine window that's reparented to another window > to handle mouse events correctly, as otherwise Wine seems to interpret > pointer events as being relative to the root window. So for example, if > I have a regular top level X11 window at position 50x50 relative to the > top left of the root window, and I reparent a Wine window into that > window, clicking at coordinates 20x20 from the top left of the > reparented Wine window will cause Wine to register a click at coordinate > 70x70. Up until now it was possible to work around this by telling Wine > about its location on screen through `ConfigureNotify` events, but that > is of course a hack. > Since you've been working on Wine's X11 driver, what do you think is the > best way to approach this in a way that isn't likely to break again in > the future? Would extending Wine's existing tracking of > reparented/embedded windows so any events related to pointer coordinates > get translated accordingly make sense? There has been various changes in the way we handle window positioning, and it's now probably more flexible to arbitrary X11 parent windows, but in any case we still always consider the X root window coordinates as the origin for the Win32 desktop. If you want to embed all Wine windows into another window and use its position as the Win32 desktop origin, it's basically what the "virtual desktop" mode is doing already. It's an option in winecfg, where we create a dedicated window for the Win32 desktop and every Wine window will be a child of it. You could probably then reparent the desktop window to the window you want? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6569#note_89502

1 0

Re: [PATCH v10 0/6] MR6569: winex11: Refactor window state/config tracker to fix race conditions.
by Robbert van der Helm (＠robbert-vdh) 02 Dec '24

02 Dec '24

On Mon Dec 2 10:04:22 2024 +0000, Rémi Bernon wrote: > `wm_state_serial` should be cleared when the window state actually > changes and the `WM_STATE` PropertyNotify event is received, calling > `window_wm_state_notify` which clears it. Ah I completely missed the assignment there at the end when I was grepping for usages of `wm_state_serial`. I still can't reliably get Wine to accept configuration events I sent to it though. If I set the `WM_STATE` property it does process the next event, but then it gets stuck again after that because now `net_wm_state_serial` will be stuck on a nonzero value. I could probably figure out a way to get Wine to cooperate, but that's almost certainly going to break in a future Wine release. To reiterate, my goal isn't necessarily to send `ConfigureNotify` events to Wine. I just want a Wine window that's reparented to another window to handle mouse events correctly, as otherwise Wine seems to interpret pointer events as being relative to the root window. So for example, if I have a regular top level X11 window at position 50x50 relative to the top left of the root window, and I reparent a Wine window into that window, clicking at coordinates 20x20 from the top left of the reparented Wine window will cause Wine to register a click at coordinate 70x70. Up until now it was possible to work around this by telling Wine about its location on screen through `ConfigureNotify` events, but that is of course a hack. Since you've been working on Wine's X11 driver, what do you think is the best way to approach this in a way that isn't likely to break again in the future? Would extending Wine's existing tracking of reparented/embedded windows so any events related to pointer coordinates get translated accordingly make sense? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6569#note_89501

1 0

[PATCH 0/1] MR6941: winevulkan: Update to VK spec version 1.4.303.
by Georg Lehmann (＠DadSchoorse) 02 Dec '24

02 Dec '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6941

3 2

Re: [PATCH v2 0/2] MR6921: ntdll: Fix reported exception code for some brk immediates. - approved
by Alexandre Julliard (＠julliard) 02 Dec '24

02 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6921

1 0

Re: [PATCH v3 0/1] MR6926: winex11: Don't tell win32 about offscreen window position. - approved
by Alexandre Julliard (＠julliard) 02 Dec '24

02 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6926

1 0