December 2024 - Wine-gitlab

[PATCH v27 0/2] MR6869: timeout: Windows 10 introduce the timeout command
by Michele Dionisio (＠michele.dionisio) 02 Dec '24

02 Dec '24

Windows 10 and 11 introduce the timeout.exe command. This is a similar program with same argument options. https://bugs.winehq.org/show_bug.cgi?id=56068 -- v27: timeout: add minimal test suite timeout: Windows 10 introduce the timeout command https://gitlab.winehq.org/wine/wine/-/merge_requests/6869

2 2

[PATCH v2 0/3] MR6939: include: Enable format attributes for debug traces in Clang MSVC mode.
by Jacek Caban (＠jacek) 02 Dec '24

02 Dec '24

-- v2: include: Enable format attributes for debug traces in Clang MSVC mode. mmdevapi/tests: Use %u format for unsigned int arguments. https://gitlab.winehq.org/wine/wine/-/merge_requests/6939

2 4

[PATCH v26 0/2] MR6869: timeout: Windows 10 introduce the timeout command
by Michele Dionisio (＠michele.dionisio) 02 Dec '24

02 Dec '24

Windows 10 and 11 introduce the timeout.exe command. This is a similar program with same argument options. https://bugs.winehq.org/show_bug.cgi?id=56068 -- v26: timeout: add minimal test suite timeout: Windows 10 introduce the timeout command https://gitlab.winehq.org/wine/wine/-/merge_requests/6869

4 5

Re: [PATCH v4 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by eric pouech (＠epo) 02 Dec '24

02 Dec '24

I mostly commented the first patch for the tests... we need I'm afraid more tests to discriminate whether the scan mask is bound to directory handle or to the directory itself reading MSDN doc [1] suggests that it's likely the former; but I never trust MSDN doc, hence the need to more tests, esp with two handles opened to the same directory and test the mixing of calls if it's the case, then it means that tweaking the fd cache is wrong (as you in your second patch), and we likely need another layer for storing the mask [1] https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/ntifs/nf-nti… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6904#note_89400

1 0

Re: [PATCH v4 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by eric pouech (＠epo) 02 Dec '24

02 Dec '24

eric pouech (@epo) commented about dlls/ntdll/tests/directory.c: > + /* Clean up from prior aborted run, if any, then set up test files */ > + ok( GetTempPathA(MAX_PATH, testdir), "couldn't get temp dir\n" ); > + strcat(testdir, "mask.tmp"); > + tear_down_mask_test(testdir); > + set_up_mask_test(testdir); > + > + pRtlMultiByteToUnicodeN(testdir_w, sizeof(testdir_w), NULL, testdir, strlen(testdir) + 1); > + if (!pRtlDosPathNameToNtPathName_U(testdir_w, &ntdirname, NULL, NULL)) > + { > + ok( 0, "RtlDosPathNametoNtPathName_U failed\n" ); > + goto done; > + } > + InitializeObjectAttributes(&attr, &ntdirname, OBJ_CASE_INSENSITIVE, 0, NULL); > + > + /* Open a handle for our test directory */ > + status = pNtOpenFile(&dirh, SYNCHRONIZE | FILE_LIST_DIRECTORY, &attr, &io, FILE_SHARE_READ, indentation issue (mix of tab & spaces?) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6904#note_89398

1 0

Re: [PATCH v4 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by eric pouech (＠epo) 02 Dec '24

02 Dec '24

eric pouech (@epo) commented about dlls/ntdll/tests/directory.c: > + InitializeObjectAttributes(&attr, &ntdirname, OBJ_CASE_INSENSITIVE, 0, NULL); > + > + /* Open a handle for our test directory */ > + status = pNtOpenFile(&dirh, SYNCHRONIZE | FILE_LIST_DIRECTORY, &attr, &io, FILE_SHARE_READ, > + FILE_SYNCHRONOUS_IO_NONALERT | FILE_OPEN_FOR_BACKUP_INTENT | FILE_DIRECTORY_FILE); > + ok( status == STATUS_SUCCESS, "failed to open dir '%s', ret 0x%lx, error %ld\n", testdir, status, GetLastError() ); > + if (status != STATUS_SUCCESS) > + { > + skip("can't test if we can't open the directory\n"); > + goto done; > + } > + > + /* Verify that updated windows 8 and higher behaviour is supported */ > + if (!winetest_platform_is_wine && !test_NtQueryDirectoryFile_mask(dirh, TRUE, atestfile, TRUE, TRUE)) > + run_updated_tests = FALSE; > + if (!winetest_platform_is_wine && !test_NtQueryDirectoryFile_mask(dirh, TRUE, notatestfile, FALSE, TRUE)) question: do you need both calls to test_NtQueryDirectoryFile_mask to invalidate a platform? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6904#note_89399

1 0

Re: [PATCH v4 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by eric pouech (＠epo) 02 Dec '24

02 Dec '24

eric pouech (@epo) commented about dlls/ntdll/tests/directory.c: > + IO_STATUS_BLOCK io; > + UINT data_size = sizeof(FILE_DIRECTORY_INFORMATION) + (MAX_PATH * sizeof(wchar_t)); > + BYTE data[8192]; > + FILE_DIRECTORY_INFORMATION *dir_info; > + WCHAR *name; > + ULONG name_len; > + ULONG mask_len = mask.Length / sizeof(WCHAR); > + > + /* Perform the query */ > + status = pNtQueryDirectoryFile( handle, NULL, NULL, NULL, &io, data, data_size, > + FileDirectoryInformation, TRUE, &mask, restart_scan ); > + if (expect_success) > + { > + if (validate_only && status != STATUS_SUCCESS) return FALSE; > + > + ok( status == STATUS_SUCCESS, "could not find file mask: '%s', restart: %d, error %ld\n", tracing GetLastError() is pointless here (you're testing ntdll APIs, while GetLastError() reflects kernel32/kernelbase API results) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6904#note_89397

1 0

Re: [PATCH v10 0/6] MR6569: winex11: Refactor window state/config tracker to fix race conditions.
by Rémi Bernon 02 Dec '24

02 Dec '24

On Sun Dec 1 21:39:49 2024 +0000, Robbert van der Helm wrote: > Thanks for the detailed write up! I only ran into this commit after > bisecting the changes between Wine 9.21 and 9.22, so I'm almost > certainly missing some context! > The problem I'm facing seems to be that as soon as `SWP_STATECHANGED` is > set and `window_set_wm_state()` gets called, `data->wm_state_serial` > gets stuck on a nonzero value since it's set to the X11 connection's > next sequence number and is then never cleared again. That causes > `window_update_client_config()` to always bail before it does anything, > which in turn causes the `NtUserPostMessage( hwnd, > WM_WINE_WINDOW_STATE_CHANGED, 0, 0 )` called from > `X11DRV_ConfigureNotify()` to not do anything anymore. > This doesn't seem to cause any problems under normal use cases, since > normally once a window is mapped, its coordinates relative to the root > window will never suddenly change (not sure if there's a spicy > interaction with multiple monitors though). But in yabridge I have to > reparent a Wine window to another window, and to make that work I've > always had to send these `ConfigureNotify` events to inform Wine about > the window's actual position on screen. Otherwise it thinks it's located > in the top left corner of the screen, and all mouse events will be at an offset. > I can open a regression bug report on bugs.winehq.org, but since what > yabridge is doing is almost certainly not the ended way to interact with > Wine, I thought I'd check here first. `wm_state_serial` should be cleared when the window state actually changes and the `WM_STATE` PropertyNotify event is received, calling `window_wm_state_notify` which clears it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6569#note_89396

1 0

[PATCH 0/4] MR6940: ole32: Property storage reading improvements
by Piotr Caban (＠piotr) 02 Dec '24

02 Dec '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6940

2 4

Re: [PATCH v4 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by Eugene McArdle (＠eugenemcardle) 02 Dec '24

02 Dec '24

OK, @epo and @DodoGTA - are there any concerns or comments regarding the updated PR? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6904#note_89391

1 0