December 2024 - Wine-gitlab

[PATCH v8 0/6] MR4826: Mach vm operations improvements
by Marc-Aurel Zent (＠mzent) 02 Dec '24

02 Dec '24

For all mach vm operations this removes the task suspend and resume, which are not needed. This uses `mach_vm_read_overwrite` to read into a caller-specified buffer, saving the `mach_vm_deallocate` call (bringing all read operations down to 1 syscall from 4). The only alignment restriction on `mach_vm_write` according to the original CMU documentation is that data is > [pointer to page aligned in array of bytes] An array of data to be written. (In practice it also works with arbitrary addresses on macOS, but it probably doesn't hurt to follow the original specifications here). The only other reference that these read/writes should be page-aligned is from the GNU Hurd documentation > The current implementation requires that address, data and data_count all be page-aligned. Otherwise, KERN_INVALID_ARGUMENT is returned. which I assume was the reason why this was originally done (plus it sounds to me like they will fix that in the future and 4fe19777 already broke GNU Hurd support anyways, if that was supposed to be working). Also this includes the missing mach part of 5b1f3b14, which was only applied to the ptrace backend, and together with the `write_process_memory` rework, this gets rid of all fixmes in mach.c -- v8: server: Do not page align address in write_process_memory. server: Do not suspend mach task in write_process_memory. server: Use mach_vm_read_overwrite in get_selector_entry. server: Do not suspend mach task in get_selector_entry. server: Use mach_vm_read_overwrite in read_process_memory. server: Do not suspend mach task in read_process_memory. https://gitlab.winehq.org/wine/wine/-/merge_requests/4826

2 8

[PATCH v30 0/2] MR6869: timeout: Windows 10 introduce the timeout command
by Michele Dionisio (＠michele.dionisio) 02 Dec '24

02 Dec '24

Windows 10 and 11 introduce the timeout.exe command. This is a similar program with same argument options. https://bugs.winehq.org/show_bug.cgi?id=56068 -- v30: timeout: add minimal test suite https://gitlab.winehq.org/wine/wine/-/merge_requests/6869

3 3

[PATCH v28 0/2] MR6869: timeout: Windows 10 introduce the timeout command
by Michele Dionisio (＠michele.dionisio) 02 Dec '24

02 Dec '24

Windows 10 and 11 introduce the timeout.exe command. This is a similar program with same argument options. https://bugs.winehq.org/show_bug.cgi?id=56068 -- v28: timeout: add minimal test suite https://gitlab.winehq.org/wine/wine/-/merge_requests/6869

3 3

[PATCH v14 0/3] MR6737: comctl32/toolbar: forward WM_NOTIFY CBEN_ENDEDITW
by Alanas Tebuev (＠BZZZZ) 02 Dec '24

02 Dec '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57178 This makes [7-zip file manager](https://www.7-zip.org/) pressing enter while editing path work: * before: * [Icon near path becomes dark (7-zip file manager doesn't go to path).](https://old.reddit.com/r/winehq/comments/16ah3ze/7zip_cant_enter_pa…) * after: * 7-zip file manager goes to path. * Path input displays incorrect path (shouldn't happen, bug in wine's comboboxex unrelated to toolbar). -- v14: comctl32/toolbar: Forward WM_NOTIFY CBEN_ENDEDITW. comctl32: Move WM_NOTIFY unicode to ansi conversion code from pager.c to commctrl.c. comctl32/tests: Test WM_NOTIFY CBEN_ENDEDITW conversion and forwarding in toolbar. https://gitlab.winehq.org/wine/wine/-/merge_requests/6737

4 6

[PATCH v2 0/9] MR6931: win32u: Move surface and swapchain wrappers from winevulkan.
by Rémi Bernon 02 Dec '24

02 Dec '24

-- v2: win32u: Move surface and swapchain wrappers from winevulkan. win32u: Keep track of redirected host vulkan functions. winevulkan: Pass wrapper structs to win32u_vkGet(Device|Instance)ProcAddr. winevulkan: Use the vulkan object as the wrapper tree node. winevulkan: Get rid of unnecessary *to_handle helpers. winevulkan: Avoid changing client command buffer pointer. winevulkan: Fix incorrect client queue pointers. winevulkan: Introduce a new vulkan_object_init helper. winevulkan: Use the result to decide if creation failed. https://gitlab.winehq.org/wine/wine/-/merge_requests/6931

2 13

Re: [PATCH v2 0/7] MR6911: ntdll: Add WaitCompletionPacket.
by Zhiyi Zhang (＠zhiyi) 02 Dec '24

02 Dec '24

On Sun Dec 1 21:56:35 2024 +0000, Jinoh Kang wrote: > I'd advise you to test WaitCompletionPacket againat waitable objects > that use `get_wait_queue_thread()`, including keyed events, mutexes, and > message queue objects (not exposed via Win32 API, only at win32k level). Thanks for the review. The problem is that there might be no threads that initiate any wait. Anyway, I will add more tests and get back to you. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6911#note_89419

1 0

[PATCH v27 0/2] MR6869: timeout: Windows 10 introduce the timeout command
by Michele Dionisio (＠michele.dionisio) 02 Dec '24

02 Dec '24

Windows 10 and 11 introduce the timeout.exe command. This is a similar program with same argument options. https://bugs.winehq.org/show_bug.cgi?id=56068 -- v27: timeout: add minimal test suite timeout: Windows 10 introduce the timeout command https://gitlab.winehq.org/wine/wine/-/merge_requests/6869

2 2

[PATCH v2 0/3] MR6939: include: Enable format attributes for debug traces in Clang MSVC mode.
by Jacek Caban (＠jacek) 02 Dec '24

02 Dec '24

-- v2: include: Enable format attributes for debug traces in Clang MSVC mode. mmdevapi/tests: Use %u format for unsigned int arguments. https://gitlab.winehq.org/wine/wine/-/merge_requests/6939

2 4

[PATCH v26 0/2] MR6869: timeout: Windows 10 introduce the timeout command
by Michele Dionisio (＠michele.dionisio) 02 Dec '24

02 Dec '24

Windows 10 and 11 introduce the timeout.exe command. This is a similar program with same argument options. https://bugs.winehq.org/show_bug.cgi?id=56068 -- v26: timeout: add minimal test suite timeout: Windows 10 introduce the timeout command https://gitlab.winehq.org/wine/wine/-/merge_requests/6869

4 5

Re: [PATCH v4 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by eric pouech (＠epo) 02 Dec '24

02 Dec '24

I mostly commented the first patch for the tests... we need I'm afraid more tests to discriminate whether the scan mask is bound to directory handle or to the directory itself reading MSDN doc [1] suggests that it's likely the former; but I never trust MSDN doc, hence the need to more tests, esp with two handles opened to the same directory and test the mixing of calls if it's the case, then it means that tweaking the fd cache is wrong (as you in your second patch), and we likely need another layer for storing the mask [1] https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/ntifs/nf-nti… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6904#note_89400

1 0