February 2024 - Wine-gitlab

[PATCH 0/1] MR5013: msi: Properly select first feature
by Fabian Maurer (＠DarkShadow44) 03 Feb '24

03 Feb '24

We need to select the first feature when all controls are created, otherwise they are not properly updated Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56290 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5013

2 1

[PATCH 0/6] MR4518: ntdll: Integrate with GDB using systemtap rtld probes.
by Rémi Bernon 02 Feb '24

02 Feb '24

Effectively implementing the debugger interface as described in https://sourceware.org/git/?p=glibc.git;a=blob;f=elf/rtld-debugger-interfac… This is an actual attempt at having this upstream, split from https://gitlab.winehq.org/wine/wine/-/merge_requests/1074 which people have been finding useful for debugging Wine directly in GDB. This supports everything you would expect, from automatic symbol loading as well as cross-syscall backtraces with the new Python unwinder. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4518

2 10

[PATCH v2 0/9] MR4954: kernelbase: Reimplement UrlCanonicalize().
by Zebediah Figura (＠zfigura) 02 Feb '24

02 Feb '24

Normally I am a strong proponent of adjusting implementations one small step at a time, but this is a bit of an extreme case. The current state of UrlCanonicalize() is a prototypical example of "spaghetti code": the implementation has been repeatedly adjusted to fix a new discovered edge case, without properly testing the scope of the new logic, with the effect that the current logic is a scattered mess of conditions that interact in unpredictable ways. To be fair, the actual function is much more complicated than one would anticipate, and the number of new weird edge cases I found while trying to flesh out existing logic was rather exhausting. I initially tried to "fix" the existing implementation one step at a time. After racking up dozens of commits without an end in sight, though, and having to waste time carefully unravelling the broken code in the right order so as to avoid temporary failures, I decided instead to just fix everything at once, effectively rewriting the function from scratch, and this proved to be much more productive. Hopefully the huge swath of new tests is enough to prove that this new implementation really is correct, and has no more spaghetti than what Microsoft made necessary. -- v2: shlwapi/tests: Add many more tests for UrlCanonicalize(). kernelbase: Use scheme_is_opaque() in UrlIs(). kernelbase: Reimplement UrlCanonicalize(). kernelbase: Do not canonicalize the relative part in UrlCombine(). shlwapi/tests: Move UrlCombine() error tests out of the loop. shlwapi/tests: Use winetest_push_context() in test_UrlCanonicalizeA(). shlwapi/tests: Remove the unused "wszExpectUrl" variable from check_url_canonicalize(). shlwapi/tests: Move the UrlCanonicalize() tests into test_UrlCanonicalizeA(). urlmon/tests: Add basic tests for CoInternetParseUrl(PARSE_CANONICALIZE). https://gitlab.winehq.org/wine/wine/-/merge_requests/4954

3 10

[PATCH 0/3] MR5010: sapi: Add stubs for ISpeechObjectToken(s).
by Shaun Ren (＠shaunren) 02 Feb '24

02 Feb '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5010

3 4

[PATCH 0/5] MR626: vkd3d-utils: Constant buffer reflection without vkd3d-shader.
by Zebediah Figura (＠zfigura) 02 Feb '24

02 Feb '24

As per discussion in 606, plumbing constant buffer reflection through vkd3d-shader requires interface design and API documentation for an interface which is inherently quite specific to one format. Instead of wasting time on this interface, just implement RDEF parsing in vkd3d-utils itself. If we change our mind about this, we can always move the implementation to vkd3d-shader anyway. This does not copy the existing implementation from Wine, because: * Wine does not validate offsets; adding this changes the parsing code significantly; * Wine incorrectly handles types, deduplicating them into an rbtree; * Wine skips several fields which I have been able to find the purpose of. The implementation is not that complex to begin with, so reimplementing it from scratch is not much work. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/626

2 5

[PATCH 0/2] MR5009: ntoskrnl.exe: Support ImagePaths just starting with System32.
by Bernhard Übelacker 02 Feb '24

02 Feb '24

https://bugs.winehq.org/show_bug.cgi?id=51998 The first patch should make no functional change, just move the block out to a helper function. I assume changing to L"" literals is expected? The second patch handles ImagePaths starting with `System32` similar like it is already done for `\\SystemRoot\\` and adds the windows directory in front of it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5009

1 2

[PATCH v7 0/7] MR4082: gdiplus: Implement font linking in GdipDrawString.
by Santino Mazza (＠tati1454) 02 Feb '24

02 Feb '24

-- v7: gdiplus: Implement font linking for gdiplus. https://gitlab.winehq.org/wine/wine/-/merge_requests/4082

3 12

[PATCH 0/1] MR5008: mscoree: Update Wine Mono to 9.0.0.
by Esme Povirk (＠madewokherd) 02 Feb '24

02 Feb '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5008

3 2

[PATCH v5 0/2] MR5007: winhttp: Add support for WINHTTP_AUTOPROXY_HOST_LOWERCASE flag in WinHttpGetProxyForUrl
by Piotr Caban (＠piotr) 02 Feb '24

02 Feb '24

-- v5: winhttp: Add support for WINHTTP_AUTOPROXY_HOST_LOWERCASE flag in WinHttpGetProxyForUrl. https://gitlab.winehq.org/wine/wine/-/merge_requests/5007

3 4

[PATCH 0/7] MR4977: winegstreamer: Allow wg_transform size changes with an explicit attribute.
by Rémi Bernon 02 Feb '24

02 Feb '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4977

2 14