February 2024 - Wine-gitlab

[PATCH v9 0/1] MR5020: kernelbase/file: implement CopyFile2
by Kartavya Vashishtha (＠kvashis) 16 Feb '24

16 Feb '24

copy implementation of CopyFileExW into CopyFile2, then implement CopyFileExW in terms of CopyFile2 should fix https://bugs.winehq.org/show_bug.cgi?id=55897, as Python does not use any new functionality nor the callback parameter from CopyFile2. I have not written extensive documentation since the original function didn't seem to have any; I can do that if recommended. I originally intended to implement the callback functionality in this MR as well, but realized that would be better as a follow-up. -- v9: implement CopyFile2 https://gitlab.winehq.org/wine/wine/-/merge_requests/5020

3 4

[PATCH v3 0/13] MR626: vkd3d-utils: Constant buffer reflection without vkd3d-shader.
by Zebediah Figura (＠zfigura) 16 Feb '24

16 Feb '24

As per discussion in 606, plumbing constant buffer reflection through vkd3d-shader requires interface design and API documentation for an interface which is inherently quite specific to one format. Instead of wasting time on this interface, just implement RDEF parsing in vkd3d-utils itself. If we change our mind about this, we can always move the implementation to vkd3d-shader anyway. This does not copy the existing implementation from Wine, because: * Wine does not validate offsets; adding this changes the parsing code significantly; * Wine incorrectly handles types, deduplicating them into an rbtree; * Wine skips several fields which I have been able to find the purpose of. The implementation is not that complex to begin with, so reimplementing it from scratch is not much work. -- v3: tests: Add more tests for resource and struct RDEF contents. tests: Test constant and resource reflection via D3DReflect(). vkd3d-shader/tpf: Set the user-packed flag for sm5.0 resources as well. vkd3d-shader/tpf: Write the component count as the column count for structs. vkd3d-shader/tpf: Explicitly write the class and base type for non-numeric types. vkd3d-shader/tpf: Do not write structs with no numeric fields into the RDEF. vkd3d-shader/tpf: Do not write non-numeric struct fields into the RDEF. vkd3d-shader/hlsl: Allocate register reservations for structs as well. vkd3d-utils: Implement ID3D12ShaderReflectionType::GetMemberTypeByIndex(). vkd3d-utils: Implement ID3D12ShaderReflectionVariable::GetType(). vkd3d-utils: Implement ID3D12ShaderReflectionConstantBuffer::GetVariableByIndex(). vkd3d-utils: Parse the RD11 section. vkd3d-utils: Implement ID3D12ShaderReflection::GetConstantBufferByIndex(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/626

3 14

[PATCH v2 0/9] MR5055: winegstreamer: Support input video frame padding and cropping.
by Rémi Bernon 16 Feb '24

16 Feb '24

On the client side, frame aperture may be included or omitted. This can be used to include or drop the frame padding, and the VideoProcessor MFT supports it. On GStreamer side, we can only use the unpadded frame size in the caps, because this is how decoders work, and padding needs to be added as a property of the input/output video buffers. Then, frame size needs to be adjusted to be consistent between input and output, and any difference considered as extra padding to be added on one side or the other. -- v2: winegstreamer: Respect video format padding for input buffers too. winegstreamer: Exclude padding from wg_format video frame size. winegstreamer: Use video info stride in buffer meta rather than videoflip. winegstreamer: Use a new wg_video_buffer_pool class to add buffer meta. winegstreamer: Update the output_format when stream format changes. winegstreamer: Pass optional GstVideoInfo to read_transform_output_data. winegstreamer: Split read_transform_output_data in two helpers. winegstreamer: Introduce a new sample_needs_copy_buffer helper. winegstreamer: Introduce a new sample_set_flags_from_buffer helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/5055

2 14

Re: [PATCH v9 0/1] MR4672: include: Add msdelta.h header file.
by Alexandre Julliard (＠julliard) 16 Feb '24

16 Feb '24

Alexandre Julliard (@julliard) commented about include/msdelta.h: > +#define DELTA_FILE_TYPE_CLI_I386 (DELTA_FILE_TYPE)0x00000010 > +#define DELTA_FILE_TYPE_CLI_AMD64 (DELTA_FILE_TYPE)0x00000020 > +#define DELTA_FILE_TYPE_CLI_ARM (DELTA_FILE_TYPE)0x00000040 > +#define DELTA_FILE_TYPE_CLI_ARM64 (DELTA_FILE_TYPE)0x00000080 > + > +#define DELTA_FILE_TYPE_SET_RAW_ONLY DELTA_FILE_TYPE_RAW > +#define DELTA_FILE_TYPE_SET_EXECUTABLES_1 DELTA_FILE_TYPE_RAW|DELTA_FILE_TYPE_I386| \ > + DELTA_FILE_TYPE_IA64|DELTA_FILE_TYPE_AMD64 > +#define DELTA_FILE_TYPE_SET_EXECUTABLES DELTA_FILE_TYPE_SET_EXECUTABLES_1 > +#define DELTA_FILE_TYPE_SET_EXECUTABLES_2 DELTA_FILE_TYPE_RAW|DELTA_FILE_TYPE_CLI_I386| \ > + DELTA_FILE_TYPE_IA64|DELTA_FILE_TYPE_CLI_AMD64| \ > + DELTA_FILE_TYPE_CLI_ARM > +#define DELTA_FILE_TYPE_SET_EXECUTABLES_3 DELTA_FILE_TYPE_RAW|DELTA_FILE_TYPE_CLI_I386| \ > + DELTA_FILE_TYPE_IA64|DELTA_FILE_TYPE_CLI_AMD64| \ > + DELTA_FILE_TYPE_CLI_ARM|DELTA_FILE_TYPE_CLI_ARM64 > +#define DELTA_FILE_TYPE_SET_EXECUTABLES_LATEST DELTA_FILE_TYPE_SET_EXECUTABLES_3 Most of these macros will need an extra pair of parentheses. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4672#note_61516

1 0

[PATCH 0/5] MR5059: mfreadwrite/reader: Repeat pushing / pulling samples while it succeeds.
by Rémi Bernon 16 Feb '24

16 Feb '24

First part of some refactor to implement the source reader pipeline. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5059

2 6

[PATCH v15 0/3] MR5081: dmime: Read through a MIDI file
by Yuxuan Shui (＠yshui) 16 Feb '24

16 Feb '24

Add a dummy track parser, that reads through MIDI tracks and events. To make sure we understand the file structure correctly, no actual tracks or events are generated. Also add test cases to make sure we read through a MIDI file correctly. This is skeleton of the actual MIDI parser. Pending on the merge of !4982 -- v15: dmime/tests: Improve error reporting from expect_track. dmime: Read through a MIDI file. dmime: Don't skip chunk for MIDI files. https://gitlab.winehq.org/wine/wine/-/merge_requests/5081

3 11

Re: [PATCH v11 0/6] MR569: tests/shader_runer: Support SRV buffers. - approved
by Zebediah Figura (＠zfigura) 16 Feb '24

16 Feb '24

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/569

1 0

[PATCH v4 0/3] MR4987: ntdll: Support generic xstate (part 1).
by Paul Gofman (＠gofman) 16 Feb '24

16 Feb '24

This is a preparation for supporting more xstate features in the contexts. The remaining parts are: - support arbitrary xstate in usr1_handler(); - support arbitrary xstate in the server contexts (probably transferring only the present part); - support arbitrary xstate in context manipulation functions; - enabling more xstates in system.c and in user shared data. -- v4: ntdll: Don't hardcode xstate size in exception stack layout. ntdll: Don't hardcode xstate size in syscall frame. ntdll: Don't hardcode xstate feature mask. https://gitlab.winehq.org/wine/wine/-/merge_requests/4987

2 4

[PATCH v3 0/3] MR4987: ntdll: Support generic xstate (part 1).
by Paul Gofman (＠gofman) 16 Feb '24

16 Feb '24

This is a preparation for supporting more xstate features in the contexts. The remaining parts are: - support arbitrary xstate in usr1_handler(); - support arbitrary xstate in the server contexts (probably transferring only the present part); - support arbitrary xstate in context manipulation functions; - enabling more xstates in system.c and in user shared data. -- v3: ntdll: Don't hardcode xstate size in exception stack layout. ntdll: Don't hardcode xstate size in syscall frame. ntdll: Don't hardcode xstate feature mask. https://gitlab.winehq.org/wine/wine/-/merge_requests/4987

4 6

[PATCH v10 0/6] MR569: tests/shader_runer: Support SRV buffers.
by Francisco Casas (＠fcasas) 16 Feb '24

16 Feb '24

This allows to declare SRV buffers in the shader tests using `[buffer srv n]` blocks, and passing them to the different backends. Also, 1/2 includes a missing bit required to parse `Buffer<>` types in the HLSL compiler. This is a step towards supporting StructuredBuffer types in further patches. -- v10: vkd3d-shader/hlsl: Parse Buffer types. tests/shader-runner: Change probe directive syntax on shader_test files. tests/shader-runner: Change resource declaration syntax on shader_test files. tests/shader-runner: Support SRV buffers. tests/shader-runner: Separate resource_type into type and dimension. vkd3d-shader/hlsl: Record valid methods in object_methods[]. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/569

2 6