February 2024 - Wine-gitlab

[PATCH v10 0/1] MR384: vkd3d: Replace the descriptor object cache with a thread-local implementation.
by Conor McCarthy (＠cmccarthy) 12 Feb '24

12 Feb '24

The PE build uses FlsAlloc(), which for our purposes makes no difference vs TlsAlloc(), and allows the use of a destruction callback. -- v10: vkd3d: Replace the descriptor object cache with a thread-local implementation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/384

2 1

[PATCH v9 0/1] MR384: vkd3d: Replace the descriptor object cache with a thread-local implementation.
by Conor McCarthy (＠cmccarthy) 12 Feb '24

12 Feb '24

The PE build uses FlsAlloc(), which for our purposes makes no difference vs TlsAlloc(), and allows the use of a destruction callback. -- v9: vkd3d: Replace the descriptor object cache with a thread-local implementation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/384

2 1

Re: [PATCH v10 0/2] MR364: vkd3d-shader/hlsl: Implement inverse trigonometry.
by Conor McCarthy (＠cmccarthy) 12 Feb '24

12 Feb '24

On Mon Feb 12 00:49:11 2024 +0000, Petrichor Park wrote: > Not sure how I should be editing this wrt !602. Should I be re-adding > all the `todo(sm>=6)` stuff? In my local changes I've completely > deferred to that MR and don't edit the tests file anymore. The SM6 implementation is now upstream, so these todos are unnecessary (and were removed in an upstream commit). -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/364#note_60828

1 0

[PATCH v7 0/1] MR5020: Draft: kernelbase/file: implement CopyFile2
by Kartavya Vashishtha (＠kvashis) 12 Feb '24

12 Feb '24

copy implementation of CopyFileExW into CopyFile2, then implement CopyFileExW in terms of CopyFile2 should fix https://bugs.winehq.org/show_bug.cgi?id=55897, as Python does not use any new functionality nor the callback parameter from CopyFile2. - followed [the Wiki](https://wiki.winehq.org/Developer_Hints#Implementing_new_API_calls) for adding a new API call - run `file.c` tests and they seem to pass I have not written extensive documentation since the original function didn't seem to have any; I can do that if recommended. I originally intended to implement the callback functionality in this MR as well, but realized that would be better as a follow-up. -- v7: create CopyFile2_impl and CopyFile2 https://gitlab.winehq.org/wine/wine/-/merge_requests/5020

4 13

[PATCH 0/1] MR305: Draft: vkd3d-shader/hlsl: Implement strings
by Petrichor Park (＠petrathekat) 11 Feb '24

11 Feb '24

Strings are opaque objects in HLSL. This implements recognizing string literals and the `string` type. This should fix the bug marked below but I'm not sure how to get my hands on a copy of Lego Star Wars Saga to test it properly. This is a super-duper draft MR; I'm certain there's problems with it. I do at least have a passing test, though. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50382 -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/305

5 24

[PATCH v3 0/1] MR5040: dmband: Implement getting/setting GUID_BandParam on band tracks.
by Yuxuan Shui (＠yshui) 11 Feb '24

11 Feb '24

split from !4982 that MR doesn't use this anymore but might still be good to have. -- v3: dmband: Implement getting/setting GUID_BandParam on band tracks. https://gitlab.winehq.org/wine/wine/-/merge_requests/5040

4 4

Re: [PATCH v10 0/2] MR364: vkd3d-shader/hlsl: Implement inverse trigonometry.
by Petrichor Park (＠petrathekat) 11 Feb '24

11 Feb '24

Not sure how I should be editing this wrt !602. Should I be re-adding all the `todo(sm>=6)` stuff? In my local changes I've completely deferred to that MR and don't edit the tests file anymore. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/364#note_60822

1 0

Re: [PATCH v10 0/2] MR364: vkd3d-shader/hlsl: Implement inverse trigonometry.
by Petrichor Park (＠petrathekat) 11 Feb '24

11 Feb '24

On Mon Jan 15 22:01:58 2024 +0000, Giovanni Mascellani wrote: > This is not wrong either, but we have a better tool for that, which is > `vkd3d_string_buffer_printf()` (and companions). > Also, notice that the `if` continuation line should be indented 8 > spaces, not 4. What would make `vkd3d_string_buffer_printf` better? It looks like `hlsl_sprintf_alloc` just forwards to that inside and I don't see what I would be writing that would be better. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/364#note_60821

1 0

[PATCH v16 0/5] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon 10 Feb '24

10 Feb '24

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v16: user32: Use the desktop shared data for GetCursorPos(). server: Expose the desktop shared mapping to clients. server: Add a sequence number to the shared data. server: Move the cursor position and last change time to the shared data. server: Create a desktop shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

1 6

[PATCH v15 0/5] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon 10 Feb '24

10 Feb '24

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v15: user32: Use the desktop shared data for GetCursorPos(). server: Add a sequence number to the shared data. server: Move the cursor position and last change time to the shared data. server: Use the helper to update the cursor last change time. server: Create a desktop shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

2 6