February 2024 - Wine-gitlab

Re: [PATCH v4 0/1] MR632: vkd3d: Implement d3d12_command_list_OMSetDepthBounds()
by Henri Verbeet (＠hverbeet) 08 Feb '24

08 Feb '24

Looking a bit closer, I notice that we don't set VK_DYNAMIC_STATE_DEPTH_BOUNDS. We should add that to dynamic_states[] in d3d12_pipeline_state_get_or_create_pipeline(). Perhaps that's a good argument for waiting for the tests to verify things work as intended though... -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/632#note_60601

1 0

[PATCH 0/1] MR5056: ntdll: Fix DW_OP_abs absolute value warning on labs() for clang.
by Marc-Aurel Zent (＠mzent) 08 Feb '24

08 Feb '24

Fixes the following warning on clang-15: ``` dlls/ntdll/unix/dwarf.h:915:45: warning: taking the absolute value of unsigned type 'ULONG_PTR' (aka 'unsigned long') has no effect [-Wabsolute-value] case DW_OP_abs: stack[sp] = labs(stack[sp]); break; ^ dlls/ntdll/unix/dwarf.h:915:45: note: remove the call to 'labs' since unsigned values cannot be negative case DW_OP_abs: stack[sp] = labs(stack[sp]); break; ^~~~ ``` Despite what it says the existing code was functioning correctly already though AFAICT. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5056

2 1

[PATCH v2 0/4] MR4983: mfreadwrite/tests: Test source reader transforms with video processing attributes.
by Rémi Bernon 08 Feb '24

08 Feb '24

-- v2: mfreadwrite/tests: Test source reader transforms with MF_SOURCE_READER_ENABLE_ADVANCED_VIDEO_PROCESSING. mfreadwrite/tests: Test source reader transforms with MF_SOURCE_READER_ENABLE_VIDEO_PROCESSING. mfreadwrite/tests: Test source reader exposed transforms and types. mfreadwrite/tests: Initialize test source stream types from descriptors. https://gitlab.winehq.org/wine/wine/-/merge_requests/4983

2 7

Re: [PATCH v4 0/1] MR632: vkd3d: Implement d3d12_command_list_OMSetDepthBounds()
by Raphael Abrantes (＠antenabr2) 08 Feb '24

08 Feb '24

I see no problem merging as-is -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/632#note_60599

1 0

[PATCH v3 0/1] MR632: Draft: vkd3d: Implement d3d12_command_list_OMSetDepthBounds()
by Raphael Abrantes (＠antenabr2) 08 Feb '24

08 Feb '24

Spec https://learn.microsoft.com/en-us/windows/win32/api/d3d12/nf-d3d12-id3d12gr…. I am just unsure if checking the max and minimum range is necessary, or if that can be understood as programming error. -- v3: vkd3d: Implement d3d12_command_list_OMSetDepthBounds() https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/632

2 1

[PATCH v2 0/1] MR632: Draft: vkd3d: Implement d3d12_command_list_OMSetDepthBounds()
by Raphael Abrantes (＠antenabr2) 08 Feb '24

08 Feb '24

Spec https://learn.microsoft.com/en-us/windows/win32/api/d3d12/nf-d3d12-id3d12gr…. I am just unsure if checking the max and minimum range is necessary, or if that can be understood as programming error. -- v2: vkd3d: Implement d3d12_command_list_OMSetDepthBounds() https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/632

3 3

Re: [PATCH v2 0/6] MR5053: wined3d: FFP refactoring.
by Henri Verbeet (＠hverbeet) 08 Feb '24

08 Feb '24

Would it make sense to rename shader_select()/vp_enable()/fp_enable() to something like shader_apply_draw_state()/vp_apply_draw_state()/fp_apply_draw_state(), along the lines of wined3d_context_vk_apply_draw_state()? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5053#note_60593

1 0

[PATCH v4 0/5] MR636: vkd3d-shader/fx: Add initial support for writing buffers descriptions.
by Nikolay Sivov (＠nsivov) 08 Feb '24

08 Feb '24

-- v4: vkd3d-shader/fx: Do not align structured data section. vkd3d-shader/fx: Add initial support for writing buffers descriptions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/636

3 9

[PATCH v6 0/2] MR5047: server, ntdll: Use 64 bit for unix thread id.
by Marc-Aurel Zent (＠mzent) 08 Feb '24

08 Feb '24

This is in preparation for the mach thread id rework, which requires 64 bit there (and incidentally also stops truncating the FreeBSD one). There wasn't any direct usage of `__int64` in the sever protocol before, so I added a new typedef and a new `dump_int64()` function (not sure if needed per se though). -- v6: ntdll: Remove unneeded FreeBSD codepath in get_unix_tid(). server, ntdll: Use 64 bit for unix thread id. https://gitlab.winehq.org/wine/wine/-/merge_requests/5047

2 2

[PATCH v5 0/2] MR5047: server, ntdll: Use 64 bit for unix thread id.
by Marc-Aurel Zent (＠mzent) 08 Feb '24

08 Feb '24

This is in preparation for the mach thread id rework, which requires 64 bit there (and incidentally also stops truncating the FreeBSD one). There wasn't any direct usage of `__int64` in the sever protocol before, so I added a new typedef and a new `dump_int64()` function (not sure if needed per se though). -- v5: ntdll: Remove unneeded FreeBSD codepath in get_unix_tid(). server, ntdll: Use 64 bit for unix thread id. https://gitlab.winehq.org/wine/wine/-/merge_requests/5047

2 3