February 2024 - Wine-gitlab

[PATCH v2 0/1] MR5056: ntdll: Fix DW_OP_abs absolute value warning on labs() for clang.
by Marc-Aurel Zent (＠mzent) 08 Feb '24

08 Feb '24

Fixes the following warning on clang-15: ``` dlls/ntdll/unix/dwarf.h:915:45: warning: taking the absolute value of unsigned type 'ULONG_PTR' (aka 'unsigned long') has no effect [-Wabsolute-value] case DW_OP_abs: stack[sp] = labs(stack[sp]); break; ^ dlls/ntdll/unix/dwarf.h:915:45: note: remove the call to 'labs' since unsigned values cannot be negative case DW_OP_abs: stack[sp] = labs(stack[sp]); break; ^~~~ ``` Despite what it says the existing code was functioning correctly already though AFAICT. -- v2: ntdll: Fix DW_OP_abs absolute value warning on labs() for clang. https://gitlab.winehq.org/wine/wine/-/merge_requests/5056

3 2

Re: [PATCH v2 0/1] MR5054: explorer: Handle the back and forward buttons of a 5-button mouse. - approved
by Alexandre Julliard (＠julliard) 08 Feb '24

08 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5054

1 0

Re: [PATCH v2 0/1] MR5036: win32u: Use consistent locking order for display related mutexes. - approved
by Alexandre Julliard (＠julliard) 08 Feb '24

08 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5036

1 0

Re: [PATCH v2 0/3] MR5032: server: Use different structures for hardware input and rawinput messages. - approved
by Alexandre Julliard (＠julliard) 08 Feb '24

08 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5032

1 0

Re: [PATCH v3 0/4] MR4983: mfreadwrite/tests: Test source reader transforms with video processing attributes. - approved
by Alexandre Julliard (＠julliard) 08 Feb '24

08 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4983

1 0

[PATCH v2 0/1] MR3422: ddraw tests for Pick and GetPickRecords
by Jeffrey Smith (＠whydoubt) 08 Feb '24

08 Feb '24

Basically, this is the tests from https://gitlab.winehq.org/wine/wine/-/merge_requests/3420 with fixes applied where they originate, rather than later in the series. -- v2: ddraw/tests: Test Pick() and GetPickRecords(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3422

3 3

[PATCH v24 0/7] MR4982: Load and play MIDI
by Yuxuan Shui (＠yshui) 08 Feb '24

08 Feb '24

There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached. Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not. -- v24: dmime: Create a band track for MIDI segments. dmime/tests: wip test for midi play dmime: Implement IDirectMusicTrack_Play for MIDI tracks. dmime: Parse MIDI tracks. https://gitlab.winehq.org/wine/wine/-/merge_requests/4982

3 9

Re: [PATCH v25 0/4] MR4982: dmime: load MIDI files
by Yuxuan Shui (＠yshui) 08 Feb '24

08 Feb '24

On Thu Feb 8 18:34:03 2024 +0000, Rémi Bernon wrote: > Yes since playing midi tracks turned out to be more involved, let's do this piecemeal like you said. i made this MR just about parsing, is this mergeable? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4982#note_60649

1 0

[PATCH 0/1] MR5006: msxml3: Enable XPath object cache.
by Hans Leidekker (＠hans) 08 Feb '24

08 Feb '24

This gives a 30% performance increase in a local test with a very large document. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5006

3 3

[PATCH v2 0/1] MR4828: mf: Only preroll when starting from stopped state.
by Yuxuan Shui (＠yshui) 08 Feb '24

08 Feb '24

Stream sink such as evr can't be prerolled a second time, and when we are restarting from a paused state, those stream sink will already be prerolled so don't preroll them again. Otherwise we will be waiting for Prerolled events that will never come. Split from !4545, splitting the fix from the tests because turns out the tests are contentious. -- v2: mf: Only preroll when starting from stopped state. https://gitlab.winehq.org/wine/wine/-/merge_requests/4828

3 2