March 2024 - Wine-gitlab - list.winehq.org

[PATCH v3 0/3] MR4826: Mach vm operations improvements
by Marc-Aurel Zent (＠mzent) 04 Mar '24

04 Mar '24

For all mach vm operations this removes the task suspend and resume, which are not needed. This uses `mach_vm_read_overwrite` to read into a caller-specified buffer, saving the `mach_vm_deallocate` call (bringing all read operations down to 1 syscall from 4). The only alignment restriction on `mach_vm_write` according to the original CMU documentation is that data is > [pointer to page aligned in array of bytes] An array of data to be written. (In practice it also works with arbitrary addresses on macOS, but it probably doesn't hurt to follow the original specifications here). The only other reference that these read/writes should be page-aligned is from the GNU Hurd documentation > The current implementation requires that address, data and data_count all be page-aligned. Otherwise, KERN_INVALID_ARGUMENT is returned. which I assume was the reason why this was originally done (plus it sounds to me like they will fix that in the future and 4fe19777 already broke GNU Hurd support anyways, if that was supposed to be working). Also this includes the missing mach part of 5b1f3b14, which was only applied to the ptrace backend, and together with the `write_process_memory` rework, this gets rid of all fixmes in mach.c -- v3: server: Simplify mach write_process_memory. server: Use mach_vm_read_overwrite in get_selector_entry. server: Use mach_vm_read_overwrite in read_process_memory. https://gitlab.winehq.org/wine/wine/-/merge_requests/4826

2 4

[PATCH 0/1] MR5218: mfreadwrite/reader: Adjust min_buffer_size to be 1s of audio data.
by Rémi Bernon 04 Mar '24

04 Mar '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5218

3 3

[PATCH 0/2] MR5158: rtworkq: Avoid closing a thread pool object while its callbacks are running.
by Zhiyi Zhang (＠zhiyi) 04 Mar '24

04 Mar '24

Patch 2 fixes a race condition in theory. I haven't found it affecting any real-world applications. These two bugs are caused by race conditions. I don't think adding tests could demonstrate them reliably. This MR can probably fix the race condition mentioned at https://gitlab.winehq.org/wine/wine/-/merge_requests/4243 patch 3. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5158

3 4

Re: [PATCH v2 0/1] MR685: vkd3d-shader/hlsl: Write the SFI0 section and "REQUIRES_ROVS" flag when ROVs are used.
by Giovanni Mascellani (＠giomasce) 04 Mar '24

04 Mar '24

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/tpf.c: > > +static void write_sm4_sfi0(struct hlsl_ctx *ctx, struct dxbc_writer *dxbc) > +{ > + struct extern_resource *extern_resources; > + unsigned int extern_resources_count; > + uint64_t *flags; > + > + flags = vkd3d_calloc(1, sizeof(*flags)); > + > + extern_resources = sm4_get_extern_resources(ctx, &extern_resources_count); > + for (unsigned int i = 0; i < extern_resources_count; ++i) > + { > + if (extern_resources[i].data_type->e.resource.rasteriser_ordered) > + *flags |= VKD3D_SM4_REQUIRES_ROVS; > + } > + sm4_free_extern_resources(extern_resources, extern_resources_count); I'd rather accumulate flags while compiling the shader rather than doing another pass at the end. Not a terribly strong opinion, though. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/685#note_63346

1 0

[PATCH v2 0/1] MR5203: webservices/tests: Fix -Warray-bounds warning on gcc 13.2.0.
by Connor McAdams (＠cmcadams) 04 Mar '24

04 Mar '24

-- v2: webservices/tests: Fix -Warray-bounds warning on gcc 13.2.0. https://gitlab.winehq.org/wine/wine/-/merge_requests/5203

3 2

[PATCH v2 0/1] MR5208: winebus.sys: Only attempt to open joysticks and gamepads in the IOHID backend.
by Tim Clem (＠tclem) 04 Mar '24

04 Mar '24

An extension of 3985b7c5. Opening the device for the Touch Bar on older MacBooks also triggers a permission prompt, so for now it makes sense to restrict the devices open. -- v2: winebus.sys: Only attempt to open joysticks and gamepads in the IOHID backend. https://gitlab.winehq.org/wine/wine/-/merge_requests/5208

3 2

[PATCH 0/5] MR5220: win32u: Move vulkan d3dkmt implementation out of winex11.
by Rémi Bernon 04 Mar '24

04 Mar '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5220

2 6

[PATCH v2 0/7] MR5174: win32u: Simplify sysparams using ascii strings for registry operations when possible.
by Rémi Bernon 04 Mar '24

04 Mar '24

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/5137 -- v2: win32u: Introduce and use new reg_(open|create)_ascii_key helpers. win32u: Use set_reg_ascii_value whenever possible. win32u: Remove unnecessary class_guidW double check. win32u: Use REG_SZ instead of REG_BINARY for some adapter keys. win32u: Remove unused wine_devpropkey_monitor_adapternameW property. win32u: Simplify adapter key path creation from gpu_guid. win32u: Use char array for the device manager context gpuid. https://gitlab.winehq.org/wine/wine/-/merge_requests/5174

1 8

[PATCH 0/2] MR5217: advapi32: Check NULL return key pointers when creating registry keys.
by Zhiyi Zhang (＠zhiyi) 04 Mar '24

04 Mar '24

Fix Warlords Battlecry III (433280) crashes at launch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5217

2 2

[PATCH v3 0/3] MR5118: Administrator tokens, part 1: Elevate processes where necessary.
by Zebediah Figura (＠zfigura) 04 Mar '24

04 Mar '24

Wine currently runs all processes with an elevated administrator token. As described in bug 40613, some applications refuse to be run with such a token. This patch set addresses the situation by creating all processes with an unelevated adminstrator token by default. When a process attempts to elevate itself through one of several mechanisms—which would show a UAC prompt on Windows—we instead silently elevate the process, as if the user had granted access through the UAC prompt. This works for almost all applications. I have found only one application which didn't get the memo, and actually asks the user to right click and run as administrator, namely PaintTool SAI. Fortunately, 063a377df4f, combined with the shell32 patch in this series, allows a Wine user to elevate that process by opening explorer.exe, right-clicking, and selecting Run as Administrator, just like on Windows. This patch series has been in Wine-Staging for about three years. This was partly to try to find and fix all the different creative ways that applications tried to elevate themselves, but mostly because I needed to find a solution for PaintTool SAI, and never quite got the time to implement run-as-administrator in shell32. EDIT: Now only includes the patches elevating processes through specific methods (runas, msi). -- v3: https://gitlab.winehq.org/wine/wine/-/merge_requests/5118

3 5