March 2024 - Wine-gitlab - list.winehq.org

Re: [PATCH v4 0/1] MR1060: include: Remove interfaces already define in msxml6.idl
by Nikolay Sivov (＠nsivov) 22 Mar '24

22 Mar '24

On Fri Mar 22 03:18:49 2024 +0000, Zebediah Figura wrote: > Is fixing the headers undesirable, then? > Is it necessary in some way to implement FreeThreadedXMLHTTP60, or can > that be done differently? No, I think it is desirable. I'm going to move some more tests out, to build with either msxml2.idl or msxml6.idl, and then we'll see what's left. XMLHTTP60 patches in the form they currently are in staging needs some work done, specifically not using rtworkq.dll. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1060#note_65806

1 0

[PATCH v3 0/5] MR5365: win32u: Introduce a new common vulkan source.
by Rémi Bernon 22 Mar '24

22 Mar '24

I missed that Zhiyi was out so I've just reordered this, calling __wine_get_vulkan_driver from winex11 d3dkmt instead. -- v3: win32u: Move vkGet(Device|Instance)ProcAddr helpers inline. winevulkan: Stop generating the wine/vulkan_driver.h header. win32u: Move vkGet(Instance|Device)ProcAddr out the drivers. win32u: Move vulkan loading and init guard out of the drivers. winemac: Use SONAME_LIBVULKAN as an alias for MoltenVK. https://gitlab.winehq.org/wine/wine/-/merge_requests/5365

2 7

[PATCH v9 0/3] MR734: vkd3d-shader/dxil: SamplePosition and SampleCount.
by Conor McCarthy (＠cmccarthy) 22 Mar '24

22 Mar '24

-- v9: vkd3d-shader/dxil: Implement DX intrinsic RenderTargetGetSampleCount. vkd3d-shader/dxil: Implement DX intrinsics Texture2DMSGetSamplePosition and RenderTargetGetSamplePosition. tests/hlsl: Add tests for GetSamplePosition() and GetSampleCount(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/734

2 3

[PATCH 0/1] MR5372: Draft: wbemprox: Stub most of the Win32_VideoController properties.
by Aida Jonikienė 22 Mar '24

22 Mar '24

This issue originated on IRC (a person complained about Tomato Jones II not working but the ole errors in the log weren't actually an issue). With this patch the game boots to the main menu (at least with wine-staging). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5372

3 12

[PATCH v6 0/1] MR5361: user32: Add LoadKeyboardLayoutEx stub.
by Vijay Kiran Kamuju (＠infyquest) 22 Mar '24

22 Mar '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=28170 -- v6: user32: Add LoadKeyboardLayoutEx stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/5361

3 3

[PATCH 0/3] MR5386: user32: Add LoadKeyboardLayoutEx stub.
by Rémi Bernon 22 Mar '24

22 Mar '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=28170 Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/5361 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5386

3 5

[PATCH v5 0/3] MR5361: user32: Add LoadKeyboardLayoutEx stub.
by Vijay Kiran Kamuju (＠infyquest) 22 Mar '24

22 Mar '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=28170 -- v5: Apply 1 suggestion(s) to 1 file(s) https://gitlab.winehq.org/wine/wine/-/merge_requests/5361

4 4

Re: [PATCH v3 0/1] MR5361: user32: Add LoadKeyboardLayoutEx stub.
by Vijay Kiran Kamuju (＠infyquest) 22 Mar '24

22 Mar '24

Please investigate this further as I am not sure why. From other internet sources, it internally calls the NtUserLoadKeyboardLayoutEx. I am not sure how the this internal function works and it seems there was a famous exploit using this internal function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5361#note_65791

1 0

Re: [PATCH v3 0/1] MR5361: user32: Add LoadKeyboardLayoutEx stub.
by Rémi Bernon 22 Mar '24

22 Mar '24

There's not much point rebasing this every day. The test seems to break some other tests and it also somehow messes with the loaded keyboard layouts list. I want to investigate a bit further how this function behaves. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5361#note_65790

1 0

Re: [PATCH v3 0/1] MR5361: user32: Add LoadKeyboardLayoutEx stub.
by Rémi Bernon 22 Mar '24

22 Mar '24

Rémi Bernon (@rbernon) commented about dlls/user32/input.c: > } > > > +/*********************************************************************** > + * LoadKeyboardLayoutEx (USER32.@) > + */ > +HKL WINAPI LoadKeyboardLayoutEx( HKL layout, const WCHAR *name, UINT flags ) > +{ > + FIXME_(keyboard)( "layout %p, name %s, flags %x, semi-stub!\n", layout, debugstr_w( name ), flags ); > + > + if (!layout) > + return NULL; > + > + return LoadKeyboardLayoutW(name, flags); ```suggestion:-3+0 if (!layout) return NULL; return LoadKeyboardLayoutW( name, flags ); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5361#note_65788

1 0