March 2024 - Wine-gitlab - list.winehq.org

Re: [PATCH v3 0/1] MR5361: user32: Add LoadKeyboardLayoutEx stub.
by Vijay Kiran Kamuju (＠infyquest) 22 Mar '24

22 Mar '24

Please investigate this further as I am not sure why. From other internet sources, it internally calls the NtUserLoadKeyboardLayoutEx. I am not sure how the this internal function works and it seems there was a famous exploit using this internal function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5361#note_65791

1 0

Re: [PATCH v3 0/1] MR5361: user32: Add LoadKeyboardLayoutEx stub.
by Rémi Bernon 22 Mar '24

22 Mar '24

There's not much point rebasing this every day. The test seems to break some other tests and it also somehow messes with the loaded keyboard layouts list. I want to investigate a bit further how this function behaves. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5361#note_65790

1 0

Re: [PATCH v3 0/1] MR5361: user32: Add LoadKeyboardLayoutEx stub.
by Rémi Bernon 22 Mar '24

22 Mar '24

Rémi Bernon (@rbernon) commented about dlls/user32/input.c: > } > > > +/*********************************************************************** > + * LoadKeyboardLayoutEx (USER32.@) > + */ > +HKL WINAPI LoadKeyboardLayoutEx( HKL layout, const WCHAR *name, UINT flags ) > +{ > + FIXME_(keyboard)( "layout %p, name %s, flags %x, semi-stub!\n", layout, debugstr_w( name ), flags ); > + > + if (!layout) > + return NULL; > + > + return LoadKeyboardLayoutW(name, flags); ```suggestion:-3+0 if (!layout) return NULL; return LoadKeyboardLayoutW( name, flags ); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5361#note_65788

1 0

Re: [PATCH v3 0/1] MR5361: user32: Add LoadKeyboardLayoutEx stub.
by Rémi Bernon 22 Mar '24

22 Mar '24

Rémi Bernon (@rbernon) commented about dlls/user32/tests/input.c: > } > } > > +static void test_keyboard_layoutex(void) ```suggestion:-0+0 static void test_LoadKeyboardLayoutEx(void) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5361#note_65789

1 0

Re: [PATCH v3 0/1] MR4878: advpack: Ignore lines that begin with '@' in (Un)RegisterOCXs sections.
by Alexandre Julliard (＠julliard) 22 Mar '24

22 Mar '24

Alexandre Julliard (@julliard) commented about dlls/advpack/tests/install.c: > "Signature=\"$Chicago$\"\n" > "AdvancedINF=2.5\n" > "[DefaultInstall]\n" > - "CheckAdminRights=1\n"; > + "CheckAdminRights=1\n" > + "[OcxInstall]\n" > + "RegisterOCXs=OCXsToRegister\n" > + "[OCXsToRegister]\n" > + "@foobar\n" > + "@foobaz\n"; That's not a very convincing test. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4878#note_65786

1 0

[PATCH v2 0/1] MR5382: gitlab: Output collapsible section markers in test stage script.
by Jinoh Kang (＠iamahuman) 22 Mar '24

22 Mar '24

See pipeline "test-linux-*" job output for preview. -- v2: gitlab: Output collapsible section markers in test stage script. https://gitlab.winehq.org/wine/wine/-/merge_requests/5382

2 1

[PATCH v8 0/3] MR734: vkd3d-shader/dxil: SamplePosition and SampleCount.
by Conor McCarthy (＠cmccarthy) 22 Mar '24

22 Mar '24

-- v8: vkd3d-shader/dxil: Implement DX intrinsic RenderTargetGetSampleCount. vkd3d-shader/dxil: Implement DX intrinsics Texture2DMSGetSamplePosition and RenderTargetGetSamplePosition. tests/hlsl: Add tests for GetSamplePosition() and GetSampleCount(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/734

2 3

[PATCH v7 0/3] MR734: vkd3d-shader/dxil: SamplePosition and SampleCount.
by Conor McCarthy (＠cmccarthy) 22 Mar '24

22 Mar '24

-- v7: vkd3d-shader/dxil: Implement DX intrinsic RenderTargetGetSampleCount. vkd3d-shader/dxil: Implement DX intrinsics Texture2DMSGetSamplePosition and RenderTargetGetSamplePosition. tests/hlsl: Add tests for GetSamplePosition() and GetSampleCount(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/734

2 3

[PATCH 0/1] MR5382: gitlab: Output collapsible section markers in test stage script.
by Jinoh Kang (＠iamahuman) 22 Mar '24

22 Mar '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5382

2 2

[PATCH v3 0/2] MR5238: krnl386, mmsystem: Simulate a hardware interrupt in MMSYSTDRV_Callback3216.
by Alex Henrie (＠alexhenrie) 22 Mar '24

22 Mar '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56260 -- v3: mmsystem: Simulate a hardware interrupt in MMSYSTDRV_Callback3216. krnl386: Add a function to simulate a hardware interrupt. https://gitlab.winehq.org/wine/wine/-/merge_requests/5238

2 2