August 2024 - Wine-gitlab - list.winehq.org

Re: [PATCH v32 0/4] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Vibhav Pant (＠vibhavp) 29 Aug '24

29 Aug '24

On Thu Aug 29 16:19:09 2024 +0000, Elizabeth Figura wrote: > Actually, I'm a bit confused, because now I'm not sure where RPC does do > that? I was assuming it was a user-marshalled type which implicitly > calls DuplicateHandle(), but that's not the case. > The lack of tests in this patch set is a little disturbing. Is it > possible to test this behaviour? I don't know under what circumstances > handle events are sent [and I can't easily find anyone successfully > using DBT_DEVTYP_HANDLE online]. We do have support for testing PnP > drivers, though, if that's necessary; see dlls/ntoskrnl.exe/tests/driver_pnp.c. @zfigura Testing it is tricky. My plan was to utilize it in the bluetooth driver by directly calling `plugplay_send_event` from the driver code itself, and I'm not sure what the equivalent of that would be in Windows. @rbernon I'm okay with using reserved as an offset to pass the device path, but we'd still have to pass it for every message for filtering. I didn't want to utilize `reserved` mostly out of caution, if it ever turned out to be that the field did have some undocumented semantics after all. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6315#note_80493

1 0

[PATCH 0/1] MR6403: winemac.drv: Call CGWindowListCreateImageFromArray through a dlsym-obtained pointer.
by Brendan Shanks (＠bshanks) 29 Aug '24

29 Aug '24

The macOS Sequoia SDK has "obsoleted" this function: calling it triggers a build error when targeting macOS Sequoia. It can still be used though, either by targeting pre-Sequoia or by getting a pointer to the function through dlsym(). This is intended to be temporary until ScreenCaptureKit.framework or some other approach can be used (see !5935). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6403

2 1

Re: [PATCH v2 0/1] MR6371: mfreadwrite: Always try inserting a converter for non-video streams. - approved
by Alexandre Julliard (＠julliard) 29 Aug '24

29 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6371

1 0

Re: [PATCH v2 0/4] MR6376: ntdll: Don't use TlsLinks in TEB. - approved
by Alexandre Julliard (＠julliard) 29 Aug '24

29 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6376

1 0

Re: [PATCH v2 0/1] MR6391: dxcore: Prefer native. - approved
by Alexandre Julliard (＠julliard) 29 Aug '24

29 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6391

1 0

[PATCH v4 0/1] MR6367: explorer: Use the EnableShell option to show or hide the taskbar.
by Rémi Bernon 29 Aug '24

29 Aug '24

The option is on by default with the virtual desktop, off by default otherwise, but can be forced on/off in either case, letting it hide the taskbar in virtual desktop mode too. The standalone systray window still uses the separate ShowSystray option which can be enabled when EnableShell is off. When EnableShell is on, the systray area will always be visible in the taskbar. -- v4: explorer: Use the EnableShell option to show or hide the taskbar. https://gitlab.winehq.org/wine/wine/-/merge_requests/6367

2 2

Re: [PATCH v2 0/1] MR6393: winemapi: Directly use xdg-email if available. - approved
by Alexandre Julliard (＠julliard) 29 Aug '24

29 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6393

1 0

Re: [PATCH v2 0/1] MR6397: include: Always declare the imagelist read and write functions. - approved
by Alexandre Julliard (＠julliard) 29 Aug '24

29 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6397

1 0

Re: [PATCH v4 0/1] MR6366: odbccp32: write_registry_values only append slash if required - approved
by Alexandre Julliard (＠julliard) 29 Aug '24

29 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6366

1 0

Re: [PATCH v2 0/1] MR6395: msiexec: Remove an obsolete fixme. - approved
by Alexandre Julliard (＠julliard) 29 Aug '24

29 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6395

1 0