August 2024 - Wine-gitlab - list.winehq.org

[PATCH 0/1] MR6392: concrt140: Don't forward _IsSynchronouslyBlocked functions.
by Paul Gofman (＠gofman) 29 Aug '24

29 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6392

4 4

Re: [PATCH v32 0/4] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Rémi Bernon 29 Aug '24

29 Aug '24

On Thu Aug 29 07:47:26 2024 +0000, Rémi Bernon wrote: > This is a huge amount of changes and it doesn't seem really justified? I > think you can do everything you need with DEV_BROADCAST_HDR already and > do not need any internal structs, or am I missing something? I mean, DEV_BROADCAST_HANDLE has a dbch_nameoffset which you can use to put the device name in it, and use that for filtering? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6315#note_80369

1 0

Re: [PATCH v32 0/4] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Rémi Bernon 29 Aug '24

29 Aug '24

Rémi Bernon (@rbernon) commented about include/wine/dbt.h: > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#ifndef __WINE_WINE_DBT_H_ > +#define __WINE_WINE_DBT_H_ > + > +#include <wine/plugplay.h> > +#include <wine/debug.h> > + > +struct device_notification_details This is a huge amount of changes and it doesn't seem really justified? I think you can do everything you need with DEV_BROADCAST_HDR already and do not need any internal structs, or am I missing something? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6315#note_80368

1 0

Re: [PATCH v2 0/2] MR6394: odbc32: Support SQLBindParameter fallback
by Hans Leidekker (＠hans) 29 Aug '24

29 Aug '24

SQLBindParameter() is a v2 function so I don't see why it would need a fallback. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6394#note_80367

1 0

Re: [PATCH v2 0/2] MR6394: odbc32: Support SQLBindParameter fallback
by Alistair Leslie-Hughes (＠alesliehughes) 29 Aug '24

29 Aug '24

On Thu Aug 29 07:07:25 2024 +0000, Hans Leidekker wrote: > Can you share a trace? I'd like to see how the app calls this function. I'm not able to find a currently log with a call to this function. All the logs to have show this function wasn't supported in the ODBC v2.0 driver. 0024:trace:odbc:load_function_table failed to load SQLBindParam This could of been another application I was testing at the time but I'm cannot remember which one. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6394#note_80366

1 0

[PATCH v3 0/1] MR6366: odbccp32: write_registry_values only append slash if required
by Alistair Leslie-Hughes (＠alesliehughes) 29 Aug '24

29 Aug '24

-- v3: odbccp32: write_registry_values only append slash if required https://gitlab.winehq.org/wine/wine/-/merge_requests/6366

3 2

Re: [PATCH v2 0/2] MR6394: odbc32: Support SQLBindParameter fallback
by Hans Leidekker (＠hans) 29 Aug '24

29 Aug '24

Can you share a trace? I'd like to see how the app calls this function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6394#note_80363

1 0

[PATCH 0/1] MR6393: winemapi: Directly use xdg-email if available.
by Elizabeth Figura (＠zfigura) 29 Aug '24

29 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6393

3 3

[PATCH v2 0/1] MR6367: explorer: Use the EnableShell option to show or hide the taskbar.
by Rémi Bernon 29 Aug '24

29 Aug '24

The option is on by default with the virtual desktop, off by default otherwise, but can be forced on/off in either case, letting it hide the taskbar in virtual desktop mode too. The standalone systray window still uses the separate ShowSystray option which can be enabled when EnableShell is off. When EnableShell is on, the systray area will always be visible in the taskbar. -- v2: explorer: Use the EnableShell option to show or hide the taskbar. https://gitlab.winehq.org/wine/wine/-/merge_requests/6367

2 4

Re: [PATCH v5 0/2] MR6059: mf: Retry PROCESSINPUTNOTIFY if TRANSFORM_TYPE_NOT_SET is returned.
by Brendan McGrath (＠redmcg) 29 Aug '24

29 Aug '24

@nsivov Are you happy with this MR as is? Or does it something else? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6059#note_80357

1 0