August 2024 - Wine-gitlab - list.winehq.org

Re: [PATCH v32 0/4] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Elizabeth Figura (＠zfigura) 29 Aug '24

29 Aug '24

On Thu Aug 29 16:15:21 2024 +0000, Elizabeth Figura wrote: > The problem isn't the name, it's the HANDLE. I suppose we *could* > manually fix that up later, but letting RPC take care of it for us seems > fine enough to me. Actually, I'm a bit confused, because now I'm not sure where RPC does do that? I was assuming it was a user-marshalled type which implicitly calls DuplicateHandle(), but that's not the case. The lack of tests in this patch set is a little disturbing. Is it possible to test this behaviour? I don't know under what circumstances handle events are sent [and I can't easily find anyone successfully using DBT_DEVTYP_HANDLE online]. We do have support for testing PnP drivers, though, if that's necessary; see dlls/ntoskrnl.exe/tests/driver_pnp.c. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6315#note_80395

1 0

Re: [PATCH v32 0/4] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Elizabeth Figura (＠zfigura) 29 Aug '24

29 Aug '24

On Thu Aug 29 07:59:06 2024 +0000, Rémi Bernon wrote: > I mean, DEV_BROADCAST_HANDLE has a dbch_nameoffset which you can use to > put the device name in it, and use that for filtering? Or if you need an > additional offset, dbch_reserved? > (Then IMO it'd be better to not have to pass the device path through RPC > for filtering on every message) The problem isn't the name, it's the HANDLE. I suppose we *could* manually fix that up later, but letting RPC take care of it for us seems fine enough to me. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6315#note_80394

1 0

[PATCH 0/1] MR6397: include: Always declare the imagelist read and write functions.
by Huw Davies (＠huw) 29 Aug '24

29 Aug '24

This matches the PSDK. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6397

3 2

[PATCH v8 0/8] MR5819: win32u: Fix DPI conversions in process_mouse_message.
by Rémi Bernon 29 Aug '24

29 Aug '24

-- v8: winex11: Map message pos to physical DPI in move_resize_window. win32u: Avoid changing thread DPI context in process_hardware_message. win32u: Factor hardware message point DPI mapping together. win32u: Use map_window_points with explicit DPI over screen_to_client. win32u: Split hardware message window lookup to a separate helper. win32u: Use per-monitor DPI window_from_point in process_mouse_message. win32u: Parameterize window_from_point dpi. server: Pass window's per-monitor DPI in set_window_pos. https://gitlab.winehq.org/wine/wine/-/merge_requests/5819

1 10

[PATCH v2 0/3] MR6386: winewayland: Reduce window surface buffer queue recreations.
by Rémi Bernon 29 Aug '24

29 Aug '24

-- v2: winewayland: Avoid recreating window surface buffer queues. winewayland: Create the window surface buffer queue unconditionally. winewayland: Set the window viewport source rectangle. https://gitlab.winehq.org/wine/wine/-/merge_requests/6386

1 4

Re: [PATCH v2 0/2] MR6394: odbc32: Support SQLBindParameter fallback
by Hans Leidekker (＠hans) 29 Aug '24

29 Aug '24

You don't need a fallback if you have SQLBindParameter(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6394#note_80374

1 0

Re: [PATCH v2 0/2] MR6394: odbc32: Support SQLBindParameter fallback
by Alistair Leslie-Hughes (＠alesliehughes) 29 Aug '24

29 Aug '24

The current Postgresql ODBC driver exports both SQLBindParam and SQLBindParameter. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6394#note_80372

1 0

Re: [PATCH v2 0/2] MR6394: odbc32: Support SQLBindParameter fallback - closed
by Alistair Leslie-Hughes (＠alesliehughes) 29 Aug '24

29 Aug '24

This merge request was closed by Alistair Leslie-Hughes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6394

1 0

Re: [PATCH v2 0/2] MR6394: odbc32: Support SQLBindParameter fallback
by Alistair Leslie-Hughes (＠alesliehughes) 29 Aug '24

29 Aug '24

I'll close this until I can workout why I needed it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6394#note_80371

1 0

[PATCH 0/1] MR6395: msiexec: Remove an obsolete fixme.
by Hans Leidekker (＠hans) 29 Aug '24

29 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6395

2 1