March 2025 - Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/1] MR6805: winewayland: Fix surface scaling with HiDPI compositor.
by 小亨 03 Mar '25

03 Mar '25

The icons and texts are too tiny in KDE Plasma 6 with 100% scaling on my 4K monitor, so I adjust it to 200%, and the window of my game just becomes 2x bigger, much bigger than my monitor. This doesn't make any sense! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6805#note_96557

1 0

[PATCH v3 0/1] MR7460: propsys/tests: Add broken for unexpected value in windows 7.
by Bernhard Übelacker 03 Mar '25

03 Mar '25

Tests show test propsys:propsys is failing for many Windows 7 machines. https://test.winehq.org/data/patterns-tb-win.html#propsys:propsys It looks like windows 7 processes VT_R4 like VT_R8. (`0.125f / 0x3e000000 (float/4 byte)` becomes `5.1392085562440189e-315 / 0x3e000000 (double/8 byte)`. Is this worth the effort to remove the failures from the test patterns page? -- v3: propsys/tests: Add broken for unexpected value in windows 7. https://gitlab.winehq.org/wine/wine/-/merge_requests/7460

1 3

[PATCH 0/1] MR7467: kernel32/tests: Work around Windows 7 issuing DllNotification even when loading with DONT_RESOLVE_DLL_REFERENCES
by Jinoh Kang (＠iamahuman) 03 Mar '25

03 Mar '25

Testbot result: https://testbot.winehq.org/JobDetails.pl?Key=151596 Fixes: 99e91f1c0fcb840b4840a4a3c2b079bad817b100 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57903 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7467

3 2

[PATCH v2 0/1] MR7451: dlls/shell32: Fix IUnknown::QueryInterface() to meet spec
by Edward OC (＠funfunctor) 03 Mar '25

03 Mar '25

The spec says if the passed pointer is NULL then return E_POINTER and not to just unconditionally deref then set NULL. Signed-off-by: Edward O'Callaghan <edward(a)antitrust.cc> -- v2: dlls/shell32: Fix IUnknown::QueryInterface() to meet spec https://gitlab.winehq.org/wine/wine/-/merge_requests/7451

4 12

[PATCH v2 0/1] MR7460: propsys/tests: Add broken for unexpected value in windows 7.
by Bernhard Übelacker 03 Mar '25

03 Mar '25

Tests show test propsys:propsys is failing for many Windows 7 machines. https://test.winehq.org/data/patterns-tb-win.html#propsys:propsys It looks like windows 7 processes VT_R4 like VT_R8. (`0.125f / 0x3e000000 (float/4 byte)` becomes `5.1392085562440189e-315 / 0x3e000000 (double/8 byte)`. Is this worth the effort to remove the failures from the test patterns page? -- v2: propsys/tests: Add broken for unexpected value in windows 7. https://gitlab.winehq.org/wine/wine/-/merge_requests/7460

2 4

Re: [PATCH v26 0/1] MR6884: Iphlpapi.dll: Included SendARP
by Huw Davies (＠huw) 03 Mar '25

03 Mar '25

It would be better to implement `SendARP()` in terms of `ResolveIpNetEntry2()`. Further, `ResolveIpNetEntry2()` should likely use the `Nsi` functions to retrieve the neighbour info from `nsiproxy`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6884#note_96536

1 0

[PATCH v4 0/6] MR7250: ntdll: Properly implement NtFlushProcessWriteBuffers (try 2).
by Jinoh Kang (＠iamahuman) 03 Mar '25

03 Mar '25

Supersedes !741. On macOS 10.14+ `thread_get_register_pointer_values` is called on every thread of the process. On Linux 4.14+ `membarrier(MEMBARRIER_CMD_PRIVATE_EXPEDITED, ...)` is used. On x86 Linux <= 4.13 and on other platforms it falls back to calling `NtGetContextThread()` on each thread. The fast path patches from @tmatthies are slightly modified in the following ways: 1. On unsupported platforms, the `try_*()` functions return `FALSE` instead of `0`. 2. `try_exp_membarrier()` is called first, then `try_mach_tgrpvs()`. --- Known applications fixed by this MR: - osu! (rhythm game) song selection menu stuttering - .NET CoreCLR GC - HotSpot JVM (-XX:+UseSystemMemoryBarrier) safepoints -- v4: kernel32/tests: Add a store buffering litmus test involving FlushProcessWriteBuffers. https://gitlab.winehq.org/wine/wine/-/merge_requests/7250

3 8

Re: [PATCH v2 0/1] MR7459: windowscodecs: Add support for WICBitmapTransformRotate270.
by Jinoh Kang (＠iamahuman) 03 Mar '25

03 Mar '25

On Mon Mar 3 11:04:01 2025 +0000, Jinoh Kang wrote: > My two cents: > This PR is a no-op change except for the test. While this PR improves > readability a little, I guess we could go further and handle flip > horz/vert flags in a more readable way if we want to go that direction? > (Otherwise just keeping the test should be fine too.) In any case, the commit message is misleading and should be reworded on commit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7459#note_96526

1 0

Re: [PATCH v2 0/1] MR7459: windowscodecs: Add support for WICBitmapTransformRotate270.
by Jinoh Kang (＠iamahuman) 03 Mar '25

03 Mar '25

On Mon Mar 3 08:08:34 2025 +0000, Dmitry Timoshkov wrote: > It looks like you are right, new tests actually pass with current > implementation. Although the patch makes support for > WICBitmapTransformRotate270 more explicit I'm not opposed to leave the > code intact. I'm open to suggestions. My two cents: This PR is a no-op change except for the test. While this PR improves readability a little, I guess we could go further and handle flip horz/vert flags in a more readable way if we want to go that direction? (Otherwise just keeping the test should be fine too.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7459#note_96525

1 0

[PATCH v5 0/1] MR7439: winedmo: Find mp3 stream info if channel data is missing.
by Brendan McGrath (＠redmcg) 03 Mar '25

03 Mar '25

This fixes missing mp3 channel data in the FFmpeg demuxer. -- v5: winedmo: Call avformat_find_stream_info for the mp3 format. https://gitlab.winehq.org/wine/wine/-/merge_requests/7439

3 3