March 2025 - Wine-gitlab - list.winehq.org

[PATCH v4 0/1] MR7439: winedmo: Find mp3 stream info if channel data is missing.
by Brendan McGrath (＠redmcg) 03 Mar '25

03 Mar '25

This fixes missing mp3 channel data in the FFmpeg demuxer. -- v4: winedmo: Call avformat_find_stream_info for the mp3 format. https://gitlab.winehq.org/wine/wine/-/merge_requests/7439

3 2

Re: [PATCH v3 0/1] MR7439: winedmo: Find mp3 stream info if channel data is missing.
by Brendan McGrath (＠redmcg) 03 Mar '25

03 Mar '25

Brendan McGrath (@redmcg) commented about dlls/winedmo/unix_demuxer.c: > } > format = demuxer->ctx->iformat; > > - if ((params->duration = get_context_duration( demuxer->ctx )) == AV_NOPTS_VALUE) > + if ((params->duration = get_context_duration( demuxer->ctx )) == AV_NOPTS_VALUE || > + strstr( format->name, "mp3")) > { > if ((ret = avformat_find_stream_info( demuxer->ctx, NULL )) < 0) > { > ERR( "Failed to find stream info, error %s.\n", debugstr_averr(ret) ); > goto failed; > } > - params->duration = get_context_duration( demuxer->ctx ); > + if (params->duration == AV_NOPTS_VALUE) > + params->duration = get_context_duration( demuxer->ctx ); @rbernon I wasn't sure how harmless/harmful this assignment was, so I added a check just in case. If you think it's unnecessary I'll remove. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7439#note_96517

1 0

[PATCH v2 0/1] MR7439: winedmo: Find mp3 stream info if channel data is missing.
by Brendan McGrath (＠redmcg) 03 Mar '25

03 Mar '25

This fixes missing mp3 channel data in the FFmpeg demuxer. -- v2: winedmo: Find mp3 stream info if channel data is missing. https://gitlab.winehq.org/wine/wine/-/merge_requests/7439

3 5

[PATCH v9 0/1] MR7288: winegstreamer: Avoid large buffer pushes in wg_transform.
by Yuxuan Shui (＠yshui) 03 Mar '25

03 Mar '25

## Context This is a problem discovered when running "Max: The Curse of Brotherhood" under proton. This game writes 4MB a piece into `wg_transform`, which contains about 4 seconds of compressed video. `wg_transform` calls `gst_pad_push` in `transform_ProcessOutput`, which takes \~300ms (i.e. 20 frames @ 60fps) to decode this buffer of video. So the end result is the game hitches every 4 seconds while playing cut scene videos. Proton currently has a special case for this particular game, for which it breaks up the buffer into small chunks to avoid long blocks. This MR adopts that and applies it generally. One concern raised by @redmcg is: > The only issue I can think of is if there are any decoders which don't have a parser; then they might not know how to deal with an arbitrary 4096 byte buffer (the parser is generally responsible for taking arbitrary buffers and producing something the decoder can work with, for example: a full frame). So this MR only enables this strategy when there is a parser element. -- v9: winegstreamer: Avoid large buffer pushes in wg_transform. https://gitlab.winehq.org/wine/wine/-/merge_requests/7288

3 4

[PATCH 0/2] MR7362: winex11.drv: Better detect and switch windows to managed.
by Paul Gofman (＠gofman) 03 Mar '25

03 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7362

4 8

Re: [PATCH v2 0/1] MR7459: windowscodecs: Add support for WICBitmapTransformRotate270.
by Dmitry Timoshkov (＠dmitry) 03 Mar '25

03 Mar '25

On Mon Mar 3 06:33:06 2025 +0000, Dmitry Timoshkov wrote: > The tests don't pass with existing code. It looks like you are right, new tests actually pass with current implementation. Although the patch makes support for WICBitmapTransformRotate270 more explicit I'm not opposed to leave the code intact. I'm open to suggestions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7459#note_96507

1 0

[PATCH 0/1] MR7464: cryptnet: Uniform return value that is the same as _wfsopen.
by Haoyang Chen (＠chenhaoyang) 03 Mar '25

03 Mar '25

INVALID_HANDLE_VALUE is non-zero, and the caller may fail to handle the error. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7464

3 2

Re: [PATCH v2 0/1] MR7459: windowscodecs: Add support for WICBitmapTransformRotate270.
by Dmitry Timoshkov (＠dmitry) 03 Mar '25

03 Mar '25

On Mon Mar 3 06:33:06 2025 +0000, Elizabeth Figura wrote: > Wait, isn't this already implemented? WICBitmapTransformRotate270 is the > bitwise OR of 90 and 180, and the code seems to take that into account, > am I missing something? The tests don't pass with existing code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7459#note_96498

1 0

[PATCH 0/5] MR7466: mf: Fix some issues with seeking.
by Conor McCarthy (＠cmccarthy) 02 Mar '25

02 Mar '25

This fixes failure to play the prologue video in Planet of the Apes: Last Frontier, which unpauses by calling Start() with a location. The exact state leading to this issue does not occur in the Start() tests, and it's not clear how to reproduce it reliably. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7466

2 5

[PATCH 0/1] MR7460: propsys/tests: Add broken for unexpected value in windows 7.
by Bernhard Übelacker 02 Mar '25

02 Mar '25

Tests show test propsys:propsys is failing for many Windows 7 machines. https://test.winehq.org/data/patterns-tb-win.html#propsys:propsys It looks like windows 7 processes VT_R4 like VT_R8. (`0.125f / 0x3e000000 (float/4 byte)` becomes `5.1392085562440189e-315 / 0x3e000000 (double/8 byte)`. Is this worth the effort to remove the failures from the test patterns page? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7460

2 3