March 2025 - Wine-gitlab - list.winehq.org

Re: [PATCH v6 0/2] MR7417: mfplat: Modify MFCreateWaveFormatExFromMFMediaType to allow all subtypes without MF_MT_USER_DATA.
by Brendan McGrath (＠redmcg) 02 Mar '25

02 Mar '25

On Sat Mar 1 21:59:13 2025 +0000, Brendan McGrath wrote: > I took a look at the linux-32 results, but I missed the mf failures (I > thought they were all ddraw). Why would linux-32 fail but not linux-64? > Anyway, it's the same test failing twice: > ``` > $ xmllint --xpath 'testsuites/testsuite/testcase[failure and > @classname="mf:transform"]/@name' winetest.xml > name="mf:transform transform.c:2587 Test failed: aacdec: > "MF_MT_USER_DATA": SetInputType returned 0." > name="mf:transform transform.c:2587 Test failed: aacdec: > "MF_MT_USER_DATA": SetInputType returned 0." > ``` > The test checks that a call to `SetInputType` on the AAC decoder returns > an error when `MF_MT_USER_DATA` is missing. It does so by relying on the > return value of `MFCreateWaveFormatExFromMFMediaType`. So it's dependent > on what was the broken behavior. I suspect it should also be checking > `cbSize`. I'll add tests to confirm as much and then fix. > Note, I have confirmed that we now have the correct behavior for > `MFCreateWaveFormatExFromMFMediaType` by adding (locally) the following > two tests: > ``` > @@ -5958,6 +5958,8 @@ static void test_MFCreateWaveFormatExFromMFMediaType(void) > { &MFAudioFormat_Float, WAVE_FORMAT_IEEE_FLOAT, > sizeof(WAVEFORMATEX), 0, }, > { &MFAudioFormat_MP3, WAVE_FORMAT_MPEGLAYER3, > sizeof(WAVEFORMATEX), 0, }, > { &DUMMY_GUID3, WAVE_FORMAT_EXTENSIBLE, > sizeof(WAVEFORMATEXTENSIBLE), 22, }, > + { &MFAudioFormat_AAC, WAVE_FORMAT_MPEG_HEAAC, > sizeof(WAVEFORMATEX), 0, }, > + { &MFAudioFormat_RAW_AAC, WAVE_FORMAT_RAW_AAC1, > sizeof(WAVEFORMATEX), 0, }, > ``` > Test bot passes: > https://testbot.winehq.org/JobDetails.pl?Key=151559 > Well Windows did, Debian crashed. I've raised MR !7465 to fix the failing test. I also add new tests that seem to indicate we are still missing some validation in the aac decoder around `MF_MT_USER_DATA`. For example, in one of the tests, I send a value of 44.1KHz in `MF_MT_AUDIO_SAMPLES_PER_SECOND`, but a value of 48KHz in `MF_MT_USER_DATA`. Windows returns `MF_E_INVALIDMEDIATYPE`, but we return `S_OK`. So this test is currently marked as todo. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7417#note_96490

1 0

Re: [PATCH v2 0/1] MR7459: windowscodecs: Add support for WICBitmapTransformRotate270.
by Elizabeth Figura (＠zfigura) 02 Mar '25

02 Mar '25

Wait, isn't this already implemented? WICBitmapTransformRotate270 is the bitwise OR of 90 and 180, and the code seems to take that into account, am I missing something? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7459#note_96487

1 0

[PATCH v2 0/10] MR7407: windowscodecs: Implement query strings enumerator.
by Nikolay Sivov (＠nsivov) 02 Mar '25

02 Mar '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: windowscodecs: Implement GetPreferredVendorGUID(). windowscodecs/metadata: Implement GetClassID(). windowscodecs/tests: Add some tests for metadata handler GetClassID(). windowscodecs/metadata: Replicate original stream position when creating writer instances from readers. windowscodecs/metadata: Restore original stream position on GetStream(). windowscodecs/tests: Add some tests for stream position handling when nested readers are used. windowscodecs: Implement CreateQueryWriterFromReader(). windowscodecs/metadata: Do not decorate 'wstr' items with a type name in returned queries. windowscodecs/tests: Add some more tests for query enumeration. windowscodecs: Implement query strings enumerator. https://gitlab.winehq.org/wine/wine/-/merge_requests/7407

3 14

Re: [PATCH v2 0/1] MR7459: windowscodecs: Add support for WICBitmapTransformRotate270. - approved
by Esme Povirk (＠madewokherd) 02 Mar '25

02 Mar '25

This merge request was approved by Esme Povirk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7459

1 0

[PATCH v2 0/1] MR7458: kernelbase/tests: Skip test if EnumSystemFirmwareTables is not available.
by Bernhard Übelacker 02 Mar '25

02 Mar '25

Tests show test kernelbase:memory is failing for many Windows 7 machines. https://test.winehq.org/data/patterns-tb-win.html#kernelbase:memory This patch adds skipping the test if function `EnumSystemFirmwareTables` is not found. -- v2: kernelbase/tests: Skip test if EnumSystemFirmwareTables is not available. https://gitlab.winehq.org/wine/wine/-/merge_requests/7458

2 4

[PATCH 0/1] MR7463: Draft: maintainers: Remove myself as the Stable maintainer.
by Michael Stefaniuc (＠mstefani) 02 Mar '25

02 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7463

2 1

[PATCH v3 0/2] MR7443: d2d1/tests: Add some tests for device context handling in the DC target.
by Nikolay Sivov (＠nsivov) 02 Mar '25

02 Mar '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: d2d1: Update DC target surface with current HDC contents on BeginDraw(). d2d1/tests: Add some tests for device context handling in the DC target. https://gitlab.winehq.org/wine/wine/-/merge_requests/7443

3 3

[PATCH 0/1] MR7458: kernelbase/tests: Skip test if EnumSystemFirmwareTables is not available.
by Bernhard Übelacker 02 Mar '25

02 Mar '25

Tests show test kernelbase:memory is failing for many Windows 7 machines. https://test.winehq.org/data/patterns-tb-win.html#kernelbase:memory This patch adds skipping the test if function `EnumSystemFirmwareTables` is not found. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7458

2 3

[PATCH 0/1] MR7459: windowscodecs: Add support for WICBitmapTransformRotate270.
by Dmitry Timoshkov (＠dmitry) 02 Mar '25

02 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7459

2 1

[PATCH v5 0/1] MR7353: winewayland: Implement SetCursorPos via pointer lock.
by Attila Fidan (＠atticf) 02 Mar '25

02 Mar '25

There is no ([not yet?](https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requ…) dedicated protocol for requesting pointer warps, but it's possible to request one with `zwp_locked_pointer_v1.set_cursor_position_hint` which may be performed when the pointer is unlocked. The idea is to quickly lock/set position/unlock. This is used by SDL (in some cases: [SDL_MOUSE_EMULATE_WARP_WITH_RELATIVE](https://wiki.libsdl.org/SDL3/SDL_HINT…) and Xwayland. The limitation is/will be that the compositor will ignore requests to warp the pointer outside of surface bounds. What I'd like to have working is the auto cursor placement feature of some applications, where they just want to call SetCursorPos towards specific UI elements inside their single window, and usually they'll be unclipped and have a visible cursor while doing this. This patch also happens to allow mouselook to work in applications which use SetCursorPos for mouselook and aren't getting covered by the heuristics that turn on Wayland relative motion (for some reason the driver thinks the cursor is visible). Seems to affect Half-Life (GoldSrc) on my system. Though force enabling relative motion with an environment variable in a custom build or somehow improving the heuristics will also fix that. ~~A suface/pointer can only have one lock or confinement, and this implementation depends on the pointer lock. So if needed, I temporarily unlock/unconfine in order to do the warp then relock/reconfine. I modified `wayland_pointer_update_constraint` so I don't have to temporarily disable relative motion during this in case it's enabled. I think it's safe/a no-op to attempt pointer warps while using relative motion, as according to the protocol the warp will not generate a relative motion event, and while there will be a wl_pointer motion event, they're ignored while relative motion is being used.~~ -- v5: winewayland: Implement SetCursorPos via pointer lock. https://gitlab.winehq.org/wine/wine/-/merge_requests/7353

4 7