September 2025 - Wine-gitlab

Re: [PATCH v2 0/1] MR9057: shell32 shlwapi: Call of ShellMessageBoxW works like Windows 11.
by Jinoh Kang (＠iamahuman) 26 Sep '25

26 Sep '25

Jinoh Kang (@iamahuman) commented about dlls/shlwapi/shlwapi.spec: > 385 stub -noname SHLoadRawAccelerators > 386 stub -noname SHQueryRawAccelerator > 387 stub -noname SHQueryRawAcceleratorMsg > -388 varargs -ordinal ShellMessageBoxWrapW(long long wstr wstr long) > +388 varargs ShellMessageBoxW(long long wstr wstr long) The CI tests are not passing due to the following build failure: ``` ../dlls/shlwapi/ordinal.c:3988:13: error: 'ShellMessageBoxW' redeclared without dllimport attribute: previous dllimport ignored [-Werror=attributes] 3988 | INT WINAPIV ShellMessageBoxW(HINSTANCE hInstance, HWND hWnd, LPCWSTR lpText, | ^~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make: *** [Makefile:151583: dlls/shlwapi/x86_64-windows/ordinal.o] Error 1 ``` To fix this, can you keep the ShellMessageBoxWrapW name and use aliasing to export it as ShellMessageBox**W** (no Wrap)? Aliases look like this: ```suggestion:-0+0 388 varargs ShellMessageBoxW(long long wstr wstr long) ShellMessageBoxWrapW ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9057#note_116871

1 0

[PATCH 0/1] MR9041: msi: fix MsiEnumFeatures[AW]() by make it look at the correct registry
by Ratchanan Srirattanamet (＠ratchanan.sr) 26 Sep '25

26 Sep '25

For some reason, MsiEnumFeaturesW() still look for the list of features in the registry key which Wine itself has not been writing to since commit af56e28f ("msi: Don't publish features to an invalid location."), authored in 2008. Make it look in the new registry location which is used by ACTION_PublishFeatures(). While we're at it, remove the helper function used only by MsiEnumFeaturesW(). A conformance test is added. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9041

3 2

[PATCH v2 0/1] MR9035: wbemprox: Use setupapi to enumerate video controllers.
by Tim Clem (＠tclem) 26 Sep '25

26 Sep '25

So that we can access the correct device IDs. --- The EA launcher uses WMI to query system information to tie licenses to particular machines. It expects that a video controller's PNPDeviceID will be valid (i.e. something under CurrentControlSet\Enum), which it no longer is since we stopped using DXGI in d511872a3d0dce5148d23ce5cbf80c989d484b26 / !7450. That information is available from setupapi, which is presumably faster than DXGI (speed was the motivating factor for !7450 - see the original bug https://bugs.winehq.org/show_bug.cgi?id=38879) I'm all ears if there's a better way to associate the devices under CurrentControlSet\Control\Class\{4d36e968-e325-11ce-bfc1-08002be10318} with those that setupapi reads from ...\Enum, or if there's a way to get the stuff that's in ...\Class out of setupapi (e.g. the RAM and DAC type). -- v2: wbemprox: Use setupapi to enumerate video controllers. https://gitlab.winehq.org/wine/wine/-/merge_requests/9035

3 3

Re: [PATCH v2 0/1] MR9057: shell32 shlwapi: Call of ShellMessageBoxW works like Windows 11.
by Matthias Zorn (＠Matthias-Zorn.0178) 26 Sep '25

26 Sep '25

On Thu Sep 25 22:36:32 2025 +0000, Jinoh Kang wrote: > Hello, thanks for your reply! > You built your program with MinGW, right? It seems MinGW has a problem > with shlwapi. > Does your program run correctly on Windows when built *with* MinGW? > Would you post a screenshot on Windows? I programmed it with the MinGW compilers (mingw32 and mingw64) in MSYS2. I tested the program on Windows 2000, Windows XP, Windows 7, and Windows 11. The program runs on Windows 7 and Windows 11: ![windows11.png](/uploads/90fff4868e9cacc3a6d1bc209a08e94e/windows11.png){width=278 height=251} When I start the program with Windows 2000 or Windows XP, I only get the following error message: ![windowsxp.PNG](/uploads/cfbc137637f6ef774bec1eb7d47b5355/windowsxp.PNG) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9057#note_116867

1 0

[PATCH v3 0/2] MR9040: cmd: Allow DIR /Oxxx at the command line to override DIRCMD=/Oyyy set in the environment.
by Joe Souza (＠JoeS209) 26 Sep '25

26 Sep '25

Fix regression, likely caused by me, where DIR /O options entered at the command line do not override any /O options that might be set in the DIRCMD environment variable. Fix is to reset applicable sort order state whenever /O is encountered in the options list. -- v3: cmd: Allow DIR /Oxxx at the command line to override DIRCMD=/Oyyy set in the environment. cmd/tests: Duplicate DIR /O tests, but specify parameters via DIRCMD environment variable. https://gitlab.winehq.org/wine/wine/-/merge_requests/9040

3 4

[PATCH v3 0/3] MR9036: wined3d: Conditionally update saved window state in fullscreen mode.
by Matteo Bruni (＠Mystral) 26 Sep '25

26 Sep '25

For Assassin's Creed Syndicate. When switching from fullscreen to a smaller windowed resolution, it calls `SetWindowPos()` centering the window, then calls `ResizeTarget()` and finally `SetFullscreenState()`, and expects the window to preserve the position. Window style handling is a bit iffy because of the manipulation we do when entering fullscreen, but that's not really new. -- v3: dxgi/tests: Test window states tracking and restoration in fullscreen mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/9036

4 7

Re: [PATCH v2 0/1] MR9057: shell32 shlwapi: Call of ShellMessageBoxW works like Windows 11.
by Jinoh Kang (＠iamahuman) 25 Sep '25

25 Sep '25

On Thu Sep 25 22:36:32 2025 +0000, Matthias Zorn wrote: > I wanted to program the PickIconDlg function for WineHQ, so I developed > a program under Windows that calls my own implementation of this > function (I called it PickIconDlg2). I looked at the source code of Wine > and got the impression that the ShellMessageBoxW function is already > implemented correctly and saw that this function is also called > internally by Wine under certain circumstances. I programmed > PickIconDlg2 to also use ShellMessageBoxW and was optimistic that the > program would run well under Wine. However, when I started the program > with Wine, it only displayed a long error message. The reason for the > program crash was that ShellMessageBoxW could not be called. So I tried > to modify ShellMessageBoxW so that the program would also run with Wine. > I compiled the program with mingw-w64 and it tried to call > ShellMessageBoxW in shlwapi.dll. Hello, thanks for your reply! You built your program with MinGW, right? It seems MinGW has a problem with shlwapi. Does your program run correctly on Windows when built *with* MinGW? Would you post a screenshot on Windows? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9057#note_116859

1 0

Re: [PATCH v2 0/1] MR9057: shell32 shlwapi: Call of ShellMessageBoxW works like Windows 11.
by Matthias Zorn (＠Matthias-Zorn.0178) 25 Sep '25

25 Sep '25

I wanted to program the PickIconDlg function for WineHQ, so I developed a program under Windows that calls my own implementation of this function (I called it PickIconDlg2). I looked at the source code of Wine and got the impression that the ShellMessageBoxW function is already implemented correctly and saw that this function is also called internally by Wine under certain circumstances. I programmed PickIconDlg2 to also use ShellMessageBoxW and was optimistic that the program would run well under Wine. However, when I started the program with Wine, it only displayed a long error message. The reason for the program crash was that ShellMessageBoxW could not be called. So I tried to modify ShellMessageBoxW so that the program would also run with Wine. I compiled the program with mingw-w64 and it tried to call ShellMessageBoxW in shlwapi.dll. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9057#note_116855

1 0

Re: [PATCH v15 0/2] MR8367: shell32: Add shield icon.
by Joel Holdsworth (＠jhol) 25 Sep '25

25 Sep '25

> And my prior patches have been asked for extensive changes, tests, etc, then someone else submits the EXACT same diff, and it passes with no commentary. You're not the first person I've heard complaining about this. It seems that patches from within Crossover have an easier time getting integrated because Julliard has an ongoing relationship with these engineers. If you're absolutely out of patience, I don't might doing some work on the graphics side, though I can't guarantee when I will have time to look at it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8367#note_116854

1 0

Re: [PATCH v15 0/2] MR8367: shell32: Add shield icon.
by James McDonnell (＠ElementalWarrior) 25 Sep '25

25 Sep '25

> 16-color VGA palette I kind of just assumed the color palette would have been handled by gimp's ico export. So when I imported it into inkscape it would be correct. Which is why everything was a raster. > These should be a vector images I did not find a svg for the 16x16 icon. Just a png. Maybe I didn't look hard enough. > prevent blurriness I had to delete most of the feathered edge and put in a hard border for this icon to look remotely nice. The 16x16 icon did not want to export to ico well, hence why the right looks slightly different than the left. It even seemed to look different between different exports. I didn't think the 256 image was even exported... Yeah I thought this MR would just have been a quick (load some obvious 'missing' icon if the other icon is not present). I barely can get myself to work on this ticket, as it is rather frustrating when you try to match examples of existing source, to be told don't do it that way, because "I don't like it that way". And my prior patches have been asked for extensive changes, tests, etc, then someone else submits the EXACT same diff, and it passes with no commentary. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8367#note_116853

1 0