September 2025 - Wine-gitlab

Re: [PATCH v15 0/2] MR8367: shell32: Add shield icon.
by Joel Holdsworth (＠jhol) 25 Sep '25

25 Sep '25

On Thu Sep 25 07:31:33 2025 +0000, James McDonnell wrote: > Please review the svg changes again. Great progress indeed. A couple of points I spotted: * The 4-bit icons need to use only colors from the [16-color VGA palette](https://en.wikipedia.org/wiki/List_of_8-bit_computer_hardware_grap…. * The 4 and 8-bit icons need to be paletted, rather than RGB. * In the 16-4 image, it looks to me that the bottom right of the shield could use some tidy up in the pixel art. It looks slightly jagged. * The 48-32, 32-32 and 16-32 icons are raster images. These should be a vector images (the 16-32 is sometimes raster in some of the other icons). It is important to keep the lines properly aligned to the pixel grid to prevent blurriness with 1px thickness. Are these included in the Tango sources? This would have been done in the original Tango source, but if the size you need is not available, you can achieve the same thing by tweaking the geometry. If you look at the other Wine icons and turn on a pixel grid in Inkscape, you will see how they have been aligned to the pixel grid. * The 48-8 and 48-4 images do not have the ids attributes set, so they won't render out. * The 256-32 image (and 48-32, 32-32 and 16-32 vector images that I am requesting), do not have the invisible rectangle element with the id set to `<rect id="icon:32-32" height="32" width="32" y="236" x="440" style="fill:none" />`, so they won't render out either. [control.svg](https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/shell32… demonstrates these points most clearly. I know this is all very pedantic, but it's necessary to achieve best results. You can understand why my [original Tango icons project](https://www.omgubuntu.co.uk/2010/05/wine-icon-facelift-on-target-for-june-looks-immeasurably-better-already) took around 14-months to complete! I thought it would be done in a weekend. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8367#note_116852

1 0

Re: [PATCH v2 0/1] MR9057: shell32 shlwapi: Call of ShellMessageBoxW works like Windows 11.
by Jinoh Kang (＠iamahuman) 25 Sep '25

25 Sep '25

Welcome to WineHQ, Matthias! Thanks for your contribution. Does this patch fix any known Windows application on Wine? Or is this a refactoring change? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9057#note_116851

1 0

[PATCH v2 0/2] MR9040: cmd: Allow DIR /Oxxx at the command line to override DIRCMD=/Oyyy set in the environment.
by Joe Souza (＠JoeS209) 25 Sep '25

25 Sep '25

Fix regression, likely caused by me, where DIR /O options entered at the command line do not override any /O options that might be set in the DIRCMD environment variable. Fix is to reset applicable sort order state whenever /O is encountered in the options list. -- v2: cmd/tests: Add DIR test for /o set in DIRCMD environment variable. https://gitlab.winehq.org/wine/wine/-/merge_requests/9040

3 6

Re: [PATCH v15 0/2] MR8367: shell32: Add shield icon.
by James McDonnell (＠ElementalWarrior) 25 Sep '25

25 Sep '25

On Tue Jul 29 18:40:30 2025 +0000, Joel Holdsworth wrote: > The > [16x16](https://git.golem.linux.it/matteobin/tango-icon-theme/src/branch/master/16x16/status/network-wireless-encrypted.png) > version will required tweaking in a pixel editor. Please review the svg changes again. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8367#note_116840

1 0

[PATCH v14 0/2] MR8367: shell32: Add shield icon.
by James McDonnell (＠ElementalWarrior) 25 Sep '25

25 Sep '25

The missing shield icon was causing Affinity Photo's installer to fail to start. -- v14: shell32: Try to lookup icon shell32: Add shield icon. https://gitlab.winehq.org/wine/wine/-/merge_requests/8367

2 2

[PATCH v2 0/1] MR9033: comdlg32: Filedialog stores location when closed.
by Janne Kekkonen (＠Janne) 24 Sep '25

24 Sep '25

Filedialog location is stored when dialog is closed. When dialog is reopenned it opens to same location. Location info is stored as long as the application is running. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=40738 -- v2: comdlg32: Filedialog stores location when closed. https://gitlab.winehq.org/wine/wine/-/merge_requests/9033

2 2

[PATCH 0/5] MR9033: comdlg32: Filedialog stores location when closed.
by Janne Kekkonen (＠Janne) 24 Sep '25

24 Sep '25

Filedialog location is stored when dialog is closed. When dialog is reopenned it opens to same location. Location info is stored as long as the application is running. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=40738 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9033

3 7

[PATCH 0/2] MR9054: winebth.sys: Remove redundant locks + Fix potential deadlocks while performing operations that block on the DBus event loop.
by Vibhav Pant (＠vibhavp) 24 Sep '25

24 Sep '25

Disconnecting and removing remote devices hold device_list_cs before blocking on the DBus event loop, which may cause a deadlock if we receive a message from BlueZ whose handler also attempts to enter device_list_cs (Like BLUETOOTH_WATCHER_EVENT_TYPE_DEVICE_PROPERTIES_CHANGED). To fix this, the device/radio handle is duplicated once found, device_list_cs is released, and the DBus method call is made using the duplicate handle(s), which are then freed normally. Also, replace the two locks in `bluetooth_radio` with `device_list_cs` instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9054

2 2

[PATCH 0/1] MR9040: cmd: Allow DIR /Oxxx at the command line to override DIRCMD=/Oyyy set in the environment.
by Joe Souza (＠JoeS209) 24 Sep '25

24 Sep '25

Fix regression, likely caused by me, where DIR /O options entered at the command line do not override any /O options that might be set in the DIRCMD environment variable. Fix is to reset applicable sort order state whenever /O is encountered in the options list. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9040

3 2

Re: [PATCH v2 0/1] MR9042: wined3d: Use malloc() for the private store. - approved
by Alexandre Julliard (＠julliard) 23 Sep '25

23 Sep '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9042

1 0