September 2025 - Wine-gitlab

[PATCH v2 0/4] MR9045: windows.devices.enumeration: Add support for device properties in DeviceInformation objects.
by Vibhav Pant (＠vibhavp) 23 Sep '25

23 Sep '25

-- v2: windows.devices.enumeration: Implement IDeviceInformationStatics::{FindAllAsyncAqsFilterAndAdditionalProperties, CreateWatcherAqsFilterAndAdditionalProperties}. windows.devices.enumeration: Implement IDeviceInformation::get_Properties. windows.devices.enumeration/tests: Add tests for IDeviceInformationStatics::FindAllAsyncAqsFilterAndAdditionalProperties. https://gitlab.winehq.org/wine/wine/-/merge_requests/9045

2 4

[PATCH 0/4] MR9045: windows.devices.enumeration: Add support for device properties in DeviceInformation objects.
by Vibhav Pant (＠vibhavp) 23 Sep '25

23 Sep '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9045

2 4

[PATCH v4 0/5] MR8969: opengl32, win32u: Fix 16-bit PFD_DRAW_TO_BITMAP rendering.
by Zowie van Dillen (＠zowie) 23 Sep '25

23 Sep '25

This MR fixes 16-bit PFD_DRAW_TO_BITMAP rendering, as tested with SimGolf and Civilization 3. The fix isn't super performant since it involves a lot of back-and-forth between CPU and GPU, which is mostly noticeable when moving staff around in SimGolf — it slows to around two or three fps —, but on the plus side it does work, which is a straight upgrade over the current version of Wine. Couple of notes: * The third commit touches several different subsystems because I had to add a constant that's visible from both opengl32 and win32u. I wasn't sure how to write this down in the commit message. * There's a bug in LLVMpipe where a 32-bit pbuffer will cause it to crash. I opened an issue for it here: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13890. I needed a 32-bit pbuffer to make this work, so I added a special check that effectively disables 16-bit bitmap rendering for LLVMpipe. * I also had to use a workaround to make blitting & OpenGL rendering work together. I wrote about it pretty extensively below. ## Combining blitting & OpenGL rendering Something that's difficult about bitmap rendering is that it allows programs to combine OpenGL drawing with direct blitting onto bitmap memory. That's difficult to imitate with the pbuffer-based implementation because there's no way to replicate memory edits on the bitmap to the GPU-based pbuffer (since there's no API calls involved in the memory edit). This had to work to make the games actually work, so I used this workaround: Each time after overwriting the bitmap from the pbuffer, we clear the pbuffer with transparent. Also instead of "overwriting" the bitmap, we instead blend the pbuffer's pixels onto the bitmap. That way we're effectively overlaying the most recent OpenGL drawings on top of the bitmap. I'm pretty confident that that approach would also help with 32-bit and 24-bit bitmap rendering, but I don't know of any programs that use 32-bit or 24-bit bitmap rendering, so I wasn't able to check. I've just left 32-bit and 24-bit bitmaps as they were. While the workaround works really well for the games, I did have to edit another test because it used glReadPixels on 16-bit bitmaps. glReadPixels will grab pixels from the transparent-background pbuffer instead of the bitmap, which gives the wrong result. I'm not under the impression that any consumer programs use bitmap rendering together with glReadPixels (it doesn't make as much sense when you could just directly read the pixels from the bitmap), but it's possible to add a wrap_glReadPixels that grabs pixels from the bitmap in case of a 16-bit memory DC. It's not important to read but I wanted to write it down for the record: I also tried another workaround to make combining blitting & OpenGL work. The thought was to overwrite the pbuffer with the bitmap just before OpenGL draws to the pbuffer, to keep them in sync. It probably would have worked out if it was possible to add something to the front of the OpenGL command buffer in a glFinish/glFlush call — then I could have inserted glDrawPixels in the front, before all of the program's rendering operations —, but it's only possible to add things to the end of the command buffer unfortunately. I tried adding a wrapper to glBegin and glClear, which checks if they were the first render operation after a glFlush or glFinish. Unfortunately that didn't work at all. I'm guessing that Civ 3 and SimGolf still do direct bitmap edits after the first call to glBegin, so by the time the program gets to glFinish/glFlush the pixels that were uploaded in the glDrawPixels command are already stale (although I didn't really check). Anyhow, that approach was pretty fruitless. -- v4: win32u: Fix garbled 24-bit bitmap rendering win32u: Add support for 16-bit bitmaps to set_dc_pixel_format and flush_memory_dc. opengl32: Return a fake pixel format when requesting 16-bit bitmap rendering. opengl32/tests: Extend 16-bit bitmap rendering test. winex11: Refine PFD_DRAW_TO_BITMAP requirements. https://gitlab.winehq.org/wine/wine/-/merge_requests/8969

3 14

[PATCH 0/4] MR9043: win32u: Implement NtGdiDdDDIQueryResourceInfo.
by Rémi Bernon 23 Sep '25

23 Sep '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9043

2 5

[PATCH 0/7] MR9044: xmllite/writer: Improve error hanlding in WriteCData().
by Nikolay Sivov (＠nsivov) 23 Sep '25

23 Sep '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9044

2 7

[PATCH 0/1] MR9042: wined3d: Use malloc() for the private store.
by Elizabeth Figura (＠zfigura) 23 Sep '25

23 Sep '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9042

2 1

[PATCH 0/2] MR9039: Include defines
by Alistair Leslie-Hughes (＠alesliehughes) 22 Sep '25

22 Sep '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9039

2 2

[PATCH v2 0/1] MR9038: Draft: msi: implement MsiProvideAssembly[AW]()
by Ratchanan Srirattanamet (＠ratchanan.sr) 22 Sep '25

22 Sep '25

TODO: - make awstring version of MsiProvideComponent() and use that. - Actually implement MsiProvideAssemblyA() using the above. - Write conformance test? Dependency: - Have ACTION_PublishAssemblies() record feature (https://gitlab.winehq.org/wine/wine/-/merge_requests/9037) - Have MsiEnumFeatures() fixed. Currently it seems to just look for features at the wrong place and thus is useless for this purpose. (Currently TODO) Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58578 -- v2: [WIP] msi: implement MsiProvideAssembly[AW]() https://gitlab.winehq.org/wine/wine/-/merge_requests/9038

2 1

[PATCH 0/1] MR9038: Draft: msi: implement MsiProvideAssembly[AW]()
by Ratchanan Srirattanamet (＠ratchanan.sr) 22 Sep '25

22 Sep '25

TODO: - make awstring version of MsiProvideComponent() and use that. - Actually implement MsiProvideAssemblyA() using the above. - Write conformance test? Dependency: - Have ACTION_PublishAssemblies() record feature - Have MsiEnumFeatures() fixed. Currently it seems to just look for features at the wrong place and thus is useless for this purpose. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58578 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9038

2 1

[PATCH 0/1] MR9037: msi: record feature in assembly publication when package has 2+ features
by Ratchanan Srirattanamet (＠ratchanan.sr) 22 Sep '25

22 Sep '25

This is necessary for correct logic of MsiProvideAssembly[AW](). Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58578 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9037

2 1