January 2026 - Wine-gitlab - list.winehq.org

[PATCH v4 0/1] MR9858: qasf: Fix use-after-free of filter in reader callback.
by Yuxuan Shui (＠yshui) 09 Jan '26

09 Jan '26

If a asf reader callback is invoked after its corresponding reader has been destroyed, it will still try to use the reader via asf_callback->filter, resulting in use-after-free. This commits sets asf_callback->filter to NULL when the reader is destroyed, and adds NULL checks to reader callback functions to make them no-op after the reader is destroyed. Fixes: Bug 59159 -- v4: qasf: Stop the WMReader first in asf_reader_destroy. https://gitlab.winehq.org/wine/wine/-/merge_requests/9858

3 8

[PATCH 0/1] MR9870: iccvid/tests: Reserve enough memory for input in test_formats (ASan).
by Bernhard Übelacker (＠bernhardu) 09 Jan '26

09 Jan '26

ASan got triggered by the new iccvid test. In `ICCVID_DecompressGetFormat` the input pointer gets read 484 (40+111*4) bytes, but variable `in` gets just the size of `BITMAPINFOHEADER`, 40 bytes allocated. CC: @zfigura [Testbot run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=161448) <details> <summary>ASan details [link](https://gitlab.winehq.org/bernhardu/wine/-/jobs/220743#L5427-L5452)</summary> ``` ==iccvid_test.exe==1720==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x0022f8e8 at pc 0x784543e2 bp 0x0022f1f0 sp 0x0022edc0 READ of size 484 at 0x0022f8e8 thread T0 #0 0x784543e1 in __asan_memcpy /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cpp:65:3 #1 0x77fd22aa in ICCVID_DecompressGetFormat /builds/bernhardu/wine/build64/../dlls/iccvid/iccvid.c:836:9 #2 0x77fd1351 in ICCVID_DriverProc /builds/bernhardu/wine/build64/../dlls/iccvid/iccvid.c:1015:16 #3 0x78e92cf3 in DRIVER_SendMessage /builds/bernhardu/wine/build64/../dlls/winmm/driver.c:130:11 #4 0x78e92ba8 in SendDriverMessage /builds/bernhardu/wine/build64/../dlls/winmm/driver.c:150:11 #5 0x7902d7e0 in MSVIDEO_SendMessage /builds/bernhardu/wine/build64/../dlls/msvfw32/msvideo_main.c:198:15 #6 0x7902db20 in ICSendMessage /builds/bernhardu/wine/build64/../dlls/msvfw32/msvideo_main.c:1163:12 #7 0x0040190d in test_formats /builds/bernhardu/wine/build64/../dlls/iccvid/tests/iccvid.c:62:11 #8 0x004010d9 in func_iccvid /builds/bernhardu/wine/build64/../dlls/iccvid/tests/iccvid.c:196:5 #9 0x00404f51 in run_test /builds/bernhardu/wine/build64/../include/wine/test.h:780:5 #10 0x00404a6b in main /builds/bernhardu/wine/build64/../include/wine/test.h #11 0x00405f05 in mainCRTStartup /builds/bernhardu/wine/build64/../dlls/msvcrt/crt_main.c:62:11 #12 0x7bcd367f in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x7b82367f) #13 0x7be4680a in call_thread_func_wrapper (C:\windows\system32\ntdll.dll+0x7bc4680a) #14 0x7be4717a in call_thread_func /builds/bernhardu/wine/build64/../dlls/ntdll/signal_i386.c:503:9 Address 0x0022f8e8 is located in stack of thread T0 at offset 1256 in frame #0 0x0040149f in test_formats /builds/bernhardu/wine/build64/../dlls/iccvid/tests/iccvid.c:25 This frame has 3 object(s): [16, 1080) 'buffer' (line 26) [1216, 1256) 'in' (line 27) [1296, 1864) 'info' (line 30) <== Memory access at offset 1256 partially underflows this variable HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow /builds/bernhardu/wine/build64/../dlls/iccvid/iccvid.c:836:9 in ICCVID_DecompressGetFormat ``` </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9870

2 1

[PATCH v7 0/1] MR9868: winewayland: Fix non-square icons with xdg-toplevel-icon protocol.
by Alex Schwartz (＠alexschwartz01) 09 Jan '26

09 Jan '26

Currently, it will stop the app that is running that has a non-square icon This PR fixes that -- v7: winewayland: Fix non-square icons with xdg-toplevel-icon protocol. https://gitlab.winehq.org/wine/wine/-/merge_requests/9868

3 2

Re: [PATCH v29 0/1] MR9414: shlwapi: Handling of "C:\...xx" in PathCanonicalize[AW].
by Thomas Csovcsity (＠thc13) 09 Jan '26

09 Jan '26

On Wed Jan 7 16:03:26 2026 +0000, Yuxuan Shui wrote: > Are we worried about backing up over a device letter in this case? i.e. `C:\\..\\something` Good catch, will have a look -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9414#note_126588

1 0

[PATCH v6 0/1] MR9868: winewayland: Fix non-square icons with xdg-toplevel-icon protocol.
by Alex Schwartz (＠alexschwartz01) 09 Jan '26

09 Jan '26

Currently, it will stop the app that is running that has a non-square icon This PR fixes that -- v6: winewayland: Fix non-square icons with xdg-toplevel-icon protocol. https://gitlab.winehq.org/wine/wine/-/merge_requests/9868

2 1

Re: [PATCH v3 0/3] MR9646: Draft: mf/tests: Scrubbing tests
by Brendan McGrath (＠redmcg) 09 Jan '26

09 Jan '26

v3: - Rebase on to master The pipeline had errors under Windows 10 this time. I will mark this as draft until I investigate. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9646#note_126579

1 0

[PATCH v5 0/1] MR9868: winewayland: Fix non-square icons with xdg-toplevel-icon protocol.
by Alex Schwartz (＠alexschwartz01) 08 Jan '26

08 Jan '26

Currently, it will stop the app that is running that has a non-square icon This PR fixes that -- v5: winewayland: Fix non-square icons with xdg-toplevel-icon protocol. https://gitlab.winehq.org/wine/wine/-/merge_requests/9868

2 1

[PATCH 0/1] MR9868: winewayland: Fix non-square icons with xdg-toplevel-icon protocol.
by Alex Schwartz (＠alexschwartz01) 08 Jan '26

08 Jan '26

Currently, it will stop the app that is running that has a non-square icon This PR fixes that -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9868

2 1

[PATCH v14 0/2] MR9832: win32u: Fix xdg-toplevel-icon Wayland protocol.
by Alex Schwartz (＠alexschwartz01) 08 Jan '26

08 Jan '26

Fixes https://bugs.winehq.org/show_bug.cgi?id=59149 -- v14: winewayland: Fix non-square icons with xdg-toplevel-icon protocol. win32u: Fix xdg-toplevel-icon Wayland protocol. https://gitlab.winehq.org/wine/wine/-/merge_requests/9832

2 3

Re: [PATCH v3 0/1] MR9863: mshtml/tests: Test calling external object's prop with return value. - approved
by Alexandre Julliard (＠julliard) 08 Jan '26

08 Jan '26

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9863

1 0