January 2026 - Wine-gitlab - list.winehq.org

[PATCH v2 0/1] MR9858: qasf: Fix use-after-free of filter in reader callback.
by Yuxuan Shui (＠yshui) 06 Jan '26

06 Jan '26

If a asf reader callback is invoked after its corresponding reader has been destroyed, it will still try to use the reader via asf_callback->filter, resulting in use-after-free. This commits sets asf_callback->filter to NULL when the reader is destroyed, and adds NULL checks to reader callback functions to make them no-op after the reader is destroyed. Fixes: Bug 59159 -- v2: qasf: Fix use-after-free of asf reader in reader callback. https://gitlab.winehq.org/wine/wine/-/merge_requests/9858

3 4

[PATCH v5 0/1] MR9111: ws2_32: Implement SIO_BSP_HANDLE_SELECT.
by Josh Steffen (＠joshsteffen) 06 Jan '26

06 Jan '26

My understanding is that, in the absence of layered service providers, `SIO_BSP_HANDLE_SELECT` should behave like `SIO_BASE_HANDLE` (this is relied upon by https://github.com/python-trio/trio) Should I add tests to verify this? If so, should they basically just be the same as the existing `SIO_BASE_HANDLE` tests? -- v5: ws2_32: Implement SIO_BSP_HANDLE_SELECT. https://gitlab.winehq.org/wine/wine/-/merge_requests/9111

2 1

[PATCH 0/1] MR9849: dxgi/tests: Add a missing return value check.
by Zhiyi Zhang (＠zhiyi) 06 Jan '26

06 Jan '26

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9849

3 2

[PATCH v2 0/1] MR9859: Draft: winevulkan: Use correct time domain for calibrated timestamps
by Etaash Mathamsetty (＠etaash.mathamsetty) 06 Jan '26

06 Jan '26

I am not sure how to address this fully, but the following patch should at least make it accurate before the machine suspends. -- v2: winevulkan: Use correct time domain for calibrated timestamps https://gitlab.winehq.org/wine/wine/-/merge_requests/9859

2 1

[PATCH 0/1] MR9859: Draft: winevulkan: Use correct time domain for calibrated timestamps
by Etaash Mathamsetty (＠etaash.mathamsetty) 06 Jan '26

06 Jan '26

I am not sure how to address this fully, but the following patch should at least make it accurate before the machine suspends. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9859

2 1

Re: [PATCH v2 0/1] MR9856: win32u: Update client surface state before swapping or presenting. - approved
by Alexandre Julliard (＠julliard) 06 Jan '26

06 Jan '26

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9856

1 0

Re: [PATCH v2 0/1] MR9855: ntdll: get_non_pe_file_info() returns NTSTATUS. - approved
by Alexandre Julliard (＠julliard) 06 Jan '26

06 Jan '26

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9855

1 0

Re: [PATCH 0/1] MR9858: qasf: Fix use-after-free of filter in reader callback.
by Yuxuan Shui (＠yshui) 06 Jan '26

06 Jan '26

wine-10.18 regression. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9858#note_126455

1 0

[PATCH v7 0/3] MR9840: winepulse.drv: A potential solution to audio crackling
by Dzmitry Keremsha (＠Vyrolian) 06 Jan '26

06 Jan '26

I have noticed that winepulse leaves too little headroom when draining the buffer, which very often leads to crackling that can't be fully resolved by manipulating latency. Let's check some math: Let's assume that the buffer (tlength) is at 33ms, and minreq is at 13.3ms. If 13.2 ms were drained, the refill would be denied. If the next timer trigger takes 14ms due to jitter, that leaves us with a 6.1ms margin. As such, if we get any jitter longer than that during refill, we get an underflow. I think this is what leads to crackles. My solution increases timer polling to 5x the frequency, so if 13.2ms were drained, the next timer trigger would happen at around 16ms. That would leave us with a 17ms headroom. The math might not be 100% representation of what happens, but I think it's quite close to reality. On practice, this does indeed help to fully get rid of crackling for an indefinite amount of time, when before they were unevitable. I understand that this might be not the most elegant approach, the 5x increase is arbitrary. I had to add another if condition to NtSetEvent to avoid issues with spatialaudio. We need as much headroom as possible and tests were failing above 1.8, so I set it to 1.75 to be sure. I think this problem is quite urgent, because while this does not happen on every system, it's frequent enough that we see "Audio: Crackling" reports on most games on protondb and there are many forum threads about audio crackling. From my experience, the only solution was switching to winealsa, which is very consistent and does not crackle at all. My experience has been very consistent with forum threads when it came to the nature of crackling. I first noticed it in Balatro, which is a very light game and should not be crackling at all on any setup. Some games have very frequent crackling every 20-30 seconds, or a buzzsaw crackling every 10-15 minutes. I hope my idea brings us closer to the ultimate fix, I really look forward to your feedback! -- v7: winepulse.drv: Prevent unsigned underflow on clock jitter winepulse.drv: Revert to adv_bytes and fix spatial audio winepulse.drv: Adjust timer period https://gitlab.winehq.org/wine/wine/-/merge_requests/9840

2 3

Re: [PATCH v3 0/1] MR9796: winebus: Adjust hatswitch encoding to follow T300RS and G29
by Tomasz Pakuła (＠Lawstorant) 06 Jan '26

06 Jan '26

On Tue Jan 6 14:49:20 2026 +0000, Rémi Bernon wrote: > I'm a bit surprised that we don't need adjustments on the dinput side, > could you tweak one of the tests in dlls/dinput/tests/joystick8.c > similarly to make sure everything is handling this pattern correctly? > (Though I don't know if we have much tests with hatswitch, maybe worth > adding a couple if not) Probably because this should always be handled dynamically. It then doesn't matter what the min and max value is. It's just that with the input plugins, developer have to do HID manually for no good reason and they don't have the know-how. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9796#note_126447

1 0