January 2026 - Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/2] MR9860: opengl32: Present on flush only when rendering to the front buffer. - approved
by Alexandre Julliard (＠julliard) 07 Jan '26

07 Jan '26

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9860

1 0

Re: [PATCH v2 0/1] MR9849: dxgi/tests: Add a missing return value check. - approved
by Alexandre Julliard (＠julliard) 07 Jan '26

07 Jan '26

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9849

1 0

[PATCH 0/1] MR9864: win32u: Clear window surface with black when creating client surface.
by Paul Gofman (＠gofman) 07 Jan '26

07 Jan '26

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59109 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9864

2 3

Re: [PATCH v29 0/1] MR9414: shlwapi: Handling of "C:\...xx" in PathCanonicalize[AW].
by Yuxuan Shui (＠yshui) 07 Jan '26

07 Jan '26

Yuxuan Shui (@yshui) commented about dlls/kernelbase/path.c: > + if ((dst > buffer + 2) && dst[-2] == '\\' && dst[-1] == '.') > { > - src += 2; /* Skip .\ */ > + dst -= 1; /* Skip .\ */ > + src++; > } > - else if (src[1] == '.' && dst != buffer && dst[-1] == '\\') > + else if ((dst > buffer + 4) && dst[-3] == '\\' && dst[-2] == '.' && dst[-1] == '.') > { > - /* \.. backs up a directory, over the root if it has no \ following X:. > - * .. is ignored if it would remove a UNC server name or initial \\ > - */ > - if (dst != buffer) > + /* \.. backs up a directory */ > + dst -= 4; > + while (dst > buffer && *dst != '\\') Are we worried about backing up over a device letter in this case? i.e. `C:\\..\\something` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9414#note_126502

1 0

[PATCH v8 0/1] MR9840: winepulse.drv: A potential solution to audio crackling
by Dzmitry Keremsha (＠Vyrolian) 07 Jan '26

07 Jan '26

I have noticed that winepulse leaves too little headroom when draining the buffer, which very often leads to crackling that can't be fully resolved by manipulating latency. Let's check some math: Let's assume that the buffer (tlength) is at 33ms, and minreq is at 13.3ms. If 13.2 ms were drained, the refill would be denied. If the next timer trigger takes 14ms due to jitter, that leaves us with a 6.1ms margin. As such, if we get any jitter longer than that during refill, we get an underflow. I think this is what leads to crackles. My solution increases timer polling to 5x the frequency, so if 13.2ms were drained, the next timer trigger would happen at around 16ms. That would leave us with a 17ms headroom. The math might not be 100% representation of what happens, but I think it's quite close to reality. On practice, this does indeed help to fully get rid of crackling for an indefinite amount of time, when before they were unevitable. I think this problem is quite urgent, because while this does not happen on every system, it's frequent enough that we see "Audio: Crackling" reports on most games on protondb and there are many forum threads about audio crackling. From my experience, the only solution was switching to winealsa, which is very consistent and does not crackle at all. My experience has been very consistent with forum threads when it came to the nature of crackling. I first noticed it in Balatro, which is a very light game and should not be crackling at all on any setup. Some games have very frequent crackling every 20-30 seconds, or buzzsaw crackling every 10-15 minutes. I hope my idea brings us closer to the ultimate fix, I really look forward to your feedback! -- v8: winepulse.drv: Increase timer frequency https://gitlab.winehq.org/wine/wine/-/merge_requests/9840

2 1

Re: [PATCH v4 0/1] MR8916: ntdll: Switch to CLOCK_BOOTTIME for monotonic counters on Linux.
by Rémi Bernon (＠rbernon) 07 Jan '26

07 Jan '26

This made the NT tick clock source diverge from other components. There's one instance of it in winevulkan, which was doing the same check to decide whether to use MONOTONIC_RAW vulkan clock source. There are also other similar uses of CLOCK_MONOTONIC_RAW in the audio drivers. I'm not exactly sure whether these actually need to match the NT ticks source, but if that's the case it might cause some issue there too. For the vulkan side, there's no CLOCK_BOOTTIME equivalent in vulkan, so there's no way to make both clock sources match anymore. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8916#note_126492

1 0

[PATCH v3 0/1] MR9859: Draft: winevulkan: Use correct time domain for calibrated timestamps
by Etaash Mathamsetty (＠etaash.mathamsetty) 07 Jan '26

07 Jan '26

I am not sure how to address this fully, but the following patch should at least make it accurate before the machine suspends. -- v3: winevulkan: Use correct time domain for calibrated timestamps https://gitlab.winehq.org/wine/wine/-/merge_requests/9859

3 5

[PATCH 0/1] MR9862: kerberos: Add support for EXTENDED_ERROR flags.
by Dmitry Timoshkov (＠dmitry) 07 Jan '26

07 Jan '26

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9862

2 1

[PATCH 0/2] MR9860: opengl32: Present on flush only when rendering to the front buffer.
by Rémi Bernon (＠rbernon) 07 Jan '26

07 Jan '26

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59190 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9860

2 2

Re: [PATCH v3 0/1] MR9858: qasf: Fix use-after-free of filter in reader callback.
by Yuxuan Shui (＠yshui) 06 Jan '26

06 Jan '26

On Wed Jan 7 01:13:05 2026 +0000, Yuxuan Shui wrote: > > It doesn't sound right that wmvcore is invoking callbacks after (or > while) the wmv object is destroyed. Are we sure that's supposed to happen? > Oh wait, do you think the destruction of IWMReader should happen first? well, that makes a lot more sense. thanks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9858#note_126482

1 0