October 2004 - Wine-Bugs - list.winehq.org

[Bug 2506] New: Fallout installer reports incorrect disk space
by Wine Bugs Oct. 10, 2004

Oct. 10, 2004

http://bugs.winehq.org/show_bug.cgi?id=2506 Summary: Fallout installer reports incorrect disk space Product: Wine Version: unspecified Platform: Other OS/Version: Linux Status: UNCONFIRMED Severity: minor Priority: P2 Component: wine-kernel AssignedTo: wine-bugs(a)winehq.org ReportedBy: wsapplegate(a)myrealbox.com Executive summary : ~~~~~~~~~~~~~~~~~~~ Fallout is an old (circa 1997) RPG, published by Interplay. The game doesn't use a standard installer (like InstallShield or similar). Rather, Interplay did write a custom installer. While recently trying to reinstall this game, I was confronted to a weird problem : the reported disk space was about 268 MiB instead of 2147 MiB as previously reported. Both values are in fact incorrect (the hard disk has much more than 2 GiB), but the latter allows for a complete installation, while the former only allows a limited installation, the remainder being read from the CD-ROM. Analysis : ~~~~~~~~~~ A quick investigation shows that the problem only occurs since WINE 20040505. Not coincidentally, this version contains changes to the GetDiskFreeSpace* functions. Tracing the _SETUP.EXE function calls, it indeed appears it makes calls to GetDiskFreeSpaceA(), which in turn calls GetDiskFreeSpaceW(). This functions returns values capped at 2 GiB, with the following parameters : 4096 bytes per sector, 1 sector per cluster, 524287 clusters. From the behaviour exhibited by the installer, it unfortunately appears the programmers used a 16-bit sized variable to store the clusters value, thus generating incorrect results when this number is above 65535, as reported by the new GetDiskFreeSpaceW(). How to reproduce : ~~~~~~~~~~~~~~~~~~ You need (1) a HDD with more than 2 GiB free space and (2) a copy of Fallout. Then, execute the following steps (assuming your CD-ROM is mounted as D:) * run "wine 'd:\\_setup.exe'" * notice the free space reported for the hard disk is incorrect Solutions and workarounds : ~~~~~~~~~~~~~~~~~~~~~~~~~~~ I personally solved the problem by kludging the GetDiskFreeSpaceW() function in dlls/kernel/volume.c to report a number of cluster below 65535 (for a 2 GiB disk, it reports 512 bytes * 64 sectors * 65535 clusters), but it's most probably incorrect (these values are not consistent with the values reported by NtQueryVolumeInformationFile()). If you run -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 0

[Bug 824] \0 character is added to REG_MULTI_SZ registry values
by Wine Bugs Oct. 10, 2004

Oct. 10, 2004

http://bugs.winehq.org/show_bug.cgi?id=824 ------- Additional Comments From randy.galbraith(a)cox.net 2004-10-10 00:05 ------- I would like to see if I could resolve this bug. However, I'm having some difficulty understanding the exact nature of the original description. In particular, can the import/export steps below be reproduce on Windows XP or just Windows 95/98/ME? I.e., does Unicode support get in the way? Here is an example program I wrote in an attempt to recreate this issue: http://members.cox.net/~rgalbraith10/wine/bug824/demo824.c http://members.cox.net/~rgalbraith10/wine/bug824/Makefile When this program is run on Windows XP (compiled with gcc under cygwin) the exported registry looks like this: [HKEY_CURRENT_USER\Software\Wine\Bug824] "Empty Value0"=hex(7): "Empty Value1"=hex(7):00,00 "Empty Value2"=hex(7):01,00,00,00 When the program is run under Wine (20040914) the exported registry looks like this: [HKEY_USERS\randy\Software\Wine\Bug824] "Empty Value0"=hex(7):00 "Empty Value1"=hex(7):00 "Empty Value2"=hex(7):01,00 So, we can see "Empty Value0" is reporting "00" (which is the issue at hand). However, what am I to make of Windows XP's "00,00" and "01,00,00,00"? I assume this is because Unicode support, but is part a worry? Interestingly user.reg in Wine stores these entries as this: [Software\\Wine\\Bug824] 1097383218 "Empty Value0"=str(7):"" "Empty Value1"=str(7):"" "Empty Value2"=str(7):"\1" Would it be correct to assume the basic issue is the choice of "str(7)" as the data type for REG_MULTI_SZ? Since this is my first ever post to Wine/Bugzilla, I would appreciate any helpful netiquette points (i.e. should I post to mailing list/newsgroup first, are URLs (as above) preferred over attachments). Kind regards, -Randy Galbraith -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 0

[Bug 1511] GDI GetObject (at least for Bitmap) is not correct.
by Wine Bugs Oct. 9, 2004

Oct. 9, 2004

http://bugs.winehq.org/show_bug.cgi?id=1511 ------- Additional Comments From hallo(a)michael-kaufmann.ch 2004-09-10 15:41 ------- Now I understand... If the buffer is NULL *and* count is zero, GetObject should return the size of the object. This is also fixed. I don't know whether Mike McCormack has read this bug report, but he has fixed it with this patch: http://www.winehq.org/hypermail/wine-patches/2003/07/0289.html So we can safely close this bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 0

[Bug 1511] GDI GetObject (at least for Bitmap) is not correct.
by Wine Bugs Oct. 9, 2004

Oct. 9, 2004

http://bugs.winehq.org/show_bug.cgi?id=1511 ------- Additional Comments From hallo(a)michael-kaufmann.ch 2004-09-10 15:30 ------- This patch has fixed the problem a long time ago: http://cvs.winehq.org/cvsweb/wine/objects/Attic/bitmap.c.diff?r1=1.56&r2=1.… If count == 0, GetObject returns 0. This means that GetObject copied 0 bytes - but it could also mean that the function failed. The result is the same, no bytes have been copied. I think we can close this bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 0

[Bug 2243] winsock: Unimplemented or unknown socket level
by Wine Bugs Oct. 9, 2004

Oct. 9, 2004

http://bugs.winehq.org/show_bug.cgi?id=2243 anssi.hannula(a)mbnet.fi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, FIXME ------- Additional Comments From anssi.hannula(a)mbnet.fi 2004-09-10 05:01 ------- Demo can be downloaded from http://www.shrapnelgames.com/downloads/SE4GoldDemo.exe -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 0

[Bug 85] Write a proper Users Guide Introduction
by Wine Bugs Oct. 9, 2004

Oct. 9, 2004

http://bugs.winehq.org/show_bug.cgi?id=85 ------- Additional Comments From scott(a)open-vote.org 2004-08-10 19:46 ------- I will take up this task.

1 0

[Bug 2502] Undefined References Prevent Compilation
by Wine Bugs Oct. 8, 2004

Oct. 8, 2004

http://bugs.winehq.org/show_bug.cgi?id=2502 tony_lambregts(a)telusplanet.net changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED ------- Additional Comments From tony_lambregts(a)telusplanet.net 2004-08-10 18:35 ------- Closing -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 0

[Bug 2502] Undefined References Prevent Compilation
by Wine Bugs Oct. 8, 2004

Oct. 8, 2004

http://bugs.winehq.org/show_bug.cgi?id=2502 Andrew.Talbot(a)talbotville.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED ------- Additional Comments From Andrew.Talbot(a)talbotville.com 2004-08-10 17:29 ------- It seems to have been a glitch on my system. It has gone away now. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 0

[Bug 2505] when loading Becky/Rebecca with wine all my icons on the kde panel get's moved around and program dont display graphics ok
by Wine Bugs Oct. 7, 2004

Oct. 7, 2004

http://bugs.winehq.org/show_bug.cgi?id=2505 tony_lambregts(a)telusplanet.net changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |http://www.rimarts.co.jp Keywords| |download, NoAppDBEntry -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 0

If you think these won't make her happy, your fooling yourself!
by Hannah N. Lewis Oct. 7, 2004

Oct. 7, 2004

Never think your not pleasing a girl again with a huge c0x! http://deregoy.com/9/4/index.php?aiw90&com5& P63N9lk864676r5s2VYLet's just walk upside down backwards.I ought, therefore, as the elephant was sideways onDropped an advolt on his head!437792957

1 0