June 2014 - Wine-Bugs - list.winehq.org

[Bug 36286] New: valgrind shows an invalid read in ieframe/tests/ie.c
by wine-bugs＠winehq.org June 3, 2014

June 3, 2014

https://bugs.winehq.org/show_bug.cgi?id=36286 Bug ID: 36286 Summary: valgrind shows an invalid read in ieframe/tests/ie.c Product: Wine Version: 1.7.18 Hardware: x86 OS: Linux Status: NEW Keywords: download, source, testcase Severity: normal Priority: P2 Component: ieframe Assignee: wine-bugs(a)winehq.org Reporter: austinenglish(a)gmail.com ==17071== Invalid read of size 4 ==17071== at 0x400AD40: memcpy (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so) ==17071== by 0x5A80552: xbuf_add (tmarshal.c:107) ==17071== by 0x5A82737: serialize_param (tmarshal.c:704) ==17071== by 0x5A82FB3: serialize_param (tmarshal.c:809) ==17071== by 0x5A88EB1: TMStubImpl_Invoke (tmarshal.c:2118) ==17071== by 0x50AD280: RPC_ExecuteCall (objidl.h:9086) ==17071== by 0x506C1ED: apartment_wndproc (compobj.c:1460) ==17071== by 0x54D8509: ??? (winproc.c:173) ==17071== by 0x54D867E: call_window_proc (winproc.c:244) ==17071== by 0x54DA817: WINPROC_call_window (winproc.c:900) ==17071== by 0x549BBE4: DispatchMessageW (message.c:4019) ==17071== by 0x4D26F60: IEWinMain (iexplore.c:1061) ==17071== by 0x475EA34: wWinMain (main.c:84) ==17071== by 0x475ED21: wmain (exe_wmain.c:51) ==17071== by 0x475EBFC: __wine_spec_exe_wentry (exe_wentry.c:36) ==17071== by 0x7B864247: ??? (process.c:1045) ==17071== by 0x7B864394: start_process (process.c:1097) ==17071== by 0x7BC87087: ??? (signal_i386.c:2571) ==17071== by 0x7BC870D0: call_thread_func (signal_i386.c:2630) ==17071== by 0x7BC87065: ??? (signal_i386.c:2571) ==17071== Address 0x47f42c8 is 16 bytes after a recently re-allocated block of size 208 alloc'd ==17071== at 0x7BC4C735: notify_alloc (heap.c:255) ==17071== by 0x7BC50F79: RtlAllocateHeap (heap.c:1716) ==17071== by 0x7B84586B: HeapAlloc (heap.c:271) ==17071== by 0x7B845A92: GlobalAlloc (heap.c:364) ==17071== by 0x7B846ECF: LocalAlloc (heap.c:967) ==17071== by 0x63A0A16: Alloc (comctl32undoc.c:74) ==17071== by 0x63F9DF0: REBAR_InsertBandT (rebar.c:2518) ==17071== by 0x63FD2C3: REBAR_WindowProc (rebar.c:3633) ==17071== by 0x54D8509: ??? (winproc.c:173) ==17071== by 0x54D867E: call_window_proc (winproc.c:244) ==17071== by 0x54DA817: WINPROC_call_window (winproc.c:900) ==17071== by 0x54971BC: call_window_proc (message.c:2223) ==17071== by 0x549A05A: send_message (message.c:3260) ==17071== by 0x549A678: SendMessageW (message.c:3454) ==17071== by 0x4D252BC: create_rebar (iexplore.c:492) ==17071== by 0x4D25371: iewnd_OnCreate (iexplore.c:506) ==17071== by 0x4D25B93: ie_window_proc (iexplore.c:665) ==17071== by 0x54D8509: ??? (winproc.c:173) ==17071== by 0x54D867E: call_window_proc (winproc.c:244) ==17071== by 0x54DA817: WINPROC_call_window (winproc.c:900) ==17071== -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 36196] New: valgrind shows some possible leaks in mmdevapi/tests/propstore.c
by wine-bugs＠winehq.org June 3, 2014

June 3, 2014

https://bugs.winehq.org/show_bug.cgi?id=36196 Bug ID: 36196 Summary: valgrind shows some possible leaks in mmdevapi/tests/propstore.c Product: Wine Version: 1.7.17 Hardware: x86 OS: Linux Status: NEW Keywords: download, source, testcase Severity: normal Priority: P2 Component: mmdevapi Assignee: wine-bugs(a)winehq.org Reporter: austinenglish(a)gmail.com ==12387== 28 bytes in 1 blocks are possibly lost in loss record 92 of 461 ==12387== at 0x7BC4C6B7: notify_alloc (heap.c:255) ==12387== by 0x7BC50EFB: RtlAllocateHeap (heap.c:1716) ==12387== by 0x4FC483E: COMPOBJ_DllList_Add (compobj.c:526) ==12387== by 0x4FC6B7A: apartment_getclassobject (compobj.c:1335) ==12387== by 0x4FCA2C4: get_inproc_class_object (compobj.c:2894) ==12387== by 0x4FCA783: CoGetClassObject (compobj.c:3032) ==12387== by 0x4FCAD45: CoCreateInstance (compobj.c:3197) ==12387== by 0x4E6D893: func_propstore (propstore.c:120) ==12387== by 0x4E80EAF: run_test (test.h:584) ==12387== by 0x4E8129E: main (test.h:654) ==12387== { -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 36586] New: valgrind shows uninitialized memory use in user32/tests/msg.c
by wine-bugs＠winehq.org June 3, 2014

June 3, 2014

https://bugs.winehq.org/show_bug.cgi?id=36586 Bug ID: 36586 Summary: valgrind shows uninitialized memory use in user32/tests/msg.c Product: Wine Version: 1.7.19 Hardware: x86 OS: Linux Status: NEW Keywords: download, source, testcase Severity: normal Priority: P2 Component: user32 Assignee: wine-bugs(a)winehq.org Reporter: austinenglish(a)gmail.com ==27824== Conditional jump or move depends on uninitialised value(s) ==27824== at 0x427931D: vfprintf (vfprintf.c:1634) ==27824== by 0x429C4E1: vsprintf (iovsprintf.c:42) ==27824== by 0x428229E: sprintf (sprintf.c:32) ==27824== by 0x4D13DF4: add_message_ (msg.c:1994) ==27824== by 0x4D4338F: test_hotkey (msg.c:13929) ==27824== by 0x4D47490: func_msg (msg.c:14598) ==27824== by 0x4DA6978: run_test (test.h:584) ==27824== by 0x4DA6D67: main (test.h:654) ==27824== Uninitialised value was created by a stack allocation ==27824== at 0x4D41D56: test_hotkey (msg.c:13707) ==27824== Use of uninitialised value of size 4 ==27824== at 0x42780CD: _itoa_word (_itoa.c:180) ==27824== by 0x427B856: vfprintf (vfprintf.c:1634) ==27824== by 0x429C4E1: vsprintf (iovsprintf.c:42) ==27824== by 0x428229E: sprintf (sprintf.c:32) ==27824== by 0x4D13DF4: add_message_ (msg.c:1994) ==27824== by 0x4D4338F: test_hotkey (msg.c:13929) ==27824== by 0x4D47490: func_msg (msg.c:14598) ==27824== by 0x4DA6978: run_test (test.h:584) ==27824== by 0x4DA6D67: main (test.h:654) ==27824== Uninitialised value was created by a stack allocation ==27824== at 0x4D41D56: test_hotkey (msg.c:13707) ==27824== -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 36398] New: valgrind shows an invalid read in comctl32/tests/toolbar.c
by wine-bugs＠winehq.org June 3, 2014

June 3, 2014

https://bugs.winehq.org/show_bug.cgi?id=36398 Bug ID: 36398 Summary: valgrind shows an invalid read in comctl32/tests/toolbar.c Product: Wine Version: 1.7.18 Hardware: x86 OS: Linux Status: NEW Keywords: download, source, testcase Severity: normal Priority: P2 Component: comctl32 Assignee: wine-bugs(a)winehq.org Reporter: austinenglish(a)gmail.com ==18993== Invalid read of size 2 ==18993== at 0x7BC55D60: RtlImageNtHeader (loader.c:2742) ==18993== by 0x7BC55EB9: RtlImageDirectoryEntryToData (loader.c:2916) ==18993== by 0x7BC6FBC4: find_entry (resource.c:189) ==18993== by 0x7BC70270: LdrFindResource_U (resource.c:303) ==18993== by 0x7B86DB6F: find_resourceW (resource.c:139) ==18993== by 0x7B86F7FD: FindResourceExW (resource.c:183) ==18993== by 0x7B86F8ED: FindResourceW (resource.c:192) ==18993== by 0x51A10FB: TOOLBAR_AddStringW (toolbar.c:2922) ==18993== by 0x51A8403: ToolbarWindowProc (toolbar.c:2993) ==18993== by 0x54CC579: ??? (in /home/austin/wine-valgrind-known/dlls/user32/user32.dll.so) ==18993== by 0x54CCCB5: call_window_proc (winproc.c:244) ==18993== by 0x54CE525: WINPROC_CallProcAtoW (winproc.c:504) ==18993== by 0x54CF3F2: WINPROC_call_window (winproc.c:911) ==18993== by 0x548DF3C: call_window_proc (message.c:2223) ==18993== by 0x5495685: send_message (message.c:3260) ==18993== by 0x5497BB0: SendMessageA (message.c:3476) ==18993== by 0x4FB7E62: test_add_string (toolbar.c:537) ==18993== by 0x4FBE480: func_toolbar (toolbar.c:1955) ==18993== by 0x4F4284B: main (test.h:584) ==18993== Address 0xdeadbeee is on thread 1's stack ==18993== -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 36129] New: valgrind shows some possible leaks in oleaut32/olepicture.c
by wine-bugs＠winehq.org June 3, 2014

June 3, 2014

https://bugs.winehq.org/show_bug.cgi?id=36129 Bug ID: 36129 Summary: valgrind shows some possible leaks in oleaut32/olepicture.c Product: Wine Version: 1.7.17 Hardware: x86 OS: Linux Status: NEW Keywords: download, source, testcase Severity: normal Priority: P2 Component: oleaut32 Assignee: wine-bugs(a)winehq.org Reporter: austinenglish(a)gmail.com ==26738== 28 bytes in 1 blocks are possibly lost in loss record 206 of 736 ==26738== at 0x7BC4D7D7: RtlAllocateHeap (heap.c:233) ==26738== by 0x54EA474: apartment_getclassobject (compobj.c:526) ==26738== by 0x54ED2D7: get_inproc_class_object (compobj.c:2894) ==26738== by 0x54EFC3B: CoGetClassObject (compobj.c:3032) ==26738== by 0x54F0307: CoCreateInstance (compobj.c:3197) ==26738== by 0x50BF1A3: OLEPictureImpl_LoadWICDecoder (olepicture.c:1163) ==26738== by 0x50BFE83: OLEPictureImpl_Load (olepicture.c:1490) ==26738== by 0x50C185E: OleLoadPicture (objidl.h:3149) ==26738== by 0x4D5BE6B: test_pic_with_stream (olepicture.c:199) ==26738== by 0x4D5C34C: test_pic (olepicture.c:281) ==26738== by 0x4D5D7F7: func_olepicture (olepicture.c:1261) ==26738== by 0x4D563A7: main (test.h:584) ==26738== ==26738== 28 bytes in 1 blocks are possibly lost in loss record 207 of 736 ==26738== at 0x7BC4D7D7: RtlAllocateHeap (heap.c:233) ==26738== by 0x54EA474: apartment_getclassobject (compobj.c:526) ==26738== by 0x54ED2D7: get_inproc_class_object (compobj.c:2894) ==26738== by 0x54EFC3B: CoGetClassObject (compobj.c:3032) ==26738== by 0x54F0307: CoCreateInstance (compobj.c:3197) ==26738== by 0x50C1E61: OleLoadPicturePath (olepicture.c:2400) ==26738== by 0x4D5D200: test_OleLoadPicturePath (olepicture.c:912) ==26738== by 0x4D5EEE4: func_olepicture (olepicture.c:1283) ==26738== by 0x4D563A7: main (test.h:584) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 36123] New: valgrind shows leaks in msiexec/msiexec.c
by wine-bugs＠winehq.org June 3, 2014

June 3, 2014

https://bugs.winehq.org/show_bug.cgi?id=36123 Bug ID: 36123 Summary: valgrind shows leaks in msiexec/msiexec.c Product: Wine Version: 1.7.17 Hardware: x86 OS: Linux Status: NEW Keywords: download, source, testcase Severity: normal Priority: P2 Component: programs Assignee: wine-bugs(a)winehq.org Reporter: austinenglish(a)gmail.com ==23034== 20 bytes in 1 blocks are definitely lost in loss record 107 of 592 ==23034== at 0x7BC4C735: notify_alloc (heap.c:255) ==23034== by 0x7BC50F79: RtlAllocateHeap (heap.c:1716) ==23034== by 0x472DD61: process_args (msiexec.c:490) ==23034== by 0x472E0BD: WinMain (msiexec.c:576) ==23034== by 0x473039B: main (exe_main.c:49) ==23034== ==23034== 26 bytes in 1 blocks are definitely lost in loss record 146 of 592 ==23034== at 0x7BC4C735: notify_alloc (heap.c:255) ==23034== by 0x7BC50F79: RtlAllocateHeap (heap.c:1716) ==23034== by 0x472CE7F: StringListAppend (msiexec.c:113) ==23034== by 0x472F9DE: WinMain (msiexec.c:966) ==23034== by 0x473039B: main (exe_main.c:49) ==23034== ==23034== 28 bytes in 1 blocks are definitely lost in loss record 150 of 592 ==23034== at 0x7BC4C735: notify_alloc (heap.c:255) ==23034== by 0x7BC50F79: RtlAllocateHeap (heap.c:1716) ==23034== by 0x472CFA7: build_properties (msiexec.c:146) ==23034== by 0x472FA15: WinMain (msiexec.c:972) ==23034== by 0x473039B: main (exe_main.c:49) ==23034== -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 36577] New: valgrind shows a use after free in urlmon/tests/url.c
by wine-bugs＠winehq.org June 3, 2014

June 3, 2014

https://bugs.winehq.org/show_bug.cgi?id=36577 Bug ID: 36577 Summary: valgrind shows a use after free in urlmon/tests/url.c Product: Wine Version: 1.7.19 Hardware: x86 OS: Linux Status: NEW Keywords: download, source, testcase Severity: normal Priority: P2 Component: urlmon Assignee: wine-bugs(a)winehq.org Reporter: austinenglish(a)gmail.com ==23547== Invalid read of size 4 ==23547== at 0x50304F6: Binding_Abort (binding.c:852) ==23547== by 0x78BB53D: abort_window_bindings (urlmon.h:408) ==23547== by 0x78A3C6C: detach_inner_window (htmlwindow.c:124) ==23547== by 0x78A421D: release_outer_window (htmlwindow.c:206) ==23547== by 0x78A45C7: HTMLWindow2_Release (htmlwindow.c:282) ==23547== by 0x7846EDB: CustomDoc_Release (mshtml.h:47873) ==23547== by 0x7834D3F: htmldoc_release (mshtml_private.h:544) ==23547== by 0x7835535: HTMLDocument_Release (htmldoc.c:140) ==23547== by 0x4EC4D3A: test_BindToObject (url.c:3332) ==23547== by 0x4EC8513: func_url (url.c:3895) ==23547== by 0x4ECA166: run_test (test.h:584) ==23547== by 0x4ECA555: main (test.h:654) ==23547== Address 0x49c3818 is 4,432 bytes inside a block of size 8,416 free'd ==23547== at 0x7BC4C72C: notify_free (heap.c:263) ==23547== by 0x7BC51071: RtlFreeHeap (heap.c:1762) ==23547== by 0x65C4013: heap_free (internet.h:136) ==23547== by 0x65C4A4F: WININET_Release (internet.c:277) ==23547== by 0x65CDD91: INTERNET_WorkerThreadFunc (internet.c:3841) ==23547== by 0x7BC90A24: worker_thread_proc (threadpool.c:110) ==23547== by 0x7BC870C7: ??? (signal_i386.c:2571) ==23547== by 0x7BC87110: call_thread_func (signal_i386.c:2630) ==23547== by 0x7BC870A5: ??? (signal_i386.c:2571) ==23547== by 0x7BC8E4EC: start_thread (thread.c:428) ==23547== by 0x421FF92: start_thread (pthread_create.c:309) ==23547== by 0x43247ED: clone (clone.S:129) ==23547== -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 36306] New: valgrind shows a possible leak in netapi32/tests/wksta.c
by wine-bugs＠winehq.org June 3, 2014

June 3, 2014

https://bugs.winehq.org/show_bug.cgi?id=36306 Bug ID: 36306 Summary: valgrind shows a possible leak in netapi32/tests/wksta.c Product: Wine Version: 1.7.18 Hardware: x86 OS: Linux Status: NEW Keywords: download, source, testcase Severity: normal Priority: P2 Component: netapi32 Assignee: wine-bugs(a)winehq.org Reporter: austinenglish(a)gmail.com ==30938== 64 bytes in 2 blocks are possibly lost in loss record 40 of 73 ==30938== at 0x7BC4C735: notify_alloc (heap.c:255) ==30938== by 0x7BC50F79: RtlAllocateHeap (heap.c:1716) ==30938== by 0x4C25EDC: ??? ==30938== by 0x4C33153: ??? ==30938== by 0x4C29723: ??? ==30938== by 0x4C29B00: ??? ==30938== by 0x4C3351B: ??? ==30938== by 0x4C33751: ??? ==30938== by 0x4C29ABA: ??? ==30938== by 0x4C3351B: ??? ==30938== by 0x4C3362E: ??? ==30938== by 0x4C2E6E4: ??? ==30938== by 0x4957493: run_wkstatransportenum_tests (wksta.c:152) ==30938== by 0x4957AB6: func_wksta (wksta.c:237) ==30938== by 0x49588C0: run_test (test.h:584) ==30938== by 0x4958CAF: main (test.h:654) ==30938== 64 bytes in 2 blocks are possibly lost in loss record 41 of 73 ==30938== at 0x7BC4C735: notify_alloc (heap.c:255) ==30938== by 0x7BC50F79: RtlAllocateHeap (heap.c:1716) ==30938== by 0x7BC39AE9: RtlInitializeCriticalSectionEx (critsection.c:326) ==30938== by 0x7B876B51: InitializeCriticalSectionEx (sync.c:356) ==30938== by 0x7B876AD0: InitializeCriticalSection (sync.c:313) ==30938== by 0x4C33177: ??? ==30938== by 0x4C29723: ??? ==30938== by 0x4C29B00: ??? ==30938== by 0x4C3351B: ??? ==30938== by 0x4C33751: ??? ==30938== by 0x4C29ABA: ??? ==30938== by 0x4C3351B: ??? ==30938== by 0x4C3362E: ??? ==30938== by 0x4C2E6E4: ??? ==30938== by 0x4957493: run_wkstatransportenum_tests (wksta.c:152) ==30938== by 0x4957AB6: func_wksta (wksta.c:237) ==30938== by 0x49588C0: run_test (test.h:584) ==30938== by 0x4958CAF: main (test.h:654) ==30938== -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 36325] New: valgrind shows a couple possible leaks in rpcrt4/tests/server.c
by wine-bugs＠winehq.org June 3, 2014

June 3, 2014

https://bugs.winehq.org/show_bug.cgi?id=36325 Bug ID: 36325 Summary: valgrind shows a couple possible leaks in rpcrt4/tests/server.c Product: Wine Version: 1.7.18 Hardware: x86 OS: Linux Status: NEW Keywords: download, source, testcase Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: austinenglish(a)gmail.com ==459== 64 bytes in 1 blocks are possibly lost in loss record 172 of 352 ==459== at 0x7BC4C735: notify_alloc (heap.c:255) ==459== by 0x7BC50F79: RtlAllocateHeap (heap.c:1716) ==459== by 0x55F927B: rpcrt4_protseq_np_alloc (rpc_transport.c:642) ==459== by 0x55F5366: alloc_serverprotoseq (rpc_server.c:927) ==459== by 0x55F5610: RPCRT4_get_or_create_serverprotseq (rpc_server.c:977) ==459== by 0x55F5709: RpcServerUseProtseqEpExA (rpc_server.c:997) ==459== by 0x55F51E2: RpcServerUseProtseqEpA (rpc_server.c:892) ==459== by 0x4973259: server (server.c:1622) ==459== by 0x49737B1: func_server (server.c:1718) ==459== by 0x4995124: run_test (test.h:584) ==459== by 0x4995513: main (test.h:654) ==459== -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 36585] New: valgrind shows uninitialized memory use in user32/tests/edit.c
by wine-bugs＠winehq.org June 3, 2014

June 3, 2014

https://bugs.winehq.org/show_bug.cgi?id=36585 Bug ID: 36585 Summary: valgrind shows uninitialized memory use in user32/tests/edit.c Product: Wine Version: 1.7.19 Hardware: x86 OS: Linux Status: NEW Keywords: download, source, testcase Severity: normal Priority: P2 Component: user32 Assignee: wine-bugs(a)winehq.org Reporter: austinenglish(a)gmail.com ../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe.so edit && touch edit.ok preloader: Warning: failed to reserve range 00110000-68000000 preloader: Warning: failed to reserve range 7f000000-82000000 ==4864== Use of uninitialised value of size 4 ==4864== at 0x403DC86: mbstowcs_sbcs (mbtowc.c:88) ==4864== by 0x403E430: wine_cp_mbstowcs (mbtowc.c:278) ==4864== by 0x7B850B05: MultiByteToWideChar (locale.c:2031) ==4864== by 0x52560FB: EDIT_EM_SetHandle (edit.c:2821) ==4864== by 0x525C68C: EditWndProc_common (edit.c:4728) ==4864== by 0x52CDFCA: EditWndProcA (winproc.c:1077) ==4864== by 0x52CB4F5: ??? (winproc.c:173) ==4864== by 0x52CB66A: call_window_proc (winproc.c:244) ==4864== by 0x52CD8B9: WINPROC_call_window (winproc.c:909) ==4864== by 0x528A11C: call_window_proc (message.c:2223) ==4864== by 0x528CFBA: send_message (message.c:3260) ==4864== by 0x528D649: SendMessageA (message.c:3476) ==4864== by 0x4DD5C07: test_EM_GETHANDLE (edit.c:2700) ==4864== by 0x4DD61E2: func_edit (edit.c:2785) ==4864== by 0x4E93978: run_test (test.h:584) ==4864== by 0x4E93D67: main (test.h:654) ==4864== Uninitialised value was created by a client request ==4864== at 0x7BC4C4D6: mark_block_uninitialized (heap.c:209) ==4864== by 0x7BC4C641: initialize_block (heap.c:240) ==4864== by 0x7BC50F4D: RtlAllocateHeap (heap.c:1717) ==4864== by 0x7B8457FF: HeapAlloc (heap.c:271) ==4864== by 0x7B845B34: GlobalAlloc (heap.c:388) ==4864== by 0x7B846E63: LocalAlloc (heap.c:967) ==4864== by 0x4DD5AD5: test_EM_GETHANDLE (edit.c:2686) ==4864== by 0x4DD61E2: func_edit (edit.c:2785) ==4864== by 0x4E93978: run_test (test.h:584) ==4864== by 0x4E93D67: main (test.h:654) ==4864== -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 1