http://bugs.winehq.org/show_bug.cgi?id=59317 StewVed <stewved@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stewved@gmail.com --- Comment #7 from StewVed <stewved@gmail.com> --- (In reply to SeongChan Lee from comment #5)
The change was introduced in this MR by me: https://gitlab.winehq.org/wine/wine/-/merge_requests/9789
Your patch seems to make the Y axis of XBOX game controllers not work for DInput, though XInput and Windows.Gaming.Input appear to work fine (joy.cpl) Since there are many DInput-based games (Star Wars Episode 1 Racer, Telltale Batman, NFS Most Wanted, The Grinch reported so far), and the problem can easily be seen in wine control joy.cpl > DInput tab, can your original commits please be reverted until a better solution is figured out? There is a patch that forces 32-bit back onto the hid: https://github.com/elgabo86/gwine/blob/main/patches/gamepad_axis_32bit_fix.m... https://bugs.winehq.org/attachment.cgi?id=80571&action=diff on the better solution front, I see your good idea of determining the size: static BYTE hid_device_determine_axis_size(LONG min, LONG max) { if ((min >= 0 && max <= 255) || (min >= -128 && max <= 127)) return 8; if ((min >= 0 && max <= 65535) || (min >= -32768 && max <= 32767)) return 16; return 32; } and that should be fine, though I think it will NEVER return 32 because the max (-32768 to 32767) is in hid_device_add_gamepad and is INT16 and USHORT, but some other part of the code seems to need the size to be 32 for the XBOX Gamepad Y axis to work?!? Just to say, everything else on the entire gampad appears to work perfectly, so I'd love to know what is special about the Y and rY axis. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.