[Bug 50382] New: Lego Star Wars Saga needs native d3dcompiler_47
https://bugs.winehq.org/show_bug.cgi?id=50382 Bug ID: 50382 Summary: Lego Star Wars Saga needs native d3dcompiler_47 Product: Wine Version: 6.0-rc3 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-d3d-util Assignee: wine-bugs(a)winehq.org Reporter: j-r(a)online.de Distribution: --- After installing Lego Star Wars Saga (GOG version) into a fresh 32 bit prefix, the game starts up fine including sound and controls, but with the exception of backgrounds and some effects nothing (logo, menu, in game characters etc) is displayed or replaced by grey boxes. winetricks d3dcompiler_47 fixes that problem. (An older App DB report using wine 3.3 mentions the same problem and fixing it by installing d3d9.) There is no console output indicating a problem in that area (recreating the test with wine 3.3 gives plenty of d3dcompiler error messages; perhaps they have been silenced since then?). Since the other d3dcompiler related bugs I checked all seemed to have d3dcompiler error messages I opened this new report, though it very likely still is a duplicate. Please advise which debug channels to turn on to generate a useful log. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50382 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12(a)gmail.com --- Comment #1 from Zebediah Figura <z.figura12(a)gmail.com> --- +d3dcompiler should probably be sufficient. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50382 --- Comment #2 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- Created attachment 68997 --> https://bugs.winehq.org/attachment.cgi?id=68997 +d3dcompiler I can confirm this with wine-6.0-rc3. Attached is a +d3dcompiler log. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50382 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- Confirming. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50382 --- Comment #4 from j-r(a)online.de --- Still present in 8,0-rc3 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50382 --- Comment #5 from j-r(a)online.de --- (In reply to j-r from comment #4)
Still present in 8,0-rc3
Or not. It's different and probably my fault. Ignore this for now. Sorry! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50382 --- Comment #6 from j-r(a)online.de --- Again, sorry that my cluelessness spams your inboxes. I checked my build and it seems the bundled vkd3d is self contained and I can't do anything wrong:-) So the result is that the original problem still exists, but the relevant code is now part of vkd3d. I guess that means we move this bug to the vkd3d component. I've dumped the shader hlsl and parsing fails before any actual shader code on the following definition string description = "Uber Shader v2.0"; I've looked at the open vkd3d bugs and this particular problem might already be mentioned - as a well known problem? - in https://bugs.winehq.org/show_bug.cgi?id=33979#c4 , but it seems not to be the focus of that or any other bug. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50382 Zeb Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Lego Star Wars Saga needs |Lego Star Wars Saga fails |native d3dcompiler_47 |to render some objects | |(needs "string" type | |parsing) Version|6.0-rc3 |1.6 Component|d3d-util |hlsl Product|Wine |vkd3d --- Comment #7 from Zeb Figura <z.figura12(a)gmail.com> --- There's a lot of HLSL bugs, yeah, but at this point we're starting to collect them by specific failure mode. Needing "string" for a normal (not effect) shader is a bit of an unusual one, though :-) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50382 snehamahajan <snehamahajun(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |snehamahajun(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50382 Neko-san <nekoNexus(a)protonmail.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nekoNexus(a)protonmail.ch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50382 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |55685 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50382 --- Comment #8 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- With wine-9.14-203-g7df297968a9 and vkd3d-git @ b23874dad600ec777c0bbe6ecc7aa3f5020476d1: 0130:err:d3dcompiler:D3DCompile2 Failed to compile shader, vkd3d result -5. 0130:err:d3dcompiler:D3DCompile2 Shader log: 0130:err:d3dcompiler:D3DCompile2 <anonymous>:126:22: E5017: Aborting due to not yet implemented feature: Evaluate string constants as static expressions. 0130:err:d3dcompiler:D3DCompile2 <anonymous>:187:63: E5000: syntax error, unexpected ':', expecting ';' or ',' 0130:err:d3dcompiler:D3DCompile2 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50382 --- Comment #9 from Nikolay Sivov <bunglehead(a)gmail.com> --- Please retest with current vkd3d, string constants parsing works now. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50382 --- Comment #10 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- With vkd3d-git @ 6226f533afb8d3fb3523fa44d5c5c1262bbcb331 : 0130:fixme:d3dcompiler:D3DCompile2 Ignoring flags 0x1200. 0130:err:d3dcompiler:D3DCompile2 Failed to compile shader, vkd3d result -4. 0130:err:d3dcompiler:D3DCompile2 Shader log: 0130:err:d3dcompiler:D3DCompile2 <anonymous>:759:1: W4300: Redefinition of USE_projectToEyeSpace. 0130:err:d3dcompiler:D3DCompile2 <anonymous>:231:63: E5000: syntax error, unexpected ':', expecting ';' or ',' 0130:err:d3dcompiler:D3DCompile2 But that's probably a new bug? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50382 --- Comment #11 from Nikolay Sivov <bunglehead(a)gmail.com> --- Gijs, could you please attach the failing shader? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50382 --- Comment #12 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- Created attachment 77069 --> https://bugs.winehq.org/attachment.cgi?id=77069 shaders (In reply to Nikolay Sivov from comment #11) Here you go. I've attached all of them, but I think vkd3d-shader-2921e750f03413b848340376171f8cc0-vs_3_0-source.hlsl is the one from the comment above. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50382 --- Comment #13 from Nikolay Sivov <bunglehead(a)gmail.com> --- This now fails on unrecognized semantic name: --- 32 »»»»»»»»float4 texcoord0: TEXCOORD0_centroid; 33 »»»»»»»»float4 texcoord1: TEXCOORD1_centroid; 34 »»»»»»»»float3 texcoord2: TEXCOORD2_centroid; 35 »»»»»»»»float1 texcoord3: TEXCOORD3_centroid; --- Looks like we don't support such modifiers - _centroid and _pp. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=50382 --- Comment #14 from j-r(a)online.de --- (In reply to Nikolay Sivov from comment #13)
This now fails on unrecognized semantic name:
--- 32 »»»»»»»»float4 texcoord0: TEXCOORD0_centroid; 33 »»»»»»»»float4 texcoord1: TEXCOORD1_centroid; 34 »»»»»»»»float3 texcoord2: TEXCOORD2_centroid; 35 »»»»»»»»float1 texcoord3: TEXCOORD3_centroid; ---
Looks like we don't support such modifiers - _centroid and _pp.
Still the case with the vkd3d bundled with wine 10.16. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=50382 --- Comment #15 from Nikolay Sivov <bunglehead(a)gmail.com> --- The _centroid suffix is now support in https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/1721. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=50382 --- Comment #16 from Nikolay Sivov <bunglehead(a)gmail.com> --- (In reply to Gijs Vermeulen from comment #12)
Created attachment 77069 [details] shaders
(In reply to Nikolay Sivov from comment #11)
Here you go. I've attached all of them, but I think vkd3d-shader-2921e750f03413b848340376171f8cc0-vs_3_0-source.hlsl is the one from the comment above.
This one compiles fine now, after _centroid suffix was implemented. Worth retesting. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=50382 --- Comment #17 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- There are no more errors when running with +d3dcompiler and VKD3D_SHADER_DEBUG=trace, but only the screen is still almost black except for a few effects. Should I add a new shader dump or a new log? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=50382 Francisco Casas <fcasas@codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fcasas@codeweavers.com --- Comment #18 from Francisco Casas <fcasas@codeweavers.com> --- On some of the provided shaders we are allocating cX registers for a uniform for which the native compiler doesn't. This can be fixed by implementing death store elimination. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/2109 Might help with this bug. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=50382 --- Comment #19 from Francisco Casas <fcasas@codeweavers.com> --- I realized that there is another uniform variable allocation discrepancy, which requires a slight improvement on the previous DSE pass implementation. I see that the bug can be fixed with these two additional patches: https://gitlab.winehq.org/fcasas/vkd3d/-/commit/1cd786b5289d332b1f86b35a95a3... https://gitlab.winehq.org/fcasas/vkd3d/-/commit/e4a3e1c29bddc8080d5e7661072b... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=50382 --- Comment #20 from Francisco Casas <fcasas@codeweavers.com> --- I sent an improved version of the previously mentioned patches as: https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/2154 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=50382 Gijs Vermeulen <gijsvrm@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #21 from Gijs Vermeulen <gijsvrm@gmail.com> --- I retested with an updated vkd3d after the aforementioned fixes were committed and can report that the game works perfectly now! Thanks! Marking FIXED. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
WineHQ Bugzilla -
WineHQ Bugzilla