March 2009 - Wine-Commits - list.winehq.org

Andrew Nguyen : tapi32: Stub lineGetDevCapsW.
by Alexandre Julliard March 23, 2009

March 23, 2009

Module: wine Branch: master Commit: af38006ad1ab107601b0f060a897eb7c322799f3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=af38006ad1ab107601b0f060a… Author: Andrew Nguyen <arethusa26(a)gmail.com> Date: Mon Mar 23 01:34:41 2009 -0500 tapi32: Stub lineGetDevCapsW. --- dlls/tapi32/line.c | 21 +++++++++++++++++---- dlls/tapi32/tapi32.spec | 1 + include/tapi.h | 5 +++-- 3 files changed, 21 insertions(+), 6 deletions(-) diff --git a/dlls/tapi32/line.c b/dlls/tapi32/line.c index 7ff1221..7145aa0 100644 --- a/dlls/tapi32/line.c +++ b/dlls/tapi32/line.c @@ -466,12 +466,25 @@ DWORD WINAPI lineGetCountryA(DWORD dwCountryID, DWORD dwAPIVersion, LPLINECOUNTR } /*********************************************************************** - * lineGetDevCaps (TAPI32.@) + * lineGetDevCapsW (TAPI32.@) */ -DWORD WINAPI lineGetDevCapsA(HLINEAPP hLineApp, DWORD dwDeviceID, DWORD dwAPIVersion, DWORD dwExtVersion, LPLINEDEVCAPS lpLineDevCaps) +DWORD WINAPI lineGetDevCapsW(HLINEAPP hLineApp, DWORD dwDeviceID, DWORD dwAPIVersion, + DWORD dwExtVersion, LPLINEDEVCAPS lpLineDevCaps) { - FIXME("(%p, %08x, %08x, %08x, %p): stub.\n", hLineApp, dwDeviceID, dwAPIVersion, dwExtVersion, lpLineDevCaps); - return 0; + FIXME("(%p, %08x, %08x, %08x, %p): stub.\n", hLineApp, dwDeviceID, dwAPIVersion, + dwExtVersion, lpLineDevCaps); + return LINEERR_OPERATIONFAILED; +} + +/*********************************************************************** + * lineGetDevCapsA (TAPI32.@) + */ +DWORD WINAPI lineGetDevCapsA(HLINEAPP hLineApp, DWORD dwDeviceID, DWORD dwAPIVersion, + DWORD dwExtVersion, LPLINEDEVCAPS lpLineDevCaps) +{ + FIXME("(%p, %08x, %08x, %08x, %p): stub.\n", hLineApp, dwDeviceID, dwAPIVersion, + dwExtVersion, lpLineDevCaps); + return LINEERR_OPERATIONFAILED; } /*********************************************************************** diff --git a/dlls/tapi32/tapi32.spec b/dlls/tapi32/tapi32.spec index d4faaff..645e7e0 100644 --- a/dlls/tapi32/tapi32.spec +++ b/dlls/tapi32/tapi32.spec @@ -43,6 +43,7 @@ @ stdcall lineGetCountryA(long long ptr) @ stdcall lineGetDevCaps(long long long long ptr) lineGetDevCapsA @ stdcall lineGetDevCapsA(long long long long ptr) +@ stdcall lineGetDevCapsW(long long long long ptr) @ stdcall lineGetDevConfig(long ptr str) lineGetDevConfigA @ stdcall lineGetDevConfigA(long ptr str) @ stdcall lineGetID(long long long long ptr str) lineGetIDA diff --git a/include/tapi.h b/include/tapi.h index fdb5e9f..9f0b695 100644 --- a/include/tapi.h +++ b/include/tapi.h @@ -888,7 +888,9 @@ DWORD WINAPI lineGetCallInfo(HCALL,LPLINECALLINFO); DWORD WINAPI lineGetCallStatus(HCALL,LPLINECALLSTATUS); DWORD WINAPI lineGetConfRelatedCalls(HCALL,LPLINECALLLIST); DWORD WINAPI lineGetCountry(DWORD,DWORD,LPLINECOUNTRYLIST); -DWORD WINAPI lineGetDevCaps(HLINEAPP,DWORD,DWORD,DWORD,LPLINEDEVCAPS); +DWORD WINAPI lineGetDevCapsA(HLINEAPP,DWORD,DWORD,DWORD,LPLINEDEVCAPS); +DWORD WINAPI lineGetDevCapsW(HLINEAPP,DWORD,DWORD,DWORD,LPLINEDEVCAPS); +#define lineGetDevCaps WINELIB_NAME_AW(lineGetDevCaps); DWORD WINAPI lineGetDevConfig(DWORD,LPVARSTRING,LPCSTR); DWORD WINAPI lineGetID(HLINE,DWORD,HCALL,DWORD,LPVARSTRING,LPCSTR); DWORD WINAPI lineGetIcon(DWORD,LPCSTR,HICON *); @@ -959,7 +961,6 @@ DWORD WINAPI lineGetAddressStatusA(HLINE,DWORD,LPLINEADDRESSSTATUS); DWORD WINAPI lineGetAppPriorityA(LPCSTR,DWORD,LPLINEEXTENSIONID const,DWORD,LPVARSTRING,LPDWORD); DWORD WINAPI lineGetCallInfoA(HCALL,LPLINECALLINFO); DWORD WINAPI lineGetCountryA(DWORD,DWORD,LPLINECOUNTRYLIST); -DWORD WINAPI lineGetDevCapsA(HLINEAPP,DWORD,DWORD,DWORD,LPLINEDEVCAPS); DWORD WINAPI lineGetDevConfigA(DWORD,LPVARSTRING,LPCSTR); DWORD WINAPI lineGetIDA(HLINE,DWORD,HCALL,DWORD,LPVARSTRING,LPCSTR); DWORD WINAPI lineGetIconA(DWORD,LPCSTR,HICON *);

1 0

James Hawkins : winebuild: Document the correlation of spec-> ordinals and spec->limit with an assertion (Coverity 902).
by Alexandre Julliard March 23, 2009

March 23, 2009

Module: wine Branch: master Commit: 665a0424cda2b390060e99659965597e5cea9775 URL: http://source.winehq.org/git/wine.git/?a=commit;h=665a0424cda2b390060e99659… Author: James Hawkins <truiken(a)gmail.com> Date: Sun Mar 22 14:32:51 2009 -0700 winebuild: Document the correlation of spec->ordinals and spec->limit with an assertion (Coverity 902). --- tools/winebuild/spec16.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tools/winebuild/spec16.c b/tools/winebuild/spec16.c index 7c6fc45..2ce3b0c 100644 --- a/tools/winebuild/spec16.c +++ b/tools/winebuild/spec16.c @@ -549,6 +549,7 @@ static void output_module16( DLLSPEC *spec ) if (!spec->ordinals) { + assert(spec->limit == 0); spec->ordinals = xmalloc( sizeof(spec->ordinals[0]) ); spec->ordinals[0] = NULL; }

1 0

Huw Davies : ole32: Register DataObject clipboard format.
by Alexandre Julliard March 23, 2009

March 23, 2009

Module: wine Branch: master Commit: e77ab142e4914b53adb42d1b8b7fd463a6d2605a URL: http://source.winehq.org/git/wine.git/?a=commit;h=e77ab142e4914b53adb42d1b8… Author: Huw Davies <huw(a)codeweavers.com> Date: Tue Mar 17 15:34:31 2009 +0000 ole32: Register DataObject clipboard format. --- dlls/ole32/clipboard.c | 15 ++++++++++++--- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/dlls/ole32/clipboard.c b/dlls/ole32/clipboard.c index 8e997ec..8a7bdd2 100644 --- a/dlls/ole32/clipboard.c +++ b/dlls/ole32/clipboard.c @@ -150,6 +150,8 @@ static ole_clipbrd* theOleClipboard; */ static const CHAR OLEClipbrd_WNDCLASS[] = "CLIPBRDWNDCLASS"; +static UINT dataobject_clipboard_format; + /* * If we need to store state info we can store it here. * For now we don't need this functionality. @@ -1175,15 +1177,22 @@ static ole_clipbrd* OLEClipbrd_Construct(void) return This; } +static void register_clipboard_formats(void) +{ + static const WCHAR DataObjectW[] = { 'D','a','t','a','O','b','j','e','c','t',0 }; + + if(!dataobject_clipboard_format) + dataobject_clipboard_format = RegisterClipboardFormatW(DataObjectW); +} + /*********************************************************************** * OLEClipbrd_Initialize() * Initializes the OLE clipboard. */ void OLEClipbrd_Initialize(void) { - /* - * Create the clipboard if necessary - */ + register_clipboard_formats(); + if ( !theOleClipboard ) { TRACE("()\n");

1 0

Huw Davies : ole32: Use IsEqualIID rather than memcmp.
by Alexandre Julliard March 23, 2009

March 23, 2009

Module: wine Branch: master Commit: c0fbbe7d910716b15607e3c988ee35614a2a2046 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c0fbbe7d910716b15607e3c98… Author: Huw Davies <huw(a)codeweavers.com> Date: Tue Mar 17 14:33:33 2009 +0000 ole32: Use IsEqualIID rather than memcmp. --- dlls/ole32/clipboard.c | 24 ++++-------------------- 1 files changed, 4 insertions(+), 20 deletions(-) diff --git a/dlls/ole32/clipboard.c b/dlls/ole32/clipboard.c index f9eefe8..8e997ec 100644 --- a/dlls/ole32/clipboard.c +++ b/dlls/ole32/clipboard.c @@ -730,40 +730,24 @@ static HRESULT WINAPI OLEClipbrd_IDataObject_QueryInterface( void** ppvObject) { ole_clipbrd *This = impl_from_IDataObject(iface); - TRACE("(%p)->(\n\tIID:\t%s,%p)\n",This,debugstr_guid(riid),ppvObject); + TRACE("(%p)->(IID:%s, %p)\n", This, debugstr_guid(riid), ppvObject); - /* - * Perform a sanity check on the parameters. - */ if ( (This==0) || (ppvObject==0) ) return E_INVALIDARG; - /* - * Initialize the return parameter. - */ *ppvObject = 0; - /* - * Compare the riid with the interface IDs implemented by this object. - */ - if (memcmp(&IID_IUnknown, riid, sizeof(IID_IUnknown)) == 0) + if (IsEqualIID(&IID_IUnknown, riid) || + IsEqualIID(&IID_IDataObject, riid)) { *ppvObject = iface; } - else if (memcmp(&IID_IDataObject, riid, sizeof(IID_IDataObject)) == 0) - { - *ppvObject = &This->lpvtbl; - } - else /* We only support IUnknown and IDataObject */ + else { WARN( "() : asking for unsupported interface %s\n", debugstr_guid(riid)); return E_NOINTERFACE; } - /* - * Query Interface always increases the reference count by one when it is - * successful. - */ IUnknown_AddRef((IUnknown*)*ppvObject); return S_OK;

1 0

Huw Davies : ole32: Rearrange functions to eliminate forward declarations.
by Alexandre Julliard March 23, 2009

March 23, 2009

Module: wine Branch: master Commit: 8beb83866ff7e9a13ab0a9d453a343674160f327 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8beb83866ff7e9a13ab0a9d45… Author: Huw Davies <huw(a)codeweavers.com> Date: Tue Mar 17 14:17:49 2009 +0000 ole32: Rearrange functions to eliminate forward declarations. --- dlls/ole32/clipboard.c | 1486 +++++++++++++++++++++++------------------------- 1 files changed, 699 insertions(+), 787 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=8beb83866ff7e9a13ab0a…

1 0

Huw Davies : ole32: Add a helper function to retrieve the implementation ptr.
by Alexandre Julliard March 23, 2009

March 23, 2009

Module: wine Branch: master Commit: 96bd8c5a7d2f99d540a69fd86c21cb86f17eff61 URL: http://source.winehq.org/git/wine.git/?a=commit;h=96bd8c5a7d2f99d540a69fd86… Author: Huw Davies <huw(a)codeweavers.com> Date: Tue Mar 17 12:44:20 2009 +0000 ole32: Add a helper function to retrieve the implementation ptr. --- dlls/ole32/clipboard.c | 94 +++++++++++++++--------------------------------- 1 files changed, 29 insertions(+), 65 deletions(-) diff --git a/dlls/ole32/clipboard.c b/dlls/ole32/clipboard.c index a1fed82..b386b1e 100644 --- a/dlls/ole32/clipboard.c +++ b/dlls/ole32/clipboard.c @@ -86,35 +86,24 @@ WINE_DEFAULT_DEBUG_CHANNEL(ole); /**************************************************************************** - * OLEClipbrd - * DO NOT add any members before the VTables declaration! + * ole_clipbrd */ -struct OLEClipbrd +struct ole_clipbrd { - /* - * List all interface VTables here - */ - const IDataObjectVtbl* lpvtbl1; /* IDataObject VTable */ - - /* - * The hidden OLE clipboard window. This window is used as the bridge between the - * the OLE and windows clipboard API. (Windows creates one such window per process) - */ - HWND hWndClipboard; + const IDataObjectVtbl* lpvtbl; /* Exposed IDataObject vtable */ - /* - * Pointer to the source data object (via OleSetClipboard) - */ - IDataObject* pIDataObjectSrc; + LONG ref; - /* - * Reference count of this object - */ - LONG ref; + HWND hWndClipboard; /* Hidden clipboard window */ + IDataObject* pIDataObjectSrc; /* Source object passed to OleSetClipboard */ }; -typedef struct OLEClipbrd OLEClipbrd; +typedef struct ole_clipbrd ole_clipbrd; +static inline ole_clipbrd *impl_from_IDataObject(IDataObject *iface) +{ + return (ole_clipbrd*)((char*)iface - FIELD_OFFSET(ole_clipbrd, lpvtbl)); +} /**************************************************************************** * IEnumFORMATETC implementation @@ -151,9 +140,9 @@ typedef struct PresentationDataHeader } PresentationDataHeader; /* - * The one and only OLEClipbrd object which is created by OLEClipbrd_Initialize() + * The one and only ole_clipbrd object which is created by OLEClipbrd_Initialize() */ -static OLEClipbrd* theOleClipboard; +static ole_clipbrd* theOleClipboard; /* @@ -161,8 +150,8 @@ static OLEClipbrd* theOleClipboard; */ void OLEClipbrd_Initialize(void); void OLEClipbrd_UnInitialize(void); -static OLEClipbrd* OLEClipbrd_Construct(void); -static void OLEClipbrd_Destroy(OLEClipbrd* ptrToDestroy); +static ole_clipbrd* OLEClipbrd_Construct(void); +static void OLEClipbrd_Destroy(ole_clipbrd* ptrToDestroy); static HWND OLEClipbrd_CreateWindow(void); static void OLEClipbrd_DestroyWindow(HWND hwnd); static LRESULT CALLBACK OLEClipbrd_WndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam); @@ -467,7 +456,7 @@ HRESULT WINAPI OleGetClipboard(IDataObject** ppDataObj) return E_OUTOFMEMORY; /* Return a reference counted IDataObject */ - hr = IDataObject_QueryInterface( (IDataObject*)&(theOleClipboard->lpvtbl1), + hr = IDataObject_QueryInterface( (IDataObject*)&(theOleClipboard->lpvtbl), &IID_IDataObject, (void**)ppDataObj); return hr; } @@ -635,14 +624,14 @@ void OLEClipbrd_UnInitialize(void) /********************************************************* * Construct the OLEClipbrd class. */ -static OLEClipbrd* OLEClipbrd_Construct(void) +static ole_clipbrd* OLEClipbrd_Construct(void) { - OLEClipbrd* This; + ole_clipbrd* This; This = HeapAlloc( GetProcessHeap(), 0, sizeof(*This) ); if (!This) return NULL; - This->lpvtbl1 = &OLEClipbrd_IDataObject_VTable; + This->lpvtbl = &OLEClipbrd_IDataObject_VTable; This->ref = 1; This->hWndClipboard = NULL; @@ -652,7 +641,7 @@ static OLEClipbrd* OLEClipbrd_Construct(void) return This; } -static void OLEClipbrd_Destroy(OLEClipbrd* This) +static void OLEClipbrd_Destroy(ole_clipbrd* This) { TRACE("()\n"); @@ -666,7 +655,6 @@ static void OLEClipbrd_Destroy(OLEClipbrd* This) HeapFree(GetProcessHeap(), 0, This); } - /*********************************************************************** * OLEClipbrd_CreateWindow() * Create the clipboard window @@ -773,7 +761,7 @@ static LRESULT CALLBACK OLEClipbrd_WndProc * Render the clipboard data. * (We must have a source data object or we wouldn't be in this WndProc) */ - OLEClipbrd_RenderFormat( (IDataObject*)&(theOleClipboard->lpvtbl1), &rgelt ); + OLEClipbrd_RenderFormat( (IDataObject*)&(theOleClipboard->lpvtbl), &rgelt ); break; } @@ -799,7 +787,7 @@ static LRESULT CALLBACK OLEClipbrd_WndProc * Render all HGLOBAL formats supported by the source into * the windows clipboard. */ - if ( FAILED( IDataObject_EnumFormatEtc( (IDataObject*)&(theOleClipboard->lpvtbl1), + if ( FAILED( IDataObject_EnumFormatEtc( (IDataObject*)&(theOleClipboard->lpvtbl), DATADIR_GET, &penumFormatetc) ) ) { WARN("(): WM_RENDERALLFORMATS failed to retrieve EnumFormatEtc!\n"); @@ -813,7 +801,7 @@ static LRESULT CALLBACK OLEClipbrd_WndProc /* * Render the clipboard data. */ - if ( FAILED(OLEClipbrd_RenderFormat( (IDataObject*)&(theOleClipboard->lpvtbl1), &rgelt )) ) + if ( FAILED(OLEClipbrd_RenderFormat( (IDataObject*)&(theOleClipboard->lpvtbl), &rgelt )) ) continue; TRACE("(): WM_RENDERALLFORMATS(cfFormat=%d)\n", rgelt.cfFormat); @@ -1064,10 +1052,7 @@ static HRESULT WINAPI OLEClipbrd_IDataObject_QueryInterface( REFIID riid, void** ppvObject) { - /* - * Declare "This" pointer - */ - OLEClipbrd *This = (OLEClipbrd *)iface; + ole_clipbrd *This = impl_from_IDataObject(iface); TRACE("(%p)->(\n\tIID:\t%s,%p)\n",This,debugstr_guid(riid),ppvObject); /* @@ -1090,7 +1075,7 @@ static HRESULT WINAPI OLEClipbrd_IDataObject_QueryInterface( } else if (memcmp(&IID_IDataObject, riid, sizeof(IID_IDataObject)) == 0) { - *ppvObject = &This->lpvtbl1; + *ppvObject = &This->lpvtbl; } else /* We only support IUnknown and IDataObject */ { @@ -1115,15 +1100,11 @@ static HRESULT WINAPI OLEClipbrd_IDataObject_QueryInterface( static ULONG WINAPI OLEClipbrd_IDataObject_AddRef( IDataObject* iface) { - /* - * Declare "This" pointer - */ - OLEClipbrd *This = (OLEClipbrd *)iface; + ole_clipbrd *This = impl_from_IDataObject(iface); TRACE("(%p)->(count=%u)\n",This, This->ref); return InterlockedIncrement(&This->ref); - } /************************************************************************ @@ -1134,22 +1115,13 @@ static ULONG WINAPI OLEClipbrd_IDataObject_AddRef( static ULONG WINAPI OLEClipbrd_IDataObject_Release( IDataObject* iface) { - /* - * Declare "This" pointer - */ - OLEClipbrd *This = (OLEClipbrd *)iface; + ole_clipbrd *This = impl_from_IDataObject(iface); ULONG ref; TRACE("(%p)->(count=%u)\n",This, This->ref); - /* - * Decrease the reference count on this object. - */ ref = InterlockedDecrement(&This->ref); - /* - * If the reference count goes down to 0, perform suicide. - */ if (ref == 0) { OLEClipbrd_Destroy(This); @@ -1176,11 +1148,7 @@ static HRESULT WINAPI OLEClipbrd_IDataObject_GetData( BOOL bClipboardOpen = FALSE; HRESULT hr = S_OK; LPVOID src; - - /* - * Declare "This" pointer - */ - OLEClipbrd *This = (OLEClipbrd *)iface; + ole_clipbrd *This = impl_from_IDataObject(iface); TRACE("(%p,%p,%p)\n", iface, pformatetcIn, pmedium); @@ -1346,11 +1314,7 @@ static HRESULT WINAPI OLEClipbrd_IDataObject_EnumFormatEtc( int cfmt, i; UINT format; BOOL bClipboardOpen; - - /* - * Declare "This" pointer - */ - OLEClipbrd *This = (OLEClipbrd *)iface; + ole_clipbrd *This = impl_from_IDataObject(iface); TRACE("(%p, %x, %p)\n", iface, dwDirection, ppenumFormatEtc);

1 0

Huw Davies : ole32: pFmt isn't exposed to the client, so simplify its allocation.
by Alexandre Julliard March 23, 2009

March 23, 2009

Module: wine Branch: master Commit: d72181381e0fd034d4b5bcb74655b15a5edfedd6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d72181381e0fd034d4b5bcb74… Author: Huw Davies <huw(a)codeweavers.com> Date: Tue Mar 17 14:25:09 2009 +0000 ole32: pFmt isn't exposed to the client, so simplify its allocation. --- dlls/ole32/clipboard.c | 22 +++++++--------------- 1 files changed, 7 insertions(+), 15 deletions(-) diff --git a/dlls/ole32/clipboard.c b/dlls/ole32/clipboard.c index efa5152..145cfea 100644 --- a/dlls/ole32/clipboard.c +++ b/dlls/ole32/clipboard.c @@ -231,7 +231,6 @@ static ULONG WINAPI OLEClipbrd_IEnumFORMATETC_AddRef(LPENUMFORMATETC iface) static ULONG WINAPI OLEClipbrd_IEnumFORMATETC_Release(LPENUMFORMATETC iface) { IEnumFORMATETCImpl *This = (IEnumFORMATETCImpl *)iface; - LPMALLOC pIMalloc; ULONG ref; TRACE("(%p)->(count=%u)\n",This, This->ref); @@ -243,12 +242,7 @@ static ULONG WINAPI OLEClipbrd_IEnumFORMATETC_Release(LPENUMFORMATETC iface) if (!ref) { TRACE("() - destroying IEnumFORMATETC(%p)\n",This); - if (SUCCEEDED(CoGetMalloc(MEMCTX_TASK, &pIMalloc))) - { - IMalloc_Free(pIMalloc, This->pFmt); - IMalloc_Release(pIMalloc); - } - + HeapFree(GetProcessHeap(), 0, This->pFmt); HeapFree(GetProcessHeap(),0,This); } return ref; @@ -379,9 +373,8 @@ static LPENUMFORMATETC OLEClipbrd_IEnumFORMATETC_Construct(UINT cfmt, const FORM { IEnumFORMATETCImpl* ef; DWORD size=cfmt * sizeof(FORMATETC); - LPMALLOC pIMalloc; - ef = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IEnumFORMATETCImpl)); + ef = HeapAlloc(GetProcessHeap(), 0, sizeof(IEnumFORMATETCImpl)); if (!ef) return NULL; @@ -391,15 +384,14 @@ static LPENUMFORMATETC OLEClipbrd_IEnumFORMATETC_Construct(UINT cfmt, const FORM ef->posFmt = 0; ef->countFmt = cfmt; - if (FAILED(CoGetMalloc(MEMCTX_TASK, &pIMalloc))) { + ef->pFmt = HeapAlloc(GetProcessHeap(), 0, size); + if (ef->pFmt) + memcpy(ef->pFmt, afmt, size); + else + { HeapFree(GetProcessHeap(), 0, ef); return NULL; } - ef->pFmt = IMalloc_Alloc(pIMalloc, size); - IMalloc_Release(pIMalloc); - - if (ef->pFmt) - memcpy(ef->pFmt, afmt, size); TRACE("(%p)->()\n",ef); return (LPENUMFORMATETC)ef;

1 0

Huw Davies : ole32: Don' t allocate the ole clipboard object in global memory - we' re not going to directly expose it to other processes.
by Alexandre Julliard March 23, 2009

March 23, 2009

Module: wine Branch: master Commit: e7ffa2aeb5f633536cf4881ebbadc3da6461af98 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e7ffa2aeb5f633536cf4881eb… Author: Huw Davies <huw(a)codeweavers.com> Date: Tue Mar 17 12:20:55 2009 +0000 ole32: Don't allocate the ole clipboard object in global memory - we're not going to directly expose it to other processes. --- dlls/ole32/clipboard.c | 77 ++++++++++-------------------------------------- 1 files changed, 16 insertions(+), 61 deletions(-) diff --git a/dlls/ole32/clipboard.c b/dlls/ole32/clipboard.c index 5bdd80a..a1fed82 100644 --- a/dlls/ole32/clipboard.c +++ b/dlls/ole32/clipboard.c @@ -108,16 +108,6 @@ struct OLEClipbrd IDataObject* pIDataObjectSrc; /* - * The registered DataObject clipboard format - */ - UINT cfDataObj; - - /* - * The handle to ourself - */ - HGLOBAL hSelf; - - /* * Reference count of this object */ LONG ref; @@ -647,68 +637,33 @@ void OLEClipbrd_UnInitialize(void) */ static OLEClipbrd* OLEClipbrd_Construct(void) { - OLEClipbrd* newObject = NULL; - HGLOBAL hNewObject = 0; - - /* - * Allocate space for the object. We use GlobalAlloc since we need - * an HGLOBAL to expose our DataObject as a registered clipboard type. - */ - hNewObject = GlobalAlloc( GMEM_DDESHARE|GMEM_MOVEABLE|GMEM_ZEROINIT, - sizeof(OLEClipbrd)); - if (hNewObject==0) - return NULL; - - /* - * Lock the handle for the entire lifetime of the clipboard. - */ - newObject = GlobalLock(hNewObject); - - /* - * Initialize the virtual function table. - */ - newObject->lpvtbl1 = &OLEClipbrd_IDataObject_VTable; + OLEClipbrd* This; - /* - * Start with one reference count. The caller of this function - * must release the interface pointer when it is done. - */ - newObject->ref = 1; + This = HeapAlloc( GetProcessHeap(), 0, sizeof(*This) ); + if (!This) return NULL; - newObject->hSelf = hNewObject; + This->lpvtbl1 = &OLEClipbrd_IDataObject_VTable; + This->ref = 1; - /* - * The Ole clipboard is a singleton - save the global handle and pointer - */ - theOleClipboard = newObject; + This->hWndClipboard = NULL; + This->pIDataObjectSrc = NULL; - return theOleClipboard; + theOleClipboard = This; + return This; } -static void OLEClipbrd_Destroy(OLEClipbrd* ptrToDestroy) +static void OLEClipbrd_Destroy(OLEClipbrd* This) { - TRACE("()\n"); + TRACE("()\n"); - if ( !ptrToDestroy ) - return; + if (!This) return; - /* - * Destroy the Ole clipboard window - */ - if ( ptrToDestroy->hWndClipboard ) - OLEClipbrd_DestroyWindow(ptrToDestroy->hWndClipboard); + theOleClipboard = NULL; - /* - * Free the actual OLE Clipboard structure. - */ - TRACE("() - Destroying clipboard data object.\n"); - GlobalUnlock(ptrToDestroy->hSelf); - GlobalFree(ptrToDestroy->hSelf); + if ( This->hWndClipboard ) + OLEClipbrd_DestroyWindow(This->hWndClipboard); - /* - * The Ole clipboard is a singleton (ptrToDestroy == theOleClipboard) - */ - theOleClipboard = NULL; + HeapFree(GetProcessHeap(), 0, This); }

1 0

Huw Davies : ole32: Simplify QueryInterface.
by Alexandre Julliard March 23, 2009

March 23, 2009

Module: wine Branch: master Commit: 319d0ddca6e2f67eddb0187a62db6ae11210e001 URL: http://source.winehq.org/git/wine.git/?a=commit;h=319d0ddca6e2f67eddb0187a6… Author: Huw Davies <huw(a)codeweavers.com> Date: Tue Mar 17 14:27:18 2009 +0000 ole32: Simplify QueryInterface. --- dlls/ole32/clipboard.c | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/dlls/ole32/clipboard.c b/dlls/ole32/clipboard.c index 145cfea..f9eefe8 100644 --- a/dlls/ole32/clipboard.c +++ b/dlls/ole32/clipboard.c @@ -183,11 +183,8 @@ static HRESULT WINAPI OLEClipbrd_IEnumFORMATETC_QueryInterface *ppvObj = NULL; - if(IsEqualIID(riid, &IID_IUnknown)) - { - *ppvObj = This; - } - else if(IsEqualIID(riid, &IID_IEnumFORMATETC)) + if(IsEqualIID(riid, &IID_IUnknown) || + IsEqualIID(riid, &IID_IEnumFORMATETC)) { *ppvObj = This; }

1 0

Huw Davies : ole32: Remove unused static variable.
by Alexandre Julliard March 23, 2009

March 23, 2009

Module: wine Branch: master Commit: e6eeb3aa17c8a90d62090822c7996747103c88ea URL: http://source.winehq.org/git/wine.git/?a=commit;h=e6eeb3aa17c8a90d62090822c… Author: Huw Davies <huw(a)codeweavers.com> Date: Tue Mar 17 11:55:09 2009 +0000 ole32: Remove unused static variable. --- dlls/ole32/clipboard.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/dlls/ole32/clipboard.c b/dlls/ole32/clipboard.c index b33cb52..5bdd80a 100644 --- a/dlls/ole32/clipboard.c +++ b/dlls/ole32/clipboard.c @@ -163,8 +163,7 @@ typedef struct PresentationDataHeader /* * The one and only OLEClipbrd object which is created by OLEClipbrd_Initialize() */ -static HGLOBAL hTheOleClipboard = 0; -static OLEClipbrd* theOleClipboard = NULL; +static OLEClipbrd* theOleClipboard; /* @@ -682,7 +681,6 @@ static OLEClipbrd* OLEClipbrd_Construct(void) * The Ole clipboard is a singleton - save the global handle and pointer */ theOleClipboard = newObject; - hTheOleClipboard = hNewObject; return theOleClipboard; } @@ -711,7 +709,6 @@ static void OLEClipbrd_Destroy(OLEClipbrd* ptrToDestroy) * The Ole clipboard is a singleton (ptrToDestroy == theOleClipboard) */ theOleClipboard = NULL; - hTheOleClipboard = 0; }

1 0