December 2021 - Wine-Commits

Nikolay Sivov : mfplat/tests: Handle ResetDevice() failure when used with D3D12 device.
by Alexandre Julliard Dec. 15, 2021

Dec. 15, 2021

Module: wine Branch: master Commit: 1e1e9463114039fc83e3407cad601e7c7855258a URL: https://source.winehq.org/git/wine.git/?a=commit;h=1e1e9463114039fc83e3407c… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Dec 15 11:12:43 2021 +0300 mfplat/tests: Handle ResetDevice() failure when used with D3D12 device. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52165 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mfplat/tests/mfplat.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/dlls/mfplat/tests/mfplat.c b/dlls/mfplat/tests/mfplat.c index 33b93852e2a..21eab6d1172 100644 --- a/dlls/mfplat/tests/mfplat.c +++ b/dlls/mfplat/tests/mfplat.c @@ -7467,6 +7467,11 @@ static void test_sample_allocator_d3d12(void) ok(hr == S_OK, "Failed to create device manager, hr %#x.\n", hr); hr = IMFDXGIDeviceManager_ResetDevice(manager, (IUnknown *)device, token); + if (FAILED(hr)) + { + win_skip("Device manager does not support D3D12 devices.\n"); + goto done; + } ok(hr == S_OK, "Failed to set a device, hr %#x.\n", hr); hr = pMFCreateVideoSampleAllocatorEx(&IID_IMFVideoSampleAllocator, (void **)&allocator);

1 0

Conor McCarthy : vkd3d: Convert the descriptor handle to a pointer when the descriptor table is set.
by Alexandre Julliard Dec. 15, 2021

Dec. 15, 2021

Module: vkd3d Branch: master Commit: ffbbee92470e2826a6ffb3c2674c54ce227f4889 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=ffbbee92470e2826a6ffb3c… Author: Conor McCarthy <cmccarthy(a)codeweavers.com> Date: Fri Dec 10 15:07:11 2021 +1000 vkd3d: Convert the descriptor handle to a pointer when the descriptor table is set. Saves a couple of conversion calls later, and more when Vulkan-backed heaps are added. Signed-off-by: Conor McCarthy <cmccarthy(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- libs/vkd3d/command.c | 6 +++--- libs/vkd3d/vkd3d_private.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libs/vkd3d/command.c b/libs/vkd3d/command.c index 37159a7..9fbde80 100644 --- a/libs/vkd3d/command.c +++ b/libs/vkd3d/command.c @@ -2605,7 +2605,7 @@ static void d3d12_command_list_prepare_descriptors(struct d3d12_command_list *li if (unbounded_offset != UINT_MAX /* Descriptors may not be set, eg. WoW. */ - && (base_descriptor = d3d12_desc_from_gpu_handle(bindings->descriptor_tables[table_index]))) + && (base_descriptor = bindings->descriptor_tables[table_index])) { heap_size = vkd3d_gpu_descriptor_allocator_range_size_from_descriptor( &device->gpu_descriptor_allocator, base_descriptor); @@ -2981,7 +2981,7 @@ static void d3d12_command_list_update_descriptors(struct d3d12_command_list *lis { if (bindings->descriptor_table_dirty_mask & ((uint64_t)1 << i)) { - if ((base_descriptor = d3d12_desc_from_gpu_handle(bindings->descriptor_tables[i]))) + if ((base_descriptor = bindings->descriptor_tables[i])) d3d12_command_list_update_descriptor_table(list, bind_point, i, base_descriptor); else WARN("Descriptor table %u is not set.\n", i); @@ -4182,7 +4182,7 @@ static void d3d12_command_list_set_descriptor_table(struct d3d12_command_list *l assert(root_signature_get_descriptor_table(root_signature, index)); assert(index < ARRAY_SIZE(bindings->descriptor_tables)); - bindings->descriptor_tables[index] = base_descriptor; + bindings->descriptor_tables[index] = d3d12_desc_from_gpu_handle(base_descriptor); bindings->descriptor_table_dirty_mask |= (uint64_t)1 << index; bindings->descriptor_table_active_mask |= (uint64_t)1 << index; } diff --git a/libs/vkd3d/vkd3d_private.h b/libs/vkd3d/vkd3d_private.h index f83fd1a..1bccb35 100644 --- a/libs/vkd3d/vkd3d_private.h +++ b/libs/vkd3d/vkd3d_private.h @@ -957,7 +957,7 @@ struct vkd3d_pipeline_bindings VkDescriptorSet descriptor_sets[VKD3D_MAX_DESCRIPTOR_SETS]; bool in_use; - D3D12_GPU_DESCRIPTOR_HANDLE descriptor_tables[D3D12_MAX_ROOT_COST]; + struct d3d12_desc *descriptor_tables[D3D12_MAX_ROOT_COST]; uint64_t descriptor_table_dirty_mask; uint64_t descriptor_table_active_mask;

1 0

Conor McCarthy : vkd3d: Change strip cut value FIXMEs to FIXME_ONCE.
by Alexandre Julliard Dec. 15, 2021

Dec. 15, 2021

Module: vkd3d Branch: master Commit: ff6e9300045df6f36b2d7a7ad6ec6ace475af3f0 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=ff6e9300045df6f36b2d7a7… Author: Conor McCarthy <cmccarthy(a)codeweavers.com> Date: Fri Dec 10 15:07:09 2021 +1000 vkd3d: Change strip cut value FIXMEs to FIXME_ONCE. These can generate many messages per frame in some games, e.g. Control. Signed-off-by: Conor McCarthy <cmccarthy(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- libs/vkd3d/command.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libs/vkd3d/command.c b/libs/vkd3d/command.c index 1db624e..37159a7 100644 --- a/libs/vkd3d/command.c +++ b/libs/vkd3d/command.c @@ -3070,7 +3070,7 @@ static void d3d12_command_list_check_index_buffer_strip_cut_value(struct d3d12_c case D3D12_INDEX_BUFFER_STRIP_CUT_VALUE_0xFFFF: if (list->index_buffer_format != DXGI_FORMAT_R16_UINT) { - FIXME("Strip cut value 0xffff is not supported with index buffer format %#x.\n", + FIXME_ONCE("Strip cut value 0xffff is not supported with index buffer format %#x.\n", list->index_buffer_format); } break; @@ -3078,7 +3078,7 @@ static void d3d12_command_list_check_index_buffer_strip_cut_value(struct d3d12_c case D3D12_INDEX_BUFFER_STRIP_CUT_VALUE_0xFFFFFFFF: if (list->index_buffer_format != DXGI_FORMAT_R32_UINT) { - FIXME("Strip cut value 0xffffffff is not supported with index buffer format %#x.\n", + FIXME_ONCE("Strip cut value 0xffffffff is not supported with index buffer format %#x.\n", list->index_buffer_format); } break;

1 0

Conor McCarthy : vkd3d-shader/spirv: Support runtime descriptor array offsets using push constants.
by Alexandre Julliard Dec. 15, 2021

Dec. 15, 2021

Module: vkd3d Branch: master Commit: 3816fa403f33aae5f110f7e62e907363c75a35e9 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=3816fa403f33aae5f110f7e… Author: Conor McCarthy <cmccarthy(a)codeweavers.com> Date: Fri Dec 3 18:58:58 2021 +1000 vkd3d-shader/spirv: Support runtime descriptor array offsets using push constants. Signed-off-by: Conor McCarthy <cmccarthy(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/vkd3d_shader.h | 36 +++++++++++++--- libs/vkd3d-shader/spirv.c | 102 ++++++++++++++++++++++++++++++++++++--------- libs/vkd3d/state.c | 16 ++++++- libs/vkd3d/vkd3d_private.h | 2 +- 4 files changed, 128 insertions(+), 28 deletions(-) Diff: https://source.winehq.org/git/vkd3d.git/?a=commitdiff;h=3816fa403f33aae5f11…

1 0

Conor McCarthy : vkd3d: Initialise root signature descriptor offset buffer to NULL.
by Alexandre Julliard Dec. 15, 2021

Dec. 15, 2021

Module: vkd3d Branch: master Commit: f65884f6b4199688395ad54298d9ee2edf7bdd28 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=f65884f6b4199688395ad54… Author: Conor McCarthy <cmccarthy(a)codeweavers.com> Date: Fri Dec 3 18:58:57 2021 +1000 vkd3d: Initialise root signature descriptor offset buffer to NULL. Signed-off-by: Conor McCarthy <cmccarthy(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- libs/vkd3d/state.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libs/vkd3d/state.c b/libs/vkd3d/state.c index cb3f99a..7c9575f 100644 --- a/libs/vkd3d/state.c +++ b/libs/vkd3d/state.c @@ -1141,6 +1141,7 @@ static HRESULT d3d12_root_signature_init(struct d3d12_root_signature *root_signa root_signature->parameters = NULL; root_signature->flags = desc->Flags; root_signature->descriptor_mapping = NULL; + root_signature->descriptor_offsets = NULL; root_signature->static_sampler_count = 0; root_signature->static_samplers = NULL; root_signature->device = device;

1 0

Conor McCarthy : vkd3d: Simplify checking if a descriptor has a view.
by Alexandre Julliard Dec. 15, 2021

Dec. 15, 2021

Module: vkd3d Branch: master Commit: 7d609770c481a5762d8fa8bc7d130f31a3c2afc8 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=7d609770c481a5762d8fa8b… Author: Conor McCarthy <cmccarthy(a)codeweavers.com> Date: Thu Dec 9 01:00:20 2021 +1000 vkd3d: Simplify checking if a descriptor has a view. Saves a few CPU cycles on a potentially very hot code path. Based on a vkd3d-proton patch by Philip Rebohle. Signed-off-by: Conor McCarthy <cmccarthy(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- libs/vkd3d/resource.c | 10 ++-------- libs/vkd3d/vkd3d_private.h | 16 ++++++++++------ 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/libs/vkd3d/resource.c b/libs/vkd3d/resource.c index 2887779..1991223 100644 --- a/libs/vkd3d/resource.c +++ b/libs/vkd3d/resource.c @@ -2130,9 +2130,7 @@ void d3d12_desc_write_atomic(struct d3d12_desc *dst, const struct d3d12_desc *sr pthread_mutex_lock(mutex); /* Nothing to do for VKD3D_DESCRIPTOR_MAGIC_CBV. */ - if ((dst->magic == VKD3D_DESCRIPTOR_MAGIC_SRV - || dst->magic == VKD3D_DESCRIPTOR_MAGIC_UAV - || dst->magic == VKD3D_DESCRIPTOR_MAGIC_SAMPLER) + if ((dst->magic & VKD3D_DESCRIPTOR_MAGIC_HAS_VIEW) && !InterlockedDecrement(&dst->u.view->refcount)) destroy_desc = *dst; @@ -2165,12 +2163,8 @@ void d3d12_desc_copy(struct d3d12_desc *dst, const struct d3d12_desc *src, mutex = d3d12_device_get_descriptor_mutex(device, src); pthread_mutex_lock(mutex); - if (src->magic == VKD3D_DESCRIPTOR_MAGIC_SRV - || src->magic == VKD3D_DESCRIPTOR_MAGIC_UAV - || src->magic == VKD3D_DESCRIPTOR_MAGIC_SAMPLER) - { + if (src->magic & VKD3D_DESCRIPTOR_MAGIC_HAS_VIEW) vkd3d_view_incref(src->u.view); - } tmp = *src; diff --git a/libs/vkd3d/vkd3d_private.h b/libs/vkd3d/vkd3d_private.h index e963131..f83fd1a 100644 --- a/libs/vkd3d/vkd3d_private.h +++ b/libs/vkd3d/vkd3d_private.h @@ -41,13 +41,17 @@ #define VK_CALL(f) (vk_procs->f) +#define MAKE_MAGIC(a,b,c,f) (((uint32_t)a) | (((uint32_t)b) << 8) | (((uint32_t)c) << 16) | f) + +#define VKD3D_DESCRIPTOR_MAGIC_HAS_VIEW 0x01000000u + #define VKD3D_DESCRIPTOR_MAGIC_FREE 0x00000000u -#define VKD3D_DESCRIPTOR_MAGIC_CBV 0x00564243u -#define VKD3D_DESCRIPTOR_MAGIC_SRV 0x00565253u -#define VKD3D_DESCRIPTOR_MAGIC_UAV 0x00564155u -#define VKD3D_DESCRIPTOR_MAGIC_SAMPLER 0x504d4153u -#define VKD3D_DESCRIPTOR_MAGIC_DSV 0x00565344u -#define VKD3D_DESCRIPTOR_MAGIC_RTV 0x00565452u +#define VKD3D_DESCRIPTOR_MAGIC_CBV MAKE_MAGIC('C', 'B', 'V', 0) +#define VKD3D_DESCRIPTOR_MAGIC_SRV MAKE_MAGIC('S', 'R', 'V', VKD3D_DESCRIPTOR_MAGIC_HAS_VIEW) +#define VKD3D_DESCRIPTOR_MAGIC_UAV MAKE_MAGIC('U', 'A', 'V', VKD3D_DESCRIPTOR_MAGIC_HAS_VIEW) +#define VKD3D_DESCRIPTOR_MAGIC_SAMPLER MAKE_MAGIC('S', 'M', 'P', VKD3D_DESCRIPTOR_MAGIC_HAS_VIEW) +#define VKD3D_DESCRIPTOR_MAGIC_DSV MAKE_MAGIC('D', 'S', 'V', 0) +#define VKD3D_DESCRIPTOR_MAGIC_RTV MAKE_MAGIC('R', 'T', 'V', 0) #define VKD3D_MAX_COMPATIBLE_FORMAT_COUNT 6u #define VKD3D_MAX_QUEUE_FAMILY_COUNT 3u

1 0

Matteo Bruni : ddraw: Fix typo in a comment.
by Alexandre Julliard Dec. 14, 2021

Dec. 14, 2021

Module: wine Branch: master Commit: 1e992a430beaa73a85313a81fd0cd1df61d91c4c URL: https://source.winehq.org/git/wine.git/?a=commit;h=1e992a430beaa73a85313a81… Author: Matteo Bruni <mbruni(a)codeweavers.com> Date: Fri Dec 10 20:03:42 2021 +0100 ddraw: Fix typo in a comment. Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ddraw/surface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ddraw/surface.c b/dlls/ddraw/surface.c index 09f52b85aed..65e24b0bbcf 100644 --- a/dlls/ddraw/surface.c +++ b/dlls/ddraw/surface.c @@ -97,7 +97,7 @@ HRESULT ddraw_surface_update_frontbuffer(struct ddraw_surface *surface, * while in exclusive mode, since it would get obscured by the popup * window. On the other hand, if the current frontbuffer *is* the GDI * frontbuffer, that's what's supposed to happen; the popup should obscure - * (oart of) the ddraw swapchain window. + * (part of) the ddraw swapchain window. * * This affects the "Deer Hunter" demo, which uses a popup window and GDI * draws to draw part of the user interface. See also the "fswindow"

1 0

Matteo Bruni : ddraw: Pass the sub resource count to ddraw_surface_reserve_memory().
by Alexandre Julliard Dec. 14, 2021

Dec. 14, 2021

Module: wine Branch: master Commit: 91916619922c96bbeedbd4b9fb233b467b62b3b1 URL: https://source.winehq.org/git/wine.git/?a=commit;h=91916619922c96bbeedbd4b9… Author: Matteo Bruni <mbruni(a)codeweavers.com> Date: Fri Dec 10 20:03:39 2021 +0100 ddraw: Pass the sub resource count to ddraw_surface_reserve_memory(). Mostly to avoid triggering the WARN() from wined3d_texture_get_sub_resource_desc() every time this function is called. Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ddraw/surface.c | 26 +++++++++++++++----------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/dlls/ddraw/surface.c b/dlls/ddraw/surface.c index 25aa2be41bb..d4fddcc8d06 100644 --- a/dlls/ddraw/surface.c +++ b/dlls/ddraw/surface.c @@ -5923,7 +5923,8 @@ static HRESULT CDECL ddraw_reset_enum_callback(struct wined3d_resource *resource return DD_OK; } -static HRESULT ddraw_surface_reserve_memory(struct wined3d_texture *wined3d_texture) +static HRESULT ddraw_surface_reserve_memory(struct wined3d_texture *wined3d_texture, + unsigned int sub_resource_count) { static const unsigned int extra_size = 0x10000; @@ -5931,9 +5932,8 @@ static HRESULT ddraw_surface_reserve_memory(struct wined3d_texture *wined3d_text struct wined3d_resource_desc resource_desc; struct wined3d_sub_resource_desc desc; unsigned int pitch, slice_pitch; - unsigned int sub_resource_idx; HRESULT hr = WINED3D_OK; - unsigned int offset; + unsigned int offset, i; wined3d_resource_get_desc(wined3d_texture_get_resource(wined3d_texture), &resource_desc); if (!(texture->texture_memory = heap_alloc_zero(resource_desc.size + extra_size))) @@ -5944,13 +5944,18 @@ static HRESULT ddraw_surface_reserve_memory(struct wined3d_texture *wined3d_text TRACE("texture->texture_memory %p.\n", texture->texture_memory); offset = 0; - sub_resource_idx = 0; - while (wined3d_texture_get_sub_resource_desc(wined3d_texture, sub_resource_idx, &desc) - == WINED3D_OK) + for (i = 0; i < sub_resource_count; ++i) { - wined3d_texture_get_pitch(wined3d_texture, sub_resource_idx, &pitch, &slice_pitch); + if (FAILED(hr = wined3d_texture_get_sub_resource_desc(wined3d_texture, i, &desc))) + { + ERR("Subresource %u not found.\n", i); + heap_free(texture->texture_memory); + texture->texture_memory = NULL; + return hr; + } + wined3d_texture_get_pitch(wined3d_texture, i, &pitch, &slice_pitch); - if (FAILED(hr = wined3d_texture_update_desc(wined3d_texture, sub_resource_idx, + if (FAILED(hr = wined3d_texture_update_desc(wined3d_texture, i, desc.width, desc.height, resource_desc.format, desc.multisample_type, desc.multisample_quality, (BYTE *)texture->texture_memory + offset, pitch))) @@ -5959,7 +5964,6 @@ static HRESULT ddraw_surface_reserve_memory(struct wined3d_texture *wined3d_text texture->texture_memory = NULL; break; } - ++sub_resource_idx; offset += desc.size; } return hr; @@ -6641,7 +6645,7 @@ HRESULT ddraw_surface_create(struct ddraw *ddraw, const DDSURFACEDESC2 *surface_ && desc->ddsCaps.dwCaps & DDSCAPS_VIDEOMEMORY && wined3d_display_mode_format.u1.dwRGBBitCount <= 16; - if (reserve_memory && FAILED(hr = ddraw_surface_reserve_memory(wined3d_texture))) + if (reserve_memory && FAILED(hr = ddraw_surface_reserve_memory(wined3d_texture, layers * levels))) { ERR("Failed to reserve surface memory, hr %#x.\n", hr); goto fail; @@ -6700,7 +6704,7 @@ HRESULT ddraw_surface_create(struct ddraw *ddraw, const DDSURFACEDESC2 *surface_ wined3d_texture_set_color_key(wined3d_texture, DDCKEY_SRCBLT, (struct wined3d_color_key *)&desc->ddckCKSrcBlt); - if (reserve_memory && FAILED(hr = ddraw_surface_reserve_memory(wined3d_texture))) + if (reserve_memory && FAILED(hr = ddraw_surface_reserve_memory(wined3d_texture, 1))) { hr = hr_ddraw_from_wined3d(hr); goto fail;

1 0

Alexandre Julliard : winebrowser: Try xdg-open before /usr/bin/open.
by Alexandre Julliard Dec. 14, 2021

Dec. 14, 2021

Module: wine Branch: master Commit: 2e569060081467361fe32a139366391e0c1734fa URL: https://source.winehq.org/git/wine.git/?a=commit;h=2e569060081467361fe32a13… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Dec 14 21:28:58 2021 +0100 winebrowser: Try xdg-open before /usr/bin/open. /usr/bin/open may be something different on Linux. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52206 Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/winebrowser/main.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/programs/winebrowser/main.c b/programs/winebrowser/main.c index 14ce00bf518..913c0a8d672 100644 --- a/programs/winebrowser/main.c +++ b/programs/winebrowser/main.c @@ -115,13 +115,11 @@ static LSTATUS get_commands( HKEY key, const WCHAR *value, WCHAR *buffer, DWORD static int open_http_url( const WCHAR *url ) { static const WCHAR defaultbrowsers[] = - L"/usr/bin/open\0" - "xdg-open\0" + L"xdg-open\0" + "/usr/bin/open\0" "firefox\0" "konqueror\0" "mozilla\0" - "netscape\0" - "galeon\0" "opera\0" "dillo\0"; WCHAR browsers[256];

1 0

Alexandre Julliard : ntdll: Fix the RtlCreateTimer() argument order.
by Alexandre Julliard Dec. 14, 2021

Dec. 14, 2021

Module: wine Branch: master Commit: 8125687441923e11ffb8918b89f3c0d85040b8e2 URL: https://source.winehq.org/git/wine.git/?a=commit;h=8125687441923e11ffb8918b… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Dec 14 21:48:44 2021 +0100 ntdll: Fix the RtlCreateTimer() argument order. Found by Dávid Török. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernelbase/sync.c | 2 +- dlls/ntdll/threadpool.c | 4 ++-- include/winternl.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/kernelbase/sync.c b/dlls/kernelbase/sync.c index ab963c62221..1ae72c770eb 100644 --- a/dlls/kernelbase/sync.c +++ b/dlls/kernelbase/sync.c @@ -818,7 +818,7 @@ BOOL WINAPI DECLSPEC_HOTPATCH CreateTimerQueueTimer( PHANDLE timer, HANDLE queue WAITORTIMERCALLBACK callback, PVOID arg, DWORD when, DWORD period, ULONG flags ) { - return set_ntstatus( RtlCreateTimer( timer, queue, callback, arg, when, period, flags )); + return set_ntstatus( RtlCreateTimer( queue, timer, callback, arg, when, period, flags )); } diff --git a/dlls/ntdll/threadpool.c b/dlls/ntdll/threadpool.c index ca323919d05..827232b2143 100644 --- a/dlls/ntdll/threadpool.c +++ b/dlls/ntdll/threadpool.c @@ -887,8 +887,8 @@ static struct timer_queue *get_timer_queue(HANDLE TimerQueue) * Creates a new timer associated with the given queue. * * PARAMS - * NewTimer [O] The newly created timer. * TimerQueue [I] The queue to hold the timer. + * NewTimer [O] The newly created timer. * Callback [I] The callback to fire. * Parameter [I] The argument for the callback. * DueTime [I] The delay, in milliseconds, before first firing the @@ -906,7 +906,7 @@ static struct timer_queue *get_timer_queue(HANDLE TimerQueue) * Success: STATUS_SUCCESS. * Failure: Any NTSTATUS code. */ -NTSTATUS WINAPI RtlCreateTimer(PHANDLE NewTimer, HANDLE TimerQueue, +NTSTATUS WINAPI RtlCreateTimer(HANDLE TimerQueue, HANDLE *NewTimer, RTL_WAITORTIMERCALLBACKFUNC Callback, PVOID Parameter, DWORD DueTime, DWORD Period, ULONG Flags) diff --git a/include/winternl.h b/include/winternl.h index 7c3a0c3cf57..0e23fdd97bf 100644 --- a/include/winternl.h +++ b/include/winternl.h @@ -4200,7 +4200,7 @@ NTSYSAPI NTSTATUS WINAPI RtlCreateProcessParameters(RTL_USER_PROCESS_PARAMETERS NTSYSAPI NTSTATUS WINAPI RtlCreateProcessParametersEx(RTL_USER_PROCESS_PARAMETERS**,const UNICODE_STRING*,const UNICODE_STRING*,const UNICODE_STRING*,const UNICODE_STRING*,PWSTR,const UNICODE_STRING*,const UNICODE_STRING*,const UNICODE_STRING*,const UNICODE_STRING*,ULONG); NTSYSAPI NTSTATUS WINAPI RtlCreateSecurityDescriptor(PSECURITY_DESCRIPTOR,DWORD); NTSYSAPI NTSTATUS WINAPI RtlCreateTimerQueue(PHANDLE); -NTSYSAPI NTSTATUS WINAPI RtlCreateTimer(PHANDLE, HANDLE, RTL_WAITORTIMERCALLBACKFUNC, PVOID, DWORD, DWORD, ULONG); +NTSYSAPI NTSTATUS WINAPI RtlCreateTimer(HANDLE,HANDLE*,RTL_WAITORTIMERCALLBACKFUNC, PVOID, DWORD, DWORD, ULONG); NTSYSAPI BOOLEAN WINAPI RtlCreateUnicodeString(PUNICODE_STRING,LPCWSTR); NTSYSAPI BOOLEAN WINAPI RtlCreateUnicodeStringFromAsciiz(PUNICODE_STRING,LPCSTR); NTSYSAPI NTSTATUS WINAPI RtlCreateUserProcess(UNICODE_STRING*,ULONG,RTL_USER_PROCESS_PARAMETERS*,SECURITY_DESCRIPTOR*,SECURITY_DESCRIPTOR*,HANDLE,BOOLEAN,HANDLE,HANDLE,RTL_USER_PROCESS_INFORMATION*);

1 0