October 2003 - Wine-Devel - list.winehq.org

Regression in lstrcmpiA (occurred in late June, NLS related)
by Troy Rollo Oct. 8, 2003

Oct. 8, 2003

When lstrcmpiA was moved from ole2nls.c to locale.c, (around 28th June) the results of comparisons in some cases became reversed. For example, the underscore now returns as greater than alphabetic characters, whereas it used to return as less than alphabetic characters. The older behaviour was consistent with Win2k. The output below is from the following source: ---begin test program--- #include <windows.h> #include <stdio.h> char *test_strings[] = { "_", "A", "a", "z", "Z", 0 }; void test_string(char *pch) { char **ppch = test_strings; while (*ppch) { printf("%s\t%s\t%d\n", pch, *ppch, lstrcmpiA(pch, *ppch)); ++ppch; } } int main(int argc, char **argv) { char **ppch = test_strings; while (*ppch) test_string(*ppch++); return 0; } ---end test program--- ---Wine output from immediately before the change--- _ _ 0sorts _ A -1 _ a -1 _ z -1 _ Z -1 A _ 1 A A 0 A a 0 A z -1 A Z -1 a _ 1 a A 0 a a 0 a z -1 a Z -1 z _ 1 z A 1 z a 1 z z 0 z Z 0 Z _ 1 Z A 1 Z a 1 Z z 0 Z Z 0 ---End--- ---Wine output from immediately after the change--- _ _ 0 _ A 1 _ a 1 _ z 1 _ Z 1 A _ -1 A A 0 A a 0 A z -1 A Z -1 a _ -1 a A 0 a a 0 a z -1 a Z -1 z _ -1 z A 1 z a 1 z z 0 z Z 0 Z _ -1 Z A 1 Z a 1 Z z 0 Z Z 0 ~---End---

8 26

Re: winebuild: small docu update
by Alexandre Julliard Oct. 8, 2003

Oct. 8, 2003

"Dimitrie O. Paun" <dpaun(a)rogers.com> writes: > Since these are internal use only, let's not document them > for external people, it will just cause problems. I disagree, it's much better to have documentation stating that they are internal than not to have any documentation at all. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Move actual code out of assert statements
by Alexandre Julliard Oct. 8, 2003

Oct. 8, 2003

Warren_Baird(a)cimmetry.com writes: > (See attached file: patch_code_out_of_asserts.txt) The indentation is messed up. You should set your editor tab width to 8 instead of 4. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Abort glyph rendering if everything is clipped
by Alexandre Julliard Oct. 8, 2003

Oct. 8, 2003

Warren_Baird(a)cimmetry.com writes: > (See attached file: patch_xrender_abort_if_clipped.txt) It would be better IMO to do that as part of the clip rectangle calculation a few lines below. -- Alexandre Julliard julliard(a)winehq.com

1 0

GDI and DirectX test suite
by Steven Edwards Oct. 7, 2003

Oct. 7, 2003

Hello, I have post a collection of tests with source code for the GDI and DirectDraw 7 interfaces at http://mail.gleneagle.net/sedwards/gdi/ The authors of the Windows2000 API Blackbook have aggreed to license the tests as public domain with a request for advertising. The ReactOS project has already started using these tests to help in our implementation and they may make a good test for WINE and Winelib. Thanks Steven __________________________________ Do you Yahoo!? The New Yahoo! Shopping - with improved product search http://shopping.yahoo.com

2 1

Re: wine/ windows/winpos.c server/window.c server/ ...
by Martin Fuchs Oct. 7, 2003

Oct. 7, 2003

Hello Alexandre, I see, you implemented storage of the four global shell and takman windows. Btw.: great unified aproach, this single get/set server call. :) But you did not yet insert the altered focus handling in set_active_window() from my patch. Is this just comming next, or is there another particular reason for not doing this? Martin On 07.10.2003 05:40:24 Alexandre Julliard wrote: > ChangeSet ID: 9656 > CVSROOT: /home/winehq/opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 2003/10/06 22:40:24 > > Modified files: > windows : winpos.c > server : window.c trace.c request.h protocol.def > include/wine : server_protocol.h > dlls/user : focus.c > > Log message: > Store the global shell, progman and taskman windows in the server > (based on a patch by Martin Fuchs). > > Patch: > http://cvs.winehq.com/patch.py?root=/home/winehq/opt/cvs-commit&id=9656 > > Old revision New revision Changes Path > 1.147 1.148 +0 -81 wine/windows/winpos.c > 1.23 1.24 +61 -0 wine/server/window.c > 1.182 1.183 +20 -0 wine/server/trace.c > 1.88 1.89 +2 -0 wine/server/request.h > 1.84 1.85 +18 -0 wine/server/protocol.def > 1.85 1.86 +27 -1 wine/include/wine/server_protocol.h > 1.5 1.6 +131 -0 wine/dlls/user/focus.c

2 5

Re: Abort glyph rendering if everything is clipped
by Dimitrie O. Paun Oct. 7, 2003

Oct. 7, 2003

On Tue, 7 Oct 2003 Warren_Baird(a)cimmetry.com wrote: Nit: why not use IsRectEmpty() ? -- Dimi.

1 0

Re: libs/unicode new conversions
by Alexandre Julliard Oct. 7, 2003

Oct. 7, 2003

Jon Griffiths <jon_p_griffiths(a)yahoo.com> writes: > This patch adds two new conversions to libs/unicode, in preparation > for their > use by an upcoming patch adding FoldStringA/W. The first converts > from any > unicode number into its unicode 0-9 representation. The second maps > from > compatibility characters to unicode. > > The rationale for placing them in libs/unicode is that both these > conversions > may be required by calls other than FoldString (at least the numeric > mapping > will be used to parse native language digits in oleaut32). IMO you should export the FoldString functionality from libs/unicode, not the tables. Also I'm not sure how you built the tables, but they need to be generated from the Unicode standard data, and the code to do that should be added to cpmap.pl. -- Alexandre Julliard julliard(a)winehq.com

2 2

cdrom problem? winefile crash
by Moreno Oct. 7, 2003

Oct. 7, 2003

Hi, fixme:cdrom:CDROM_GetInterfaceInfo CD-ROM device (11, 0) not supported what it mean? this is my cd is (11, 0) and then? brw-rw---- 1 moreno cdwriter 11, 0 gen 1 1970 /dev/scsi/host0/bus0/target0/lun0/cd i don't know if is for that but winefile crash!! fixme:cdrom:CDROM_GetInterfaceInfo CD-ROM device (11, 0) not supported err:dosfs:DRIVE_GetLabel Invalid or unreadable superblock on /dev/fd0 (A:). Invalid or unreadable superblock on /dev/fd0 (A:). Maybe not FAT? fixme:bitmap:CreateBitmap planes = 35 wine: Unhandled exception (thread 0009), starting debugger... fixme:cdrom:CDROM_GetInterfaceInfo CD-ROM device (11, 0) not supported WineDbg starting on pid 8 thx -- Moreno <morenoca(a)freemail.it>

2 1

Re: Oleaut32 3
by Dimitrie O. Paun Oct. 7, 2003

Oct. 7, 2003

On Mon, 6 Oct 2003, Jon Griffiths wrote: > Hi, > > Part 3 of oleaut32 updates. Hi Jon, Cool stuff, but I don't understand why we have all these forwards: +HRESULT WINAPI VarDecFromUI1(BYTE bIn, DECIMAL* pDecOut) +{ + return _VarDecFromUI1(bIn, pDecOut); +} We don't seem to pass any additional info to _VarDecFromUI1, why not simply get rid of it, and implement stuff in the real VarDecFromUI1? -- Dimi.

3 4