July 2007 - Wine-Devel - list.winehq.org

Re: [try4 3/3] gdi32: added PATH_PolyDraw
by Misha Koshelev July 4, 2007

July 4, 2007

> If either part of an if-else statement is compound, then fully-bracketed > syntax (as it is known) is considered good style by some (for example, see > the Indian Hill Style and Coding Standard): it may make problem detection > easier. > > -- > Andy. Ah, ok. Never mind about this stylistic comment then. Misha

1 0

CreateJobObject (kernel32) and friends
by Donald Gordon July 4, 2007

July 4, 2007

Hi I'm trying to get Visual C++'s vcbuild (builds project files from the command line) running under Wine, but it seems to need CreateJobObject (and I'm guessing the other job object functions), which doesn't appear to be implemented yet. Is implementing this something that would be doable by someone new to the Wine code? Or does someone have most of an implementation of this lying around uncommitted already? thanks donald

2 2

re: CreateJobObject (kernel32) and friends
by Dan Kegel July 4, 2007

July 4, 2007

don wrote: > I'm trying to get Visual C++'s vcbuild (builds > project files from the command line) running > under Wine, but it seems to need CreateJobObject Which version of Visual C++ is this?

3 3

Re: [PATCH] WINSPOOL.DRV: Choose first printer found as the default
by Detlef Riekenberg July 4, 2007

July 4, 2007

On Di, 2007-07-03 at 14:06 -0300, Pedro Araujo Chaves Jr. wrote: > # [PATCH] WINSPOOL.DRV: Choose first printer found as the default Why do you think, that you need this? Different default Printers (CUPS and Wine) confuse most Users. > -- By by ... Detlef

2 2

[try4 3/3] gdi32: added PATH_PolyDraw
by Misha Koshelev July 4, 2007

July 4, 2007

> + else if((types[i] & ~PT_CLOSEFIGURE) == PT_LINETO){ > + PATH_LineTo(dc, pts[i].x, pts[i].y); > + } > + if(!((i + 2 < cbPoints) && (types[i + 1] == PT_BEZIERTO) > + && ((types[i + 2] & ~PT_CLOSEFIGURE) == PT_BEZIERTO))){ > + goto err; > + } > + else{ > + goto err; > + } On a more stylistic note, any reason for all these single line if statements that have their contents enclosed in {}'s? (i.e., instead of: if (a) { call_b(); } why not just: if (a) call_b(); If anything, this adds one unnecessary line with the single } after the statement itself, and seems unnecessary to me. Misha

2 1

Re: [try4 3/3] gdi32: added PATH_PolyDraw
by Misha Koshelev July 4, 2007

July 4, 2007

> @@ -835,6 +835,10 @@ BOOL WINAPI PolyDraw(HDC hdc, const POIN > result = dc->funcs->pPolyDraw( dc->physDev, lppt, lpbTypes, cCount ); > goto end; > } > + if( PATH_IsPathOpen( dc->path ) ){ > + result = PATH_PolyDraw(dc, lppt, lpbTypes, cCount); > + goto end; > + } I believe the correct order here is: --- if( PATH_IsPathOpen( dc->path )) result = PATH_PolyDraw(dc, lppt, lpbTypes, cCount); else if (dc->funcs->pPolyDraw) result = dc->funcs->pPolyDraw( dc->physDev, lppt, lpbTypes, cCount ); else{ Non-path open case here result = TRUE; } end: GDI_ReleaseObj( hdc ); return result; --- The reason is that BeginPath either calls pBeginPath, in which case the gdi driver handles the path calls, or it sets path state to PATH_Open, which means we will be handling the path ourselves and we then do not call any of the gdi driver's pFunc functions while we are in the path (also if you look at most of the other functions in painting.c they are implemented in this way). Also, if you do the if ... else's like I showed above, you can avoid all the goto's except the ones in the non-path open case in case of failure. Misha

1 0

Re: [advapi32] Create a standard Wine list to keep track of the service handles
by Paul Vriens July 4, 2007

July 4, 2007

On 7/3/07, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > This patch makes sure we can check if a service handle is valid. With this patch > the tests I've sent previously will pass. If this one is accepted I'll resent > the corrected tests. > > Changelog > Create a standard Wine list to keep track of the service handles > > Cheers, > > Paul. > > > Hi, I'm assuming this patch was not up to standard. What do I need to change to get this thing on the road? Is it way to much overkill? Should I go a different path for these handle checks? Cheers, Paul.

1 0

dsound: Disable property sets if hardware doesn't support it
by Maarten Lankhorst July 4, 2007

July 4, 2007

2007/7/4, Robert Reif <reif(a)earthlink.net>: > This patch: > http://www.winehq.org/pipermail/wine-patches/2007-June/039942.html > causes RightMark3DSound.exe > (http://audio.rightmark.org/products/rm3ds.shtml) to crash. > > It appears that the code always expects a property set interface to > succeed and > crashes on a NULL pointer when it doesn't. > > Reverting this patch lets the program run. I'm trying to find wether it's a caps/flags issue or wether that patch is bad, not sure yet. I cant look today yet, but it seems that returning that is not entirely invalid, since testsuite for propset sort of allows it to fail, so perhaps it's something else. I'll try to take a look after I'm done with exams. Maarten

1 0

Re: secur32: Don't free the password in InitializeSecurityContextW to enable the credentials handle to be re-used in further InitializeSecurityContextW calls.
by Kai Blin July 4, 2007

July 4, 2007

Is that possible in Windows or is this a hack to work around a missing credentials cache? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

2 2

Re: ole32: Constify some variables (2 of 2) (Resend)
by Alexandre Julliard July 4, 2007

July 4, 2007

Andrew Talbot <Andrew.Talbot(a)talbotville.com> writes: > What is wrong with this patch, please? gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_OLE32_ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o storage32.o storage32.c storage32.c:3498: error: conflicting types for ‘StorageImpl_WriteBigBlock’ storage32.c:94: error: previous declaration of ‘StorageImpl_WriteBigBlock’ was here make[2]: *** [storage32.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0