July 2007 - Wine-Devel - list.winehq.org

WineHQ screenshots link
by Alexander Nicolaysen Sørnes July 2, 2007

July 2, 2007

Currently the Screenshots link on the WineHQ site points to a page with 9 screenshots and some links, while there are 3992 screenshots in the AppDB. Would anyone object to me changing the link to point to the AppDB instead? Alexander N. Sørnes

4 3

Re: [2/2] gdi32: fixed PolyDraw for open path case [try3]
by Alexandre Julliard July 2, 2007

July 2, 2007

"Evan Stade" <estade(a)gmail.com> writes: > @@ -838,6 +838,65 @@ BOOL WINAPI PolyDraw(HDC hdc, const POIN > } > GDI_ReleaseObj( hdc ); > > + if( PATH_IsPathOpen( dc->path ) ){ > + lastmove.x = orig_pos.x = dc->CursPosX; > + lastmove.y = orig_pos.y = dc->CursPosY; Accessing the DC after GDI_ReleaseObj is not allowed. The code was doing that already so it's not your bug, but it would be good to fix it while you're at it. Also like Misha said you should put the open path case in a separate path function. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [winex11.drv] text/plain is CF_TEXT
by Alexandre Julliard July 2, 2007

July 2, 2007

"Damjan Jovanovic" <damjan.jov(a)gmail.com> writes: > The text/plain MIME type is exactly the same as CF_TEXT - both have > \r\n line endings so calling X11DRV_XDND_UnixToDos is wrong. It would probably be better to make X11DRV_XDND_UnixToDos cope with both formats, that should be easy. -- Alexandre Julliard julliard(a)winehq.org

1 0

wine 0.9.39: Calysto v1.4 NULL dereference reports
by Domagoj Babic July 2, 2007

July 2, 2007

Hello, I finally found time to go through Calysto reports for wine. Here are the warnings related to applications. For libraries, since Calysto doesn't know the calling context, any parameter ptr dereference without checking is considered a bug. We can go over those warnings later if anyone is really interested. Here we go: --------------------------------------------------------------- wine 0.9.39: Calysto: ??/11 [Please replace ?? with the number of reports that require some corrective action, adding assertion is considered a corrective action. For every report, leave + if requires corrective action, replace with - if it's definitely false positive, and replace with ? if unknown. For false positives, please provide explanations. For ?, please ask what's unclear. If you discover new bugs that Calysto should have caught, please mention that as well.] *** Analyzing /work/benchmarks/BINARY/wine_v0.9.39/tools_fnt2bdf.bc *** Possible NULL-ptr deref (vc32): @/work/benchmarks/SOURCES/wine-0.9.39/tools/fnt2bdf.c:91 + main (fnt2bdf.c:548) calls return_data_value (@572), passing it a pointer to &(pTInfo->type_id), which return_data_value dereferences (@91). pTInfo aliases (lpdata+2), and lpdata was initialized with a call to get_resource_table (@561), which can set it to NULL (either if malloc (@534) returns NULL, or if it is set explicitly to NULL (@540)). *** Analyzing /work/benchmarks/BINARY/wine_v0.9.39/tools_makedep.bc *** Possible NULL-ptr deref (vc796): @/work/benchmarks/SOURCES/wine-0.9.39/tools/makedep.c:196 + Ptr p xmalloc-ed (makedep.c:187) dereferenced. Note that although xmalloc checks pointer (util.c:31), report(R_FATAL, "msg") does not exit, but only reports the msg and returns, so p (NULL) will be still dereferenced. *** Analyzing /work/benchmarks/BINARY/wine_v0.9.39/tools_sfnt2fnt.bc *** Possible NULL-ptr deref (vc47): @/work/benchmarks/SOURCES/wine-0.9.39/tools/sfnt2fnt.c:240 + malloc-ed ptr eblc dereferenced without checking Possible NULL-ptr deref (vc58): @/work/benchmarks/SOURCES/wine-0.9.39/tools/sfnt2fnt.c:321 + malloc-ed ptr dfCharTable dereferenced without checking Possible NULL-ptr deref (vc61): @/work/benchmarks/SOURCES/wine-0.9.39/tools/sfnt2fnt.c:338 + ptr os2, returned by function FT_Get_Sfnt_Table dereferenced without checking - I couldn't find the source of that function. *** Analyzing /work/benchmarks/BINARY/wine_v0.9.39/tools_winebuild_winebuild.bc *** Possible NULL-ptr deref (vc5400): @/work/benchmarks/SOURCES/wine-0.9.39/tools/winebuild/import.c:108 + seems that table->names can be NULL (or unitialized) at this line if the test @102 is false, and in the following call chain: main -> parse_options -> add_extra_ld_symbol -> add_name Possible NULL-ptr deref (vc5868): @/work/benchmarks/SOURCES/wine-0.9.39/tools/winebuild/import.c:362 + seems that ignore_symbols.names can be NULL if test @359 is true. *** Analyzing /work/benchmarks/BINARY/wine_v0.9.39/tools_winedump_winedump.bc *** Possible NULL-ptr deref (vc11598): @/work/benchmarks/SOURCES/wine-0.9.39/tools/winedump/main.c:334 + malloc-ed ptr buf dereferenced without checking Possible NULL-ptr deref (vc5636): @/work/benchmarks/SOURCES/wine-0.9.39/tools/winedump/debug.c:687 + malloc-ed ptr stabbuff dereferenced without checking *** Analyzing /work/benchmarks/BINARY/wine_v0.9.39/tools_winegcc_winegcc.bc *** Possible NULL-ptr deref (vc978): @/work/benchmarks/SOURCES/wine-0.9.39/tools/winegcc/winegcc.c:467 + ptr output_file, returned from strdup, dereferenced without checking. strdup can return NULL. Possible NULL-ptr deref (vc1013): @/work/benchmarks/SOURCES/wine-0.9.39/tools/winegcc/utils.c:118 + starray_dup (utils.c:136) initializes dup with strarray_alloc(). strarray_alloc also sets dup->base to NULL. Then strarray_dup calls strarray_add (@142), passing it a pointer to dup. If the test in strarray_add (@113) fails, the function dereferences dup->base directly. --------------------------------------------------------------- Feedback will be appreciated. I can't do another round of checking before Aug 1, as I'm travelling. At that point Calysto will have more knowledge about clib functions, hopefully resulting in more bugs being reported. Regards, -- Domagoj Babic http://www.domagoj.info/ http://www.calysto.org/

4 7

Re: ws2_32: Dont tell users to run Wine as root when sockets not creatable
by Kai Blin July 1, 2007

July 1, 2007

On Saturday 30 June 2007 01:48:06 Ben Hodgetts (Enverex) wrote: > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index 90fa9b0..5984790 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_32/socket.c > @@ -3767,9 +3767,11 @@ SOCKET WINAPI WSASocketW(int af, int type, int > protocol, > if (GetLastError() == WSAEACCES) /* raw socket denied */ > { > if (type == SOCK_RAW) > - MESSAGE("WARNING: Trying to create a socket of type > SOCK_RAW, will fail unless running as root\n"); Your mail client mangled the long lines. Please make sure to actually attach the patch before sending. git-format-patch does that when given the --attach parameter. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

2 2

Re: [PATCH] check for overflow of the textures areas.
by H. Verbeet July 1, 2007

July 1, 2007

Native D3D actually seems to allow this, and just corrupts the memory. If we're going to do these checks, we should simply return WINED3D_OK, and possibly print a TRACE or WARN. (See eg. IWineD3DDeviceImpl_SetTextureStageState).

1 0

Re: mshtml: Implement HTMLDocument_QueryInterface for IHTMLDOMNode, IHTMLElement and IHTMLElement2.
by Jacek Caban July 1, 2007

July 1, 2007

Hi, I've just sent a test showing that native doesn't implement these interfaces so we shouldn't either. It's strange because IDL declaration says something else. And BTW. your patch violates COM QueryInterface rules (not that MS always respects these rules...). Thanks, Jacek

2 4