July 2007 - Wine-Devel - list.winehq.org

[advapi32] Create a standard Wine list for the service handles
by Paul Vriens July 3, 2007

July 3, 2007

Hi, I've attached a possible solution for checking the validity of the service handle before using it. Can somebody please comment on this? Do I need to protect the list with a CriticalSection? Is this overkill? Cheers, Paul.

2 2

Parallels Wine dlls rebuilt with mingw for your testing
by Steven Edwards July 3, 2007

July 3, 2007

Hi, I expect if any ofyou are interested you've already talked to Stefan about the code drop from Parallels he is reviewing. I did a build of the drop with Mingw and was able to build everything except ddraw.dll. If anyone is interested in the binary and makefiles, I've forwarded the information on to Stefan with directions on how to build and a rather hackish patch. He said he would post the mingw package sometime later today. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

3 2

request to change appdb message
by Louis. Lenders July 3, 2007

July 3, 2007

Hi, since a few weeks the following message is displayed when you try to submit test results into appdb: Please DO NOT include crash or Wine debug output. Instead report the crash as a bug in the Wine bugzilla at http://bugs.winehq.org. We ask that you use bugzilla because developers do not monitor the AppDB for bugs. I'm not that happy with this message for a few reasons: 1. Most testers will not attach this to a bug, either because there isn't an entry for the app in bugzilla, or they don't bother to do so. 2. There are crashes like these that users attach: wine app.exe err:module:import_dll Library MSVBVM60.DLL (which is needed by L"C:\\app.exe") not found err:module:LdrInitializeThunk Main exe initialization for L"C:\\app.exe" failed, status c0000135 We don't want users to attach these things in bugzilla, we'd rather point them what to do in the email-field. If users don't attach crashes anymore to the testresults , i cannot by no means see anymore if a testresult is valid or not. I'd rather see something like: Please DO include crash or Wine debug output here, and report the crash as a bug in the Wine bugzilla at http://bugs.winehq.org. Any comments? --------------------------------- Yahoo! Answers - Get better answers from someone who knows. Tryit now.

6 12

ole32: Parameter question
by Andrew Talbot July 2, 2007

July 2, 2007

Hi, In ole32/ifs.c:RemoveMemoryLocation(), should the parameter be a LPVOID *, or should it be just a LPVOID (or LPCVOID, to be more precise)? I want to constify it, but I'm uncertain if its current depth of indirection is correct. Thanks, -- Andy.

2 1

Re: oleaut32: Constify some variables
by Robert Shearman July 2, 2007

July 2, 2007

Andrew Talbot wrote: > -static OLEFontImpl* OLEFontImpl_Construct(LPFONTDESC fontDesc); > +static OLEFontImpl* OLEFontImpl_Construct(const FONTDESC *fontDesc); > static void OLEFontImpl_Destroy(OLEFontImpl* fontDesc); > static ULONG WINAPI OLEFontImpl_AddRef(IFont* iface); Even if the compiler allows this, it does not make sense. Why would a constructor not want to modify the object it is constructing? -- Rob Shearman

1 0

Re: [4/5] WineD3D: Offscreen rendering from foreign threads
by Stefan Dösinger July 2, 2007

July 2, 2007

Am Montag, 2. Juli 2007 17:46 schrieb Stefan Dösinger: Do not apply this patch yet, it has some problems. Patch 5 should still apply though

1 0

Crosscompile failures for gdiplus
by Paul Vriens July 2, 2007

July 2, 2007

Hi, Ever since gdiplus tests (roughly 2 weeks ago) got added to Wine we have crosscompile failures: i386-mingw32-gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -Wcast-qual -o brush.cross.o brush.c brush.c:1: warning: -fPIC ignored for target (all code is position independent) i386-mingw32-gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -Wcast-qual -o pen.cross.o pen.c pen.c:1: warning: -fPIC ignored for target (all code is position independent) ../../../tools/make_ctests -o testlist.c brush.c pen.c i386-mingw32-gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -Wcast-qual -o testlist.cross.o testlist.c testlist.c:1: warning: -fPIC ignored for target (all code is position independent) i386-mingw32-gcc brush.cross.o pen.cross.o testlist.cross.o -o gdiplus_crosstest.exe -lgdiplus -lkernel32 /usr/local/lib/gcc/i386-mingw32/3.4.5/../../../../i386-mingw32/bin/ld: cannot find -lgdiplus collect2: ld returned 1 exit status make: *** [gdiplus_crosstest.exe] Error 1 Does anybody feel up to fixing MingW so we will have a new winetest executable soon? No new one since June 12 on http://www.astro.gla.ac.uk/users/paulm/WRT/CrossBuilt/ . Cheers, Paul.

3 2

Re: msi [6/10]: pcchValue represents the length of szValue in TCHARS, not bytes
by Alexandre Julliard July 2, 2007

July 2, 2007

"James Hawkins" <truiken(a)gmail.com> writes: > @@ -341,10 +341,15 @@ UINT WINAPI MsiSourceListGetInfoW( LPCWS > } > else if (strcmpW(INSTALLPROPERTY_PACKAGENAMEW, szProperty)==0) > { > + *pcchValue = *pcchValue * sizeof(WCHAR); > rc = RegQueryValueExW(sourcekey, INSTALLPROPERTY_PACKAGENAMEW, 0, 0, > - (LPBYTE)szValue, pcchValue); > + (LPBYTE)szValue, pcchValue); > if (rc != ERROR_SUCCESS && rc != ERROR_MORE_DATA) > rc = ERROR_SUCCESS; > + if (*pcchValue) > + *pcchValue = (*pcchValue - 1) / sizeof(WCHAR); > + if (szValue) > + szValue[*pcchValue] = '\0'; You shouldn't use the results if the registry function failed. Also there isn't much point in checking pcchValue for NULL since you accessed it already. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/5] WineD3D: rsq and rcp use the .w component if no swizzle is given
by Alexandre Julliard July 2, 2007

July 2, 2007

Stefan Dösinger <stefan(a)codeweavers.com> writes: > Updates the comment why the shader comment is needed - tests showed that the > shaders have to have a minimal size on windows. If the comment is only needed for size then you could use some padding instead of the actual string. If the string is needed then you should declare it as a string and copy it, not as an array of DWORDs, that will be a pain to maintain or grep. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [advapi32/tests #2] Add tests for OpenServiceA
by James Hawkins July 2, 2007

July 2, 2007

On 7/2/07, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > I've added some tests for OpenServiceA. Some of them crash on Wine, but I've > opted to let them in (inside an if(0) though). The crashes happen because we > assume that when a handle is not NULL it's correct. > The policy for crashing tests is that you need to fix the bug that causes the tests to crash either before you send in the test patch or in the same patch as the tests. if(0) is only for tests that crash on Windows. -- James Hawkins

2 1