August 2007 - Wine-Devel - list.winehq.org

[Winetest] Status update (rsabase and secur32)
by Paul Vriens Aug. 8, 2007

Aug. 8, 2007

Hi, The new winetest is running fine and new reports are produced (http://test.winehq.org/data/200708071000/) I have seen at least 2 things so far that I need some info on. rsabase.dll is not available on for example w2k3 and vista but the tests ran in the past. secur32.dll is not available on for example NT4 but the current tests check if security.dll is available instead. What should we do to cater for the above: - we could move for example rsabase tests to rsaenh (we forward everything to rsaenh as well) and something similar for secur32. - we could implement an exception list in winetest for these particular cases. Remarks/Comments? Cheers, Paul.

3 3

Missing library - faultrep.
by Peter Dons Tychsen Aug. 7, 2007

Aug. 7, 2007

Hello. Wine is missing the library "faultrep". The library comes with Windows, and is used by apps for error reporting. Most apps don't really need it (unless something goes wrong), but simply require the DLL to be present. To start with i just wanted to add the DLL to Wine. I tried to submit a patch for this missing lib, but got zero response. Probably because there was something wrong with my commit. Any guess on what was wrong? /Pedro

2 4

Patch: VarWeekdayName
by Jiří Paleček Aug. 7, 2007

Aug. 7, 2007

Hello, I want to ask, is anything wrong with this patch? http://www.winehq.org/pipermail/wine-patches/2007-July/041434.html I'm asking because I have other patches, but don't know if it is worthwhile to send them. Regards Jiri Palecek

8 21

Re: [winecfg] Show version again in About box
by Dmitry Timoshkov Aug. 7, 2007

Aug. 7, 2007

"Paul Vriens" <paul.vriens.wine(a)gmail.com> wrote: > 'Wine 0.9.42' looks so much nicer than 'PACKAGE_STRING'. Thanks for catching this. Although a comment explaining why config.h is needed while there is no visible usage of #ifdef HAVE_xxx macros would be nice. -- Dmitry.

1 0

Re: [2/6] gdiplus: added GdipCreateBitmapFromFile
by Alexandre Julliard Aug. 7, 2007

Aug. 7, 2007

"Evan Stade" <estade(a)gmail.com> writes: > + CloseHandle(file); > + > + if(CreateStreamOnHGlobal(buff, TRUE, &stream) != S_OK){ > + ERR("could not make stream\n"); > + GdipFree(buff); > + return GenericError; > + } You should create a stream on the file directly instead of reading it in first. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/6] gdiplus: added GdipBitmapLockBits/GdipBitmapUnlockBits
by Alexandre Julliard Aug. 7, 2007

Aug. 7, 2007

"Evan Stade" <estade(a)gmail.com> writes: > + bm_is_selected = (BOOL) hdc; That's ugly, you should use something like (hdc != 0) instead. > + stride = bmi.bmiHeader.biWidth * bitspp / 8; > + stride += stride % 4; This doesn't do what you want. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: #1 winhttp: Forward WinHttpTime{From, To}SystemTime to their counterparts in wininet.
by Robert Shearman Aug. 7, 2007

Aug. 7, 2007

Hans Leidekker wrote: > Forward WinHttpTime{From, To}SystemTime to their counterparts in wininet. > We shouldn't be implementing winhttp on top of wininet as there are functions such as WinHttpSetCredentials (http://msdn2.microsoft.com/en-us/library/Aa384112.aspx) that can't be implemented on top of wininet functions. There are also issues with different error codes being returned as well as different callbacks (http://msdn2.microsoft.com/en-us/library/aa383917.aspx) -- Rob Shearman

5 7

FW: [Bug 2520] menu bar problem
by Ann & Jason Edmeades Aug. 6, 2007

Aug. 6, 2007

>Vitaliy >Jason, please don't forget to cc wine-bugs when you reassign the bug. Yeah, sorry... Its late here :-) Out of interest, why don't we fix bugzilla to always enforce that userid (ie if it gets removed, it automatically gets inserted back). I'm sure I'm not the only one who forgets to do it sometimes? Jason

1 0

Re: [WINE] WIDL regression between 0.9.38 and 0.9.39
by Dan Hipschman Aug. 6, 2007

Aug. 6, 2007

On Mon, Aug 06, 2007 at 04:24:39PM +0200, Herv? Poussineau wrote: > Hi Dan, > > I'm using Wine IDL compiler to compile some .idl files, and I found a > regression in WIDL between 0.9.38 and 0.9.39. > As you are the one who mostly changed WIDL between these releases, I'm > sending you this email ;) > > My .idl file looks like this one: > > [ > uuid (00112233-4455-6677-8899-AABBCCDDEEFF), > version(1.0), > pointer_default(unique) > #ifndef __midl > ,explicit_handle > #endif > ] > interface MyInterface > { > unsigned long GetRoot(handle_t BindingHandle, > [out, string, size_is(Length)] wchar_t > *RootString, > [in] unsigned long Length); > } > > Of course, Microsoft MIDL accepts to compile this file, so WIDL should too. > WIDL 0.9.38 was working, but WIDL 0.9.39 gives the following error: > error: write_string_tfs: Unimplemented for type 0x1b of name: RootString > > Type 0x1b is RPC_FC_CARRAY, but write_string_tfs function only supports > RPC_FC_BYTE, RPC_FC_CHAR and RPC_FC_WCHAR. > > Any idea how to fix it, or am I forced to keep WIDL 0.9.38? > > Thanks in advance, > > Hervé Hi Hervé. Thanks for the bug report. The code related to this problem was being worked on quite a bit recently, so I don't doubt there may be a regression. I may be a bit slow to look at this since I'm in the middle of working on something else at the moment, hence I'm CC-ing the list so other people can see that the problem exists. Dan

1 0

Re: [PATCH] msi: correct buffer overrun in msi_get_deferred_action().
by James Hawkins Aug. 6, 2007

Aug. 6, 2007

On 8/5/07, William Waghorn <willw(a)litany.me.uk> wrote: > --- > dlls/msi/custom.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/msi/custom.c b/dlls/msi/custom.c > index 390113e..17f581c 100644 > --- a/dlls/msi/custom.c > +++ b/dlls/msi/custom.c > @@ -153,7 +153,7 @@ static LPWSTR msi_get_deferred_action(LPCWSTR > action, LPCWSTR actiondata, > return strdupW(action); > > len = lstrlenW(action) + lstrlenW(actiondata) + > - lstrlenW(usersid) + lstrlenW(prodcode) + 5; > + lstrlenW(usersid) + lstrlenW(prodcode) + 9; > deferred = msi_alloc(len * sizeof(WCHAR)); > > sprintfW(deferred, format, actiondata, usersid, prodcode, action); > This has been properly fixed in git. -- James Hawkins

1 0