August 2007 - Wine-Devel - list.winehq.org

Sent a patch twice
by Rene Kok Aug. 4, 2007

Aug. 4, 2007

I never submitted a patch before. It wasn't a patch I created just resubmitting it. However I accidentally sent it to the wine-patches mailing list twice. The first time I wasn't subscribed, which I prefer not to because the huge amount of mail I'll get when I do :-) I subscribed and sent it again and now it's in there twice, oops! Anyway hope it's ok.

2 1

Re: mshtml: Remove const in front of REFIID as that is a macro that already starts with const.
by Andrew Talbot Aug. 4, 2007

Aug. 4, 2007

Michael Stefaniuc wrote: > Jacek, > > I'm not sure about this patch. gcc 3.1.1 produced a warning about a > double const. The rules of what is const depending on where in the > declaration it is placed are mind bongling (especially at 1am) and I > don't know what the intention was here so please review. > > -static const REFIID tid_ids[] = { > +static REFIID tid_ids[] = { > &IID_IHTMLWindow2 > }; > It would be easier if one were obliged to always put const (and volatile) qualifiers to the right of what they qualify, then the whole declaration would read from right to left. Thus, here, char const * const *p; p is a pointer to a constant pointer to a constant char. The almost-universally adopted convention of putting the left-most qualifer on the left of the type it qualifies, as in const char *ch; rather than the equivalent char const *ch; rather spoils this flow. Here, static const REFIID tid_ids[]; could be rewritten static REFIID const tid_ids[]; And REFIID in a C setting is defined as: const GUID * __MIDL_CONST (where __MIDL_CONST is "const", if rpcproxy.h has not been included). So, in case anyone is still awake and interested: static const REFIID tid_ids[]; is equivalent to static const GUID *const const tid_ids[]; (Note the erroneous double const.) or static GUID const *const const tid_ids[]; as I would prefer to put it. So, to conclude, you don't want the extra const, and it may not have been the const you thought it was, either. :) -- Andy.

1 1

Bug introduced in 0.9.42 in printer dialog
by Christian Pradelli Aug. 4, 2007

Aug. 4, 2007

A bug was introduced in version 0.9.42, that makes printer dialogs to not work. When you press Accept button in the printer dialog the I receive the followin error: fixme:commdlg:PRINTDLG_UpdatePrintDlgA No lpdm ptr? fixme:commdlg:PRINTDLG_WMCommandA Update printdlg was not successful! Should I post to bugzilla? Regards Christian c_pradelli(a)yahoo.com

2 1

Re: [PATCH] wined3d: Pass correct coord parameter to texture*DProj functions
by H. Verbeet Aug. 4, 2007

Aug. 4, 2007

On 04/08/07, Vitaly Budovski <vbudovski(a)gmail.com> wrote: > --- > dlls/wined3d/glsl_shader.c | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) > This patch is plain wrong. The caller of shader_glsl_get_sample_function() is responsible for correctly adding the correct component for projected lookups, since that isn't always the "next" component, but in fact depends on the instruction that does the sampling. Of course if the author of this patch had actually read the source for the callers of shader_glsl_get_sample_function() (pshader_glsl_tex() in particular...) or alternatively had been familiar with D3D shader assembly, he would have known that. It does make me wonder though, particularly given the lack of any explanation for the patch, if this is actually supposed to fix anything?

1 0

Re: netapi32: Add lmuseflg.h and include it from lmuse.h.
by Kai Blin Aug. 4, 2007

Aug. 4, 2007

On Saturday 04 August 2007 03:20:00 Francois Gouget wrote: > +/* > + * Copyright (C) the Wine project I think you need a year in the copyright statement. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: Nigel Liang : winecfg: Read/write registry in unicode.
by James Hawkins Aug. 4, 2007

Aug. 4, 2007

On 8/3/07, Alexandre Julliard <julliard(a)wine.codeweavers.com> wrote: > Module: wine > Branch: master > Commit: 2d5a89bab087d09f3e3876e29ae32a2e863273fe > URL: http://source.winehq.org/git/wine.git/?a=commit;h=2d5a89bab087d09f3e3876e29… > > Author: Nigel Liang <ncliang(a)gmail.com> > Date: Thu Aug 2 16:33:24 2007 -0700 > > winecfg: Read/write registry in unicode. > This patch breaks setting the windows version in winecfg (and I assume everything else that uses the registry): jhawkins(a)sphere2:~$ winecfg wine: Unhandled page fault on read access to 0x00000000 at address 0x7e5859d7 (thread 0010), starting debugger... Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x7e5859d7). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7e5859d7 ESP:0033e2f0 EBP:0033e328 EFLAGS:00010246( - 00 -RIZP1) EAX:00000000 EBX:7e58d9e4 ECX:ffffffff EDX:00000000 ESI:7e587b60 EDI:00000000 Stack dump: 0x0033e2f0: 00110000 00000000 0000001c 0000000b 0x0033e300: 0016cdf8 0000000b 00000054 001727f8 0x0033e310: 0000001c 00172858 0016cdf8 7e58d9e4 0x0033e320: 7e587b60 7e587ac2 0033efd8 7e578877 0x0033e330: 80000002 7e587b60 7e587ab4 00000000 0x0033e340: 00000001 00000073 0033e398 7e1d19a7 Backtrace: =>1 0x7e5859d7 set_reg_key+0x8f(root=0x80000002, path=0x7e587b60, name=0x7e587ab4, value=0x0) [/home/jhawkins/wine/programs/winecfg/winecfg.c:471] in winecfg (0x0033e328) -- James Hawkins

2 1

Re: gdi32: don't print fixme more than once
by Robert Shearman Aug. 3, 2007

Aug. 3, 2007

Evan Stade wrote: > diff --git a/dlls/gdi32/enhmetafile.c b/dlls/gdi32/enhmetafile.c > index 9e7684b..2b4d03f 100644 > --- a/dlls/gdi32/enhmetafile.c > +++ b/dlls/gdi32/enhmetafile.c > @@ -1172,6 +1172,7 @@ BOOL WINAPI PlayEnhMetaFileRecord( > > case EMR_EXTSELECTCLIPRGN: > { > + static int extselectcliprgn_cases; > #if 0 > const EMREXTSELECTCLIPRGN lpRgn = (const EMREXTSELECTCLIPRGN *)mr; > HRGN hRgn = ExtCreateRegion(NULL, lpRgn->cbRgnData, (RGNDATA *)lpRgn->RgnData); > @@ -1180,7 +1181,8 @@ #if 0 > /* ExtSelectClipRgn created a copy of the region */ > DeleteObject(hRgn); > #endif > - FIXME("ExtSelectClipRgn\n"); > + if(!(extselectcliprgn_cases++)) > + FIXME("ExtSelectClipRgn\n"); > break; > } > It would be better to re-enable this code, remove the fixme and fix whatever bug caused it to be disabled in the first place than to not show the fixme as often. -- Rob Shearman

1 0

Re: [4/5] WineD3D: WINED3DSAMP_MAXMIPLEVEL fixes
by H. Verbeet Aug. 3, 2007

Aug. 3, 2007

You are now executing that code multiple times.

2 1

Re: Lostwages : contributing.diff
by Jeremy White Aug. 3, 2007

Aug. 3, 2007

Hi Tom, Thanks for thinking of this; I think James would appreciate it if he wasn't listed by name, though. Otherwise, though, it looks great. Cheers, Jeremy Tom Wickline wrote: > Hello, > > I'm CC: Jeremy White in on this patch, if possible I would like to ask > for his approval on the patch before its committed. > > About the patch: > I Changed the mailing address of the WPF to point to the Software > Freedom Conservancy, and added some info about it being a 501(c)(3) > organization. > > Cheers, > > Tom > > Changelog: update WPF information and mailing address > > > ------------------------------------------------------------------------ > > Index: en/contributing.template > =================================================================== > RCS file: /home/wine/lostwages/templates/en/contributing.template,v > retrieving revision 1.33 > diff -u -r1.33 contributing.template > --- en/contributing.template 21 Jun 2007 20:21:46 -0000 1.33 > +++ en/contributing.template 31 Jul 2007 02:55:13 -0000 > @@ -363,8 +363,17 @@ > <h3 id="wpf">Wine Party Fund</h3> > > <p>The purpose of the Wine Party Fund is to show appreciation to Wine > - developers by collecting funds for developer meetings, such as future Wine > - Conferences, or in some cases to purchase documentation.</p> > +developers by collecting funds for developer meetings, such as future > +Wine Conferences, or in some cases to purchase documentation.</p> > + > +<p>The organization that currently manages our donations is the > +<a href="http://conservancy.softwarefreedom.org/">Software Freedom > +Conservancy</a>. If you have any questions or are otherwise in need > +of further assistance please visit the SFC site.</p> > + > +<p>The Software Freedom Conservancy is a 501(c)(3) organization, and > +donations made through it are fully tax-deductible to the extent > +permitted by law.</p> > <p><strong>Ways to contribute:</strong></p> > <form action="https://www.paypal.com/cgi-bin/webscr" method="post"> > <div> > @@ -379,13 +388,12 @@ > <p>We also have a SourceForge PayPal account > <a href="http://sourceforge.net/donate/index.php?group_id=6241">sourceforge.net</a></p> > > -<p>You can also send cash, checks or international money order in US funds to:</p> > -<address>The Wine Party Fund > -c/o Jeremy White > -CodeWeavers > -2356 University Ave. West > -Suite 420 > -St. Paul, MN 55114</address> > +<p>You can also send cash, cheque or international money order in US funds to:</p> > +<address>Wine Project > +c/o James Vasille > +Software Freedom Conservancy > +1995 Broadway FL 17 > +New York, NY 10023-5882</address> > <p>Purchase books or music from <a href="http://www.amazon.com/exec/obidos/redirect-home/winehq"> > Amazon.com</a> or <a href="http://www.cdnow.com/from=sr-1093221">CDnow</a> (Use > these specific links only, so that the Wine Party Fund gets the credit.)</p>

1 0

[Fwd: [winetest] New gather script]
by Paul Vriens Aug. 3, 2007

Aug. 3, 2007

Hi, Forgot to include wine-devel. -------- Original Message -------- Subject: [winetest] New gather script Hi Ferenc, Could you have a look at the new 'gather' script? (you're the original author after all). The new winetest (when committed of course) executable will report when a test is missing because of a failing dll. I've severely changed/mutilated 'gather' so: - it finds these missing dll tests and marks them - doesn't add these to the overall list of tests - goes through the whole list of tests to find out if (and why) tests are missing - it now shows also complete failing tests (for the group) in the group overview - add some extra onMouseOver on both group and single tests. - make sure we always show missing tests in the group overview. The new variables: $test->{dllmissing}->{$dll} (shows if a system/test is missing a dll) $group->{dllmissing}->{$unit} (tells if at least one system in the group is missing this dll, used for having a nice onMouseOver in the Main Summary) $group->{testmissing}->{$testname} (tells if at least one system in the group has a missing test for an unknown reason, needed to cope with the same onMouseOver as mentioned above). I'll split it up in smaller chunks when sent to wine-patches. Cheers, Paul. Index: gather =================================================================== RCS file: /home/wine/tools/winetest/gather,v retrieving revision 1.20 diff -u -r1.20 gather --- gather 13 Mar 2007 16:10:46 -0000 1.20 +++ gather 3 Aug 2007 07:28:36 -0000 @@ -96,9 +96,19 @@ my ($digest, $unit, $test, $count, $todo, $error, $skipped, $source, $rev) = split; my $testname = "$unit:$test"; + if ($test =~ /_dll_missing/) { + # Mark this dll as being missing on one or more systems + + # For this run on this system + $testref->{dllmissing}->{$unit} = "This dll is missing on this system"; + # For the whole group + $group->{dllmissing}->{$unit} = "This dll is missing for some tests"; + } + else { + $alltests{$testname} = "http://cvs.winehq.org/cvsweb/wine/$source" . ($rev ne "-"?"#rev$rev":"") + unless exists $alltests{$testname}; + } $testref->{results}->{$testname} = [$count, $todo, $error, $skipped]; - $alltests{$testname} = "http://cvs.winehq.org/cvsweb/wine/$source" . ($rev ne "-"?"#rev$rev":"") - unless exists $alltests{$testname}; if ($count ne "failed") { if (defined $group->{extrema}->{$testname}) { my $extrema = $group->{extrema}->{$testname}; @@ -117,6 +127,28 @@ push @{$group->{tests}}, $testref; } +# Find missing tests and/or missing dlls and mark them +foreach my $group (@groups) { + next unless exists $group->{tests}; + foreach my $testname (sort keys %alltests) { + foreach my $test (@{$group->{tests}}) { + if (!exists $test->{results}->{$testname}) { + # The test is missing, try to find the reason + my ($dll,$subtest) = split(/:/, $testname); + if (exists $test->{dllmissing}->{$dll}) { + $test->{results}->{$testname} = [-1, -1, -1, -1]; + $group->{digest}->{$testname} = "differ"; + } + else { + $test->{results}->{$testname} = [-2, -2, -2, -2]; + $group->{digests}->{$testname} = "differ"; + $group->{testmissing}->{$testname} = $testname; + } + } + } + } +} + # Write out the tables my ($header); # same in thead and tfoot @@ -197,28 +229,42 @@ # Output a single cell of a test sub singletest { my ($test, $testname, $groupname) = @_; - - if (!exists $test->{results}->{$testname}) { - print OUT " <td class=\"note\">.</td>\n"; + my $file = "$test->{dir}/$testname.txt"; + my ($count, $todo, $error, $skipped) = @{$test->{results}->{$testname}}; + if ($count eq "failed") { + # test run failed + my $msg = $todo eq "-"?"crash": + $todo == 258?"timeout":"failed"; + my $fail = -r "$datadir/$build/$file"?"<a href=\"$file\">$msg</a>":$msg; + print OUT " <td class=\"note\">$fail</td>\n"; + } elsif ($count == -1) { + # dll missing + my ($dll, $subtest) = split(/:/, $testname); + print OUT <<"EOF"; + <td class="skip_pass"><a + title="No tests run as $dll.dll is not present on this system" + onMouseOver="No tests run as $dll.dll is not present on this system" + >0</a></td> +EOF + } elsif ($count == -2) { + # test missing + print OUT <<"EOF"; + <td class="skip_fail"><a + title="No tests run for an unknown reason" + onMouseOver="No tests run for an unknown reason" + >0</a></td> +EOF } else { - my $file = "$test->{dir}/$testname.txt"; - my ($count, $todo, $error, $skipped) = @{$test->{results}->{$testname}}; - if ($count eq "failed") { - my $msg = $todo eq "-"?"crash": - $todo == 258?"timeout":"failed"; - my $fail = -r "$datadir/$build/$file"?"<a href=\"$file\">$msg</a>":$msg; - print OUT " <td class=\"note\">$fail</td>\n"; - } else { - my $class = $error?"fail":"pass"; - my $skip = $skipped?"skip_":""; - print OUT <<"EOF"; + # test has run + my $class = $error?"fail":"pass"; + my $skip = $skipped?"skip_":""; + print OUT <<"EOF"; <td class="$skip$class"><a href="$file" title="$count tests, $todo TODO, $error errors, $skipped skipped" onMouseOver="refresh('$testname','$groupname $test->{tag}',$count,$todo,$error,$skipped);" >$error</a></td> EOF - } } } @@ -236,6 +282,7 @@ } else { my $href = "href=\"#$group->{name}\""; if (exists $group->{extrema}->{$testname}) { + # At least one system in this group has run this test. my ($min,$max) = @{$group->{extrema}->{$testname}}; my $class = $min==0?($max==0?"pass":"mixed"):"fail"; my $title = $min==0?"":" title=\"Best: $min\""; @@ -246,7 +293,23 @@ >$max</a></td> EOF } else { - print OUT " <td class=\"note\"><a $href>.</a></td>\n"; + my ($dll, $subtest) = split(/:/, $testname); + if ($group->{testmissing}->{$testname}) { + # At least one system in the group has a missing test (but + # not because of a missing dll). + print OUT " <td class=\"fail\"><a $href>.</a></td>\n"; + } elsif (exists $group->{dllmissing}->{$dll}) { + # All systems in the group have a missing dll related to this test. + print OUT <<"EOF"; + <td class="pass"><a $href + title="No tests run as $dll.dll is not present on all $group->{name} systems" + onMouseOver="No tests run as $dll.dll is not present on all $group->{name} systems" + >0</a></td> +EOF + } else { + # All systems in this group failed to correctly run the test. + print OUT " <td class=\"fail\"><a $href>.</a></td>\n"; + } } } }

1 0