August 2007 - Wine-Devel - list.winehq.org

msvcrt40.dll
by luis.busquets＠ilidium.com Aug. 3, 2007

Aug. 3, 2007

Dear all, In relation to the file msvcrt40.dll File Version 5.1.2600.2180 Product Version 5.1.2600.2180 This file has been transformed and forwards all of its calls to either msvcrt.dll or msvcirt.dll The forwards to msvcrt.dll are set in the current wine msvcr40.spec but the rest of the functions, which should be forwarded to msvcirt, are stub. Nevertheless, msvcirt.dll is not currently one of the files to be ported, i.e., dlls/msvcirt does not exist. My questions are: 1. Can we add the forward to all the rest of the functions in the msvcrt40.dll spec file to msvcirt.dll? 2. Should we first add a wine port of msvcirt.dll? Luis

2 1

[PATCH 2/5] urlmon: Use BSCF_ values passed to report_data to keep track of download state.
by Misha Koshelev Aug. 2, 2007

Aug. 2, 2007

> Hi Misha, > > Misha Koshelev wrote: > > This simplifies the code a bit by getting rid of an enum and a corresponding variable in the IBinding > > implementation, as we can successfully use the bscf values that are passed to report_data to get all > > the information. > > > > Additionally, the original implementation was somewhat incorrect at least for the case of the Http protocol > > as far as sending OnStopBinding > > This patch is already accepted, but unfortunately it's wrong. Tests > changed in the attached patch succeed on native urlmon.dll and fail on > current Wine. Probably only BSCF_LASTDATANOTIFICATION flag should be > used. Other OnProgress callbacks should be called depending on the real > binding state, not the one reported by protocol handler. > > Jacek >

1 0

Re: wine3d3: Check the destination recangle when for FastBlt().
by Stefan Dösinger Aug. 2, 2007

Aug. 2, 2007

Am Sonntag, 29. Juli 2007 21:28 schrieb Peter Dons Tychsen: > Hello Wine! > > I have fixed a small bug in FastBlt(), which caused Wine to crash if the > application tried to do FastBlt() to a surface using a bad destination > setup. The problem is already fixed in normal Blt(), but was broken for > FastBlt(). > > This fixes a crash for the little game "Treasure Mole Winter Vacations": This check should be in ddraw, not wined3d. ddraw, d3d8 and d3d9 have different ideas about such checks, that's why the check was moved from WineD3D to the client libs. Originally it was in LockRect, and when it was moved the check was lost in Blt and BltFast. There should be a check in ddraw already, maybe it is not sufficient. Also please write a test case to verify that the fix is correct(look at dlls/ddraw/tests/dsurface.c). This will also prevent the problem from coming back. Treasure Mole broke after the ddraw rewrite because exactly this check was missing. I implemented it in LockRect, like in old ddraw, but I forgot to write a test for BltFast. Then a d3d9 game was broken because d3d9 LockRect behaved differently, a test was written for Lock(Rect) in ddraw, d3d8 and d3d9, and the range check moved to ddraw, d3d8 and d3d9 to be able to implement different checking in each version. Since I forgot to write a test when I originally fixed Treasure Mole the bug could creep back in again :-(

2 4

Re: [PATCH 2/5] urlmon: Use BSCF_ values passed to report_data to keep track of download state.
by Jacek Caban Aug. 2, 2007

Aug. 2, 2007

Hi Misha, Misha Koshelev wrote: > This simplifies the code a bit by getting rid of an enum and a corresponding variable in the IBinding > implementation, as we can successfully use the bscf values that are passed to report_data to get all > the information. > > Additionally, the original implementation was somewhat incorrect at least for the case of the Http protocol > as far as sending OnStopBinding This patch is already accepted, but unfortunately it's wrong. Tests changed in the attached patch succeed on native urlmon.dll and fail on current Wine. Probably only BSCF_LASTDATANOTIFICATION flag should be used. Other OnProgress callbacks should be called depending on the real binding state, not the one reported by protocol handler. Jacek diff --git a/dlls/urlmon/tests/url.c b/dlls/urlmon/tests/url.c index 187fb03..dcae846 100644 --- a/dlls/urlmon/tests/url.c +++ b/dlls/urlmon/tests/url.c @@ -255,6 +255,7 @@ static HRESULT WINAPI Protocol_Start(IInternetProtocol *iface, LPCWSTR szUrl, SET_EXPECT(OnDataAvailable); SET_EXPECT(OnStopBinding); + bscf = BSCF_LASTDATANOTIFICATION; hres = IInternetProtocolSink_ReportData(pOIProtSink, bscf, 13, 13); ok(hres == S_OK, "ReportData failed: %08x\n", hres);

1 0

Re: WGL: GetPixelFormat fix for offscreen formats
by Tomas Carnecky Aug. 2, 2007

Aug. 2, 2007

from the patch: return physDev->current_pf; + TRACE("(%p): returns %d\n", physDev, physDev->current_pf); } What's the purpose of that TRACE() ? tom

2 1

Is there a process for reviewing a bugzilla staffer?
by Whit Blauvelt Aug. 2, 2007

Aug. 2, 2007

Hi, Is there a formal process for reviewing an arguably incompetent bugzilla staffer? Obviously it wouldn't be to submit their name as a bug. But is there any defined administrative layer that concerns itself with people on that level who are dragging on the project? I looked around a bit for information on this. Sorry if it's posted somewhere and I missed it. Thanks, Whit

6 10

Re: [1/5] DDraw: Some drivers return DDERR_INVALIDPARAMS if DXTn surfaces aren't supported
by H. Verbeet Aug. 2, 2007

Aug. 2, 2007

On 02/08/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: >+ ok(hr == DD_OK || hr == DDERR_NOTEXTUREHW || DDERR_INVALIDPARAMS, That doesn't do what you want it to do. If the return value is irrelevant though, what's the point of the test?

2 3

RE: Is there a process for reviewing a bugzilla staffer?
by EA Durbin Aug. 2, 2007

Aug. 2, 2007

I don't think we need to be rude and poke fun at new wine users by pointing out their mistakes to everyone. He may someday prove to be a valuable asset to the project, or may be driven off from contributing altogether because a dev/admin had to point out his errors for "entertainment" purposes. I don't see being rude to new users "entertainment", it comes across as being kind of a bully and deters people from contributing. We're all linux/wine newbs at some point, and telling them their posts are useless information instead of trying to help them in a friendly fashion is going to end up driving them away from the project.> Date: Wed, 1 Aug 2007 21:09:13 -0600> From: wine-devel(a)kievinfo.com> To: wine-devel(a)winehq.org> Subject: Re: Is there a process for reviewing a bugzilla staffer?> > Whit Blauvelt wrote:> > Hi,> > > > Is there a formal process for reviewing an arguably incompetent bugzilla> > staffer? Obviously it wouldn't be to submit their name as a bug. But is> > there any defined administrative layer that concerns itself with people on> > that level who are dragging on the project?> > > > I looked around a bit for information on this. Sorry if it's posted> > somewhere and I missed it.> > > > Thanks,> > Whit> > > > To spare everyone time and to skip directly to an entertainment see bug > 9147: http://bugs.winehq.org/show_bug.cgi?id=9147> > Vitaliy.> > > _________________________________________________________________ See what you’re getting into…before you go there. http://newlivehotmail.com

1 0

Re: [5/5] D3D9: Check for volume texture support before running the volume test
by H. Verbeet Aug. 2, 2007

Aug. 2, 2007

On 02/08/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if(!(caps.TextureCaps & D3DPTEXTURECAPS_CUBEMAP)) { That doesn't check for volume textures.

2 1

dwarf2_parse_udt_type Unhandled Tag type 0x16
by Robert Reif Aug. 2, 2007

Aug. 2, 2007

I get tons of these sometimes when a program crashes: fixme:dbghelp_dwarf:dwarf2_parse_udt_type Unhandled Tag type 0x16 at ctx(0x34ec70,L"kernel32<elf>"), for debug_info(abbrev:0x17ab04,symt:0xe24ee4) which makes debugging difficult.

1 0