September 2007 - Wine-Devel

Re: winex11.drv[1/4]: fix two bugs in WTInfoA
by Alexandre Julliard Sept. 19, 2007

Sept. 19, 2007

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > Two bugs I've found working on previous implentations > From b233532f7adc140c4e36fb2288581fe0ff181935 Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?Miko=C5=82aj_Zalewski?= <mikolaj(a)zalewski.pl> > Date: Mon, 17 Sep 2007 11:54:41 -0700 > Subject: [PATCH] winex11.drv: fix two bugs in WTInfoA Please write a better description of the changes, "fix bug" can apply to just about any commit (and in general, if you have two bugs to fix there should be two patches...) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: A first implentation of services.exe
by Robert Shearman Sept. 18, 2007

Sept. 18, 2007

Mikolaj Zalewski wrote: > I don't want this patch to get committed but to maybe get some > comments. If the patch will be considered to be ok I can send it as > three smaller patches. It implements the basic infrastructure for > services.exe - a process that maintains the services database and > states. I think this can be useful in the long run. Absolutely. > This patch > currently doesn't implement anything useful - it connects to > services.exe in OpenSCManager and disconnect in CloseServiceHandle and > validating the database name is now done in services.exe but if this > approach is good I will add more functionality. > It looks good to me, but I'm a bit worried that you'll come across bugs/unimplemented features in widl when you start adding more calls. > Is there a way to check if a RPC connection over a named pipe was > closed by the client (probably we should close all it's handles in > such a case)? Yes, you can do this using context handles, but unfortunately we're lacking support for these on the RPC server side and in widl. > Also this program show a bug in our rpcrt4 - if we pass > NULL as a [in,unique,string] parameter rpcrt4 will crash because of a > strlen on it in NdrConformantStringBufferSize. To see it one can > remove the workaround in OpenSCManager and do a `make test`. That sounds like a bug in widl to me, and I'll take a look. > Macros > like RET_IF_ERROR should be removed from the final version or can they > stay? Definitely should be removed. > diff --git a/include/wine/svcctl_shared.h b/include/wine/svcctl_shared.h > new file mode 100644 > index 0000000..5687ddc > --- /dev/null > +++ b/include/wine/svcctl_shared.h > @@ -0,0 +1,35 @@ > +/* > + * SVCCTL (services.exe RPC interface) shared constants > + * > + * Copyright (C) 2007 Google (Mikolaj Zalewski) > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#ifndef __WINE_SVCCTL_SHARED_H > +#define __WINE_SVCCTL_SHARED_H > + > +#include <stdarg.h> > +#include <windef.h> > +#include <winbase.h> > + > +#define SVCCTL_TRANSPORT {'n','c','a','c','n','_','n','p',0} > +#define SVCCTL_ENDPOINT {'\\','p','i','p','e','\\','s','v','c','c','t','l',0} > + > +/* Not the Windows event name - if needed the true one can be found in Inside Windows */ > +#define SVCCTL_STARTED_EVENT (const WCHAR[]){'S','v','c','c','t','l','S','t','a','r','t','e','d',0} > + > + > +#endif /* __WINE_RPCSS_SHARED_H */ > We shouldn't need another file for this. You can put this same stuff in svcctl.idl using cpp_quote. > +DWORD RPC_MainLoop() Make sure to fully specify the parameters for functions with no parameters by declaring them as "(void)". -- Rob Shearman

1 0

Want to contact Mike McCormack
by Stefan Ensslen Sept. 18, 2007

Sept. 18, 2007

Dear Sirs, I wanted to contact Mike McCormack from the WinE developer team, but my email to mike(a)codeweavers.com bounced. If you could send me his new email address, I'd be very happy. The question I wanted to ask Mr. McCormack is the following: Dear Mike, I have found your code for generating proxy/stub-code at www.winehq.org. I wanted to ask where you have found a documentation of the functions used in this code (for example NdrProxyInitialize, NdrProxySendReceive, and so on). The MSDN doesn't provide any _valuable_ documentation for this function, so you surely have another source of documentation. Thanks in advance, Stefan Ensslen -- GMX FreeMail: 1 GB Postfach, 5 E-Mail-Adressen, 10 Free SMS. Alle Infos und kostenlose Anmeldung: http://www.gmx.net/de/go/freemail

2 1

AppDB down - too many SQL connections?
by Alexander Nicolaysen Sørnes Sept. 18, 2007

Sept. 18, 2007

Hello, I am unable to access the database now because of too many MySQL connections. Does anyone have a log file to indicate whether this is some sort of attack, or whether we just have too many legitimate users? Alexander N. Sørnes

2 1

make crosstest is missing -lcabinet
by Pedro Araújo Sept. 18, 2007

Sept. 18, 2007

Hi all, I've been trying to cross-compile the Wine tests, but I keep getting this error: $ ./configure && make crosstest [SNIP] i586-mingw32msvc-gcc advpack.cross.o files.cross.o install.cross.o testlist.cross.o -o advpack_crosstest.exe -lcabinet -luser32 -ladvapi32 -lkernel32 /usr/lib/gcc/i586-mingw32msvc/3.4.5/../../../../i586-mingw32msvc/bin/ld: cannot find -lcabinet collect2: ld returned 1 exit status make[2]: *** [advpack_crosstest.exe] Error 1 make[2]: Leaving directory `/.../dlls/advpack/tests' make[1]: *** [advpack/tests/__crosstest__] Error 2 make[1]: Leaving directory `/.../dlls' make: *** [dlls/__crosstest__] Error 2 Am I missing anything? Thanks in advance. -- - Pedro.

2 2

Problem with TCP Option 0x00000008
by Christian Mahnke Sept. 18, 2007

Sept. 18, 2007

Hello, i have a problem with a program that uses a network license manager. I've installed native DCOM using the winetricks script. When i start the program i got the message "fixme:winsock:WS_setsockopt Unknown IPPROTO_TCP optname 0x00000008" after the loading of native rpcltccm.dll. To work around this i've compiled a modified wine 0.9.44 with an empty case statement for 0x00000008 in socket.c. It doesn't help much, the program just fails a bit later. The TCP Option 0x00000008 is defined as TCP_ATMARK in ws2_ipdef.h in the Windows SDK. Does anyone know how this should be mapped ? Cheers, Christian

4 6

compile wine from sources - strange messages
by Andrey Gavrilin Sept. 18, 2007

Sept. 18, 2007

Hello. I wish to compile wine from sources. Has received such message. The distribution: Ubuntu 7.04. What headers files does not suffice? PS I used the program the translator from Russian to English. configure: WARNING: jack/jack.h: present but cannot be compiled configure: WARNING: jack/jack.h: check for missing prerequisite headers? configure: WARNING: jack/jack.h: see the Autoconf documentation configure: WARNING: jack/jack.h: section "Present But Cannot Be Compiled" configure: WARNING: jack/jack.h: proceeding with the preprocessor's result configure: WARNING: jack/jack.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------ ## configure: WARNING: ## Report this to wine-devel(a)winehq.org ## configure: WARNING: ## ------------------------------------ ## configure: WARNING: pthread.h: present but cannot be compiled configure: WARNING: pthread.h: check for missing prerequisite headers? configure: WARNING: pthread.h: see the Autoconf documentation configure: WARNING: pthread.h: section "Present But Cannot Be Compiled" configure: WARNING: pthread.h: proceeding with the preprocessor's result configure: WARNING: pthread.h: in the future, the compiler will take precedence

2 1

Re: kernel32: Don't crash accessing an invalid handle in GlobalSize
by Robert Shearman Sept. 18, 2007

Sept. 18, 2007

James Hawkins wrote: > + if (IsBadReadPtr(pintern, 1)) > + { > + SetLastError(ERROR_INVALID_HANDLE); > + return 0; > + } > + > if(pintern->Magic==MAGIC_GLOBAL_USED) > { > if (!pintern->Pointer) /* handle case of GlobalAlloc( ??,0) */ It would be better to wrap the Magic access with an exception handler rather than use IsBadReadPtr. -- Rob Shearman

1 0

Re: fix for bug 9665
by James Hawkins Sept. 17, 2007

Sept. 17, 2007

On 9/17/07, Martin <martin.marsan(a)gmail.com> wrote: > > > 2007-09-17 Martin Sand <deadlock(a)start.no> > > * dlls/ddraw/direct3d.c: > ddraw: fixes a bug which prevents Kings Quest 8 from starting(bug 9665) > A good changelog entry details what you changed, not what apps are fixed by a change. -- James Hawkins

2 1

Re: fix for bug 9665
by Stefan Dösinger Sept. 17, 2007

Sept. 17, 2007

Am Montag, 17. September 2007 20:45:04 schrieb Martin: I doubt this fix is correct, as explained in bug 9665 a few minutes ago. It should fail the d3d test too

1 0