September 2007 - Wine-Devel

Re: advapi32: add some more rights constants for ConvertStringSecurityDescriptorToSecurityDescriptor
by Hans Leidekker Sept. 22, 2007

Sept. 22, 2007

On Saturday 22 September 2007 04:19:09 Mikolaj Zalewski wrote: > + > + ADS_RIGHT_DELTE = 0x00010000, You're missing an E there. -Hans

1 0

re: Will ROS and WINE still be steady be synchronized ?
by Dan Kegel Sept. 21, 2007

Sept. 21, 2007

Shachar Shemesh wrote: > As far as I understand this, if I disassemble Microsoft binaries (it is > legal in Israel), then the resulting knowledge is legal to use - > anywhere (in other words - the only one who can be sued is me, and the > jurisdiction is Israel, where the action is legal). I am not a lawyer, but I bet you're wrong there. The disassembled code is probably considered a copy, using it could be a copyright violation, and if any such code snuck into Wine, we'd have to go rip it out at great cost. - Dan

5 11

Re: services.exe[3/3]: start a local RPC server and make advapi32 connect/disconnect to it on service manager handle creation/destruction
by Robert Shearman Sept. 21, 2007

Sept. 21, 2007

Mikolaj Zalewski wrote: > + /* Compatible with Windows function 0x0f */ > + DWORD svcctl_OpenSCManagerW( > + SvcCtlRpcHandle rpc_handle, > + [in,unique,string] LPCWSTR MachineName, > + [in,unique,string] LPCWSTR DatabaseName, > The string attribute should be redundant as LPCWSTR should already be declared as a string type. I also noticed this redundancy in your fourth services patch. > + if ((err = RpcServerInqBindings(&pbindingVector)) != ERROR_SUCCESS) > + { > + WINE_ERR("RpcServerInqBindings failed with error %u\n", err); > + return err; > + } What's the purpose of this? You don't actually use the binding vector anywhere. -- Rob Shearman

1 0

Re: Patch: ntoskrnl.exe - Added PsCreateSystemThread
by Dmitry Timoshkov Sept. 21, 2007

Sept. 21, 2007

"Carroll Vance" <ovencleaner(a)gmail.com> wrote: > I have implemented PsCreateSystemThread in ntoskrnl.exe. This API i have > found used by programs like nProtect gameguard, and is a pretty commonly > used kernel api. This either ends up calling CreateThread or > CreateRemoteThread depending on if a process handle was provided. You can call CreateRemoteThread without any checks for the process handle. > This is my > first patch, I read over the dev docs and patch format, I hope I did not > miss anything. I have tested this with a driver I made and it seemed to work > fine. Your patch mixes tabs and spaces on the same line, that makes formatting messy. Also if you could add spaces around '!=' and '==' in if statements that would make the code slightly more readable. -- Dmitry.

1 0

Re: Always set DIOBJECTDATAFORMAT.pguid to GUID_Button for joystick buttons
by John Klehm Sept. 21, 2007

Sept. 21, 2007

On 9/20/07, Antonio Cuni <anto.cuni(a)gmail.com> wrote: > At least one game (Pro Evolution Soccer 6) rely on the pguid field of > the DIOBJECTDATAFORMAT struct to respond to joystick button's events. > Setting pguid to GUID_Button solves the problem. > > 2007-09-20 Antonio Cuni <anto.cuni(a)gmail.com> > > * dlls/dinput/joystick_linux.c, > dlls/dinput/joystick_linuxinput.c > Always set DIOBJECTDATAFORMAT.pguid to GUID_Button for > joystick buttons > > > + df->rgodf[idx].pguid = &GUID_Button; // some games require the GUID to be > + > df->rgodf[idx].pguid = &GUID_Button; // some games require the GUID to be GUID_Button > You need to use C style comments /* */ Regards =), --John Klehm

1 0

Re: Always set DIOBJECTDATAFORMAT.pguid to GUID_Button for joystick buttons
by Vitaliy Margolen Sept. 21, 2007

Sept. 21, 2007

Antonio Cuni wrote: > At least one game (Pro Evolution Soccer 6) rely on the pguid field of > the DIOBJECTDATAFORMAT struct to respond to joystick button's events. > Setting pguid to GUID_Button solves the problem. > > 2007-09-20 Antonio Cuni <anto.cuni(a)gmail.com> > > * dlls/dinput/joystick_linux.c, > dlls/dinput/joystick_linuxinput.c > Always set DIOBJECTDATAFORMAT.pguid to GUID_Button for > joystick buttons > Thank you for the patch. I have few comments about it: > -- /tmp/wine-0.9.45/dlls/dinput/joystick_linux.c 2007-09-14 19:30:55.000000000 +0200 > +++ ./joystick_linux.c 2007-09-20 17:02:15.000000000 +0200 You should diff from the top of the tree (above line should say dlls/dinput/joystick_linux.c). > + df->rgodf[idx].pguid = &GUID_Button; // some games require the GUID to be GUID_Button C++ comments are not allowed in Wine. Please put comments above the code. > newDevice->buttons[i] = 0x80 | newDevice->numButtons; > + df->rgodf[idx].pguid = &GUID_Button; // some games require the GUID to be GUID_Button > df->rgodf[idx++].dwType = DIDFT_MAKEINSTANCE(newDevice->numButtons++) | DIDFT_PSHBUTTON; Please don't use tabs. Use spaces to keep formating. Vitaliy.

1 0

Re: Implemented PsCreateSystemThread in ntoskrnl.exe
by Juan Lang Sept. 20, 2007

Sept. 20, 2007

Hi Carroll, + if (ProcessHandle!=0) + localThreadHandle = CreateRemoteThread(ProcessHandle,0,0,StartRoutine,StartContext,0,&ThreadId); + else localThreadHandle = CreateThread(0,0,StartRoutine,StartContext,0,&ThreadId); + + if (localThreadHandle==0) return STATUS_SEVERITY_ERROR; You should use NtCreateThread rather than CreateThread. It also returns a proper status, so you don't have to guess like you do here. --Juan

2 2

[PATCH] fix small spelling mistakes
by Juan Lang Sept. 20, 2007

Sept. 20, 2007

Hi Peter, > correct spelling of iff -> if Just so you know, iff is a common abbreviation meaning "if and only if." I don't think that's any clearer in the cases you modified, so I think your patch is fine, I just thought you (and others) might be interested. --Juan

2 1

Will ROS and WINE still be steady be synchronized ?
by theUser BL Sept. 20, 2007

Sept. 20, 2007

Hi! I have also ask the question in a mail in the ROS-Mailinglist -- until now there comes now answer. http://www.reactos.org/archives/public/ros-dev/2007-August/009718.html Will ReactOS and WINE still be steady synchronized? ROS have for example an other Notepad.exe and an other Wordpad.exe The WineMINE have on ROS the colors of the original Windows WinMine. And the cards.dll have other cards. AT first it used the cards of http://nifty.stanford.edu/2004/EstellCardGame/ But after the comment of http://www.reactos.org/archives/public/ros-dev/2007-July/009625.html it used the cards at http://sourceforge.net/projects/macsolitairex WINE on the other side used since the beginning of its cards.dll the Microsoft copyrighted cards, which are also part of MS-Windows. So, for me it seems, that ROS and WINE goes two different ways since some time without syncronizing the source-codes, which can be used for both projects. Is that true? And if yes: Why? Greatings theuserbl _________________________________________________________________ Sie suchen E-Mails, Dokumente oder Fotos? Die neue MSN Suche Toolbar mit Windows-Desktopsuche liefert in sekundenschnelle Ergebnisse. Jetzt neu! http://desktop.msn.de/ Jetzt gratis downloaden!

4 4

Re: WineD3D: better video memory reporting
by Juan Lang Sept. 20, 2007

Sept. 20, 2007

Your patch appears empty: > Type: text/x-diff > Size: 0 bytes --Juan

2 1