December 2009 - Wine-Devel - list.winehq.org

Re: [PATCH 2/5] wined3d: Filter window messages generated by switching to fullscreen and back.
by Stefan Dösinger Dec. 15, 2009

Dec. 15, 2009

This looks correct to me, I'm just asking to make sure I understand this correctly: > + filter_messages = swapchain->filter_messages; > + swapchain->filter_messages = TRUE; > + > SetWindowLongW(window, GWL_STYLE, style); > SetWindowLongW(window, GWL_EXSTYLE, exstyle); > SetWindowPos(window, HWND_TOP, 0, 0, w, h, SWP_FRAMECHANGED | SWP_SHOWWINDOW); > + > + swapchain->filter_messages = filter_messages; > } I am not seeing any place where swapchain->filter_messages is set so something other than FALSE, except of the same code in restore_fullscreen_window. Am I right to assume that this construct is meant to catch situations where the app's wndproc calls wined3d when receiving a WM_DISPLAYCHANGE message? > @@ -965,6 +976,13 @@ void get_drawable_size_swapchain(struct wined3d_context *context, UINT *width, U > LRESULT swapchain_process_message(IWineD3DSwapChainImpl *swapchain, HWND window, > UINT message, WPARAM wparam, LPARAM lparam, WNDPROC proc) > { > + if (swapchain->filter_messages) > + { > + TRACE("Filtering message: window %p, message %#x, wparam %#lx, lparam %#lx.\n", > + window, message, wparam, lparam); > + return CallWindowProcW(DefWindowProcW, window, message, wparam, lparam); > + } > + This calls the default Win32 wndproc in user32, and thus bypasses the app's wndproc, correct? There's the other call below added by patch 1 which calls proc instead. I'm asking because the lack of a ! in the if condition confused me at first.

2 1

Re: [2/3] WineD3D: Properly release client storage memory
by Henri Verbeet Dec. 15, 2009

Dec. 15, 2009

2009/12/15 Stefan Dösinger <stefan(a)codeweavers.com>: > + This->Flags &= ~(SFLAG_ALLOCATED | SFLAG_SRGBALLOCATED); That's pretty much what surface_force_reload() does.

1 0

Re: [3/3] WineD3D: Don't enable render_to_fbo on single buffered swapchains
by Henri Verbeet Dec. 15, 2009

Dec. 15, 2009

2009/12/15 Stefan Dösinger <stefan(a)codeweavers.com>: > + && present_parameters->BackBufferCount > 0 "BackBufferCount" is unsigned.

1 0

Test suite under Intel drivers
by Jaime Rave Dec. 14, 2009

Dec. 14, 2009

Hi wine devs, I'm writing you to ask some help to try to fix the the Wine test suite under the Intel drivers. I have already fill a bug with freedesktop but they are asking for some wine devs to give them some openGL test to add it to the piglit testcases. The bug is: http://bugs.freedesktop.org/show_bug.cgi?id=25432 Some words from the bug: "There are probably some actual bugs in our OpenGL, and there may also be bugs in the testcase. What it'll take to fix it is somebody (probably Wine developers/fans) isolating some OpenGL testcases for inclusion in piglit that will catch the bugs that this D3D test is hitting in OpenGL." Thanks in advance for your help. -- Jaime Rave Torres Ingeniero de Sistemas Miembro de la Fundación de Software Libre de Colombia http://www.fslcol.org/ http://sobrelibertad.blogspot.com/ 3003160361

2 1

Re: [PATCH 2/2] mmdevapi: Add more tests
by Paul Vriens Dec. 14, 2009

Dec. 14, 2009

On 12/14/2009 10:09 AM, Maarten Lankhorst wrote: > + hr = IMMDeviceEnumerator_GetDefaultAudioEndpoint(mme, eRender, eMultimedia,&dev); > + ok(hr == S_OK, "GetDefaultAudioEndpoint failed: 0x%08x\n", hr); > + if (hr != S_OK) > + { > + skip("GetDefaultAudioEndpoint returns 0x%08x, skipping tests\n", hr); > + return; > + } Hi Maarten, This one introduces a failure on Vista+ (obviously) for boxes with a soundcard so it seems (by looking at other tests for these boxes): http://test.winehq.org/data/tests/mmdevapi:dependency.html Could you have a look? -- Cheers, Paul.

2 1

Re: [PATCH 14/14] [WineDbg]: fix some casts issues on 64bit platform
by Alexandre Julliard Dec. 14, 2009

Dec. 14, 2009

Eric Pouech <eric.pouech(a)orange.fr> writes: > diff --git a/programs/winedbg/dbg.y b/programs/winedbg/dbg.y > index 855407f..7ed6307 100644 > --- a/programs/winedbg/dbg.y > +++ b/programs/winedbg/dbg.y > @@ -281,9 +281,9 @@ info_command: > | tINFO tCLASS { info_win32_class(NULL, NULL); } > | tINFO tCLASS tSTRING { info_win32_class(NULL, $3); } > | tINFO tWND { info_win32_window(NULL, FALSE); } > - | tINFO tWND expr_rvalue { info_win32_window((HWND)$3, FALSE); } > + | tINFO tWND expr_rvalue { info_win32_window((HWND)(DWORD_PTR)$3, FALSE); } > | tINFO '*' tWND { info_win32_window(NULL, TRUE); } > - | tINFO '*' tWND expr_rvalue { info_win32_window((HWND)$4, TRUE); } > + | tINFO '*' tWND expr_rvalue { info_win32_window((HWND)(DWORD_PTR)$4, TRUE); } > | tINFO tPROCESS { info_win32_processes(); } > | tINFO tTHREAD { info_win32_threads(); } > | tINFO tEXCEPTION { info_win32_exceptions(dbg_curr_tid); } It seems to me that it's expr_rvalue itself that should be a DWORD_PTR, it can be used to specify addresses at other places too. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [usrmarshal] Check the actual size of safe arrays marshaled, not just projected size.
by Paul Vriens Dec. 14, 2009

Dec. 14, 2009

On 12/11/2009 04:25 PM, Jeremy White wrote: > --- > dlls/oleaut32/tests/usrmarshal.c | 41 +++++++++++++++++++++++-------------- > 1 files changed, 25 insertions(+), 16 deletions(-) > Hi Jeremy, This one looks like to have introduced some test failures on Win9x/WinME: http://test.winehq.org/data/tests/oleaut32:usrmarshal.html Could you have a look? -- Cheers, Paul.

1 0

RE: WineTestBot
by Greg Geldorp Dec. 14, 2009

Dec. 14, 2009

Hi Andre, > From: Andre Hentschel > > Some Questions/Suggestions by me: > - Are the VMs running on Computer at VMWare, on some Internetserver or at your home? I have a personal box (Dell SC1435, Quad core AMD Opteron @ 2.2 GHz, 16GB RAM) collocated at a large Dutch ISP. WineTestBot and the test VMs are all running on that box. VMware is not involved (yet?). > - IMO you should add pruning to your script, we are at about 120 tests and i guess old ones can be deleted Yes, I started working on a Janitor.pl script last weekend. Should be ready some time this week. The plan is to throw everything away that's older than a week. > - Will you add one or more Wine-Machines to cover that, too? It's not a priority for me, I might look at that once I get the bot to phase 3 (where it will watch wine-patches for test changes and run them automatically). Thanks for your feedback, Ge.

1 0

Re: Rob Shearman : msvcrt: Free memory allocated in TLS slot on module unload as well as thread exit.
by Nikolay Sivov Dec. 14, 2009

Dec. 14, 2009

On 12/14/2009 18:51, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: c20868e0a2f7af909cf8af2877ae8b024fa6d11e > URL: http://source.winehq.org/git/wine.git/?a=commit;h=c20868e0a2f7af909cf8af287… > > Author: Rob Shearman<robertshearman(a)gmail.com> > Date: Mon Dec 14 14:13:57 2009 +0000 > > msvcrt: Free memory allocated in TLS slot on module unload as well as thread exit. > > --- > > dlls/msvcrt/main.c | 27 +++++++++++++++------------ > 1 files changed, 15 insertions(+), 12 deletions(-) > It's a partial solution I suppose? I works for a one thread only that unloads module.

2 2

WineTestBot
by André Hentschel Dec. 14, 2009

Dec. 14, 2009

Hi, First i have to thank Mr. Geldorp for this really great gift :) Some Questions/Suggestions by me: - Are the VMs running on Computer at VMWare, on some Internetserver or at your home? - IMO you should add pruning to your script, we are at about 120 tests and i guess old ones can be deleted - Will you add one or more Wine-Machines to cover that, too? -- Best Regards, André Hentschel

1 0