December 2009 - Wine-Devel - list.winehq.org

Re: meaning of "Hardware" field in bugzilla?
by Dan Kegel Dec. 14, 2009

Dec. 14, 2009

Sure, once it's far enough along... might be a bit early yet? On Dec 11, 2009 6:15 PM, "Tom Wickline" <twickline(a)gmail.com> wrote: On Sat, Dec 12, 2009 at 2:35 AM, Austin English <austinenglish(a)gmail.com> wrote: > > > Dan and I dis... If your going to re-work this I would also add ARM to the list, their has been some work to port Wine to the ARM processor lately. Anyone have any objections to adding a ARM selection to the list? ARM -> RISC Cheers, Tom

4 5

Re: msi: Add binary search to the string table.
by Henri Verbeet Dec. 14, 2009

Dec. 14, 2009

2009/12/14 Hans Leidekker <hans(a)codeweavers.com>: > Addresses a performance bottleneck in the Visual Studio 2005 installer. > See http://bugs.winehq.org/show_bug.cgi?id=14168 Does it really make sense to maintain both a hash table and a binary search tree?

3 2

re: ntdll: Ignore the hole in the FILE_PIPE_WAIT_FOR_BUFFER structure passed into NtFsControlFile before writing the structure to the server.
by Dan Kegel Dec. 14, 2009

Dec. 14, 2009

Rob's patch is the most precise solution. The macro should probably go in a .h file as it might be useful elsewhere. Alternately I can suppress all errors from functions like server_ioctl_file but it'd be better to just mark the holes as defined. Thanks, Rob!

1 0

weird and funky things happen when viewing guimark in ie6 in wine...
by Dan Kegel Dec. 14, 2009

Dec. 14, 2009

Austin has a workaround for the problem that makes ie6 exit immediately ( http://code.google.com/p/winezeug/issues/detail?id=78 ). While testing it on guimark, wine ~.wine/drive_c/Program\ Files/Internet\ Explorer/IEXPLORE.EXE http://www.craftymind.com/factory/guimark/GUIMark_HTML4.html I noticed something strange when I closed ie6 after running for a few seconds. Either I see some sort of file leak (and this is with a fully vanilla fresh wine): ... wine client error:10c: pipe: Too many open files fixme:wininet:InternetSetOptionW INTERNET_OPTION_COOKIES_3RD_PARTY; STUB fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_REQUEST_PRIORITY (-1): STUB fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_CODEPAGE (65001): STUB fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_ERROR_MASK(11): STUB wine client error:10d: pipe: Too many open files fixme:wininet:InternetSetOptionW INTERNET_OPTION_COOKIES_3RD_PARTY; STUB fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_REQUEST_PRIORITY (-1): STUB fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_CODEPAGE (65001): STUB fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_ERROR_MASK(11): STUB ... or I see Building font metrics. This may take some time... Font metrics: 0.0% done ... and the whole long font metric rebuilding process, which should never be happening anymore for local X servers (right?). The "wine client error" comes from ntdll/server.c. It ought to be easy to get a backtrace from the problem using winedbg by setting a breakpoint, but I haven't managed to so far. Debugging this is complicated by the fact that GuiMark seems to crash my home router; maybe it does too many fetches too quickly. Do other people see this, too? Firefox seems to handle it well in wine, and doesn't show this problem. If this turns out to be an ie6 bug, we don't care, but there's some chance it's a wine bug. Guimark seems to be quite the stress test. - Dan

3 2

Re: (resend)shlwapi: implement SHPropertyBag_ReadLONG
by Jacek Caban Dec. 14, 2009

Dec. 14, 2009

Hi Aric, On 12/11/09 10:44 PM, Aric Stewart wrote: > --- > dlls/shlwapi/ordinal.c | 25 +++++++++++++++++++++++++ > dlls/shlwapi/shlwapi.spec | 2 +- > 2 files changed, 26 insertions(+), 1 deletions(-) + hr = IPropertyBag_Read(ppb, pszPropName,&var, NULL); + if (SUCCEEDED(hr)) + *pValue = V_I4(&var); You should make sure that var is of VT_I4 type and return an error or do conversion if it's not. Thanks, Jacek

2 1

Re: ws2_32: Fix allocating a hostent with no h_aliases list.
by Alexandre Julliard Dec. 14, 2009

Dec. 14, 2009

Erich Hoover <ehoover(a)mines.edu> writes: > @@ -4616,11 +4620,18 @@ static struct WS_hostent *WS_create_he(char *name, int aliases, int addresses, i > sizeof(char *)*aliases + > sizeof(char *)*addresses); > > - /* Place addresses in the allocated memory, making sure to have enough > - * room for the NULL at the end of the list. > + /* NOTE: Even if the alias and address lists are "empty" the list pointer must > + * be non-NULL and contain a single NULL item. > */ > + if (aliases == 0 || addresses == 0) > + { > + FIXME("Cannot create a hostent with an empty list pointer!\n"); > + return NULL; > + } That's an internal constraint in the code, it doesn't make sense to have a FIXME. If you really want a check it should be an assert(). -- Alexandre Julliard julliard(a)winehq.org

1 0

Upcoming WWN
by Zachary Goldberg Dec. 13, 2009

Dec. 13, 2009

Greetings Folks, As is the usual excuse "real life" has gotten in the way of producing quality and timely World Wine News issues. Dan Kegel recently had the idea of putting together a wiki page where the community as a whole can contribute to the next issue. I concurred and Dan put together the following page: http://wiki.winehq.org/RecentNewsQueue Which has a preface as follows: "This is the inbox for Wine Weekly News. The WWN editor invites Wine developers and users to submit articles here for inclusion in the next edition of WWN, but reserves the right to edit mercilessly. This page will be cleared each time a new WWN is published.' So, feel free to throw up some topics you would like to see discussed and maybe some extra detail that wouldn't ordinarily have showed up on wine-devel (you can include links to wine-devel too if you feel like being really nice to the editor :)). I'll post some ideas for articles during the day tomorrow (something about dsound and OpenAL anybody?) that hopefully we can flesh out along with ideas from the community at large. Cheers, -Zach

1 0

New winetricks 20091213: ie6 and gecko fixed; new verbs vcrun6sp6, python-comtypes, richtx32; less restrictive art2kmin, clearer license text.
by Dan Kegel Dec. 13, 2009

Dec. 13, 2009

Austin and Andrew have been hard at work keeping winetricks working smoothly. In particular, the ie6 and gecko verbs should work again. Thanks guys! Changes since 20091125: Austin English: Workaround wine bug for IE6 Update shockwave sha1sum Add python-comtypes verb Explain windows licensing a bit better Gdiplus no longer comes from powerpoint viewer, update description accordingly Update DivX to latest version, remove obsolete /silent option Make append_path work if called more than once When installing gecko, regsvr32 mshtml afterward, so it actually works Update KDE to 0.9.6-5 When using native mdac, also override oledb32 Bump artk2min to 2007 Access runtime (freely redistributable, wooo!) Andrew Nguyen: Update flash to latest version. Check more exit codes. Update the vb6run verb to use the Service Pack 6 variant. Revise vcrun6 verb to remove more fake DLLs and more simply extract mfc42u.dll. Add vcrun6sp6 verb. (New verb rather than update of vcrun6 as it's a huge download.) Add richtx32 verb. Dan Kegel: Add heapcheck verb (for use with the not-yet-committed heapcheck patches) Avoid double-trying regedit Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.)

1 0

Re: mshtml: Implement IHTMLImgElement get_Name
by Jacek Caban Dec. 13, 2009

Dec. 13, 2009

Hi Alistair, On 12/13/09 12:11 PM, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > mshtml: Implement IHTMLImgElement get_Name + nsres = nsIDOMHTMLImageElement_GetName(This->nsimg,&src_str); + if(NS_FAILED(nsres)) { + ERR("GetName failed: %08x\n", nsres); + return E_FAIL; + } You leak src_str here. +#define test_img_name(u) _test_img_name(__LINE__,u) +static void _test_img_name(unsigned line, IUnknown *unk) +{ + IHTMLImgElement *img = _get_img_iface(line, unk); + static WCHAR sNameImage[] = {'W','i','n','e','I','m','g',0}; Please make it more generic and avoid using lstrcmpW by getting expected name as const char* argument and using strcmp_wa to compare strings. Jacek

1 0

Re: [3/6]user32/tests: Test for SwitchDesktop API
by James McKenzie Dec. 13, 2009

Dec. 13, 2009

shanmukha sainath addepalli wrote: > Hi, > > The test for SwitchDesktop has not submitted earlier. This test > performs switching between two desktops using SwitchDesktop API. > Will this test and the other test compile into winetest_latest.exe and will this test give the results you expect on any version of Windows (95 through 7)? These test should be added first before adding any code to the existing Wine base and validated to have correct values. James McKenzie

1 0