December 2009 - Wine-Devel - list.winehq.org

Re: [PATCH 2/2] server: Include user groups in file mode calculation when user is file owner
by Alexandre Julliard Dec. 10, 2009

Dec. 10, 2009

"Ben Peddell" <klightspeed(a)netspace.net.au> writes: > @@ -474,7 +475,9 @@ mode_t sd_to_mode( const struct security_descriptor *sd, const SID *owner ) > if (access & FILE_EXECUTE) > denied_mode |= S_IXUSR|S_IXGRP|S_IXOTH; > } > - else if (security_equal_sid( sid, owner )) > + else if (security_equal_sid( sid, owner ) || > + (security_equal_sid( user, owner ) && > + token_sid_present( current->process->token, sid, TRUE ))) > { > unsigned int access = generic_file_map_access( ad_ace->Mask ); > if (access & FILE_READ_DATA) > @@ -498,7 +501,9 @@ mode_t sd_to_mode( const struct security_descriptor *sd, const SID *owner ) > if (access & FILE_EXECUTE) > new_mode |= S_IXUSR|S_IXGRP|S_IXOTH; > } > - else if (security_equal_sid( sid, owner )) > + else if (security_equal_sid( sid, owner ) || > + (security_equal_sid( user, owner ) && > + token_sid_present( current->process->token, sid, FALSE ))) You should most likely set the group permissions too in that case. -- Alexandre Julliard julliard(a)winehq.org

2 3

Unable to cleanly install cups-devel.i686 on a Fedora 12 x86_64 machine
by Alex Villacís Lasso Dec. 10, 2009

Dec. 10, 2009

I have just updated my setup to Fedora 12 on 64 bits, and I want to compile Wine for this setup. I followed the instructions at: http://wiki.winehq.org/WineOn64bit on the section for Fedora 12. However, I have the following error when trying to install the packages as directed by the wiki: Error en la verificación de la transacción: file /usr/bin/cups-config from install of cups-devel-1:1.4.2-7.fc12.i686 conflicts with file from package cups-devel-1:1.4.2-7.fc12.x86_64 Resumen de errores ------------- What I understand from this is that /usr/bin/cups-config is provided by both packages, and cannot be marked as shared by both packages. I want to have both 32 and 64-bit support for compiling programs that use CUPS. Does this problem have a clean workaround? Or should I complain instead to the Fedora packagers?

5 4

Re: [2/3] wineboot: Terminate processes immediately after WM_ENDSESSION.
by Juan Lang Dec. 10, 2009

Dec. 10, 2009

Hi Vincent, - /* wait for app to quit on its own for a while */ - ret = WaitForSingleObject( process_handle, PROCQUIT_TIMEOUT ); + /* Check whether the app quit on its own */ + ret = WaitForSingleObject( process_handle, 0 ); CloseHandle( process_handle ); if (ret == WAIT_TIMEOUT) I'm confused why you removed the timeout. The documented behavior[1, 2] is to wait a short timeout, show a dialog if the app hasn't quit by then, then kill it. This change makes wineboot terminate a process immediately. Is this really necessary to fix the bug? I'd expect that you want to handle the WAIT_OBJECT_0 case in addition to the WAIT_TIMEOUT case, and leave the timeout alone. --Juan [1] http://blogs.msdn.com/michen/archive/2008/04/04/Application-termination-whe… [2] http://blogs.msdn.com/oldnewthing/archive/2008/04/21/8413175.aspx

2 2

Leaks galore!
by Dan Kegel Dec. 10, 2009

Dec. 10, 2009

http://kegel.com/wine/valgrind/logs/2009-12-05-01.15/ shows the same results as http://kegel.com/wine/valgrind/logs/2009-12-04-18.45/ but with a looser filter, i.e. I now even show files whose only sin is a memory leak (in the past, I had suppressed those because I cared more about non-leak errors). It also suppresses several more persistent sources of warnings, for which I've filed a couple bugs: http://bugs.winehq.org/show_bug.cgi?id=20917 http://bugs.winehq.org/show_bug.cgi?id=20919 With those changes, I now see 457 non-leak errors, (~134 of which are due to the fresh regression http://bugs.winehq.org/show_bug.cgi?id=20920 ) and 1560 leak errors (~300 of which are due to ntlm_auth, which I'm still trying to suppress), in the wine conformance test suite.

5 12

Re: [ddraw/tests] Fix some test failures on Vista+
by Stefan Dösinger Dec. 10, 2009

Dec. 10, 2009

Am 10.12.2009 um 13:21 schrieb Paul Vriens: > <0004-Fix-some-test-failures-on-Vista.patch> > const char *name; > DDPIXELFORMAT fmt; > BOOL getdc_capable; > + HRESULT alt_result; > } testdata[] = { You are setting the alt_result only for the 4 failing tests. I think C sets the others to 0 because the initializer is static data I think its better to explicitly set it in all other test formats to avoid confusion

2 4

Re: winedbg: Add spanish translation
by Paul Vriens Dec. 10, 2009

Dec. 10, 2009

On 12/09/2009 03:30 AM, Jaime Rave wrote: > +LANGUAGE LANG_SPANISH, SUBLANG_DEFAULT Hi, Shouldn't this one need a SUBLANG_NEUTRAL instead? Or is this translation specific to "Spanish (Traditional Sort)"? See also: http://wiki.winehq.org/SublangNeutral -- Cheers, Paul.

1 0

Re: [PATCH 2/2] mmdevapi: add some initial tests
by Alexandre Julliard Dec. 10, 2009

Dec. 10, 2009

1 0

Re: [PATCH 2/7] dsound: Clean up DSPROPERTY_DescriptionW, try 2
by Detlef Riekenberg Dec. 10, 2009

Dec. 10, 2009

On Mi, 2009-12-09 at 16:57 +0100, Maarten Lankhorst wrote: > + { > + /* FIXME: Still a memory leak.. */ This should be fixed before sending to wine-patches -- By by ... Detlef

2 1

Re: [3/5] WineD3D: Test and fix ddraw and d3d9 GetDC differences
by Paul Vriens Dec. 10, 2009

Dec. 10, 2009

On 09/05/2009 04:54 PM, Stefan Dösinger wrote: > This patch uses a d3d9-side filter in favor of adding a 2nd set of > getdc-capable format flags. > Hi Stefan, These tests have failures on Vista+ boxes: dsurface.c:3243: Test failed: GetDC on a D3DFMT_X8B8G8R8 surface failed(0x88760249), expected it to work dsurface.c:3243: Test failed: GetDC on a D3DFMT_X8B8G8R8 surface failed(0x88760249), expected it to work dsurface.c:3243: Test failed: GetDC on a D3DFMT_A4R4G4B4 surface failed(0x88760249), expected it to work dsurface.c:3243: Test failed: GetDC on a D3DFMT_X4R4G4B4 surface failed(0x88760249), expected it to work These are real ones with NVIDIA, ATI and Intel cards but also VMware boxes with the latest VMware driver "VMware SVGA 3D (Microsoft Corporation - WDDM)". Should I change the test to introduce an alternative result for these 4 formats? -- Cheers, Paul.

2 1

Re: [PATCH 3/4] jscript: Added Function constructor tests.
by Detlef Riekenberg Dec. 10, 2009

Dec. 10, 2009

On Do, 2009-12-10 at 01:15 +0100, Jacek Caban wrote: > +func = new Function(); > +tmp = func(); > +ok(tmp === undefined, "func(1,3,2) = " + tmp) Greetings from Copy & Paste -- By by ... Detlef

1 0