May 2010 - Wine-Devel - list.winehq.org

Re: kernel32/tests: Remove variable len which is not really used from test_CommandLine.
by testbot＠testbot.winehq.org May 5, 2010

May 5, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1901 Your paranoid android. === W98SE (32 bit process) === Failure running script in VM: Exceeded timeout limit of 315 sec

2 1

Re: wined3d: Remove variable blue_shift which is not really used from IWineGDISurfaceImpl_SaveSnapshot. (RESEND)
by Alexandre Julliard May 5, 2010

May 5, 2010

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > I didn't see any response, directly or on wine-devel, so I assume > this one just fell through the cracks; thus resending (now in git > format-patch format and proper Subject). It's very unlikely that we'd want to use red and green but not blue... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wined3d: Remove variable blue_shift which is not really used from IWineGDISurfaceImpl_SaveSnapshot. (RESEND)
by Henri Verbeet May 5, 2010

May 5, 2010

On 5 May 2010 00:24, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > I didn't see any response, directly or on wine-devel, so I assume > this one just fell through the cracks; thus resending (now in git > format-patch format and proper Subject). > It probably should be used. At first sight it looks like that's not the only issue with that function though.

1 0

Trying again
by Joakim Tjernlund May 5, 2010

May 5, 2010

This didn't show up in the archives, so trying again. >From 7882df972ec827f0e7b7b622c01be2644e54d122 Mon Sep 17 00:00:00 2001 From: Joakim Tjernlund <Joakim.Tjernlund(a)transmode.se> Date: Mon, 3 May 2010 20:30:32 +0200 Subject: [PATCH] RegisterWaitForSingleObject() fix special tmo == 0 case. At http://msdn.microsoft.com/en-us/library/aa332406%28VS.71%29.aspx one can read: "If the timeOutInterval parameter is not zero (0) and the executeOnlyOnce parameter is false, the timer is reset every time the event is signaled or the time-out interval elapses." timeOutInterval == 0 makes the above false and the timer should NOT be reset, fix that. Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund(a)transmode.se> --- dlls/ntdll/threadpool.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/ntdll/threadpool.c b/dlls/ntdll/threadpool.c index 44afb01..f6c9fb4 100644 --- a/dlls/ntdll/threadpool.c +++ b/dlls/ntdll/threadpool.c @@ -377,7 +377,8 @@ static DWORD CALLBACK wait_thread_proc(LPVOID Arg) wait_work_item->Callback( wait_work_item->Context, TimerOrWaitFired ); wait_work_item->CallbackInProgress = FALSE; - if (wait_work_item->Flags & WT_EXECUTEONLYONCE) + if (!wait_work_item->Milliseconds || + wait_work_item->Flags & WT_EXECUTEONLYONCE) break; } else -- 1.6.4.4

2 1

What is the point of mincore() in reserve_area() in libs/wine/mmap.c?
by Johann "Myrkraverk" Oskarsson May 5, 2010

May 5, 2010

Hi all, In the Solaris/BSD implementation of reserve_area() in libs/wine/mmap.c there is for (i = 0; i < size; i += pagesize) if (mincore( (caddr_t)addr + i, pagesize, &vec ) != -1) break; &vec is never used again in that function. What is the point of mincore() ? I'm looking at this in reference to bug 22033. Johann

3 2

Re: user32/tests: Remove variable hdata which is not really used from test_initialisation.
by testbot＠testbot.winehq.org May 5, 2010

May 5, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1902 Your paranoid android. === W98SE (32 bit dde) === dde.c:586: Test failed: Expected TestDDEServer(, got TestDDEServer:(04dc) dde.c:588: Test failed: Got size 20 for TestDDEServer:(04dc) dde.c:934: Test failed: Expected 0, got 0000c1ae dde.c:737: Test failed: Expected '[BadCommand(Var)]', got [Command-2(Var)] dde.c:738: Test failed: Expected 18, got 32 dde.c:714: Test failed: Expected 9 or 11, got 12 dde.c:939: Test failed: Expected item atom, got 00000000 dde.c:939: Test failed: Expected item atom, got 008307f4 dde.c:812: Test failed: client failed with 14 error(s) dde.c:2040: Test failed: Expected 0xdeadbeef, got 00000083

1 0

Re: RegisterWaitForSingleObject() fix special tmo == 0 case.
by Charles Davis May 4, 2010

May 4, 2010

On 5/4/10 12:06 AM, Joakim Tjernlund wrote: > > Here are two versions Generally, it's a bad idea to put two patches in one mail. You should instead have two separate emails, one for each patch. Chip

1 0

Re: [PATCH 1/2] tools: Added a script to build BMPs from SVGs
by Alexandre Julliard May 4, 2010

May 4, 2010

Joel Holdsworth <joel(a)airwebreathe.org.uk> writes: > Signed-off-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> > --- > Make.rules.in | 5 +-- > tools/buildbitmap | 90 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 92 insertions(+), 3 deletions(-) > create mode 100755 tools/buildbitmap This could go in the buildicon script, most of the code is the same. -- Alexandre Julliard julliard(a)winehq.org

1 0

Winebuild b0rken on Mac OS X?
by Charles Davis May 4, 2010

May 4, 2010

While building Wine (latest git) on Mac OS X, I noticed this: /usr/bin/nm: object: amstream_test.MDsdpi.o malformed object (LC_SEGMENT command 0 filesize field greater than vmsize field) Undefined symbols: "_GetDesktopWindow", referenced from: _func_amstream in amstream.o "_TlsGetValue", referenced from: _get_tls_data in testlist.o "_MultiByteToWideChar", referenced from: _func_amstream in amstream.o _func_amstream in amstream.o "_CloseHandle", referenced from: _func_amstream in amstream.o "_TlsSetValue", referenced from: _get_tls_data in testlist.o "_DirectDrawCreate", referenced from: _func_amstream in amstream.o "_CoCreateInstance", referenced from: _create_ammultimediastream in amstream.o "_WaitForSingleObject", referenced from: _winetest_wait_child_process in testlist.o "_CoInitializeEx", referenced from: _func_amstream in amstream.o "_HeapAlloc", referenced from: _get_tls_data in testlist.o "_CoUninitialize", referenced from: _func_amstream in amstream.o _func_amstream in amstream.o "_GetExitCodeProcess", referenced from: _winetest_wait_child_process in testlist.o "_GetEnvironmentVariableA", referenced from: _main in testlist.o _main in testlist.o _main in testlist.o _main in testlist.o "_ExitProcess", referenced from: _exit_process in testlist.o ___wine_spec_exe_entry in libwinecrt0.a(exe_entry.o) "_CreateFileA", referenced from: _func_amstream in amstream.o _func_amstream in amstream.o "_TlsAlloc", referenced from: _run_test in testlist.o ld: symbol(s) not found collect2: ld returned 1 exit status winegcc: gcc failed make[1]: *** [amstream_test.exe.so] Error 2 make: *** [dlls/amstream/tests] Error 2 Something's gone horribly wrong. Winebuild shouldn't be generating b0rken Mach-O files. What gives?

2 3

Re: [12/13]docs/wineusr: unix paths are supported
by Austin English May 4, 2010

May 4, 2010

2010/5/4 André Hentschel <nerv(a)dawncrow.de>: > --- > en/wineusr-running.sgml | 8 ++++++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/en/wineusr-running.sgml b/en/wineusr-running.sgml > index f36383f..106be37 100644 > --- a/en/wineusr-running.sgml > +++ b/en/wineusr-running.sgml > @@ -90,8 +90,8 @@ Usage: wine PROGRAM [ARGUMENTS...] Run the specified program > in the <parameter>Path</parameter> environment variable, you can > simply give the executable file name. However, if the executable > is not in <parameter>Path</parameter>, you must give the full path to > - the executable (in Windows format, not UNIX format!). For > - example, given a <parameter>Path</parameter> of the following: > + the executable. For example, given a <parameter>Path</parameter> > + of the following: > </para> > <screen> > Path="c:\windows;c:\windows\system;e:\;e:\test;f:\" > @@ -112,7 +112,11 @@ Path="c:\windows;c:\windows\system;e:\;e:\test;f:\" > </screen> > <para> > (note the backslash-escaped "\" !) > + or: > </para> > + <screen> > +<prompt>$</prompt> <userinput>wine ~/.wine/drive_c/myapps/foo.exe</userinput> > + </screen> > <para> > For details on running text mode (CUI) executables, read the > <link linkend="CUI-programs">section</link> below. > -- A lot of programs break when using Unix paths. I don't think we should encourage it. Perhaps instead put an example using wine start /unix. -- -Austin

2 1

Re: gdi32: Fix underline and strikeout for clipped to the rectangle text
by Alexandre Julliard May 4, 2010

May 4, 2010

Ilya Shpigor <shpigor(a)etersoft.ru> writes: > There is bug with underline and strikeout font in ExtTextOutW. > > The text is clipped if the ETO_CLIPPED flag have been set and rectangle > smaller then needed for text. But underline and strikeout lines is drawed > same as when text fit in the rectangle. > > The problem screenshot (wine below): > http://bugs.etersoft.ru/attachment.cgi?id=1678 > > I suggest to check if the y coordinate of line is smaller then text rectangle > bottom. That's of course not sufficient for correct clipping. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Valgrind's wine_cp_wcstombs warnings
by Jordan Ayers May 4, 2010

May 4, 2010

> Hi, > > running the MCI tests with Valgrind generates a lot of output like follows > > ==13170== Use of uninitialised value of size 4 > ==13170== at 0x4035369: wine_cp_wcstombs (wctomb.c:147) > ...[every line from 148 to 161] > ==13170== Use of uninitialised value of size 4 > ==13170== at 0x403550A: wine_cp_wcstombs (wctomb.c:162) > > I suspect the A<->W mapping is still not fully correct (I know at > least one more case, but I'm not sure it gets triggered by the tests) > but perhaps it's also the W->UNIX.UTF-8 conversions internal to Wine > which cause these hits. How do I tell? > > Is there any way to get more precise reporting for the above messages > (e.g. a backtrace)? The present output is not helpful at identifying > the origin of the uninitialised read. > > Perhaps Valgrind is broken? Why does it mention "size 4" when all > access in the offending function is either "char *" or "short *" > according to the source > http://source.winehq.org/source/libs/wine/wctomb.c#L145 ? > > Thanks for your help, > Jörg Höhle Joerg, If you're on a 32-bit system, your pointers would be where the 'size 4' is coming from. It looks like Valgrind thinks a pointer being dereferenced isn't initialized. (maybe src?) Jordan Ayers

1 0

Re: [3/3] rundll32: Recognize entry points passed as ordinal numbers. (try 2)
by Alexandre Julliard May 4, 2010

May 4, 2010

Andrew Nguyen <anguyen(a)codeweavers.com> writes: > @@ -119,30 +119,43 @@ static FARPROC16 get_entry_point16( HINSTANCE16 inst, LPCWSTR entry ) > static void *get_entry_point32( HMODULE module, LPCWSTR entry, BOOL *unicode ) > { > void *ret; > - DWORD len = WideCharToMultiByte( CP_ACP, 0, entry, -1, NULL, 0, NULL, NULL ); > - char *entryA = HeapAlloc( GetProcessHeap(), 0, len + 1 ); > - > - if (!entryA) > - return NULL; > > - WideCharToMultiByte( CP_ACP, 0, entry, -1, entryA, len, NULL, NULL ); > + /* determine if the entry point is an ordinal */ > + if (entry[0] == '#') > + { > + int ordinal = atoiW( entry + 1 ); > + if (ordinal <= 0) > + return NULL; You don't set the unicode flag in this case. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wined3d: Fix some complaints in d3d9 texture test
by Henri Verbeet May 4, 2010

May 4, 2010

2010/5/4 Ričardas Barkauskas <miegalius(a)gmail.com>: > Fixes some GL_INVALID_ENUM fixmes in d3d9 texture tests and bug 11167. > Why are you setting GL_GENERATE_MIPMAP_SGIS?

2 1

Re: [PATCH 4/5] d3d9/tests: Allow D3DFMT_A2R10G10B10 as supported adapter mode.
by testbot＠testbot.winehq.org May 3, 2010

May 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1890 Your paranoid android. === W7PRO (32 bit device) === device.c:2442: Test failed: Expected foreground window 00020142, got 00010040. device.c:2578: Test failed: Expected foreground window 00030142, got 00010040.

1 0

Re: [1/2] dlls/crypt32: implement PFXImportCertStore()
by Juan Lang May 3, 2010

May 3, 2010

Hi Phillippe, this attempt looks pretty incomplete. First off: + ret = pPKCS12_verify_mac(pkcs12, password, len); + if (ret == 0) + ERR_(crypt)("failed to verify pkcs12 {%p} with password \"%s\" using func {%p}\n", pkcs12, password, pPKCS12_verify_mac); + else + TRACE_(crypt)("verified pkcs12 {%p} with password \"%s\" using func {%p}\n", pkcs12, password, pPKCS12_verify_mac); You accept the PKCS12 file even if the password is incorrect. This is clearly wrong. + /* extract private key and certificate */ + ret = pPKCS12_parse(pkcs12, password, &pkey, &cert, NULL); You don't support more than a single certificate in the PKCS12 file. This may be fine for the majority of uses, but at least a warning indicating more certificates are present would be helpful. Also, a PKCS12 file can contain more than just certificates, and the tests ought at least to check this. For example, what about a PKCS12 file with a CRL in it? OpenSSL also supports at least a couple of attributes associated with the certificates. From the man page for PKCS12_parse: The friendlyName and localKeyID attributes (if present) on each certificate will be stored in the alias and keyid attributes of the X509 structure. The Crypto API also supports setting such attributes, and if you aren't going to support these, at least the tests should cover them (and marked todo_wine) so we know they're still not done. More questions: + const WCHAR storeName[] = {'S', 't', 'o', 'r', 'e', ' ', 'N', 'a', 'm', 'e', 0}; + store = CertOpenStore(CERT_STORE_PROV_MEMORY, 0, (HCRYPTPROV)NULL, CERT_STORE_CREATE_NEW_FLAG, storeName); What's the purpose of the store name? Does the native implementation do this? If not, it can be omitted. If so, the tests should check it. Thanks, --Juan

2 5

[PATCH] RegisterWaitForSingleObject() fix special tmo == 0 case.
by Joakim Tjernlund May 3, 2010

May 3, 2010

At http://msdn.microsoft.com/en-us/library/aa332406%28VS.71%29.aspx one can read: "If the timeOutInterval parameter is not zero (0) and the executeOnlyOnce parameter is false, the timer is reset every time the event is signaled or the time-out interval elapses." timeOutInterval == 0 makes the above false and the timer should NOT be reset, fix that. Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund(a)transmode.se> --- Forget the earlier patches, this feels like the right fix. dlls/ntdll/threadpool.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/ntdll/threadpool.c b/dlls/ntdll/threadpool.c index 44afb01..f6c9fb4 100644 --- a/dlls/ntdll/threadpool.c +++ b/dlls/ntdll/threadpool.c @@ -377,7 +377,8 @@ static DWORD CALLBACK wait_thread_proc(LPVOID Arg) wait_work_item->Callback( wait_work_item->Context, TimerOrWaitFired ); wait_work_item->CallbackInProgress = FALSE; - if (wait_work_item->Flags & WT_EXECUTEONLYONCE) + if (!wait_work_item->Milliseconds || + wait_work_item->Flags & WT_EXECUTEONLYONCE) break; } else -- 1.6.4.4

1 0

Why reserve space below 2G without preloader? wrt. patch 1aa749d & bug 22033
by Johann "Myrkraverk" Oskarsson May 3, 2010

May 3, 2010

Hi all, Out of sheer curiousity, why is it important to reserve space below 2G when there is no preloader? Patch 1aa749d, is libwine: Reserve some low memory space even without a preloader. has the comment: /* if we don't have a preloader, try to reserve some space below 2Gb */ and is the regression for bug 22033. http://bugs.winehq.org/show_bug.cgi?id=22033 I will be trying to determine the excact cause of the bug later. Johann

3 2

Re: [2/5] rundll32: Fail if a rundll32 window cannot be created.
by Alexandre Julliard May 3, 2010

May 3, 2010

Andrew Nguyen <anguyen(a)codeweavers.com> writes: > --- > programs/rundll32/rundll32.c | 16 +++++++++++++--- > 1 files changed, 13 insertions(+), 3 deletions(-) This will prevent initializing the prefix without an X display. Why do you need this? -- Alexandre Julliard julliard(a)winehq.org

2 1

Valgrind's wine_cp_wcstombs warnings
by Joerg-Cyril.Hoehle＠t-systems.com May 3, 2010

May 3, 2010

Hi, running the MCI tests with Valgrind generates a lot of output like follows ==13170== Use of uninitialised value of size 4 ==13170== at 0x4035369: wine_cp_wcstombs (wctomb.c:147) ...[every line from 148 to 161] ==13170== Use of uninitialised value of size 4 ==13170== at 0x403550A: wine_cp_wcstombs (wctomb.c:162) I suspect the A<->W mapping is still not fully correct (I know at least one more case, but I'm not sure it gets triggered by the tests) but perhaps it's also the W->UNIX.UTF-8 conversions internal to Wine which cause these hits. How do I tell? Is there any way to get more precise reporting for the above messages (e.g. a backtrace)? The present output is not helpful at identifying the origin of the uninitialised read. Perhaps Valgrind is broken? Why does it mention "size 4" when all access in the offending function is either "char *" or "short *" according to the source http://source.winehq.org/source/libs/wine/wctomb.c#L145 ? Thanks for your help, Jörg Höhle

1 0

Re: ddraw: Fix missing D3D misc caps
by Stefan Dösinger May 3, 2010

May 3, 2010

Am 02.05.2010 um 22:07 schrieb Ričardas Barkauskas: > Fixes missing D3D misc caps needed by Independence War 2: Edge Of Chaos (bug 7012) The patch seems ok

1 0

Re: [ddraw] Fix discrepancy in alpha mask for WINED3DFMT_B2G3R3A8_UNORM.
by Stefan Dösinger May 3, 2010

May 3, 2010

Am 02.05.2010 um 08:26 schrieb Vincent Pelletier: > > PixelFormat_DD2WineD3D returns WINED3DFMT_B2G3R3A8_UNORM when alpha mask > is 0xFF00, which is consistent with constant name (A8). The patch looks ok to me.

1 0

Re: [PATCH] Fix Unicode escape string occurring when calling GetClipboardData(CF_TEXT).
by Dmitry Timoshkov May 3, 2010

May 3, 2010

Sin-ta Hsiea <ibmibmibm.tw(a)gmail.com> wrote: > Here's a patch that fetch UTF8 string, and convert to local codepage. > + count = WideCharToMultiByte(CP_OEMCP, 0, lpwstr, -1, NULL, 0, NULL, NULL); > + hText = GlobalAlloc(GMEM_MOVEABLE | GMEM_DDESHARE, count); > + > + if (hText) > + { > + CHAR *text = GlobalLock(hText); > + WideCharToMultiByte(CP_OEMCP, 0, lpwstr, -1, text, -1, NULL, NULL); > + GlobalUnlock(hText); > + } CP_OEMCP is not a local codepage. -- Dmitry.

1 0

Re: [Wine] Potential bug in RtlRegisterWait()
by Joakim Tjernlund May 3, 2010

May 3, 2010

Charles Davis <cdavis(a)mymail.mines.edu> wrote on 2010/05/03 01:18:25: > > On 5/2/10 3:02 PM, Joakim Tjernlund wrote: > > > > Noticed that RtlRegisterWait() will approve a zero timeout value(Milliseconds == 0) > > > > This makes ies4linux spin the CPU 100% when visiting a > > https page. The below crude patch fixes it: > > > > --- dlls/ntdll/threadpool.c.org 2010-05-02 22:37:08.000000000 +0200 > > +++ dlls/ntdll/threadpool.c 2010-05-02 22:46:45.000000000 +0200 > > @@ -427,6 +427,9 @@ > > > > TRACE( "(%p, %p, %p, %p, %d, 0x%x)\n", NewWaitObject, Object, Callback, > Context, Milliseconds, Flags ); > > > > + if (!Milliseconds) > > + return RPC_NT_INVALID_TIMEOUT; > > + > > wait_work_item = RtlAllocateHeap( GetProcessHeap(), 0, sizeof(*wait_work_item) ); > > if (!wait_work_item) > > return STATUS_NO_MEMORY; > > > > On a related note, whitout this patch wineserver also goes into an endless > > loop, doing brk() calls over and over until memory is exausted. Seems > > like a bug that too. > This looks like something you should post to wine-devel. Right, posting there but with a new patch. I think the orginal fix was wrong. Here is a new one: >From 2f5e169e286265bb82b17f76023c463bc2a96703 Mon Sep 17 00:00:00 2001 From: Joakim Tjernlund <Joakim.Tjernlund(a)transmode.se> Date: Mon, 3 May 2010 09:03:09 +0200 Subject: [PATCH] RegisterWaitForSingleObjectX(), fix tmo == 0 Timeout == 0 is special, from the manual: The time-out interval, in milliseconds. The function returns if the interval elapses, even if the object's state is nonsignaled. If dwMilliseconds is zero, the function tests the object's state and returns immediately. If dwMilliseconds is INFINITE, the function's time-out interval never elapses. 1) Only call Callback iff signaled 2) Implies WT_EXECUTEONLYONCE. 3) Callback should be called before returning. This is a crude fix not impl. 3) but is enough to get ies4linux around the 100% CPU problem. Not sure tmo == 0 implies returning a NULL ptr for phNewWaitObject too. --- dlls/ntdll/threadpool.c | 14 ++++++++++---- 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/dlls/ntdll/threadpool.c b/dlls/ntdll/threadpool.c index 44afb01..159baee 100644 --- a/dlls/ntdll/threadpool.c +++ b/dlls/ntdll/threadpool.c @@ -373,11 +373,17 @@ static DWORD CALLBACK wait_thread_proc(LPVOID Arg) wait_work_item->Context ); TimerOrWaitFired = TRUE; } - wait_work_item->CallbackInProgress = TRUE; - wait_work_item->Callback( wait_work_item->Context, TimerOrWaitFired ); - wait_work_item->CallbackInProgress = FALSE; + /* Milliseconds == 0 is special, only call Callback iff + signaled and treat as WT_EXECUTEONLYONCE */ + if (wait_work_item->Milliseconds || !TimerOrWaitFired) + { + wait_work_item->CallbackInProgress = TRUE; + wait_work_item->Callback( wait_work_item->Context, TimerOrWaitFired ); + wait_work_item->CallbackInProgress = FALSE; + } - if (wait_work_item->Flags & WT_EXECUTEONLYONCE) + if (!wait_work_item->Milliseconds || + wait_work_item->Flags & WT_EXECUTEONLYONCE) break; } else -- 1.6.4.4

1 0

Re: localspl/tests: Improve the tests in test_XcvDataPort_AddPort by properly checking return values and avoiding a duplicat
by testbot＠testbot.winehq.org May 3, 2010

May 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1881 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0