February 2011 - Wine-Devel - list.winehq.org

Re: gdi32: Fix the glyph rotation transformation matrix.
by Alexander Kochetkov Feb. 24, 2011

Feb. 24, 2011

Hi, Dmitry Timoshkov! The patch brakes rotation for modes with positive axis. Try apply this patch to the test application attached to the bug #22996.

1 1

Re: kernel32/tests: remove win9x hacks
by Paul Vriens Feb. 24, 2011

Feb. 24, 2011

On 02/23/2011 10:15 AM, Austin English wrote: > SetLastError(0xdeadbeef); > ret = GetFullPathNameW(NULL, 0, NULL, NULL); I think you can get rid of the above two as well as they are merely used to trigger the ERROR_CALL_NOT_IMPLEMENTED. > - is_win9x = !ret&& GetLastError() == ERROR_CALL_NOT_IMPLEMENTED; > - > - if (is_win9x) > - win_skip("Skipping some tests that cause GetFullPathNameA to crash on Win9x\n"); -- Cheers, Paul.

4 3

Apologies to the List
by James McKenzie Feb. 24, 2011

Feb. 24, 2011

First, my tirade was not intended to be as such. I wanted to pull the patch because it was incorrect and I did not want anyone else working on it while I silently trimmed it and made it better. Second, I realize this has affected my 'Jeremy White' score. I hope that AJ understands why the code was pulled and that this happens frequently with a project this large. I am aware that the code was placed into the LGPL at the time it was posted to Wine Patches. Third, I will be posting here three patches for riched20/test/editor.c. It is my desire that these patches be examined, with a critical eye and feedback applied. Be brutal, be blunt and most of all be helpful. If I write back that I don't understand what you are talking about, I really don't and may need additional guidance (examples, pointing out other code with a similar purpose.) This is how we grow and learn. Very respectfully, James McKenzie

3 5

Re: include: Add an errno number
by Alexandre Julliard Feb. 23, 2011

Feb. 23, 2011

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -23,6 +23,7 @@ > > # define EPERM 1 > # define ENOENT 2 > +# define ENOFILE ENOENT I don't see that in the MS headers. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/2] user32: make DIB_GetBitmapInfo checks stricter
by Alexandre Julliard Feb. 23, 2011

Feb. 23, 2011

Wolfram Sang <wolfram(a)the-dreams.de> writes: > @@ -988,6 +988,9 @@ static void test_LoadImage(void) > bmpimage[0x18]++; /* biWidth > 65535 */ > test_LoadImageFile("BMP (too wide)", bmpimage, sizeof(bmpimage), "bmp", 0); > bmpimage[0x18]--; > + bmpimage[0x11]++; /* biSize > 2^24 */ > + test_LoadImageFile("BMP (broken biSize)", bmpimage, sizeof(bmpimage), "bmp", 0); > + bmpimage[0x11]--; That's not a very convincing test. You should test more interesting sizes like intermediate values, off-by-one, etc. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: avicap32: Use define instead of hardcoded value
by André Hentschel Feb. 23, 2011

Feb. 23, 2011

sry, please ignore that one. -- Best Regards, André Hentschel

1 0

Re: comctl32: Add missing break (Coverity)
by Nikolay Sivov Feb. 23, 2011

Feb. 23, 2011

On 2/23/2011 19:28, Amine Khaldi wrote: > CIDs 1581 and 1583. > @@ -1852,6 +1852,7 @@ COMBOEX_EditWndProc (HWND hwnd, UINT uMsg, > WPARAM wParam, LPARAM lParam, > > case VK_UP: > step = -1; > + break; > case VK_DOWN: > /* by default, step is 1 */ > oldItem = SendMessageW (infoPtr->hwndSelf, CB_GETCURSEL, 0, 0); This is wrong. > @@ -2297,6 +2297,7 @@ static LRESULT > TOOLBAR_Cust_AvailDragListNotification(const CUSTDLG_INFO *custIn > TOOLBAR_Cust_AddButton(custInfo, hwnd, nIndexFrom, nIndexTo); > } > } > + break; > case DL_CANCELDRAG: > /* Clear drag arrow */ > DrawInsert(hwnd, hwndList, -1); Why? Looks to me it's fine to clear on dropped case too. Coverity is a bit paranoid about missed breaks. Also don't include completely unrelated changes to one patch. > > Regards, > Amine. > > >

3 4

Re: d3dcompiler_43: Add missing break (Coverity)
by Matteo Bruni Feb. 23, 2011

Feb. 23, 2011

2011/2/23 Amine Khaldi <amine.khaldi(a)reactos.org>: > CID 1585. > > Regards, > Amine. > This doesn't seem to be the correct fix. With that break you aren't going to return any string and that will cause problems thereafter. You should replace the "case 2:" with "default:" instead (like BWRITERSPR_RASTOUT some rows above). BTW, thanks for the patches!

1 0

Re: gdi32: first look for a printer driver name in the registry (try 3)
by Dmitry Timoshkov Feb. 23, 2011

Feb. 23, 2011

Vitaly Perov <vitperov(a)etersoft.ru> wrote: > + if (!hKey) RegCloseKey(hKey); This is a typo. -- Dmitry.

1 0

Re: [PATCH] user32: remove side effect code out of asserts() (Coverity)
by Marvin Feb. 23, 2011

Feb. 23, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9432 Your paranoid android. === WINEBUILD (build) === Make failed

1 0