June 2011 - Wine-Devel - list.winehq.org

Re: [2/2] advapi32: Use an architecture neutral structure to marshall service status information.
by Alexandre Julliard June 10, 2011

June 10, 2011

Hans Leidekker <hans(a)codeweavers.com> writes: > ENUM_SERVICE_STATUSW and ENUM_SERVICE_STATUS_PROCESSW embed pointers so we cannot > use these structures on Wow64, where the service manager runs as a 64-bit process and > the querying process can be 32-bit. You should still keep the proper structure layout, for instance by using LONG_PTRs instead. You definitely don't want to make two server calls for every request. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/5] msi: Pass the full custom action command to CreateProcess.
by Alexandre Julliard June 10, 2011

June 10, 2011

Hans Leidekker <hans(a)codeweavers.com> writes: > @@ -772,10 +772,22 @@ static HANDLE execute_command( const WCHAR *exe, WCHAR *arg, const WCHAR *dir ) > { > STARTUPINFOW si; > PROCESS_INFORMATION info; > + int len; > + WCHAR *cmd; > BOOL ret; > > + len = strlenW( exe ); > + if (arg) len += strlenW( arg ) + 1; > + if (!(cmd = msi_alloc( (len + 1) * sizeof(WCHAR) ))) return INVALID_HANDLE_VALUE; > + strcpyW( cmd, exe ); > + if (arg) > + { > + strcatW( cmd, szSpace ); > + strcatW( cmd, arg ); > + } > memset( &si, 0, sizeof(STARTUPINFOW) ); > - ret = CreateProcessW( exe, arg, NULL, NULL, FALSE, 0, NULL, dir, &si, &info ); > + ret = CreateProcessW( NULL, cmd, NULL, NULL, FALSE, 0, NULL, dir, &si, &info ); You should still pass the exe name to CreateProcess in addition to the command line. You probably also want to quote it in the command line if it contains spaces. Also some callers pass a NULL exe. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [5/5] msi: Implement and test MsiSetFeatureAttributes.
by Marvin June 10, 2011

June 10, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11595 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5979: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [4/5] msi: Implement and test MsiGetFeatureInfo.
by Marvin June 10, 2011

June 10, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11594 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5979: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [1/2] d3dx9/test: Add UpdateSemantics test. (try 2)
by Stefan Dösinger June 9, 2011

June 9, 2011

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Looks ok to me Am 09.06.2011 um 17:50 schrieb Michael Mc Donnell: > Removed a superfluous test. > Added NULL check before releasing mesh. > Changed struct declaration style. > Changed the struct declaration style again. > --- > dlls/d3dx9_36/tests/mesh.c | 279 ++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 279 insertions(+), 0 deletions(-) > <0001-d3dx9-test-Add-UpdateSemantics-test.patch> -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJN8VlIAAoJEN0/YqbEcdMw9a0P/R7/63zSoVb7sig95T+WQDDX HkASb2vhp9dgs65zNCA6Vm6mCqPh62aNa3IKThtrVRQcPmmPFndgz8KmHXHzYZMj 6aQsiaa+vL4Yf4qcub+KwMej/S/A5txmVuXmOtreqJAGAKL6B/QA59KKw46JAlHT 15hggvXCHx0HaMBOP+bhcAlEOCI1QMZb1ygkzOILZ6ooy+0gOfOzSfl20Fk4Iy6X fPNhtE+goV6tYnP8I1hJEBg2TFPlN1YF25SxFJ/CIcHaJHYGAAL8LquMciVOdZ1C KsSrQzFFBw9fySvZC8rkaMAW5jIg27njRs4QB2CGEd5OkFc4I2KqZ4f1EwS/zdHp hAlvJmSRzB7Tq08ToW1a2ebX6dHyNfLinCKKpsmo5jk4V1FVN2DTWjsQs/mCIbCF EoUF0/NyIJHocOa71IV1Xj5uN7dvcZyqrJ3ZBVwDKU4o6G7uIDus0gbTVpliqty/ aBcvhwtHx6donMVt+KqPpM23tvomCr553fw93lCbB55vdZvjUUcWY5lL1HDp7qbI lkwz6aNjUhsA21u7uqANnThqm25pXLElnYR8O6LuU3AfsdkJAodK5JZ6/50aleI9 t3/Ke6ugHeywrpvXJVVzzJT3cOqsF0lQBvGegOYlSCdHm1MxtVDpdP1M2wKMce0z 2eXYa2k0EP7H0oMVERbP =WyeT -----END PGP SIGNATURE-----

1 0

Re: setupapi: Make sure machine name is non-empty before failing (try 2)
by Marvin June 9, 2011

June 9, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11589 Your paranoid android. === WNT4WSSP6 (32 bit devinst) === No test summary line found

1 0

Re: setupapi: Make sure machine name is non-empty before failing
by Dmitry Timoshkov June 9, 2011

June 9, 2011

Juan Lang <juan.lang(a)gmail.com> wrote: > +static const WCHAR emptyW[] = { 0 }; ... > - if (MachineName != NULL) > + if (MachineName != NULL && strcmpW(MachineName, emptyW)) What's wrong with 'if (MachineName && *MachineName)' ? -- Dmitry.

2 1

re: TaskDialog implementation
by Dan Kegel June 9, 2011

June 9, 2011

Patrick wrote: > I'd like to port my re-implementation of task dialogs > (http://www.korosoft.net/projects/tdemu/) to WINE Awesome! > I would like to have some guidance ... [Why was my patch from > yesterday not accepted?] An iota of guidance was provided at http://source.winehq.org/patches/ Scroll down to your patch, you can see it's in "Pending" state. Scroll down further, you'll see that "Pending" means "The patch is not obviously correct at first glance. Making a more convincing argument, preferably in the form of a test case, may help." See also http://wiki.winehq.org/SubmittingPatches for a generic checklist. Your patch seemed to do three things: - moving old stub into new file - adding a TaskDialog function - adding ordinals Those three things could all be separate patches, and some of them could have tests. I'd suggest sending just one of the three first (probably not the one that moves code to a new file), and including a test with the first patch. - Dan

1 0

Re: [1/2] d3dx9/test: Add UpdateSemantics test.
by Stefan Dösinger June 9, 2011

June 9, 2011

On Wednesday 08 June 2011 18:51:41 Michael Mc Donnell wrote: > unsigned int faces[] = {0, 1, 2}; > unsigned int num_faces = sizeof(faces) / 3; Does this do what you want? As far as I can see you want ARRAY_SIZE(faces) / 3. > + struct { > + D3DXVECTOR3 position0; > + D3DXVECTOR3 position1; > + D3DXVECTOR3 normal; > + DWORD color; > + } vertices[] = { > ... Another style nitpick: Bracket placing. > + /* Two null pointers. Setting only the mesh to null will result in an > + * exception on Windows. > + */ > + hr = mesh->lpVtbl->UpdateSemantics(NULL, NULL); I think setting the instance pointer to NULL when invoking a method doesn't need a test, it will give you odd results. What you show here is that native checks the only method parameter before it accesses the object instance. Remember, usually apps will invoke this via C++: mesh->UpdateSemantics(declaration); Similarly it isn't necessary to check iface or This against NULL in the implementations. Otherwise this looks OK

4 6

Re: [PATCH 2/2] urlmon: Added empty file binding test
by Marvin June 9, 2011

June 9, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11581 Your paranoid android. === WVISTAADM (32 bit protocol) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH 1/4] shell32/tests: basic tests of IKnownFolderManager
by Vincent Povirk June 9, 2011

June 9, 2011

+ OleInitialize(NULL); Any particular reason you're using this instead of CoInitialize? I don't think there's anything wrong with it, but CoInitialize is more common. + todo_wine + ok(cat==KF_CATEGORY_FIXED, "invalid folder category: %d\n", cat); You'd be using cat uninitialized when the function is not implemented in Wine. I suggest initializing it to 0 or something. Same with redirectionCapabilities later. + ok(lstrcmpW(sWinDir, folderPath)==0, "invalid path returned: %s\n", wine_dbgstr_w(folderPath)); It might be useful to print sWinDir as well. If there's some situation where it's the right path but not quite the same string, that'd be good to know. + /* try to set new path */ + hr = IKnownFolder_SetPath(folder, 0, sTempDir); + todo_wine + ok(hr == S_OK, "setting path failed: 0x%08x\n", hr); I'd suggest making up + registering your own known folder to test this feature, rather than using a standard one. I worry someone could end up with a broken Windows install if we fail to put it back somehow.

2 1

Re: [2/2] d3dx9: Implement UpdateSemantics mesh method.
by Marvin June 8, 2011

June 8, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11567 Your paranoid android. === WXPPROSP3 (32 bit mesh) === mesh: unhandled exception c0000005 at 0042EA43 === W2K3R2SESP2 (32 bit mesh) === mesh: unhandled exception c0000005 at 0042EA43 === WVISTAADM (32 bit mesh) === mesh: unhandled exception c0000005 at 0042EA43 === W2K8SE (32 bit mesh) === mesh: unhandled exception c0000005 at 0042EA43 === W7PRO (32 bit mesh) === mesh: unhandled exception c0000005 at 0042EA43 === W7PROX64 (32 bit mesh) === mesh: unhandled exception c0000005 at 0042EA43 === W7PROX64 (64 bit mesh) === Timeout

1 0

Simple Windows Diaglogue App
by Lewis McLean June 8, 2011

June 8, 2011

Hi, I'm trying to compile a simple windows dialogue app over to run on *nix with winelib. I'm looking at it as proof of concept for porting a larger application over. I've been getting errors from gcc to do with vc++ casting, where it loses precision. LinuxPort.cpp: In function 'int WinMain(HINSTANCE__*, HINSTANCE__*, CHAR*, int)': LinuxPort.cpp:34: error: cast from 'CHAR*' to 'WORD' loses precision LinuxPort.cpp:39: error: cast from 'CHAR*' to 'WORD' loses precision winegcc: i486-linux-gnu-g++ failed Ive tried to use static_cast<> and also c-style casting using () but can't seem to get it working. Any ideas? Thanks, Lewis

2 1

Re: [1/2] d3dx9/test: Add UpdateSemantics test.
by Marvin June 8, 2011

June 8, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11566 Your paranoid android. === WXPPROSP3 (32 bit mesh) === mesh: unhandled exception c0000005 at 0042EB8D === W2K3R2SESP2 (32 bit mesh) === mesh: unhandled exception c0000005 at 0042EB8D === WVISTAADM (32 bit mesh) === mesh: unhandled exception c0000005 at 0042EB8D === W2K8SE (32 bit mesh) === mesh: unhandled exception c0000005 at 0042EB8D === W7PRO (32 bit mesh) === mesh: unhandled exception c0000005 at 0042EB8D === W7PROX64 (32 bit mesh) === mesh: unhandled exception c0000005 at 0042EB8D === W7PROX64 (64 bit mesh) === Timeout

1 0

re: Simple Windows Diaglogue App
by Dan Kegel June 8, 2011

June 8, 2011

Lewis wrote: > I'm trying to compile a simple windows dialogue app over to run on *nix > with winelib. I'm looking at it as proof of concept for porting a larger > application over. First off, why winelib rather than plain wine? Are you planning on targeting non-x86 computers? > LinuxPort.cpp:34: error: cast from 'CHAR*' to 'WORD' loses precision It might help to see your source code. - Dan

1 0

mmdevapi event driven (aka. pull) mode
by Joerg-Cyril.Hoehle＠t-systems.com June 8, 2011

June 8, 2011

Hi, >What behavior do you think Wine is going to do wrong Matthew van Eerde's web log has a sample silence playing application using EVENTCALLBACK mode. http://blogs.msdn.com/b/matthew_van_eerde/archive/2008/12/10/sample-playing… Running it in Wine shows that Wine violates the assumption/invariant/guarantee IMHO Event signaled => there's room in the buffer -- much like winmm's MOM_DONE signals that a buffer is free. I don't know when the first event is signaled nor at what rate they are signaled. (Perhaps one is signaled every time one of the mixer's 10ms chunks is processed?). The app immediately complains and exits. Wine's mmdevapi current unconditional and periodic SetEvent does not match the above program's expectations (nor would it match exclusive mode behaviour: event => complete buffer free for writing). A periodic 10ms event may be fine when playing goes smooth, but that's not the case right at the beginning, esp. when filling the buffer before calling Start. I should turn that into a distinct bug report. Regards, Jörg Höhle

1 0

Re: [4/4] d3dx9/tests: Add tests for D3DXLoadMeshFromXInMemory.
by Marvin June 7, 2011

June 7, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11553 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: [PATCH 5/5] wined3d: Rename IWineD3DDeviceImpl_LoadLogo() to device_load_logo().
by Stefan Dösinger June 7, 2011

June 7, 2011

On Tuesday 07 June 2011 19:44:49 Henri Verbeet wrote: > if (wined3d_settings.logo) > - IWineD3DDeviceImpl_LoadLogo(device, wined3d_settings.logo); > + device_load_logo(device, wined3d_settings.logo); Does the logo stuff still work? I thought about removing it, I don't think it has any use. The original intentions were for debugging(Is wined3d used on Windows?) and for making nice and fancy screenshots, but I don't think anyone uses it.

2 1

Re: [6/7] server: Implement RegisterHotKey/UnregisterHotKey.
by Marvin June 7, 2011

June 7, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11551 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [5/7] user32: Do not check the last error on succeeding hotkey calls.
by Marvin June 7, 2011

June 7, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11550 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [4/7] user32: Test registering the same hotkey hwnd/id pair twice.
by Marvin June 7, 2011

June 7, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11549 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [3/7] user32: Add test showing hotkeys change the async key state.
by Marvin June 7, 2011

June 7, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11548 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [2/7] user32: Ignore paint messages in hotkey tests.
by Marvin June 7, 2011

June 7, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11547 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [1/7] user32: Add test for flags on keyboard messages.
by Marvin June 7, 2011

June 7, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11546 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Various locale tests for wine
by Akihiro Sagawa June 7, 2011

June 7, 2011

Hi, I have a problem about testing wine where specific to locales (or ANSI code pages). Because test bots don't seem to test wine in non-English locales. I'd like to get wine's test results in various locale environments from test.winehq.org. Firstly, as a wine intended to handle locale properly, all tests should succeed in any locales. We could discover locale-depended failure in other locales. Secondly, if I add a locale specific test, it easy to prove the issue to others. In my opinion, adding Russian, Japanese and Chinese would be better. They are tested by existing XP bots. So how about adding non-English wine environments to the testbot farm? -- Best Regards, Akihiro Sagawa

2 1