June 2011 - Wine-Devel - list.winehq.org

Re: d3dx9/tests: Fix comparison that expects NAN, since NAN != NAN.
by Alexandre Julliard June 28, 2011

June 28, 2011

Dylan Smith <dylan.ah.smith(a)gmail.com> writes: > @@ -4834,7 +4834,7 @@ static void test_create_skin_info(void) > for (i = 0; i < num_influences; i++) { > ok(exp_vertices[i] == vertices[i], > "influence[%d]: expected vertex %u, got %u\n", i, exp_vertices[i], vertices[i]); > - ok(exp_weights[i] == weights[i], > + ok((isnan(exp_weights[i]) && isnan(weights[i])) || exp_weights[i] == weights[i], I put this in for now to fix the tests, but isnan() isn't really portable, we should try to find a better way. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [2/2] gdiplus: Implement GdipMeasureDriverString.
by Alexandre Julliard June 27, 2011

June 27, 2011

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > From 520906b62d02cb9c886404caa03d1fcb634f574b Mon Sep 17 00:00:00 2001 > From: Vincent Povirk <vincent(a)codeweavers.com> > Date: Mon, 27 Jun 2011 13:24:39 -0500 > Subject: [PATCH 2/3] gdiplus: Implement GdipMeasureDriverString. It doesn't work here: ../../../tools/runtest -q -P wine -M gdiplus.dll -T ../../.. -p gdiplus_test.exe.so graphics.c && touch graphics.ok graphics.c:3110: Test failed: Expected 7.00, got 8.00 make: *** [graphics.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ws2_32: return an error in SO_CONNECT_TIME stub
by Dmitry Timoshkov June 27, 2011

June 27, 2011

Austin English <austinenglish(a)gmail.com> wrote: > @@ -2554,7 +2554,7 @@ INT WINAPI WS_getsockopt(SOCKET s, INT level, > } > *(DWORD*)optval = pretendtime++; > *optlen = sizeof(DWORD); > - return ret; > + return SOCKET_ERROR; > } Filling out optval and optlen but returning SOCKET_ERROR doesn't make sense. Probably Eye-Fi doesn't change the return value. What kind of socket both of the applications do pass? -- Dmitry.

2 1

Re: oleaut32: Implement ICreateTypeInfo2 SetHelpStringContext
by Michael Stefaniuc June 27, 2011

June 27, 2011

Hello Alistair, Alistair Leslie-Hughes wrote: > Changelog: > oleaut32: Implement ICreateTypeInfo2 SetHelpStringContext > > dlls/oleaut32/typelib2.c | 9 +++++++-- > 1 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/dlls/oleaut32/typelib2.c b/dlls/oleaut32/typelib2.c > index e9c7613..459547f 100644 > --- a/dlls/oleaut32/typelib2.c > +++ b/dlls/oleaut32/typelib2.c > @@ -3067,8 +3067,13 @@ static HRESULT WINAPI ICreateTypeInfo2_fnSetHelpStringContext( > ICreateTypeInfo2* iface, /* [I] The typeinfo on which to set the help string context. */ > ULONG dwHelpStringContext) /* [I] The help string context. */ > { > - FIXME("(%p,%d), stub!\n", iface, dwHelpStringContext); > - return E_OUTOFMEMORY; > + ICreateTypeInfo2Impl *This = (ICreateTypeInfo2Impl *)iface; please do not add any more of those cast but add a impl_from_ICreateTypeInfo2() helper as per the COM guidline at http://wiki.winehq.org/COMGuideline. Bonus points for doing the COM cleanup too ;) thanks bye michael

1 0

Re: [docs] winedev: A hint for patch separation
by Jerome Leclanche June 27, 2011

June 27, 2011

That sounds like we want people to avoid testing wine. How about "Patches must not break building Wine nor its testsuite. Adding dead code should also be avoided."? </bikeshed> J. Leclanche 2011/6/26 André Hentschel <nerv(a)dawncrow.de>: > --- > en/winedev-coding.sgml | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/en/winedev-coding.sgml b/en/winedev-coding.sgml > index eacf6d8..8b0f0d9 100644 > --- a/en/winedev-coding.sgml > +++ b/en/winedev-coding.sgml > @@ -207,6 +207,10 @@ code > is your friend! > </para> > <para> > + Every patch must not break building and testing Wine and > + adding dead code should be avoided. > + </para> > + <para> > Save yourself some embarrassment and run your patched code > against more than just your current test example. Experience > will tell you how much effort to apply here. If there are > -- > > Best Regards, André Hentschel > > >

2 1

Re: [PATCH 9/9] server+user32: Added GetRawInputData implementation (try 8)
by Marvin June 27, 2011

June 27, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11988 Your paranoid android. === W7PROX64 (32 bit input) === No test summary line found === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [PATCH 8/9] server+user32: Added GetRawInputBuffer implementation (try 8)
by Marvin June 27, 2011

June 27, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11987 Your paranoid android. === W7PROX64 (32 bit input) === No test summary line found === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [PATCH 7/9] server+user32: Added RegisterRawInputDevices implementation (try 8)
by Marvin June 27, 2011

June 27, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11986 Your paranoid android. === W7PROX64 (32 bit input) === No test summary line found === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [PATCH 6/9] server+user32: Added GetRegisteredRawInputDevices implementation (try 8)
by Marvin June 27, 2011

June 27, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11985 Your paranoid android. === W7PROX64 (32 bit input) === No test summary line found === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [PATCH 1/3] user32/tests: Added client-side raw input function tests (try 5 resend)
by Vincas Miliūnas June 27, 2011

June 27, 2011

On 06/22/2011 06:41 PM, André Hentschel wrote: > ... Done - http://source.winehq.org/patches/data/75767

1 0