June 2011 - Wine-Devel - list.winehq.org

Re: [2/8] dxdiag: Introduce the file output infrastructure.
by Alexandre Julliard June 13, 2011

June 13, 2011

Andrew Nguyen <anguyen(a)codeweavers.com> writes: > --- > programs/dxdiag/Makefile.in | 3 +- > programs/dxdiag/main.c | 39 +++++++++++++++++++++++++++--- > programs/dxdiag/output.c | 54 +++++++++++++++++++++++++++++++++++++++++++ > programs/dxdiag/output.h | 49 +++++++++++++++++++++++++++++++++++++++ > 4 files changed, 140 insertions(+), 5 deletions(-) Please don't add so many new files. A single header for the whole program would do, and a couple of source files should be enough considering the amount of code you have. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: cmd: add support for todo_wine constructions in testing infrastructure
by Jacek Caban June 13, 2011

June 13, 2011

Hi Frédéric, On 06/12/11 23:01, Frédéric Delanoy wrote: > - > + is_todo_wine = is_todo_wine_line(exp_ptr, exp_nl); > + There is no need to add such logic directly to test_output, this can be returned from comare_line. Jacek

2 2

Re: d3dx9: Implement GetImageInfoFromResource(A/W) for bitmaps.
by Vincent Povirk June 13, 2011

June 13, 2011

You should probably call D3DXGetImageInfoFromFileInMemory for the real work. On Sun, Jun 12, 2011 at 10:32 PM, Charles Welton <charleswfb(a)gmail.com> wrote: > The code works except it doesn't try to detect the bitmap format. > Kindly ask for review and how to properly implement this. Should > GetDIBits be used? > > -- > Charles Welton > > > >

2 1

Re: comctl32/tests: Added first TaskDialog test. (try 2)
by Marvin June 12, 2011

June 12, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11662 Your paranoid android. === WXPPROSP3 (32 bit taskdlg) === taskdlg.c:43: Test failed: COMCTL32.DLL is not loaded! === W2K3R2SESP2 (32 bit taskdlg) === taskdlg.c:43: Test failed: COMCTL32.DLL is not loaded! === W7PRO (32 bit taskdlg) === taskdlg.c:43: Test failed: COMCTL32.DLL is not loaded! === W7PROX64 (32 bit taskdlg) === taskdlg.c:43: Test failed: COMCTL32.DLL is not loaded! === W7PROX64 (64 bit taskdlg) === taskdlg.c:43: Test failed: COMCTL32.DLL is not loaded!

1 0

About building test suite for Windows
by Patrick Gauthier June 12, 2011

June 12, 2011

Hi, As I was writing my task dialog test I ran into a few problems trying to test on Windows... First, I tried building it using make crosstest but I keep getting this: $ gmake crosstest crosstest is not supported (mingw not installed?) gmake: *** [crosstest] Error 1 I am on FreeBSD 8.2-RELEASE (i386), I have the following mingw ports installed (using pkg_add) mingw32-bin-msvcrt-r3.18.a3.14 mingw32-binutils-2.21,1 mingw32-directx-20020518 mingw32-gcc-4.5.0_1,1 mingw32-pdcurses-3.4 mingw32-pthreads-2.8.0 I deleted config.status (there was no config.cache) and re-ran ./configure, it fails to detect mingw, so I gave up on that. I then tried building them on Windows directly instead (using Visual Studio 2008 with Windows SDK v7.0) as describred there: http://www.winehq.org/docs/winedev-guide/testing-windows However, trying to compile comctl32_tests using the WINE headers would complain about EXCEPTION_EXECUTE_HANDLER being undefined. On the other hand, compiling with the MSVC headers would complain about TVIS_FOCUSED not being present. According to this: http://support.microsoft.com/kb/166471 it has been deprecated and removed from MS headers a long time ago. Eventually I would like to just be able to make crosstest so that I can stay in one dev environments and not two, so if anybody could help me about why isn't mingw32 detected, I would like it. Thanks. - Patrick

5 5

Re: winealsa.drv/midi.c: Adds the midi MTC Quarter Frame messages support.
by BACRI Stephane June 12, 2011

June 12, 2011

Hi all. Was there something incorrect in this patch I submitted in may, or in the way I submitted it? Perhaps should I have mentioned that it had been tested in several ways with hardware & software. Regards. Stéphane.

2 3

Re: [PATCH] wined3d: Dont just print a FIXME on error, handle it (Coverity)
by Henri Verbeet June 11, 2011

June 11, 2011

On 11 June 2011 17:26, Marcus Meissner <marcus(a)jet.franken.de> wrote: > if (state <= HIGHEST_TRANSFORMSTATE) > + { > mat = &device->updateStateBlock->state.transforms[state]; > + } > else > + { > FIXME("Unhandled transform state %#x.\n", state); > + return WINED3D_OK; > + } > This works, so I'm not too bothered either way, but I think the following looks slightly nicer: if (state > HIGHEST_TRANSFORMSTATE) { WARN("Invalid transform state %#x.\n", state); return WINED3D_OK; } mat = &device->updateStateBlock->state.transforms[state]; multiply_matrix(&temp, mat, matrix);

1 0

Re: [PATCH 1/4] Check for null pointers before strcmp. (LLVM/Clang)
by Juan Lang June 11, 2011

June 11, 2011

Hi Lauri, ok(pdst != NULL, "inet_ntoa failed %s\n", dst); - ok(!strcmp(pdst, addr0_Str),"Address %s != %s\n", pdst, addr0_Str); + ok(pdst && !strcmp(pdst, addr0_Str),"Address %s != %s\n", pdst, addr0_Str); This change doesn't accomplish anything. In the first place, the previous ok which you did not change already ensures pdst is not NULL. While it's true that this ok could fail, leading to a following crash in the tests, the fact that the tests pass indicates this isn't happening. Second, the ok output message also dereferences pdst by printing it, so in the case that it is NULL, you haven't fixed anything. Really, I suggest you just ignore this warning, it's not worth the extra baggage. --Juan

3 3

Re: [PATCH] wined3d: Dont just print a FIXME on error, handle it (Coverity)
by Stefan Dösinger June 11, 2011

June 11, 2011

On Saturday 11 June 2011 11:17:58 Marcus Meissner wrote: > else > + { > FIXME("Unhandled transform state %#x.\n", state); > + return WINED3DERR_INVALIDCALL; > + } Please return WINED3D_OK, like wined3d_device_set_sampler_state and other setters. Native doesn't do this kind of consistency checking, so apps will get D3D_OK returned if they pass an out of range state(unless the setter segfaults).

1 0

Re: [PATCH] user32: initialize all of msg (Coverity)
by Marvin June 11, 2011

June 11, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11625 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0