June 2011 - Wine-Devel - list.winehq.org

Re: [PATCH 4/4] Make sure to use a return value. (LLVM/Clang)
by Marvin June 10, 2011

June 10, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11621 Your paranoid android. === WNT4WSSP6 (32 bit sock) === sock.c:524: Test failed: oob_server (82): received less data than expected: 2024 of 2040 === WXPPROSP3 (32 bit sock) === sock.c:524: Test failed: oob_server (70c): received less data than expected: 2024 of 2040 === W2K3R2SESP2 (32 bit sock) === sock.c:524: Test failed: oob_server (b90): received less data than expected: 2024 of 2040 === WVISTAADM (32 bit sock) === sock.c:524: Test failed: oob_server (948): received less data than expected: 2024 of 2040 === W2K8SE (32 bit sock) === sock.c:524: Test failed: oob_server (bb0): received less data than expected: 2024 of 2040 === W7PRO (32 bit sock) === sock.c:524: Test failed: oob_server (2fc): received less data than expected: 2024 of 2040 === W7PROX64 (32 bit sock) === sock.c:524: Test failed: oob_server (440): received less data than expected: 2024 of 2040 === W7PROX64 (64 bit sock) === sock.c:524: Test failed: oob_server (3ec): received less data than expected: 2024 of 2040

1 0

testbot flakiness?
by Dan Kegel June 10, 2011

June 10, 2011

https://testbot.winehq.org/JobDetails.pl?Key=11509 shows failures and crashes, but the nearly identical https://testbot.winehq.org/JobDetails.pl?Key=11510 does not. (The latter one just adds a call to GetProcessMemoryInfo() in the xyz() logging function.) And the failure shown by the first patch has a last error on creating the batch file of 8, ERROR_NOT_ENOUGH_MEMORY, which is suspicious. Not quite sure what's going on there.

2 2

Re: [1/2] d3dx9/test: Add UpdateSemantics test. (try 2)
by Dylan Smith June 10, 2011

June 10, 2011

> +static void test_update_semantics(void) > +{ > ... > + int offset = 12; sizeof(D3DXVECTOR3) might be clearer.

2 1

Re: [2/2] d3dx9: Implement UpdateSemantics mesh method. (try 2)
by Dylan Smith June 10, 2011

June 10, 2011

Your patches have dos line endings (i.e. "\r\n") which causes git apply to fail, although the patch command only gives a warning. @@ -208,6 +221,12 @@ static DWORD WINAPI > ID3DXMeshImpl_GetNumBytesPerVertex(ID3DXMesh *iface) > TRACE("iface (%p)\n", This); > + if (!This->vertex_declaration) > + { > + WARN("Can't get number of bytes per vertex of an invalid vertex > declaration.\n"); > + return E_FAIL; > + } GetNumBytesPerVertex returns a DWORD not an HRESULT, so I wouldn't expect E_FAIL to ever be returned? Unusual behaviour like this should be covered by a test. + /* An application can pass an invalid declaration to UpdateSemantics > and > + * still expect D3D_OK (see tests). If the declaration is invalid, > then > + * subsequent calls to GetDeclaration, GetNumBytesPerVertex, and > DrawSubset, > + * which use the declaration, will fail. > + */ D3DXCreateMesh fails when the declaration contains a non-zero Stream value. I would expect UpdateSemantics to be as strict as D3DXCreateMesh, otherwise a test could validate the different behaviour. You tested a declaration with larger fields, but not with the vertex size being smaller or greater. (E.g. Try removing the last field, or appending a field.) I did some testing and couldn't get GetDeclaration or GetNumBytesPerVertex to fail on windows. DrawSubset did seem to fail after UpdateSemantics is called with a declaration that causes CreateVertexDeclaration to fail. This suggests that the native implementation probably just stores the D3DVERTEXELEMENT9 array and calls CreateVertexDeclaration on DrawSubset. You can probably cache the created vertex declaration and release it on UpdateSemantics for performance.

2 1

Re: cmd: Ensure mkdir returns an error for pre-existing directories
by Marvin June 10, 2011

June 10, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11601 Your paranoid android. === WVISTAADM (32 bit) === batch: unhandled exception c0000005 at 77496FCF === W2K8SE (32 bit) === batch: unhandled exception c0000005 at 778A8915 === W7PRO (32 bit) === batch.c:70: Test failed: CreateFile failed batch: unhandled exception c0000005 at 772D3067 === W7PROX64 (32 bit) === batch.c:96: Test failed: CreateProcess failed: 1450 === W7PROX64 (64 bit) === Timeout

1 0

Re: [2/2] advapi32: Use an architecture neutral structure to marshall service status information.
by Alexandre Julliard June 10, 2011

June 10, 2011

Hans Leidekker <hans(a)codeweavers.com> writes: > ENUM_SERVICE_STATUSW and ENUM_SERVICE_STATUS_PROCESSW embed pointers so we cannot > use these structures on Wow64, where the service manager runs as a 64-bit process and > the querying process can be 32-bit. You should still keep the proper structure layout, for instance by using LONG_PTRs instead. You definitely don't want to make two server calls for every request. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/5] msi: Pass the full custom action command to CreateProcess.
by Alexandre Julliard June 10, 2011

June 10, 2011

Hans Leidekker <hans(a)codeweavers.com> writes: > @@ -772,10 +772,22 @@ static HANDLE execute_command( const WCHAR *exe, WCHAR *arg, const WCHAR *dir ) > { > STARTUPINFOW si; > PROCESS_INFORMATION info; > + int len; > + WCHAR *cmd; > BOOL ret; > > + len = strlenW( exe ); > + if (arg) len += strlenW( arg ) + 1; > + if (!(cmd = msi_alloc( (len + 1) * sizeof(WCHAR) ))) return INVALID_HANDLE_VALUE; > + strcpyW( cmd, exe ); > + if (arg) > + { > + strcatW( cmd, szSpace ); > + strcatW( cmd, arg ); > + } > memset( &si, 0, sizeof(STARTUPINFOW) ); > - ret = CreateProcessW( exe, arg, NULL, NULL, FALSE, 0, NULL, dir, &si, &info ); > + ret = CreateProcessW( NULL, cmd, NULL, NULL, FALSE, 0, NULL, dir, &si, &info ); You should still pass the exe name to CreateProcess in addition to the command line. You probably also want to quote it in the command line if it contains spaces. Also some callers pass a NULL exe. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [5/5] msi: Implement and test MsiSetFeatureAttributes.
by Marvin June 10, 2011

June 10, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11595 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5979: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [4/5] msi: Implement and test MsiGetFeatureInfo.
by Marvin June 10, 2011

June 10, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11594 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5979: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [1/2] d3dx9/test: Add UpdateSemantics test. (try 2)
by Stefan Dösinger June 9, 2011

June 9, 2011

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Looks ok to me Am 09.06.2011 um 17:50 schrieb Michael Mc Donnell: > Removed a superfluous test. > Added NULL check before releasing mesh. > Changed struct declaration style. > Changed the struct declaration style again. > --- > dlls/d3dx9_36/tests/mesh.c | 279 ++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 279 insertions(+), 0 deletions(-) > <0001-d3dx9-test-Add-UpdateSemantics-test.patch> -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJN8VlIAAoJEN0/YqbEcdMw9a0P/R7/63zSoVb7sig95T+WQDDX HkASb2vhp9dgs65zNCA6Vm6mCqPh62aNa3IKThtrVRQcPmmPFndgz8KmHXHzYZMj 6aQsiaa+vL4Yf4qcub+KwMej/S/A5txmVuXmOtreqJAGAKL6B/QA59KKw46JAlHT 15hggvXCHx0HaMBOP+bhcAlEOCI1QMZb1ygkzOILZ6ooy+0gOfOzSfl20Fk4Iy6X fPNhtE+goV6tYnP8I1hJEBg2TFPlN1YF25SxFJ/CIcHaJHYGAAL8LquMciVOdZ1C KsSrQzFFBw9fySvZC8rkaMAW5jIg27njRs4QB2CGEd5OkFc4I2KqZ4f1EwS/zdHp hAlvJmSRzB7Tq08ToW1a2ebX6dHyNfLinCKKpsmo5jk4V1FVN2DTWjsQs/mCIbCF EoUF0/NyIJHocOa71IV1Xj5uN7dvcZyqrJ3ZBVwDKU4o6G7uIDus0gbTVpliqty/ aBcvhwtHx6donMVt+KqPpM23tvomCr553fw93lCbB55vdZvjUUcWY5lL1HDp7qbI lkwz6aNjUhsA21u7uqANnThqm25pXLElnYR8O6LuU3AfsdkJAodK5JZ6/50aleI9 t3/Ke6ugHeywrpvXJVVzzJT3cOqsF0lQBvGegOYlSCdHm1MxtVDpdP1M2wKMce0z 2eXYa2k0EP7H0oMVERbP =WyeT -----END PGP SIGNATURE-----

1 0