July 2011 - Wine-Devel - list.winehq.org

Re: [PATCH 1/5] d3dx9_36: Implement D3DXHANDLE more robustly
by Henri Verbeet July 5, 2011

July 5, 2011

On 5 July 2011 23:45, Travis Athougies <iammisc(a)gmail.com> wrote: > Fixes bug 26583. > > Allows deadspace 2 to run without native dlls. This contains no useful information about what issue this is supposed to fix, unless you expect people to actually debug it themselves first. And I even went through the trouble to lookup the bug. > +static WORD new_handle_with_desc_and_name(ID3DXConstantTableImpl* This, D3DXCONSTANT_DESC* desc, LPCSTR name, LPCSTR full_name) > +{ > + ++This->handle_count; > + if (This->handles) > + This->handles = HeapReAlloc(GetProcessHeap(), 0, This->handles, sizeof(ctab_handle) * This->handle_count); > + else > + This->handles = HeapAlloc(GetProcessHeap(), 0, sizeof(ctab_handle) * This->handle_count); > + > + This->handles[This->handle_count - 1].desc = *desc; > + This->handles[This->handle_count - 1].desc.Name = strdup(name); > + This->handles[This->handle_count - 1].full_name = strdup(full_name); > + > + return This->handle_count; > +} That's just terrible.

1 0

Re: d3dx9_36: Push down the scope of two variables. (RESEND)
by Alexandre Julliard July 5, 2011

July 5, 2011

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > This does not fix a bug or add a feature, but it makes the coder easier > to follow. Narrower scope tends to be a good thing for variables, both > for human readers and compilers (though modern ones should not need the > hint). Not necessarily, that's a matter of taste (IOW, not something you should "fix" in other people's code). -- Alexandre Julliard julliard(a)winehq.org

4 3

Re: [PATCH 1/2] d3dx9/line: Implement Begin and End methods. (try 2)
by Charles Welton July 5, 2011

July 5, 2011

Is there a reason why this patch and it's brother weren't merged in yet? This has been sitting for a few days and no comments about it yet. On 06/29/2011 07:08 PM, Charles Welton wrote: > Since the last patch spent some time without comments and wasn't > commited, I'm resending. > > Try 2 because of TRACE calls and whitespace fixes. > > --- > dlls/d3dx9_36/line.c | 73 > +++++++++++++++++++++++++++++++++++++++++++++++--- > 1 files changed, 69 insertions(+), 4 deletions(-) > > -- Charles Welton

2 1

Re: [4/9] msxml3: Implement IXMLDOMNodeList::QueryInterface(IEnumVARIANT).
by Nikolay Sivov July 5, 2011

July 5, 2011

On Tue, Jul 5, 2011 at 8:11 PM, Adam Martinson <amartinson(a)codeweavers.com> wrote: > --- > dlls/msxml3/nodelist.c | 33 ++++++++++++++++++++++++++++++++- > dlls/msxml3/selection.c | 34 ++++++++++++++++++++++++++++++++-- > 2 files changed, 64 insertions(+), 3 deletions(-) > > + else if ( IsEqualGUID( riid, &IID_IEnumVARIANT ) ) + { + if (!This->enumv && + (This->enumv = create_nodelist_enum(&This->IXMLDOMNodeList_iface))) + IXMLDOMNodeList_Release(iface); /* create_nodelist_enum() adds a ref, and we don't here. */ + + if (!This->enumv) + { + *ppvObject = NULL; + return E_OUTOFMEMORY; + } + + IEnumVARIANT_AddRef(This->enumv); + *ppvObject = This->enumv; + return S_OK; + } Shouldn't this->enumv be protected somehow to work with multiple threads? I know that so called FreeThreaded* thing is only reported to be supported, but still. Maybe something like pointer exchange call will work.

2 1

Re: [PATCH] wscript: implemented Host_get_BuildVersion
by Paul Vriens July 5, 2011

July 5, 2011

On 07/04/2011 11:28 PM, Michał Ziętek wrote: > +ok(typeof(WScript.BuildVersion) === "number", "typeof(WScript.BuldVersion) = " + typeof(WScript.BuldVersion)); Patch is already committed but there is a typo here 'BuldVersion' instead of 'BuildVersion'. -- Cheers, Paul.

1 0

Re: winedevice: eliminate the driver_name global variable
by Alexandre Julliard July 5, 2011

July 5, 2011

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * winedevice: eliminate the driver_name global variable > > This is part of general refactoring to make the driver loading code reusable. Have you fixed it since last time or is it the same patch? Either way it's still crashing. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 03/10] winmm: Implement waveOut* on top of MMDevAPI
by Alexandre Julliard July 5, 2011

July 5, 2011

Andrew Eikum <aeikum(a)codeweavers.com> writes: > +static MMRESULT WINMM_SendDeviceThreadMessage(UINT msg, WPARAM wp) > +{ > + DWORD wait; > + MMRESULT res; > + > + EnterCriticalSection(&g_devthread_lock); > + > + if(!PostThreadMessageW(g_devthread_id, msg, wp, (DWORD_PTR)&res)){ > + ERR("PostThreadMessage failed: %d\n", GetLastError()); > + LeaveCriticalSection(&g_devthread_lock); > + return MMSYSERR_ERROR; > + } > + > + wait = WaitForSingleObject(g_devthread_evt, INFINITE); > + > + LeaveCriticalSection(&g_devthread_lock); If you are going to wait for a reply it would be better to create a HWND_MESSAGE window and do a SendMessage to it, then you get all the synchronization for free. -- Alexandre Julliard julliard(a)winehq.org

1 0

Glitch-free iTunes?
by Keith Curtis July 5, 2011

July 5, 2011

Hi; Here is a rant about iTunes: http://www.pcworld.com/businesscenter/article/229398-2/day_3_dude_wheres_my… You guys are doing great, but I think it would be better if you were to work more in priority order. There are 200M devices, last I checked. I don't think iTunes has ever properly worked in WINE. It seems like Apple keep revising it and so the current WINE never works with the current iTunes. Can you make a goal of supporting iTunes with no glitches? I know many of you are volunteers, but it is globally efficient if the installation number plays into the priority of the bugs. Just this one app could be huge for Linux on the desktop. Warm regards, -Keith

9 12

Re: [3/6] wined3d: Use dummy textures for all the texture targets when the texture is unset.
by Henri Verbeet July 5, 2011

July 5, 2011

On 4 July 2011 22:32, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > + if ((!texture && old_texture_type != GL_NONE) || (texture && texture->target != old_texture_type)) > + { Actually, just thought of this now, but I'm not sure you can do this like that. The way you're using old_texture_type it's context state, not device state.

1 0

Re: [3/6] wined3d: Use dummy textures for all the texture targets when the texture is unset.
by Henri Verbeet July 5, 2011

July 5, 2011

On 4 July 2011 22:32, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > + TRACE("Dummy 2D texture %d given name %d.\n", i, device->dummyTextureName[i]); This is pretty minor, but those are unsigned.

1 0