July 2011 - Wine-Devel - list.winehq.org

Re: cmd/tests: Add test for parameter detection
by Marvin July 11, 2011

July 11, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12408 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter') === W2KPROSP4 (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter') === WXPPROSP3 (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter') === W2K3R2SESP2 (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter') === WVISTAADM (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter') === W2K8SE (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter') === W7PRO (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter')

1 0

Re: [4/5] dinput: Added device's owner username set by SetActionMap and the respective GetProperty to retrieve it
by Vitaliy Margolen July 11, 2011

July 11, 2011

On 07/08/2011 12:01 PM, Lucas Fialho Zawacki wrote: > + memcpy(ps->wsz, This->owner, strlenW(This->owner)*sizeof(WCHAR)); You can use strcpyW instead. Or even lstrcpynW to guard against buffer overflow. > @@ -1459,10 +1469,22 @@ HRESULT WINAPI IDirectInputDevice8WImpl_SetActionMap(LPDIRECTINPUTDEVICE8W iface > LPCWSTR lpszUserName, > DWORD dwFlags) You need to modify ascii version of SetActionMap as well. Vitaliy.

1 0

build error in dlls/d3dx9_36/tests/math.c
by Marcus Meissner July 11, 2011

July 11, 2011

Hi, I get on dlls/d3dx9_36/tests/math.c: (Code added in a6b40624dbc457ba7b0b4b307b1eb88617c67197 by Misha Koshelev <misha680(a)gmail.com>) gcc -c -I. -I. -I../../../include -I../../../include -DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-stateme nt -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -DLDAP_DEPRECATED=1 -march=i586 -mtune=i686 -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-prot ector -funwind-tables -fasynchronous-unwind-tables -g -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o mesh.o mesh.c math.c: In function 'test_D3DXFloat_Array': math.c:2251: error: 'INFINITY' undeclared (first use in this function) math.c:2251: error: (Each undeclared identifier is reported only once math.c:2251: error: for each function it appears in.) math.c:2253: error: 'NAN' undeclared (first use in this function) make[1]: *** [math.o] Error 1 NAN and INFINITY variables are ISO C 99 features and would need #define _ISOC99_SOURCE at the beginning of the source. Would such a patch be accepted? Or perhaps add 0.0/0.0 1.0/0.0 or similar constructs? Ciao, Marcus

4 3

Re: xlive preliminary implementation
by Damjan Jovanovic July 11, 2011

July 11, 2011

On Sat, Jul 9, 2011 at 10:24 AM, Giovanni Ongaro <giovanni.nicola(a)ticino.com> wrote: > Hi, i am a compuer scientist in the age of 46, > i have written a partial porting of xliveless to the wine git tree > adding the xlive dll. > > Right now it is in this state: > > Section 8 runs but does not save > > FUEL runs but does not save > > Red faction Guerrilla starts but i do not know if it saves > > Bulletstorm seems to save ok > > Batman Arkham Asylum runs and saves ok > > Street fighter 4 gives error after starting launcher > > Alarm for cobra 11 the syndicate does not start > > Fallout 3 runs and saves ok > > > > Your changes to dlls/xlive were not included in your patch, you probably forgot to do "git add dlls/xlive" first: --- configure | 777 ++++++++++++++++++++++++++++------------------------------ configure.ac | 1 + 2 files changed, 375 insertions(+), 403 deletions(-) Also you don't need to send changes to configure, only configure.ac. Otherwise thank you for your contribution. Damjan Jovanovic

1 0

Re: xmllite: Implement CreateXmlWriter
by Octavian Voicu July 11, 2011

July 11, 2011

On Sun, Jul 10, 2011 at 1:17 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Subject: [PATCH] Implement CreateXmlWriter ... > +/* > + * XMLLite IXmlReader tests > + * ... > +typedef struct _xmlreader > +{ > + IXmlWriter IXmlWriter_iface; > + LONG ref; > +} xmlwriter; Looks like you have some copy-paste errors (IXmlReader and _xmlreader). Cheers, Octavian

1 0

Some notes from wineconf about the 1.4 release -- are we on track?
by Scott Ritchie July 10, 2011

July 10, 2011

According to Alexandre... 1.4 will be out "sometime in 2011" At the time of wineconf we already had several new features: animated cursors, 64-bit Gecko, native cursor themes, AcceptEx support, mono packages Goals for the 1.4 release: Successful 64-bit make test Successful 32-bit make test ;) RTL support Transparency/compositing XInput2 USB support Audio redesign DIB Engine There were also these suggestions: Addons or plugins of some sort - eg a theme for GTK-grabbing Dosbox integration - possibly using Windows versions as add-on - get rid of Winedos code Plus, of course, the general goal of making more applications work :) It seems like we're making serious progress. Have any of these stalled or become less important? Has any new big feature not listed above been done that's worth listing? Is "sometime in 2011" still the best guess for 1.4's release? Thanks, Scott Ritchie

3 2

Re: d3dx9_36: Use cross-platform versions of infinity and NaN.
by Marvin July 9, 2011

July 9, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12221 Your paranoid android. === WXPPROSP3 (32 bit math) === math.c:2275: Test failed: Got ffff, expected 7fff or 7fff for index 18. === W2K3R2SESP2 (32 bit math) === math.c:2275: Test failed: Got ffff, expected 7fff or 7fff for index 18. === WVISTAADM (32 bit math) === math.c:2275: Test failed: Got ffff, expected 7fff or 7fff for index 18. === W2K8SE (32 bit math) === math.c:2275: Test failed: Got ffff, expected 7fff or 7fff for index 18. === W7PRO (32 bit math) === math.c:2275: Test failed: Got ffff, expected 7fff or 7fff for index 18. === W7PROX64 (32 bit math) === math.c:2275: Test failed: Got ffff, expected 7fff or 7fff for index 18.

3 4

Re: [PATCH 2/9] winmm: Implement waveOut* on top of MMDevAPI
by Alexandre Julliard July 9, 2011

July 9, 2011

Andrew Eikum <aeikum(a)codeweavers.com> writes: > @@ -198,21 +1771,25 @@ UINT WINAPI waveOutGetErrorTextA(UINT uError, LPSTR lpText, UINT uSize) > */ > UINT WINAPI waveOutGetErrorTextW(UINT uError, LPWSTR lpText, UINT uSize) > { > - UINT ret = MMSYSERR_BADERRNUM; > - > - if (lpText == NULL) ret = MMSYSERR_INVALPARAM; > - else if (uSize == 0) ret = MMSYSERR_NOERROR; > - else if ( > - /* test has been removed because MMSYSERR_BASE is 0, and gcc did emit > - * a warning for the test was always true */ > - (/*uError >= MMSYSERR_BASE && */ uError <= MMSYSERR_LASTERROR) || > - (uError >= WAVERR_BASE && uError <= WAVERR_LASTERROR)) { > - if (LoadStringW(hWinMM32Instance, > - uError, lpText, uSize) > 0) { > - ret = MMSYSERR_NOERROR; > - } > - } > - return ret; > + TRACE("(%u, %p, %u)\n", uError, lpText, uSize); > + > + if(!WINMM_StartDevicesThread()) > + return MMSYSERR_ERROR; > + > + if(!lpText) > + return MMSYSERR_INVALPARAM; > + > + if(uSize == 0) > + return MMSYSERR_NOERROR; > + > + if(uError > MMSYSERR_LASTERROR || uError < WAVERR_BASE || > + uError > WAVERR_LASTERROR) > + return MMSYSERR_BADERRNUM; This doesn't do what you want (and that sort of change could easily be a separate patch). -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 01/10] user32/tests: Added DefRawInputProc tests (try 15)
by Alexandre Julliard July 9, 2011

July 9, 2011

"Vincas Miliūnas" <vincas.miliunas(a)gmail.com> writes: > + ret = pDefRawInputProc(&input, 0, sizeof(RAWINPUTHEADER)); > + ok(ret == S_OK, "Given (&input, 0, sizeof), " > + "DefRawInputProc should acknowledge that no data was provided\n"); > +} That's not really testing anything. Also please avoid that sort of error message, describing the input is useless, it's just noise that is going to bitrot. A simple "DefRawInputProc returned %x" would be a lot more useful. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/5] dinput: Added device's owner username set by SetActionMap and the respective GetProperty to retrieve it
by Lucas Zawacki July 8, 2011

July 8, 2011

I realized this patch and the next are wrong and don't work, despite the tests passing. No need to bother reading them. 2011/7/8 Lucas Fialho Zawacki <lfzawacki(a)gmail.com>: > --- > dlls/dinput/device.c | 22 ++++++++++++++++++++++ > dlls/dinput/device_private.h | 1 + > 2 files changed, 23 insertions(+), 0 deletions(-) > > diff --git a/dlls/dinput/device.c b/dlls/dinput/device.c > index 5d81227..99c854c 100644 > --- a/dlls/dinput/device.c > +++ b/dlls/dinput/device.c > @@ -953,6 +953,16 @@ HRESULT WINAPI IDirectInputDevice2WImpl_GetProperty(LPDIRECTINPUTDEVICE8W iface, > TRACE("buffersize = %d\n", pd->dwData); > break; > } > + case (DWORD_PTR) DIPROP_USERNAME: > + { > + LPDIPROPSTRING ps = (LPDIPROPSTRING)pdiph; > + > + if (pdiph->dwSize != sizeof(DIPROPSTRING)) return DIERR_INVALIDPARAM; > + if (strlenW(This->owner) == 0) return S_FALSE; > + > + memcpy(ps->wsz, This->owner, strlenW(This->owner)*sizeof(WCHAR)); > + break; > + } > case (DWORD_PTR) DIPROP_VIDPID: > FIXME("DIPROP_VIDPID not implemented\n"); > return DIERR_UNSUPPORTED; > @@ -1459,10 +1469,22 @@ HRESULT WINAPI IDirectInputDevice8WImpl_SetActionMap(LPDIRECTINPUTDEVICE8W iface > LPCWSTR lpszUserName, > DWORD dwFlags) > { > + IDirectInputDeviceImpl *This = impl_from_IDirectInputDevice8W(iface); > DIPROPDWORD dp; > + DWORD username_size = MAX_PATH; > + WCHAR username[MAX_PATH]; > > FIXME("(%p)->(%p,%s,%08x): semi-stub !\n", iface, lpdiaf, debugstr_w(lpszUserName), dwFlags); > > + /* NULL username defaults to the logged user */ > + if (lpszUserName == NULL) > + { > + GetUserNameW(username, &username_size); > + lpszUserName = username; > + } > + > + memcpy(This->owner, lpszUserName, strlenW(lpszUserName)*sizeof(WCHAR)); > + > if (lpdiaf->dwBufferSize > 0) > { > dp.diph.dwSize = sizeof(DIPROPDWORD); > diff --git a/dlls/dinput/device_private.h b/dlls/dinput/device_private.h > index 503698a..6df8d93 100644 > --- a/dlls/dinput/device_private.h > +++ b/dlls/dinput/device_private.h > @@ -81,6 +81,7 @@ struct IDirectInputDeviceImpl > /* Action mapping */ > int num_actions; /* number of actions mapped */ > ActionMap *action_map; /* array of mappings */ > + WCHAR owner[MAX_PATH]; /* username of the device's owner */ > }; > > extern BOOL get_app_key(HKEY*, HKEY*) DECLSPEC_HIDDEN; > -- > 1.7.0.4 >

1 0